nvda
Replace scons app signing from signtool to signpath
#16673
Merged
Overview
Commits
21
Changes
View On GitHub

Replace scons app signing from signtool to signpath #16673

seanbudd merged 21 commits into nvaccess:master from gerald-hartig:master
gerald-hartig
gerald-hartig Update to build pipeline for HSM signed code WIP
8de99032
gerald-hartig Reminder to remove possibly unused keys
a992b0be
gerald-hartig Reminder to install PS module
5edcdfae
gerald-hartig Replacing ability to do self-signed builds
ae929cd2
AppVeyorBot
gerald-hartig Comments
e30e00e0
AppVeyorBot
gerald-hartig Bugfix for local and appveyor builds
cbbbd069
coderabbitai
coderabbitai
coderabbitai commented on 2024-06-10
gerald-hartig Updating to release signing policy with new API key
ca7abf84
seanbudd seanbudd added conceptApproved
seanbudd
gerald-hartig Adding signpath module
ff13fda2
gerald-hartig Cleaning up comments
4f738dfd
gerald-hartig gerald-hartig changed the title WIP replace scons app signing from signtool to signpath Replace scons app signing from signtool to signpath 1 year ago
gerald-hartig gerald-hartig marked this pull request as ready for review 1 year ago
gerald-hartig gerald-hartig requested a review 1 year ago
gerald-hartig gerald-hartig requested a review from SaschaCowley SaschaCowley 1 year ago
gerald-hartig gerald-hartig marked this pull request as draft 1 year ago
gerald-hartig Final cleanup
418b17c6
gerald-hartig Bugfix in original signing function introduced by refactoring
e56be12d
gerald-hartig Workaround to skip unwanted files
765dd7f9
gerald-hartig
coderabbitai
coderabbitai commented on 2024-06-12
gerald-hartig gerald-hartig marked this pull request as ready for review 1 year ago
seanbudd
seanbudd commented on 2024-06-13
gerald-hartig Apply suggestions from code review
8f86ba56
gerald-hartig
gerald-hartig commented on 2024-06-14
gerald-hartig Update appx/sconscript
fea0491c
AppVeyorBot
XLTechie
XLTechie commented on 2024-06-14
seanbudd seanbudd added merge-early
gerald-hartig Disabling appx, and iterating through dll/exe signing
06b6fd44
gerald-hartig Merge branch 'master' of https://github.com/gerald-hartig/nvda
c929bda9
gerald-hartig Disable appx
66716c18
gerald-hartig Replacing implicit boolean to avoid confusion
32643319
gerald-hartig Bugfix on retval
ad91f57d
seanbudd seanbudd added this to the 2024.3 milestone 1 year ago
seanbudd
seanbudd commented on 2024-06-19
seanbudd
seanbudd commented on 2024-06-19
seanbudd Apply suggestions from code review
bca72164
seanbudd
coderabbitai
coderabbitai commented on 2024-06-19
gerald-hartig Adding coderabbit suggestion
ded6c7e8
seanbudd
seanbudd approved these changes on 2024-06-26
seanbudd
seanbudd approved these changes on 2024-06-26
seanbudd
seanbudd approved these changes on 2024-06-26
seanbudd
seanbudd approved these changes on 2024-06-26
seanbudd
seanbudd seanbudd merged e6ba6cb1 into master 1 year ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
conceptApproved merge-early
Milestone
2024.3
Terms Of Use Privacy Policy Refund Policy Impressum