nvda
Message Dialog API take 2
#17582
Merged

Commits
  • Working refactored message dialog based on extant message dialog and draft spec
    SaschaCowley committed 1 year ago
  • Improve positioning
    SaschaCowley committed 1 year ago
  • Explicitly focus default item
    SaschaCowley committed 1 year ago
  • Improved types and type hints
    SaschaCowley committed 1 year ago
  • Switched to setLabelText to avoid mnemonic issue
    SaschaCowley committed 1 year ago
  • Switched to icon bundles
    SaschaCowley committed 1 year ago
  • Renamed private methods to be dunder
    SaschaCowley committed 1 year ago
  • Some manual test cases
    SaschaCowley committed 1 year ago
  • Added check for default item before focusing
    SaschaCowley committed 1 year ago
  • Minor changes to make temp code work better
    SaschaCowley committed 1 year ago
  • Implementation of addButton, addOkButton and addCancelButton
    SaschaCowley committed 1 year ago
  • Return self for chaining, and add a option to set as default
    SaschaCowley committed 1 year ago
  • Added close functionality
    SaschaCowley committed 1 year ago
  • Fixed layout issues and updated test case
    SaschaCowley committed 1 year ago
  • Added post popup call
    SaschaCowley committed 1 year ago
  • Added infrastructure for updates to API not yet implemented
    SaschaCowley committed 1 year ago
  • Merge branch 'master' into messageDialogApi
    SaschaCowley committed 1 year ago
  • Swiutch to using partials for callback calling
    SaschaCowley committed 1 year ago
  • Added translator comments and some docstrings
    SaschaCowley committed 1 year ago
  • Added type checking to `__call_callback`
    SaschaCowley committed 1 year ago
  • Made `addButton` a `singledispatchmethod` that will add a `MessageDialogButton` if provided
    SaschaCowley committed 1 year ago
  • Refactored `addOkButton` and `addCancelButton` to be `partialmethod`s rather than normal functions.
    SaschaCowley committed 1 year ago
  • Added multi button add method
    SaschaCowley committed 1 year ago
  • Documentation improvements
    SaschaCowley committed 1 year ago
  • Added deque to track open MessageDialog instances
    SaschaCowley committed 1 year ago
  • Refactored to use a registry oif callbacks
    SaschaCowley committed 1 year ago
  • Added adders for oother default button types
    SaschaCowley committed 1 year ago
  • Added custom button IDs
    SaschaCowley committed 1 year ago
  • Various code clean-ups
    SaschaCowley committed 1 year ago
  • Partially working modal dialogs
    SaschaCowley committed 1 year ago
  • Better handling of modal dialogs (still not woroking properly as blockingInstancesExist tries to access destroyed instances)
    SaschaCowley committed 1 year ago
  • Fixed problem with blocking instances exist
    SaschaCowley committed 1 year ago
  • WIP better performance tracing and layout encapsulation
    SaschaCowley committed 1 year ago
  • Reorganised MessageDialog code
    SaschaCowley committed 1 year ago
  • Fixed return codes not working
    SaschaCowley committed 1 year ago
  • Explicitly hide dialog when closing
    SaschaCowley committed 1 year ago
  • Added escape code enum to support ID_NONE and ID_ANY
    SaschaCowley committed 1 year ago
  • Changed MessageDialogButton.default to MessageDialogButton.default_focus, and added a MessageDialogButton.default_action field.
    SaschaCowley committed 1 year ago
  • Corrected variable names
    SaschaCowley committed 1 year ago
  • Removed staticmethods to classmethods
    SaschaCowley committed 1 year ago
  • Made isBlocking a property
    SaschaCowley committed 1 year ago
  • Improved type annotations
    SaschaCowley committed 1 year ago
  • Documentation improvements
    SaschaCowley committed 1 year ago
  • Made Show and ShowModal work in line with wx.Dialog expectations
    SaschaCowley committed 1 year ago
  • Added help id argument
    SaschaCowley committed 1 year ago
  • Added exception for trying to show a MessageDialog without buttons
    SaschaCowley committed 1 year ago
  • Renamed DefaultMessageDialogButtons to DefaultMessageDialogButton
    SaschaCowley committed 1 year ago
  • Added an enumeration of common button combinations, and a buttons parameter to MessageDialog's initializer
    SaschaCowley committed 1 year ago
  • Used MessageDialog for about dialog
    SaschaCowley committed 1 year ago
  • Added deprecation warning to gui.message.messageBox
    SaschaCowley committed 1 year ago
  • Re-enabled system test "Quits from keyboard with about dialog open"
    SaschaCowley committed 1 year ago
  • Updated block action to bring blocking dialogs to foreground
    SaschaCowley committed 1 year ago
  • Default action forces close
    SaschaCowley committed 1 year ago
  • Added a docstring
    SaschaCowley committed 1 year ago
  • Added a draft class-level docstring
    SaschaCowley committed 1 year ago
  • Respect CloseEvent.CanVeto
    SaschaCowley committed 1 year ago
  • Initial message dialog unit tests
    SaschaCowley committed 1 year ago
  • Refactored to use a common base class
    SaschaCowley committed 1 year ago
  • Removed default button assignment (reimplement later)
    SaschaCowley committed 1 year ago
  • Tests for adding standard buttons
    SaschaCowley committed 1 year ago
  • Added support for adding DefaultMessageDialogButtons with MessageDialog.addButtons without unpacking
    SaschaCowley committed 1 year ago
  • Added methods to easily add default buttons and unit tests for same
    SaschaCowley committed 1 year ago
  • Add hasDefaultAction property
    SaschaCowley committed 1 year ago
  • Add docstrings
    SaschaCowley committed 1 year ago
  • Improved implementation of default action getters
    SaschaCowley committed 1 year ago
  • Slightly refactored tests and improved docstrings for some tests
    SaschaCowley committed 1 year ago
  • Slight refacter to closing logic
    SaschaCowley committed 1 year ago
  • Re-implemented get default action and tests for same
    SaschaCowley committed 1 year ago
  • Made _getDefaultActionOrFallback comply with the return type opf _getDefaultAction
    SaschaCowley committed 1 year ago
  • Added additional setters and tests
    SaschaCowley committed 1 year ago
  • Call default callback when closing programatically
    SaschaCowley committed 1 year ago
  • Added docstrings to tests
    SaschaCowley committed 1 year ago
  • Made fallback default action more robust
    SaschaCowley committed 1 year ago
  • Renamed several double-underscored variables and methods to be single-underscored
    SaschaCowley committed 1 year ago
  • Added tests and docstrings
    SaschaCowley committed 1 year ago
  • Added lots of docstrings.
    SaschaCowley committed 1 year ago
  • Made a bunch of class names more usable
    SaschaCowley committed 1 year ago
  • Fixed some type info
    SaschaCowley committed 1 year ago
  • Added tests for _flatten_buttons
    SaschaCowley committed 1 year ago
  • Made the Show method comply with that of wx.Dialog
    SaschaCowley committed 1 year ago
  • Documentation improvements
    SaschaCowley committed 1 year ago
  • Restored behaviour of having an OK button as default
    SaschaCowley committed 1 year ago
  • Fixed label not being applied to buttons.
    SaschaCowley committed 1 year ago
  • Made id and button positional-only
    SaschaCowley committed 1 year ago
  • Rename several button properties to bring them into line with NVDA coding style and make the code more self-documenting.
    SaschaCowley committed 1 year ago
  • Parameterized tests for the default button adders to make code more DRY
    SaschaCowley committed 1 year ago
  • Test that buttons are unique when adding
    SaschaCowley committed 1 year ago
  • Changed addButtons to accept an Collection of Buttons, rather than an unpacked tuple of Buttons and DefaultButtonSets
    SaschaCowley committed 1 year ago
  • Remove _flattenButtons
    SaschaCowley committed 1 year ago
  • Fixed some types
    SaschaCowley committed 1 year ago
  • Tightened some logic and made the close box enabled only when there is a valid EscapeId
    SaschaCowley committed 1 year ago
  • Fixed test dialog
    SaschaCowley committed 1 year ago
  • Formatted
    SaschaCowley committed 1 year ago
  • Reimplemented gui.message.messageBox using MessageDialog
    SaschaCowley committed 1 year ago
  • Re-implemented the message box shim
    SaschaCowley committed 1 year ago
  • Refactored and documented.
    SaschaCowley committed 1 year ago
  • Added a helper function for calling wx functions on the main thread and waiting for their return.
    SaschaCowley committed 1 year ago
  • Used new wxCallOnMain function foor message box shim
    SaschaCowley committed 1 year ago
  • Tidied up message box shim
    SaschaCowley committed 1 year ago
  • Added new function to changes
    SaschaCowley committed 1 year ago
  • + more commits ...
Loading