nvda
Add leading silence detection and removal logic
#17648
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
28
Changes
View On
GitHub
Add leading silence detection and removal logic
#17648
seanbudd
merged 28 commits into
nvaccess:master
from
gexgd0419:trim-leading-silence
Add leading silence detection and removal logic
bd5eece8
Call startTrimmingLeadingSilence in stop and _idleCheck
f42ded78
Add changelog entry
4157888d
gexgd0419
marked this pull request as ready for review
1 year ago
gexgd0419
requested a review
1 year ago
gexgd0419
requested a review
from
SaschaCowley
1 year ago
gexgd0419
marked this pull request as draft
1 year ago
Add generateSilence in SilenceDetect
8ac53260
Add pre_synthSpeak extension point in synthDriverHandler
c4b00365
Check speech sequence in nvwave.py to see if leading silence is inser…
55062da3
Add pre_synthSpeak in developerGuide
896a1d36
gexgd0419
marked this pull request as ready for review
1 year ago
Enable trimming by default for speech only
77e93a9f
AKJUS
approved these changes on 2025-01-27
Fix
e4b5ec5a
AKJUS
approved these changes on 2025-01-27
SaschaCowley
added
merge-early
SaschaCowley
added this to the
2025.2
milestone
1 year ago
seanbudd
added
conceptApproved
seanbudd
requested a review
from
seanbudd
1 year ago
SaschaCowley
commented on 2025-02-05
SaschaCowley
requested changes on 2025-02-05
SaschaCowley
commented on 2025-02-05
Clear (initialize) the smp value before reading samples
5af95005
Add comments for min/max value trimming
90388698
Add Changes for Developers entry
4faa2c5f
Apply suggestions from code review
59851471
Apply suggestions
2fc2ed44
Revert "Add generateSilence in SilenceDetect"
7df9f7a6
Add config item speech.trimLeadingSilence in advanced settings
212476d6
Allow disabling by user
c2f98f56
gexgd0419
requested a review
1 year ago
gexgd0419
requested a review
from
Qchristensen
1 year ago
SaschaCowley
requested changes on 2025-02-05
Remove unused code
9dde0bd6
Remove GUI structure from name "AdvancedSettingsTrimLeadingSilence"
b9d3d941
Update user_docs/en/userGuide.md
8202b446
Reload synth when settings changes
75c21792
Add copyright header for silenceDetect.h
f65a5494
Pre-commit auto-fix
41da5745
gexgd0419
requested a review
from
SaschaCowley
1 year ago
SaschaCowley
commented on 2025-02-06
Change anchor
648ebd2f
SaschaCowley
approved these changes on 2025-02-06
Qchristensen
approved these changes on 2025-02-06
SaschaCowley
removed this from to the
2025.2
milestone
1 year ago
SaschaCowley
added this to the
2025.1
milestone
1 year ago
seanbudd
commented on 2025-02-07
Update user_docs/en/changes.md
52f72521
Move speech queue checking into WavePlayer class
a91b6c63
Pre-commit auto-fix
1bcb48ef
Remove unused function `WaveFormat::convertFrom`
d54df2e2
gexgd0419
requested a review
from
seanbudd
1 year ago
seanbudd
approved these changes on 2025-02-11
seanbudd
merged
1dc0f762
into master
1 year ago
gexgd0419
deleted the trim-leading-silence branch
1 year ago
nvaccess
locked
and limited conversation to collaborators
290 days ago
Login to write a write a comment.
Login via GitHub
Reviewers
seanbudd
Qchristensen
SaschaCowley
AKJUS
Assignees
No one assigned
Labels
conceptApproved
merge-early
Milestone
2025.1
Login to write a write a comment.
Login via GitHub