nvda
Fix SAPI5
#18300
Merged
Overview
Commits
35
Changes
View On GitHub

Fix SAPI5 #18300

seanbudd merged 35 commits into nvaccess:master from gexgd0419:sapi5-fix
gexgd0419
gexgd0419
jcsteh
gexgd0419
seanbudd seanbudd added merge-early
jcsteh
gexgd0419 Only call idle() when the last stream closes
9cbf543f
gexgd0419 gexgd0419 changed the base branch from master to beta 288 days ago
gexgd0419 gexgd0419 force pushed from 0dd15c99 to 9cbf543f 288 days ago
gexgd0419 gexgd0419 changed the title Attempt to fix SAPI5 Fix SAPI5 287 days ago
gexgd0419 gexgd0419 marked this pull request as ready for review 287 days ago
gexgd0419 gexgd0419 requested a review 287 days ago
gexgd0419 gexgd0419 requested a review from seanbudd seanbudd 287 days ago
gexgd0419 gexgd0419 marked this pull request as draft 287 days ago
gexgd0419 Only send bookmarks when speaking
0d4457ec
gexgd0419 Fix
8e684f02
gexgd0419 Put new bookmark lists in a queue
2dbf76e2
gexgd0419
jcsteh
jcsteh
gexgd0419
jcsteh
jcsteh
gexgd0419
jcsteh
gexgd0419
jcsteh
gexgd0419
jcsteh
jcsteh
jcsteh
hwf1324
gexgd0419
AppVeyorBot
gexgd0419
jcsteh
jcsteh
jcsteh
jcsteh
jcsteh
jcsteh
gexgd0419
jcsteh
gexgd0419
gexgd0419
jcsteh
jcsteh
jcsteh
jcsteh
gexgd0419
jcsteh
jcsteh
gexgd0419
gexgd0419
jcsteh
gexgd0419
gexgd0419 Process SpVoice.Speak() calls in a separate thread, one at a time
1ac9a56f
gexgd0419 Set SAPI5 audio output to the first available output to reset audio f…
2b326f2d
gexgd0419 gexgd0419 force pushed from 6a200c3b to 2b326f2d 278 days ago
gexgd0419 Set the audio output device to reset the audio format parameters
01d14b62
gexgd0419 Fix speak thread
7fbe186d
seanbudd seanbudd added this to the 2025.3 milestone 274 days ago
seanbudd seanbudd changed the base branch from beta to master 274 days ago
gexgd0419 gexgd0419 marked this pull request as ready for review 273 days ago
gexgd0419 gexgd0419 marked this pull request as draft 273 days ago
gexgd0419 Merge branch 'master' into sapi5-fix
fb93f1a5
gexgd0419 Merge branch 'master' into sapi5-fix
3337febd
gexgd0419 Change `_bookmarks` to `_bookmarkLists`
e2fc7d87
gexgd0419 Add checks for WASAPI state
1eedc93a
gexgd0419 Add SPEVENT utils; change type hints for pointers
20b7c82a
gexgd0419 Change `SynthDriverAudioStream` to be based on `ISpAudio`
00eae906
gexgd0419 Rename to `SynthDriverAudio`; change docstrings and type hints
22d33001
pre-commit-ci[bot] Pre-commit auto-fix
6fe554a4
gexgd0419
seanbudd seanbudd marked this pull request as ready for review 272 days ago
seanbudd seanbudd requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 272 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2025-07-15
gexgd0419 Apply suggestions from code review
8c1540a6
seanbudd
seanbudd commented on 2025-07-16
seanbudd
seanbudd seanbudd marked this pull request as draft 272 days ago
seanbudd seanbudd added blocked/needs-testing
jcsteh
seanbudd
gexgd0419 Update source/synthDrivers/sapi5.py
959062b8
gexgd0419 Rename `SPDFID_WaveFormatEx` to `_SPDFID_WaveFormatEx`
2da3b038
gexgd0419 Add `_SPEventEnum`
55d67522
gexgd0419 Rename `SynthDriverAudio` to `SynthDriverAudioStream`
4745f853
gexgd0419 Wait for cancellation to complete
77f6702c
gexgd0419 Add type aliases back to prevent breaking the API; add doc strings
cf60b020
gexgd0419 Move condition variable predicates to class level
6f425dfd
gexgd0419 Comments
f81e983c
gexgd0419 Preserve `isSpeaking` to not break the API
f63ca28d
gexgd0419 Clear `_isCancelling` flag in time
68950d82
gexgd0419 Add changelog entries
9fe7a299
gexgd0419 gexgd0419 marked this pull request as ready for review 270 days ago
gexgd0419 Set `restype` for `CoTaskMemAlloc`
9f1ebf34
gexgd0419
seanbudd seanbudd requested a review from seanbudd seanbudd 267 days ago
seanbudd seanbudd removed blocked/needs-testing
seanbudd seanbudd removed this from to the 2025.3 milestone 266 days ago
seanbudd seanbudd added this to the 2026.1 milestone 266 days ago
cary-rowen
seanbudd
seanbudd
seanbudd commented on 2025-07-24
seanbudd seanbudd requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 264 days ago
seanbudd seanbudd marked this pull request as draft 264 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2025-07-24
gexgd0419 Apply suggestions from code review
f9b17a0c
gexgd0419 Deprecate type aliases and isSpeaking
5753eb50
gexgd0419 Add COM type hints; capitalize COM method names to match the actual n…
7a523481
gexgd0419 Add deprecation in changelog
555f70f7
gexgd0419 gexgd0419 force pushed from 9bb5c6d3 to 555f70f7 261 days ago
gexgd0419 gexgd0419 marked this pull request as ready for review 261 days ago
seanbudd seanbudd removed this from to the 2026.1 milestone 259 days ago
seanbudd seanbudd added this to the 2025.2 milestone 259 days ago
seanbudd seanbudd removed this from to the 2025.2 milestone 259 days ago
seanbudd seanbudd added this to the 2025.3 milestone 259 days ago
seanbudd
seanbudd approved these changes on 2025-07-29
seanbudd Apply suggestions from code review
9373a168
seanbudd seanbudd enabled auto-merge (squash) 259 days ago
seanbudd
seanbudd commented on 2025-07-29
seanbudd Update source/synthDrivers/sapi5.py
be8519df
seanbudd seanbudd merged d2b34e46 into master 259 days ago
gexgd0419 gexgd0419 deleted the sapi5-fix branch 259 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
merge-early
Milestone
2025.3
Terms Of Use Privacy Policy Refund Policy Impressum