PR #18981 Clean up 32-bit copy when installing 64bit

Clean up 32-bit copy when installing 64bit #18981

seanbudd merged 35 commits into master from 64-uninstall-cleanup

Clean up 32-bit installed copies safely

3150eabc

seanbudd marked this pull request as ready for review 271 days ago

seanbudd requested a review 271 days ago

seanbudd requested a review from

SaschaCowley 271 days ago

seanbudd requested a review from

copilot-pull-request-reviewer 271 days ago

seanbudd marked this pull request as draft 271 days ago

copilot-pull-request-reviewer commented on 2025-09-24

close keys safely

a0784d8d

close keys safely

913cea78

close keys safely

d3af0513

simplify ease of access checks

6a025c23

improve key access for more accurate log messages

c776c94b

fix premature close

fce02097

Merge remote-tracking branch 'origin/master' into 64-uninstall-cleanup

d592672b

Merge remote-tracking branch 'origin/master' into 64-uninstall-cleanup

9c5f708e

fix close

a2dfa1cb

seanbudd marked this pull request as ready for review 266 days ago

seanbudd changed the title ~~Clean up 32-bit installed copies safely~~ Clean up 32-bit installed NVDA's registry 266 days ago

seanbudd requested a review from

copilot-pull-request-reviewer 266 days ago

copilot-pull-request-reviewer commented on 2025-09-29

improve logging

a206e036

seanbudd marked this pull request as draft 266 days ago

handle install

7829eb3d

Merge remote-tracking branch 'origin/master' into 64-uninstall-cleanup

cabc566e

apply review comments

f410820a

seanbudd changed the title ~~Clean up 32-bit installed NVDA's registry~~ Clean up 32-bit copy when installing 64bit 266 days ago

fix up x86 cleanup

108fbfe4

remove X86 dir

ba72d35f

remove X86 dir

c496be6d

remove X86 dir

462c2514

seanbudd marked this pull request as ready for review 266 days ago

always clean up program files

11db5ce2

seanbudd added conceptApproved

SaschaCowley commented on 2025-09-30

Update source/installer.py

47c9fd6e

seanbudd requested a review from

SaschaCowley 265 days ago

Revert "always clean up program files"

770a0a59

Clean x86 dir safer

d3d61bbb

add return types

86f773d6

fix check prev install

bee8825a

seanbudd requested a review from

michaelDCurran 264 days ago

Pre-commit auto-fix

41e60ff2

SaschaCowley commented on 2025-10-01

seanbudd commented on 2025-10-01

Update source/installer.py

29a3d32f

remove _RegistryKeyX86 in favour of access views

65181020

michaelDCurran commented on 2025-10-01

seanbudd commented on 2025-10-01

Update source/installer.py

bdbe8cc2

Pre-commit auto-fix

7b268377

fix compare prev install

72d95711

seanbudd marked this pull request as draft 264 days ago

fix _defaultInstallDirX86

565b4bdb

seanbudd force pushed from f966d765 to 565b4bdb 263 days ago

fix deleteKeyEx

52a91be5

improve NVDA remote

9d1dbe38

fix install comparison

d0dd7362

seanbudd marked this pull request as ready for review 263 days ago

seanbudd requested a review from

copilot-pull-request-reviewer 263 days ago

copilot-pull-request-reviewer commented on 2025-10-02

Update source/_remoteClient/urlHandler.py

62928e40

SaschaCowley approved these changes on 2025-10-02

SaschaCowley enabled auto-merge (squash) 263 days ago

disabled auto-merge 263 days ago
Manually disabled by user

seanbudd merged 2b0424e4 into master 262 days ago

seanbudd deleted the 64-uninstall-cleanup branch 262 days ago

github-actions added this to the 2026.1 milestone 262 days ago

Reviewers

SaschaCowley

michaelDCurran

copilot-pull-request-reviewer

Assignees

No one assigned

Labels

conceptApproved

Milestone

2026.1

nvda Clean up 32-bit copy when installing 64bit #18981 Merged

Clean up 32-bit copy when installing 64bit #18981

nvda
Clean up 32-bit copy when installing 64bit
#18981

Merged