nvda
added an @script decorator to scriptHandler for setting script metadata
#8236
Merged

added an @script decorator to scriptHandler for setting script metadata #8236

michaelDCurran merged 22 commits into nvaccess:master from i6266
LeonarddeR
ctoth added an @script decorator for setting script metadata to the scriptH…
f4572129
ctoth Removed gesture attribute from script functions
b0f8169e
ctoth Removed unused getScripts method from BaseObject
976cb862
Merge remote-tracking branch 'origin/master' into t6266
046a1ea7
Address review comment and rename GestureCollector to ScriptableType
6d906711
Make the script decorator gestures work both for normal and dynamic N…
74c5d142
First baceObject tests
9f78bfdd
Fix decorated scripts not properly being added when subclassing objects
ef3fe254
Finish unit tests
cfe7278a
LeonarddeR LeonarddeR requested a review from feerrenrut feerrenrut 8 years ago
LeonarddeR LeonarddeR requested a review from jcsteh jcsteh 8 years ago
LeonarddeR LeonarddeR closed this 8 years ago
LeonarddeR LeonarddeR deleted the i6266 branch 8 years ago
LeonarddeR LeonarddeR restored the head branch 8 years ago
LeonarddeR
LeonarddeR LeonarddeR reopened this 8 years ago
derekriemer
derekriemer dismissed these changes on 2018-05-05
Add bypasInputHelp and resumeSayAllMode to the script decorator
b8ed39fd
Review actions
760606f2
Add unit tests for the script decorator itself
9f9c814f
derekriemer
derekriemer commented on 2018-05-06
Update developer guide
e8311ca0
feerrenrut
feerrenrut requested changes on 2018-05-14
Review actions
ea358e16
jcsteh
jcsteh
jcsteh requested changes on 2018-05-14
Review actions regarding devGuide and comments
d902366c
Only use the per class __gestures dictionary, also for decorated scripts
8cc9a58c
LeonarddeR
Last review action
d17e441e
Revert NVDAObjects/__init__.py to master, as in the end, this hasn't …
d2f2d438
Also revert changes to test suite objectProvider
e984f684
jcsteh
jcsteh approved these changes on 2018-05-15
Split of lines in devGuide
db2d1028
LeonarddeR
Rename the scripts in test_baseObject to follow the phonetic alphabet…
296edc98
Log warnings when using the script decorator in a wrong way, either b…
1698d4f0
feerrenrut
feerrenrut approved these changes on 2018-05-15
feerrenrut feerrenrut dismissed their stale review 8 years ago
I believe that all of the changes requested by @derekriemer were addressed, so I will incubate this now.
nvaccessAuto nvaccessAuto added incubating
nvaccessAuto nvaccessAuto assigned feerrenrut feerrenrut 8 years ago
michaelDCurran michaelDCurran merged 9d35a2fe into master 8 years ago
nvaccessAuto nvaccessAuto removed incubating
nvaccessAuto nvaccessAuto added this to the 2018.3 milestone 8 years ago

Login to write a write a comment.

Login via GitHub

Assignees
Labels
Milestone