nvda
added an @script decorator to scriptHandler for setting script metadata
#8236
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
22
Changes
View On
GitHub
added an @script decorator to scriptHandler for setting script metadata
#8236
michaelDCurran
merged 22 commits into
nvaccess:master
from i6266
added an @script decorator for setting script metadata to the scriptH…
f4572129
Removed gesture attribute from script functions
b0f8169e
Removed unused getScripts method from BaseObject
976cb862
Merge remote-tracking branch 'origin/master' into t6266
046a1ea7
Address review comment and rename GestureCollector to ScriptableType
6d906711
Make the script decorator gestures work both for normal and dynamic N…
74c5d142
First baceObject tests
9f78bfdd
Fix decorated scripts not properly being added when subclassing objects
ef3fe254
Finish unit tests
cfe7278a
LeonarddeR
requested a review
from
feerrenrut
8 years ago
LeonarddeR
requested a review
from
jcsteh
8 years ago
LeonarddeR
closed this
8 years ago
LeonarddeR
deleted the i6266 branch
8 years ago
LeonarddeR
restored the head branch
8 years ago
LeonarddeR
reopened this
8 years ago
derekriemer
dismissed these changes on 2018-05-05
Add bypasInputHelp and resumeSayAllMode to the script decorator
b8ed39fd
Review actions
760606f2
Add unit tests for the script decorator itself
9f9c814f
derekriemer
commented on 2018-05-06
Update developer guide
e8311ca0
feerrenrut
requested changes on 2018-05-14
Review actions
ea358e16
jcsteh
requested changes on 2018-05-14
Review actions regarding devGuide and comments
d902366c
Only use the per class __gestures dictionary, also for decorated scripts
8cc9a58c
Last review action
d17e441e
Revert NVDAObjects/__init__.py to master, as in the end, this hasn't …
d2f2d438
Also revert changes to test suite objectProvider
e984f684
jcsteh
approved these changes on 2018-05-15
Split of lines in devGuide
db2d1028
Rename the scripts in test_baseObject to follow the phonetic alphabet…
296edc98
Log warnings when using the script decorator in a wrong way, either b…
1698d4f0
feerrenrut
approved these changes on 2018-05-15
feerrenrut
dismissed their stale review
8 years ago
I believe that all of the changes requested by @derekriemer were addressed, so I will incubate this now.
nvaccessAuto
added
incubating
nvaccessAuto
assigned
feerrenrut
8 years ago
michaelDCurran
merged
9d35a2fe
into master
8 years ago
nvaccessAuto
removed
incubating
nvaccessAuto
added this to the
2018.3
milestone
8 years ago
Login to write a write a comment.
Login via GitHub
Reviewers
jcsteh
feerrenrut
derekriemer
Assignees
feerrenrut
Labels
None yet
Milestone
2018.3