nvda
Get reliable points from offsets in virtual buffers
#8479
Merged
Overview
Commits
26
Changes
View On GitHub

Get reliable points from offsets in virtual buffers #8479

feerrenrut merged 26 commits into nvaccess:master from geckoPointFromOffset
LeonarddeR
LeonarddeR LeonarddeR added feature/browse-mode
LeonarddeR LeonarddeR added app/chrome
LeonarddeR LeonarddeR added app/firefox
LeonarddeR LeonarddeR added component/text-info
LeonarddeR LeonarddeR requested a review from jcsteh jcsteh 7 years ago
LeonarddeR LeonarddeR requested a review from michaelDCurran michaelDCurran 7 years ago
Adriani90
LeonarddeR LeonarddeR changed the title Get reliable points from offsets in Mozilla and Chrome virtual buffers Get reliable points from offsets in virtual buffers 7 years ago
LeonarddeR
Adriani90
LeonarddeR
Adriani90
LeonarddeR
Adriani90
Adriani90
LeonarddeR
Adriani90
Adriani90
Adriani90
Adriani90
Adriani90
LeonarddeR
Add the ia2StartOffset to a Gecko TextFieldNode if that node originat…
fc46d4ba
Add helper methods to get raw nodes from a buffer
fea0cfe3
Fix VirtualBuffer._getControlFieldAttribs to search for attributes wi…
8f06d96e
When characters are stripped from a TextFieldNode, add an additional …
2d970f90
Add unit for text fields and use that instead of new helper functions
39a44333
Implement pointFromOffset for GECKO
ee3d1c69
Raise a LookupError when no identifier could be retrieved from an offset
200309c9
Improve pointFromOffset in Adobe Reader as well
b216bc88
Also implement getOffsetFromPoint for gecko
5eaa5459
Fall back to the base implementation for point from offset when Adobe…
6202999d
Raise LookupError before the base implementation for getting points f…
eac351f1
Change an assertion for TextInfo into an if check which is more safe
a6fca0b6
jcsteh
jcsteh requested changes on 2018-07-25
jcsteh
Review actions
20ec3c9c
Hopefully made checking stripped chars from start of text field nodes…
cc7d31fe
LeonarddeR
jcsteh
jcsteh
jcsteh requested changes on 2018-07-31
Merge remote-tracking branch 'origin/master' into geckoPointFromOffset
9a6ff308
Revert change to getControlFieldAttribs
ec626a02
Revert the addition of _getOffsetFromPoint for Gecko virtual buffers
0202412d
LeonarddeR
jcsteh
jcsteh requested changes on 2018-08-01
Review action
72cf1fae
Make use of locationHelper within the adobe reader VBuf pyuthon code
99d3d027
LeonarddeR LeonarddeR removed review request from michaelDCurran michaelDCurran 7 years ago
LeonarddeR LeonarddeR requested a review from michaelDCurran michaelDCurran 7 years ago
jcsteh
jcsteh dismissed these changes on 2018-08-03
michaelDCurran
michaelDCurran dismissed these changes on 2018-08-03
michaelDCurran
LeonarddeR
feerrenrut
LeonarddeR
Use the center of bounding rectangles for Gecko
c19970ec
LeonarddeR LeonarddeR dismissed their stale review via c19970ec 7 years ago
LeonarddeR LeonarddeR dismissed their stale review via c19970ec 7 years ago
LeonarddeR
Restored brackets, no functional change
ac67fe8f
Edited changes.t2t
9c9945e1
feerrenrut
feerrenrut commented on 2018-08-07
feerrenrut
feerrenrut commented on 2018-08-07
feerrenrut
Use locationHelper to calculate a center point from character extends
c17223e4
LeonarddeR
jcsteh
feerrenrut
LeonarddeR
feerrenrut
Revert "Edited changes.t2t"
2bc47096
Merge remote-tracking branch 'origin/master' into geckoPointFromOffset
c1b0e317
LeonarddeR
feerrenrut
feerrenrut dismissed these changes on 2018-08-20
feerrenrut Update changes file for PR #8479
d215ef7e
feerrenrut feerrenrut dismissed their stale review via d215ef7e 7 years ago
feerrenrut feerrenrut merged ec3eeee9 into master 7 years ago
nvaccessAuto nvaccessAuto added this to the 2018.4 milestone 7 years ago
LeonarddeR LeonarddeR added BabbageWork

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
feature/browse-mode app/chrome app/firefox component/text-info BabbageWork
Milestone
2018.4
Terms Of Use Privacy Policy Refund Policy Impressum