PR #457 Improve types for `ThrottlingOctokitOptions`

Improve types for `ThrottlingOctokitOptions` #457

gr2m merged 15 commits into master from improve-types-to-octokit-options-plugin

oscard0m commented on 2022-02-18

oscard0m changed the title ~~WIP: Improve types for `ThrottlingOctokitOptions`~~ Improve types for `ThrottlingOctokitOptions` 3 years ago

wolfy1339 commented on 2022-02-18

wolfy1339 added Type: Feature

wolfy1339 added typescript

wolfy1339 commented on 2022-02-18

oscard0m force pushed from c01f1180 to 04e36482 3 years ago

oscard0m force pushed from 04e36482 to c567474f 3 years ago

oscard0m requested a review from

wolfy1339 3 years ago

oscard0m force pushed from c567474f to c1691833 3 years ago

wolfy1339 requested changes on 2022-03-03

oscard0m force pushed from c1691833 to 6f5d4f04 3 years ago

oscard0m force pushed from b7deee4f to acdb3ce3 3 years ago

oscard0m force pushed from acdb3ce3 to 596782ee 3 years ago

oscard0m force pushed from d7659c8a to acf03b46 3 years ago

wolfy1339 dismissed these changes on 2022-03-10

wolfy1339 commented on 2022-03-11

feat(types): improve types for ThrottlingOptions to make it more accu…

3ad42143

refactor(types): apply second iteration on trying to improve types fo…

69f747bd

fix(retry.test.ts): adopt new ThrottlingOption type

1dd24837

fix(plugin.test.ts): adopt ThrottlingOptions type

e719d063

fix(events.test.ts): adopt ThrottlingOptions type

ed5f5785

refactor(ts-ignore): use 'ts-expect-error' to keep track when annotat…

87e1d6c3

fix(route-matcher): improve typing for 'paths'

6be81ba3

feat(types): improve type for 'Bottleneck' and 'connection'

5ccd50f6

oscard0m force pushed from d9a42101 to ab7bbab3 3 years ago

test(types): add TS validation to assure types are properly configured

00114706

oscard0m force pushed from ab7bbab3 to 00114706 3 years ago

fix(types): use types suggested by wolfy

434936ad

oscard0m added blocked

build(deps): update @octokit/core to v3.6.0

c1d93860

fix(types): remove unnecessary //@ts-expect-error in index.ts

8d61b721

refactor(index.ts): remove unnecessary ts-expect-error for retryAfter

750f3a3d

oscard0m force pushed from e92e997b to 750f3a3d 3 years ago

oscard0m marked this pull request as ready for review 3 years ago

oscard0m removed blocked

oscard0m requested a review from

wolfy1339 3 years ago

oscard0m dismissed their stale review 3 years ago

I want to re-run checks

ci(test.yml): rename jobs to asure they match required check run names

56136e80

fix(types): use 'never' to assure the Union does not allow 'onAbuse' …

81fce787

wolfy1339 approved these changes on 2022-03-16

oscard0m requested a review from

gr2m 3 years ago

gr2m approved these changes on 2022-03-17

gr2m merged fd92be9d into master 3 years ago

gr2m deleted the improve-types-to-octokit-options-plugin branch 3 years ago

github-actions added released

Reviewers

gr2m

wolfy1339

G-Rath

Assignees

No one assigned

Labels

Type: Feature

Milestone

No milestone

plugin-throttling.js Improve types for `ThrottlingOctokitOptions` #457 Merged

Improve types for `ThrottlingOctokitOptions` #457

plugin-throttling.js
Improve types for `ThrottlingOctokitOptions`
#457

Merged