👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.
Hi Eirik, IIRC the cache is global - so I don't think running the test in the same VM will work. I mean, I don't think we will be testing the same thing.
Hi Eirik, IIRC the cache is global - so I don't think running the test in the same VM will work. I mean, I don't think we will be testing the same thing.
If the test should fail because of a regression, then yes, the next parameterized run of the test may start with a non-empty cache. I could add an assertEmptyJarFileCaches
method to the start of the test execution, this will verify that all test runs starting with a non-empty cache fails.
I could add an
assertEmptyJarFileCaches
method to the start of the test execution, this will verify that all test runs starting with a non-empty cache fails.
I went ahead and added a sanity check verifying that the JarFileFactory
caches are unpopulated at the beginning of each test run.
Login to write a write a comment.
Can I get a review of this test-only cleanup/speedup PR which modernizes the test
RemoveJar.java
.This test attempts a variety of class loading scenarios on a URLClassLoader and verifies that when the loader is closed, it has released its JAR file (such that it may be deleted on Windows).
Changes in this PR include:
@Parameterized
instead of using multiple jtreg runsjavac
via ToolProviderJarOutputStream
instead of calling out to thejar
tool.A nice benefit of this change is that it speeds up the runtime from ~15 seconds to ~1 second on my laptop.
Unfortunately, this test relies on Windows to fail, that is something I plan to look into separately.
Verification: GHA tests pending. (No local Windows dev environment)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22319/head:pull/22319
$ git checkout pull/22319
Update a local copy of the PR:
$ git checkout pull/22319
$ git pull https://git.openjdk.org/jdk.git pull/22319/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22319
View PR using the GUI difftool:
$ git pr show -t 22319
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22319.diff
Using Webrev
Link to Webrev Comment