PR #2073 fix: safe opcache_reset

fix: safe opcache_reset #2073

AlliBalliBaba wants to merge 50 commits into main from fix/opcache-safe-reset

Tests.

e94e3bcb

Merge branch 'main' into fix/opcache-safe-reset

48bf41ff

Wait 1s for deadlocks.

973d722a

Merge branch 'main' into fix/opcache-safe-reset

2a9a9a81

Adjusts waitgroup logic.

d1e28d5d

Starts separate opcache_reset request flow once all threads are stopped.

8e87d008

Test with grace period (again)

acf2a1c8

Force all threads to call opcache_reset().

d8c185cc

test

3e7cdd02

henderkes force pushed from ff7ff1e1 to e54cd962 84 days ago

henderkes force pushed from e54cd962 to 5c8e3406 84 days ago

Merge remote-tracking branch 'origin/main' into fix/opcache-safe-reset

1d75824b

henderkes force pushed from 5c8e3406 to 1d75824b 84 days ago

fix clang format

df82e814

call into cgo for reset directly, no fake dummy

0d87765f

henderkes force pushed from e7bd25a6 to 0d87765f 84 days ago

clang fmt

0564eaf1

override opcache reset handler for every php thread in php 8.2

49fc8784

maybe after request startup?

22c6ba60

henderkes force pushed from 15aae23d to 22c6ba60 83 days ago

try not resetting opcache?

66702fe0

don't overrride opcache_reset at all in php 8.2

7cb94e6d

dont even run the test

e9533b8f

henderkes force pushed from fc58c35c to e9533b8f 83 days ago

don't wait for resetting in php 8.2

7c28f3d4

henderkes force pushed from 4ec8f3ea to ae5315fb 83 days ago

henderkes force pushed from ae5315fb to 819096cf 83 days ago

henderkes force pushed from 819096cf to ecfb4352 83 days ago

henderkes force pushed from ecfb4352 to eced1fd1 83 days ago

original opcache reset in 8.2

d88821a8

henderkes force pushed from eced1fd1 to d88821a8 83 days ago

henderkes force pushed from 1092d258 to d88821a8 83 days ago

make it run on 8.2 again

45d49c1a

henderkes marked this pull request as ready for review 82 days ago

AlliBalliBaba commented on 2026-03-15

henderkes commented on 2026-03-16

Update worker.go

d189770c

Merge remote-tracking branch 'origin/main' into fix/opcache-safe-reset

0b2521d9

henderkes approved these changes on 2026-03-24

fix tests timing out

eebec0b8

cap sleep at 100ms

30407d77

henderkes requested a review from

dunglas 71 days ago

Merge remote-tracking branch 'origin/main' into fix/opcache-safe-reset

fc77310d

Merge branch 'main' into fix/opcache-safe-reset

d5ed5dae

Merge branch 'main' into fix/opcache-safe-reset

3e8d548f

dunglas commented on 2026-04-17

dunglas requested a review from

copilot-pull-request-reviewer 23 days ago

copilot-pull-request-reviewer commented on 2026-05-13

Cleans up implementation and adresses race conditions.

6a0428f0

merge

4036febc

Merge branch 'main' into fix/opcache-safe-reset

a7e88316

formatiing

1c38ab88

Merge branch 'main' into fix/opcache-safe-reset

1f23436e

merge draining with timeouts.

81688bf0

Fix for 8.2

1d5d954a

test

8f28271c

test

8dd20fe1

Merge branch 'main' into fix/opcache-safe-reset

2ed4581b

address random testing reproducibility comment from copilot

2f9e5cee

address other copilot comment

fac95212

don't overwrite orig_opcache_reset pointer with our own replacement

19d8010b

damn clang format

08c9d607

Merge branch 'main' into fix/opcache-safe-reset

f4d23364

henderkes commented on 2026-05-19

dont sleep too long

8e76bd7e

Merge branch 'main' into fix/opcache-safe-reset

90b1863b

reduce test flakyness

41429641

warns if original opcache reset is null.

1ec4cc1a

warns if original opcache reset id null

c5ef9fc7

Merge branch 'fix/opcache-safe-reset' of https://github.com/dunglas/f…

1eeeca21

fixes conflict.

eea6f17b

Reviewers

henderkes

dunglas

copilot-pull-request-reviewer

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

frankenphp fix: safe opcache_reset #2073 Open

fix: safe opcache_reset #2073

frankenphp
fix: safe opcache_reset
#2073

Open