frankenphp
fix: reboot threads on opcache reset and watcher
#2364
Open
Overview
Commits
50
Changes
View On GitHub

fix: reboot threads on opcache reset and watcher #2364

AlliBalliBaba wants to merge 50 commits into main from fix/reboot-threads-on-opcache-reset-and-watcher
AlliBalliBaba
AlliBalliBaba Tests.
e94e3bcb
AlliBalliBaba Merge branch 'main' into fix/opcache-safe-reset
48bf41ff
AlliBalliBaba Wait 1s for deadlocks.
973d722a
AlliBalliBaba Merge branch 'main' into fix/opcache-safe-reset
2a9a9a81
AlliBalliBaba Adjusts waitgroup logic.
d1e28d5d
AlliBalliBaba Starts separate opcache_reset request flow once all threads are stopped.
8e87d008
AlliBalliBaba Test with grace period (again)
acf2a1c8
AlliBalliBaba Force all threads to call opcache_reset().
d8c185cc
AlliBalliBaba test
3e7cdd02
henderkes Merge remote-tracking branch 'origin/main' into fix/opcache-safe-reset
1d75824b
henderkes fix clang format
df82e814
henderkes call into cgo for reset directly, no fake dummy
0d87765f
henderkes clang fmt
0564eaf1
henderkes override opcache reset handler for every php thread in php 8.2
49fc8784
henderkes maybe after request startup?
22c6ba60
henderkes try not resetting opcache?
66702fe0
henderkes don't overrride opcache_reset at all in php 8.2
7cb94e6d
henderkes dont even run the test
e9533b8f
henderkes don't wait for resetting in php 8.2
7c28f3d4
henderkes original opcache reset in 8.2
d88821a8
henderkes make it run on 8.2 again
45d49c1a
henderkes Update worker.go
d189770c
henderkes Merge remote-tracking branch 'origin/main' into fix/opcache-safe-reset
0b2521d9
henderkes fix tests timing out
eebec0b8
henderkes cap sleep at 100ms
30407d77
henderkes Merge remote-tracking branch 'origin/main' into fix/opcache-safe-reset
fc77310d
henderkes Merge branch 'main' into fix/opcache-safe-reset
d5ed5dae
AlliBalliBaba Merge branch 'main' into fix/opcache-safe-reset
3e8d548f
AlliBalliBaba Merge branch 'main' into fix/opcache-safe-reset
dc9a2717
AlliBalliBaba restarts completely
97376a7f
AlliBalliBaba removes unnecessary states.
672997bf
AlliBalliBaba removes unused code.
28b52c2d
AlliBalliBaba AlliBalliBaba changed the title Fix/reboot threads on opcache reset and watcher fix: reboot threads on opcache reset and watcher 52 days ago
AlliBalliBaba fixes internal function.
7e627bd2
AlliBalliBaba updates comments.
7762da52
AlliBalliBaba
AlliBalliBaba AlliBalliBaba requested a review from henderkes henderkes 52 days ago
AlliBalliBaba
AlliBalliBaba AlliBalliBaba marked this pull request as ready for review 51 days ago
AlliBalliBaba requires a safe state on change.
3da984dd
AlliBalliBaba handles incative threads correctly.
56418cd6
dunglas
henderkes
AlliBalliBaba
AlliBalliBaba Merge branch 'main' into fix/reboot-threads-on-opcache-reset-and-watcher
154f02c0
AlliBalliBaba better race condition guards
5f05e752
AlliBalliBaba Cleans up state transitions.
69b589a5
AlliBalliBaba cleanup
a687780b
AlliBalliBaba removes randomness
612e0fdf
AlliBalliBaba also trigger on any opcache overflow.
9a274673
AlliBalliBaba fixes reason.
b9a46327
AlliBalliBaba
henderkes
dunglas dunglas requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 10 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-06-03
AlliBalliBaba various opilot suggestions
54932de9
AlliBalliBaba makes sure test doesn't fail randomly.
1131762f
AlliBalliBaba make sure watcher dirs are fully empty.
db3c1401
AlliBalliBaba Ignore calls on empty main thread.
3e560551
AlliBalliBaba typo
f2eaae1e
henderkes
henderkes commented on 2026-06-07
AlliBalliBaba uses separate states for single and multi-reboots.
cc9d2e33
AlliBalliBaba fix hot reload test race condition
32d773a0

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum