connectedhomeip
Update ACL API to support ARL use cases
#34537
Merged
Overview
Commits
19
Changes
View On GitHub

Update ACL API to support ARL use cases #34537

mergify merged 19 commits into project-chip:master from tleacmcsa:arl-acl-api-updates
tleacmcsa
tleacmcsa289 days ago

ARL needs to know what attribute/command/event is being accessed and with which interaction model action. This change brings this knowledge into the AccessControl classes Check method for further enhancement with ARL feature on top.

tleacmcsa Update ACL API to support ARL use cases
38db8432
semanticdiff-com
semanticdiff-com289 days ago

Review changes with SemanticDiff.

github-actions github-actions added app
github-actions
github-actions289 days ago (edited 289 days ago)

PR #34537: Size comparison from 4334e91 to 38db843

Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, stm32, tizen)
platform target config section 4334e91 38db843 change % change
bl602 lighting-app bl602 FLASH 1274146 1274264 118 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1288404 1288522 118 0.0
RAM 95568 95568 0 0.0
bl602+rpc FLASH 1313114 1313232 118 0.0
RAM 103848 103848 0 0.0
bl702 lighting-app bl702 FLASH 1095040 1095158 118 0.0
RAM 15245 15245 0 0.0
bl702+mfd FLASH 1105734 1105852 118 0.0
RAM 15397 15397 0 0.0
bl702+rpc FLASH 1185106 1185224 118 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 878084 878458 374 0.0
RAM 27348 27348 0 0.0
bl706-wifi FLASH 1130780 1130972 192 0.0
RAM 14681 14681 0 0.0
bl702l lighting-app bl702l FLASH 1081938 1082056 118 0.0
RAM 21800 21800 0 0.0
bl702l+mfd FLASH 1093200 1093318 118 0.0
RAM 21960 21960 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 800212 800396 184 0.0
RAM 109276 109276 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816684 816868 184 0.0
RAM 117020 117020 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808652 808852 200 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762416 762616 200 0.0
RAM 105448 105448 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747068 747244 176 0.0
RAM 105632 105632 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606670 606854 184 0.0
RAM 204564 204564 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652210 652386 176 0.0
RAM 204836 204836 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 669281 669497 216 0.0
RAM 77740 77740 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 689141 689357 216 0.0
RAM 80380 80380 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 689141 689357 216 0.0
RAM 80380 80380 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 646077 646293 216 0.0
RAM 72808 72808 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609737 609945 208 0.0
RAM 70884 70884 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629365 629573 208 0.0
RAM 73428 73428 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629365 629573 208 0.0
RAM 73428 73428 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625433 625649 216 0.0
RAM 73900 73900 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645141 645357 216 0.0
RAM 76444 76444 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645141 645357 216 0.0
RAM 76444 76444 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593661 593869 208 0.0
RAM 67852 67852 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613513 613721 208 0.0
RAM 70492 70492 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613513 613721 208 0.0
RAM 70492 70492 0 0.0
efr32 lighting-app BRD4187C FLASH 927248 927432 184 0.0
RAM 134568 134568 0 0.0
lock-app BRD4338a FLASH 734684 734852 168 0.0
RAM 208004 208004 0 0.0
window-app BRD4187C FLASH 1014772 1014964 192 0.0
RAM 126648 126648 0 0.0
esp32 all-clusters-app c3devkit DRAM 91020 91020 0 0.0
FLASH 1482368 1482570 202 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117500 117500 0 0.0
FLASH 1551631 1551823 192 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2710575 2711201 626 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5902302 5902928 626 0.0
RAM 499576 499576 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5306932 5307558 626 0.0
RAM 235920 235920 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4707492 4708118 626 0.0
RAM 213664 213664 0 0.0
chip-tool debug unknown 5784 5784 0 0.0
FLASH 12336908 12337536 628 0.0
RAM 553458 553458 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11343039 11343667 628 0.0
RAM 550298 550298 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4463202 4463828 626 0.0
RAM 199248 199248 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5631521 5632145 624 0.0
RAM 224464 224464 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4757958 4758584 626 0.0
RAM 200704 200704 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4402420 4403046 626 0.0
RAM 194880 194880 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4540568 4541196 628 0.0
RAM 199416 199416 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 2991613 2992253 640 0.0
RAM 154056 154056 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5983421 5984045 624 0.0
RAM 578144 578144 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10549501 10550125 624 0.0
RAM 638984 638984 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503444 1503636 192 0.0
RAM 226720 226720 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 897228 897428 200 0.0
RAM 141608 141608 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 962828 963032 204 0.0
RAM 140712 140712 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 832644 832844 200 0.0
RAM 140464 140464 0 0.0
nxp contact k32w0+release FLASH 576100 576308 208 0.0
RAM 70104 70104 0 0.0
k32w1+release FLASH 591808 592008 200 0.0
RAM 74144 74144 0 0.0
light k32w0+release FLASH 611696 611888 192 0.0
RAM 69608 69608 0 0.0
k32w1+release FLASH 676528 676728 200 0.0
RAM 82912 82912 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1622948 1623124 176 0.0
RAM 209776 209776 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1533444 1533620 176 0.0
RAM 206584 206584 0 0.0
light cy8ckit_062s2_43012 FLASH 1460468 1460644 176 0.0
RAM 199848 199848 0 0.0
lock cy8ckit_062s2_43012 FLASH 1459668 1459844 176 0.0
RAM 224328 224328 0 0.0
stm32 light STM32WB5MM-DK FLASH 475408 475600 192 0.0
RAM 144300 144300 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1669024 1669356 332 0.0
RAM 48924 48924 0 0.0
chip-tool-ubsan arm unknown 2388 2388 0 0.0
FLASH 16381654 16382294 640 0.0
RAM 7190408 7190600 192 0.0
andy31415
andy31415 commented on 2024-07-26
Conversation is marked as resolved
Show resolved
src/access/AccessControl.h
3233namespace chip {
3334namespace Access {
3435
36
using namespace chip::Protocols::InteractionModel;
andy31415289 days ago

please no using namespace in headers.

tleacmcsa287 days ago

done.

andy31415
andy31415 commented on 2024-07-26
Conversation is marked as resolved
Show resolved
src/access/AccessControl.h
636640 * @retval #CHIP_NO_ERROR if allowed.
637641 */
638 CHIP_ERROR Check(const SubjectDescriptor & subjectDescriptor, const RequestPath & requestPath, Privilege requestPrivilege);
642
 CHIP_ERROR Check(const SubjectDescriptor & subjectDescriptor, const RequestPath & requestPath, Privilege requestPrivilege,
andy31415289 days ago

please fix the order to keep request last. It seems the intent was request data (descriptor, path) to be first, then the request last.

Also this starts growing into having too many arguments. We may decide to have a builder pattern starting now, something like Check(Request, Privilege) where Request is a builder with SetDescriptor, SetPath, SetMsgType).

tleacmcsa287 days ago

done.

andy31415
andy31415 commented on 2024-07-26
Conversation is marked as resolved
Show resolved
src/access/AccessControl.cpp
171171 return 'u';
172172}
173173
174
char GetActionStringForLogging(MsgType action)
andy31415288 days ago

please fix return type or name: char is not a string.

andy31415288 days ago

I see the previous implementation also did that :( So pre-existing.... sigh. Can be a followup that probably never happens.

tleacmcsa288 days ago

The intent was to log a single character, not a string.

andy31415
andy31415 commented on 2024-07-26
Conversation is marked as resolved
Show resolved
src/access/RequestPath.h
2828 // NOTE: eventually this will likely also contain node, for proxying
29 ClusterId cluster = 0;
30 EndpointId endpoint = 0;
29 ClusterId cluster = 0;
30 EndpointId endpoint = 0;
31
 uint32_t entityId = 0; // attribute, command, or event id. Ignored if entityWildcarded is true
andy31415288 days ago

how about using a std::optional? then nullopt is "wildcard" otherwise an actual id.

How does one distinguish between this being a attribute, command or event ID? The description should explain this. The "or" is confusing. The IDs here are of a different namespace and are not unique.

E.g. AccessControl::AccessControlExtensionChanged is event 1, AccessControl::extension is attribute 1,

andy31415288 days ago

I think comment should be that this is based on MsgType ... however then why is this separated out? Maybe requestpath should instead be a structure of request that contains all information.

tleacmcsa287 days ago

I believe I have addressed these concerns.

tleacmcsa274 days ago (edited 274 days ago)

Resolving conversation, but tracking here for 1.4 continuation: #34913

andy31415
andy31415 commented on 2024-07-26
Conversation is marked as resolved
Show resolved
src/app/reporting/Engine.cpp
337337 Access::Privilege requestPrivilege = RequiredPrivilege::ForReadEvent(path);
338338
339 err = Access::GetAccessControl().Check(apReadHandler->GetSubjectDescriptor(), requestPath, requestPrivilege);
339
 err = Access::GetAccessControl().Check(apReadHandler->GetSubjectDescriptor(), requestPath, requestPrivilege, MsgType::SubscribeRequest);
andy31415288 days ago

Engine handles both read and subscribe requests. Can we differentiate between them at this point?

tleacmcsa287 days ago

Here we are dealing with events and along with the RequestType I just added, I think I have addressed your concern.

bzbarsky-apple
bzbarsky-apple commented on 2024-07-26
Conversation is marked as resolved
Show resolved
src/access/AccessControl.h
3233namespace chip {
3334namespace Access {
3435
36
using namespace chip::Protocols::InteractionModel;
bzbarsky-apple289 days ago

Please no using outside function/class scope in headers.

tleacmcsa285 days ago

done.

Conversation is marked as resolved
Show resolved
src/access/AccessControl.h
629632
630633 /**
631634 * Check whether access (by a subject descriptor, to a request path,
632 * requiring a privilege) should be allowed or denied.
635
 * requiring a privilege) should be allowed or denied. The IM action
636
 * is provided for context.
bzbarsky-apple288 days ago

It's not clear that the "IM action" is the right abstraction here, or at least it would need a lot more documentation. For example, what happens if someone passes in MsgType::ReportData (which is the obvious action for a subscription report)?

It would be better if there were a clear "operation being performed" enum (more or less matching AccessRestrictionTypeEnum in the spec, but I think the access module has its own data types defined for things like that). Because the fact that for events you should pass SubscribeRequest but for attributes you should pass ReadRequest even if the attribute is in fact being reported due to a subscription is (1) odd and (2) completely un-guessable from this API surface.

Plausible values for that enum would be: ReadAttribute, WriteAttribute, InvokeCommand, ReadEvent.

Also, fundamentally this value here affects how the entityId is interpreted in the RequestPath, right? It seems like fundamentally we should be keeping that information together, in that RequestPath should have an additional member indicating what entityId really means, and we should not have a separate arg here.

tleacmcsa287 days ago

Done.

tleacmcsa274 days ago (edited 274 days ago)

Resolving conversation, but tracking here for 1.4 continuation: #34913

Conversation is marked as resolved
Show resolved
src/access/RequestPath.h
2828 // NOTE: eventually this will likely also contain node, for proxying
29 ClusterId cluster = 0;
30 EndpointId endpoint = 0;
29 ClusterId cluster = 0;
30 EndpointId endpoint = 0;
31
 uint32_t entityId = 0; // attribute, command, or event id. Ignored if entityWildcarded is true
32
 bool entityWildcarded = false;
bzbarsky-apple288 days ago

entityWildcarded seems to be entirely unused (looking at the everything-together PR at #34485. Why is it here?

tleacmcsa288 days ago

Oops, missed it in the PR breakup. Good catch.

tleacmcsa287 days ago

Fixed.

Conversation is marked as resolved
Show resolved
src/app/CommandHandlerImpl.cpp
404404 Access::SubjectDescriptor subjectDescriptor = GetSubjectDescriptor();
405405
 Access::RequestPath requestPath{ .cluster = concretePath.mClusterId, .endpoint = concretePath.mEndpointId };
bzbarsky-apple288 days ago

Don't we need to pass in the entityId here and in other places? Looks like a few places like EventManagement were fixed to do that, but others were not.

It's unfortunate that we are using these structs with no way to force consumers to initialize the data, so the compiler is not catching this problem for us. :(

bzbarsky-apple288 days ago

Maybe we should:

  1. static_assert that kInvalidCommandId, kInvalidAttributeId, and kInvalidEventId are all equal.
  2. Initialize entityId to that value they're all equal to (e.g. to kInvalidAttributeId).
  3. Make sure that Check() fails out immediately if the request path has the invalid value.

That way at least at runtime we will hopefully check places that forget to set the entity id.

tleacmcsa287 days ago

I believe all Check calls have populated requestType and entityId. The more clear requestType should make it clear what entityId represents now. Let me know if you still feel that more is needed.

tcarmelveilleux275 days ago

This is resolved now.

tleacmcsa Addressed review comments
cbb2cc3e
github-actions
github-actions287 days ago (edited 287 days ago)

PR #34537: Size comparison from 4334e91 to cbb2cc3

Increases above 0.2%:

platform target config section 4334e91 cbb2cc3 change % change
telink all-clusters-app tlsr9118bdk40d FLASH 667410 669522 2112 0.3
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 615474 617586 2112 0.3
window-covering tlsr9118bdk40d FLASH 519532 521644 2112 0.4
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4334e91 cbb2cc3 change % change
bl602 lighting-app bl602 FLASH 1274146 1274358 212 0.0
RAM 95424 95432 8 0.0
bl602+mfd FLASH 1288404 1288616 212 0.0
RAM 95568 95584 16 0.0
bl602+rpc FLASH 1313114 1313326 212 0.0
RAM 103848 103856 8 0.0
bl702 lighting-app bl702 FLASH 1095040 1095252 212 0.0
RAM 15245 15257 12 0.1
bl702+mfd FLASH 1105734 1105946 212 0.0
RAM 15397 15401 4 0.0
bl702+rpc FLASH 1185106 1185318 212 0.0
RAM 24245 24253 8 0.0
bl706-eth FLASH 878084 878552 468 0.1
RAM 27348 27360 12 0.0
bl706-wifi FLASH 1130780 1131080 300 0.0
RAM 14681 14693 12 0.1
bl702l lighting-app bl702l FLASH 1081938 1082150 212 0.0
RAM 21800 21812 12 0.1
bl702l+mfd FLASH 1093200 1093412 212 0.0
RAM 21960 21964 4 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 800212 800380 168 0.0
RAM 109276 109284 8 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816684 816852 168 0.0
RAM 117020 117028 8 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808652 808836 184 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762416 762600 184 0.0
RAM 105448 105448 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747068 747236 168 0.0
RAM 105632 105640 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606670 606906 236 0.0
RAM 204564 204580 16 0.0
lock CC3235SF_LAUNCHXL FLASH 652210 652442 232 0.0
RAM 204836 204852 16 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 669281 669481 200 0.0
RAM 77740 77748 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 689141 689333 192 0.0
RAM 80380 80380 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 689141 689333 192 0.0
RAM 80380 80380 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 646077 646269 192 0.0
RAM 72808 72816 8 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609737 609889 152 0.0
RAM 70884 70884 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629365 629525 160 0.0
RAM 73428 73436 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629365 629525 160 0.0
RAM 73428 73436 8 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625433 625601 168 0.0
RAM 73900 73900 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645141 645317 176 0.0
RAM 76444 76452 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645141 645317 176 0.0
RAM 76444 76452 8 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593661 593829 168 0.0
RAM 67852 67860 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613513 613681 168 0.0
RAM 70492 70492 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613513 613681 168 0.0
RAM 70492 70492 0 0.0
efr32 lighting-app BRD4187C FLASH 927248 927432 184 0.0
RAM 134568 134576 8 0.0
lock-app BRD4338a FLASH 734684 734884 200 0.0
RAM 208004 208008 4 0.0
window-app BRD4187C FLASH 1014772 1014996 224 0.0
RAM 126648 126656 8 0.0
esp32 all-clusters-app c3devkit DRAM 91020 91036 16 0.0
FLASH 1482368 1482590 222 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117500 117516 16 0.0
FLASH 1551631 1551839 208 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2710575 2711347 772 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5902302 5903108 806 0.0
RAM 499576 499608 32 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5306932 5307706 774 0.0
RAM 235920 235920 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4707492 4707938 446 0.0
RAM 213664 214048 384 0.2
chip-tool debug unknown 5784 5784 0 0.0
FLASH 12336908 1233777 862 0.0
RAM 553458 553458 0 0.0
chip-tool-ipv6only arm64 unknown 20192 20192 0 0.0
FLASH 11035932 11036604 672 0.0
RAM 603176 603176 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11343039 11343869 830 0.0
RAM 550298 550298 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4463202 4463974 772 0.0
RAM 199248 199248 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5631521 5632289 768 0.0
RAM 224464 224464 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4757958 4758730 772 0.0
RAM 200704 200704 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4402420 4403194 774 0.0
RAM 194880 194880 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4540568 4541342 774 0.0
RAM 199416 199416 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 2991613 2992429 816 0.0
RAM 154056 154088 32 0.0
thermostat-no-ble arm64 unknown 9208 9208 0 0.0
FLASH 4259844 4260500 656 0.0
RAM 236360 236368 8 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5983421 5984189 768 0.0
RAM 578144 578176 32 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10549501 10550429 928 0.0
RAM 638984 638984 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503444 1503636 192 0.0
RAM 226720 226728 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 897228 897444 216 0.0
RAM 141608 141613 5 0.0
nrf7002dk_nrf5340_cpuapp FLASH 962828 963048 220 0.0
RAM 140712 140717 5 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 832644 832828 184 0.0
RAM 140464 140468 4 0.0
nxp contact k32w0+release FLASH 576100 576276 176 0.0
RAM 70104 70112 8 0.0
k32w1+release FLASH 591808 591968 160 0.0
RAM 74144 74152 8 0.0
light k32w0+release FLASH 611696 611872 176 0.0
RAM 69608 69616 8 0.0
k32w1+release FLASH 676528 676712 184 0.0
RAM 82912 82928 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1622948 1623220 272 0.0
RAM 209776 209792 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1533444 1533668 224 0.0
RAM 206584 206584 0 0.0
light cy8ckit_062s2_43012 FLASH 1460468 1460708 240 0.0
RAM 199848 199856 8 0.0
lock cy8ckit_062s2_43012 FLASH 1459668 1459908 240 0.0
RAM 224328 224344 16 0.0
qpg lighting-app qpg6105+debug FLASH 653084 653276 192 0.0
RAM 104680 104688 8 0.0
lock-app qpg6105+debug FLASH 612288 612456 168 0.0
RAM 99320 99328 8 0.0
stm32 light STM32WB5MM-DK FLASH 475408 475592 184 0.0
RAM 144300 144308 8 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 633182 619190 -13992 -2.2
RAM 50576 50664 88 0.2
all-clusters-app tlsr9118bdk40d FLASH 667410 669522 2112 0.3
RAM 148536 147944 -592 -0.4
all-clusters-minimal-app tlsr9528a FLASH 780420 765540 -14880 -1.9
RAM 113300 110140 -3160 -2.8
bridge-app tlsr9258a FLASH 677462 677806 344 0.1
RAM 95384 91320 -4064 -4.3
contact-sensor-app tlsr9528a_retention FLASH 634766 620782 -13984 -2.2
RAM 50620 50708 88 0.2
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720638 706626 -14012 -1.9
RAM 77196 74036 -3160 -4.1
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 615474 617586 2112 0.3
RAM 144724 144128 -596 -0.4
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 803278 803666 388 0.0
RAM 103128 99056 -4072 -3.9
lock-app-dfu tlsr9528a FLASH 666594 652560 -14034 -2.1
RAM 69900 66740 -3160 -4.5
ota-requestor-app tlsr9258a FLASH 695498 695842 344 0.0
RAM 95068 91004 -4064 -4.3
pump-app-usb tlsr9518adk80d FLASH 629838 630136 298 0.0
RAM 59556 55484 -4072 -6.8
pump-controller-app tlsr9518adk80d FLASH 607440 607738 298 0.0
RAM 56800 52728 -4072 -7.2
shell tlsr9518adk80d FLASH 466520 466654 134 0.0
RAM 72488 68412 -4076 -5.6
smoke_co_alarm-app tlsr9528a_retention FLASH 641384 627544 -13840 -2.2
RAM 52248 52344 96 0.2
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651262 651560 298 0.0
RAM 60436 56364 -4072 -6.7
thermostat tlsr9518adk80d FLASH 626148 626446 298 0.0
RAM 57124 53052 -4072 -7.1
window-covering tlsr9118bdk40d FLASH 519532 521644 2112 0.4
RAM 97856 97260 -596 -0.6
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1669024 1669576 552 0.0
RAM 48924 48940 16 0.0
chip-tool-ubsan arm unknown 2388 2388 0 0.0
FLASH 16381654 16384350 2696 0.0
RAM 7190408 7191568 1160 0.0
tleacmcsa Merge branch 'project-chip:master' into arl-acl-api-updates
8edf94c2
github-actions
github-actions286 days ago (edited 286 days ago)

PR #34537: Size comparison from d9bcdd3 to 8edf94c

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section d9bcdd3 8edf94c change % change
bl602 lighting-app bl602 FLASH 1276462 1276662 200 0.0
RAM 95576 95576 0 0.0
bl602+mfd FLASH 1290720 1290920 200 0.0
RAM 95728 95728 0 0.0
bl602+rpc FLASH 1315430 1315886 456 0.0
RAM 104000 104000 0 0.0
bl702 lighting-app bl702 FLASH 1097356 1097556 200 0.0
RAM 15257 15257 0 0.0
bl702+mfd FLASH 1108050 1108250 200 0.0
RAM 15401 15401 0 0.0
bl702+rpc FLASH 1187422 1187622 200 0.0
RAM 24253 24253 0 0.0
bl706-eth FLASH 880656 880856 200 0.0
RAM 27360 27360 0 0.0
bl706-wifi FLASH 1133608 1133896 288 0.0
RAM 14693 14693 0 0.0
bl702l lighting-app bl702l FLASH 1084254 1084710 456 0.0
RAM 21812 21812 0 0.0
bl702l+mfd FLASH 1095516 1095716 200 0.0
RAM 21964 21964 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 801924 802092 168 0.0
RAM 109428 109428 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816684 816852 168 0.0
RAM 117028 117028 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808652 808836 184 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762416 762600 184 0.0
RAM 105448 105448 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747068 747236 168 0.0
RAM 105640 105640 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606674 606906 232 0.0
RAM 204580 204580 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652210 652442 232 0.0
RAM 204852 204852 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671001 671201 200 0.0
RAM 77892 77892 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 690861 691053 192 0.0
RAM 80524 80524 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 690861 691053 192 0.0
RAM 80524 80524 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 647797 647989 192 0.0
RAM 72960 72960 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609713 609889 176 0.0
RAM 70884 70884 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629341 629525 184 0.0
RAM 73436 73436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629341 629525 184 0.0
RAM 73436 73436 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625409 625601 192 0.0
RAM 73900 73900 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645117 645317 200 0.0
RAM 76452 76452 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645117 645317 200 0.0
RAM 76452 76452 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593637 593829 192 0.0
RAM 67860 67860 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613489 613681 192 0.0
RAM 70492 70492 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613489 613681 192 0.0
RAM 70492 70492 0 0.0
efr32 lighting-app BRD4187C FLASH 929000 929184 184 0.0
RAM 134700 134700 0 0.0
lock-app BRD4338a FLASH 734716 734956 240 0.0
RAM 207988 207988 0 0.0
window-app BRD4187C FLASH 1014780 1015028 248 0.0
RAM 126636 126636 0 0.0
esp32 all-clusters-app c3devkit DRAM 91180 91180 0 0.0
FLASH 1484266 1484456 190 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117660 117660 0 0.0
FLASH 1553239 1553407 168 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2710605 2711349 744 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5911254 5911998 744 0.0
RAM 500312 500312 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5315394 5316138 744 0.0
RAM 236592 236592 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4707196 4707940 744 0.0
RAM 214048 214048 0 0.0
chip-tool debug unknown 5784 5784 0 0.0
FLASH 12337160 12337962 802 0.0
RAM 553522 553522 0 0.0
chip-tool-ipv6only arm64 unknown 20192 20192 0 0.0
FLASH 11035980 11036604 624 0.0
RAM 603240 603240 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11343261 11344063 802 0.0
RAM 550362 550362 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4463232 4463976 744 0.0
RAM 199248 199248 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5640753 5641505 752 0.0
RAM 225136 225136 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4757986 4758730 744 0.0
RAM 200704 200704 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4402452 4403196 744 0.0
RAM 194880 194880 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4540598 4541344 746 0.0
RAM 199416 199416 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3000653 3001405 752 0.0
RAM 154760 154760 0 0.0
thermostat-no-ble arm64 unknown 9208 9208 0 0.0
FLASH 4259860 4260500 640 0.0
RAM 236368 236368 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5983453 5984189 736 0.0
RAM 578176 578176 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10549869 10550621 752 0.0
RAM 638984 638984 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503444 1503636 192 0.0
RAM 226728 226728 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 898960 899140 180 0.0
RAM 141757 141757 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 964548 964736 188 0.0
RAM 140861 140861 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 834276 834460 184 0.0
RAM 140612 140612 0 0.0
nxp contact k32w0+release FLASH 576084 576276 192 0.0
RAM 70112 70112 0 0.0
k32w1+release FLASH 591784 591968 184 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 611696 611872 176 0.0
RAM 69616 69616 0 0.0
k32w1+release FLASH 676528 676712 184 0.0
RAM 82928 82928 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1625044 1625284 240 0.0
RAM 209936 209936 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1535284 1535524 240 0.0
RAM 206728 206728 0 0.0
light cy8ckit_062s2_43012 FLASH 1462532 1462772 240 0.0
RAM 200000 200000 0 0.0
lock cy8ckit_062s2_43012 FLASH 1459668 1459908 240 0.0
RAM 224344 224344 0 0.0
qpg lighting-app qpg6105+debug FLASH 654812 655004 192 0.0
RAM 104844 104844 0 0.0
lock-app qpg6105+debug FLASH 612264 612456 192 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 477112 477304 192 0.0
RAM 144452 144452 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619000 619190 190 0.0
RAM 50664 50664 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 671138 671328 190 0.0
RAM 148088 148088 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 767122 767312 190 0.0
RAM 110284 110284 0 0.0
bridge-app tlsr9258a FLASH 677616 677806 190 0.0
RAM 91320 91320 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620592 620782 190 0.0
RAM 50708 50708 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706436 706626 190 0.0
RAM 74036 74036 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 619218 619408 190 0.0
RAM 144272 144272 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 805362 805552 190 0.0
RAM 99200 99200 0 0.0
lock-app-dfu tlsr9528a FLASH 652370 652560 190 0.0
RAM 66740 66740 0 0.0
ota-requestor-app tlsr9258a FLASH 695652 695842 190 0.0
RAM 91004 91004 0 0.0
pump-app-usb tlsr9518adk80d FLASH 629946 630136 190 0.0
RAM 55484 55484 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607548 607738 190 0.0
RAM 52728 52728 0 0.0
shell tlsr9518adk80d FLASH 466654 466654 0 0.0
RAM 68412 68412 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627334 627544 210 0.0
RAM 52344 52344 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651370 651560 190 0.0
RAM 56364 56364 0 0.0
thermostat tlsr9518adk80d FLASH 626256 626446 190 0.0
RAM 53052 53052 0 0.0
window-covering tlsr9118bdk40d FLASH 521454 521644 190 0.0
RAM 97260 97260 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1674116 1674608 492 0.0
RAM 49636 49636 0 0.0
chip-tool-ubsan arm unknown 2388 2388 0 0.0
FLASH 16382014 16384582 2568 0.0
RAM 7190464 7191568 1104 0.0
tleacmcsa tleacmcsa requested a review from andy31415 andy31415 285 days ago
tleacmcsa tleacmcsa requested a review from bzbarsky-apple bzbarsky-apple 285 days ago
bzbarsky-apple
bzbarsky-apple commented on 2024-07-29
Conversation is marked as resolved
Show resolved
src/access/RequestPath.h
40 EndpointId endpoint = 0;
41 RequestType requestType = RequestType::kRequestTypeUnknown;
42
43
 //entityId represents an attribute, command, or event ID, which is determined by the requestType. Wildcard if omitted.
bzbarsky-apple285 days ago

OK, so what request type is used for an event read (not subscribe)?

tleacmcsa285 days ago

There is some confusion with the spec here (at least to me). The algorithm section 6.6.5.2 seems to only check subscriptions for events, but the cluster spec section 9.10.5.3 only refers to reading events, not subscribing. I agree, it makes sense to be able to restrict access to both.

bzbarsky-apple284 days ago

Fundamentally, "read" vs "subscribe" is not a useful distinction for access purposes. The distinctions we care about are:

  1. What does the entity id represent? Is it an attribute, event, or command?
  2. Which access type are we performing? Really, for events and commands there is only one access type (read and invoke respectively), while for attributes there are potentially two: read and write.
tleacmcsa278 days ago

This should be resolved.

Conversation is marked as resolved
Show resolved
src/access/RequestPath.h
41 RequestType requestType = RequestType::kRequestTypeUnknown;
42
43 //entityId represents an attribute, command, or event ID, which is determined by the requestType. Wildcard if omitted.
44
 std::optional<uint32_t> entityId;
bzbarsky-apple285 days ago

So wildcarding is used here only for "reading or subscribing to events" and "it's a wildcard path", right?

But then how is this meant to be implemented, exactly? We really do need to know what events are involved to do the relevant checks correctly for ARL, no?

tleacmcsa285 days ago

A wildcard here would only make sense when reading events or attributes, or subscribing to them, yes.

If a request is made using a wildcard, restriction checks would fail if there is any intersection between that and what is restricted. Meaning, a single attribute/event restriction entry would block a wildcard request if that wildcard would have included the entry.

Make sense? Or am I missing something?

bzbarsky-apple284 days ago

That's not how wildcards are supposed to work with access check failures. The way it's supposed to work is that you just exclude anything you don't have access to from the set of things you actually get reports on. If that results in an empty set, the whole subscription is denied.

But doing whole-node wildcard subscriptions is the normal way controllers operate. If you disallow those if there is "any intersection", you would break every controller out there.

tleacmcsa278 days ago

Got it. Wildcard subscriptions will succeed. The check will be on the event read and at time of event delivery.

Conversation is marked as resolved
Show resolved
src/access/AccessControl.cpp
341 GetRequestTypeStringForLogging(requestPath.requestType));
324342 }
325343#endif // CHIP_PROGRESS_LOGGING && CHIP_CONFIG_ACCESS_CONTROL_POLICY_LOGGING_VERBOSITY > 1
326344
bzbarsky-apple285 days ago

Doesn't this need to fail out if the RequestPath is not well-formed (i.e. request type is unknown)?

tleacmcsa285 days ago

Fixed.

tcarmelveilleux275 days ago

This is no longer fiexed.

tleacmcsa275 days ago

Correct. @tcarmelveilleux requested that this validation be done behind an ARL capability check, which is coming in the main ARL PR.

tleacmcsa275 days ago

Ok, another pass at this topic: a check was put in place that will only run if ARL feature is enabled. It is not enabled as of this PR.

Conversation is marked as resolved
Show resolved
src/access/AccessControl.h
2525#include <lib/core/CHIPCore.h>
2626#include <lib/core/Global.h>
2727#include <lib/support/CodeUtils.h>
28
#include <protocols/interaction_model/Constants.h>
bzbarsky-apple285 days ago

Why is this needed?

tleacmcsa285 days ago

Removed.

hawk248
hawk248 approved these changes on 2024-07-29
tleacmcsa Merge branch 'project-chip:master' into arl-acl-api-updates
88884005
tleacmcsa Merge branch 'project-chip:master' into arl-acl-api-updates
8dbf1ac6
github-actions
github-actions285 days ago (edited 285 days ago)

PR #34537: Size comparison from 7153cbd to 8dbf1ac

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 7153cbd 8dbf1ac change % change
bl602 lighting-app bl602 FLASH 1277116 1277316 200 0.0
RAM 95888 95888 0 0.0
bl602+mfd FLASH 1291374 1291574 200 0.0
RAM 96040 96040 0 0.0
bl602+rpc FLASH 1316084 1316284 200 0.0
RAM 104312 104312 0 0.0
bl702 lighting-app bl702 FLASH 1098268 1098468 200 0.0
RAM 15241 15241 0 0.0
bl702+mfd FLASH 1108962 1109162 200 0.0
RAM 15385 15385 0 0.0
bl702+rpc FLASH 1188334 1188534 200 0.0
RAM 24237 24237 0 0.0
bl706-eth FLASH 881302 881502 200 0.0
RAM 27344 27344 0 0.0
bl706-wifi FLASH 1134400 1134688 288 0.0
RAM 14677 14677 0 0.0
bl702l lighting-app bl702l FLASH 1085166 1085622 456 0.0
RAM 21796 21796 0 0.0
bl702l+mfd FLASH 1096428 1096628 200 0.0
RAM 21948 21948 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802304 802488 184 0.0
RAM 109844 109844 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816996 817180 184 0.0
RAM 117444 117444 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808992 809160 168 0.0
RAM 111724 111724 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762756 762924 168 0.0
RAM 105864 105864 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747392 747576 184 0.0
RAM 106056 106056 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610134 610382 248 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652614 652846 232 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671369 671553 184 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691221 691413 192 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691221 691413 192 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648157 648349 192 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610017 610193 176 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629653 629821 168 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629653 629821 168 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625721 625897 176 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645429 645613 184 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645429 645613 184 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599437 599621 184 0.0
RAM 68364 68364 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619297 619481 184 0.0
RAM 70996 70996 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619297 619481 184 0.0
RAM 70996 70996 0 0.0
efr32 lighting-app BRD4187C FLASH 929392 929584 192 0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 735076 735316 240 0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015188 1015412 224 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 91564 91564 0 0.0
FLASH 1488748 1488938 190 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 118052 118052 0 0.0
FLASH 1557607 1557771 164 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2729683 2730459 776 0.0
RAM 128272 128272 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5969464 5970208 744 0.0
RAM 505944 505944 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5333048 5333792 744 0.0
RAM 239632 239632 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4710496 4711240 744 0.0
RAM 216960 216960 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12396394 12397196 802 0.0
RAM 555418 555418 0 0.0
chip-tool-ipv6only arm64 unknown 20256 20256 0 0.0
FLASH 11084652 11085276 624 0.0
RAM 605296 605296 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11377253 11378055 802 0.0
RAM 552154 552154 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4466484 4467228 744 0.0
RAM 202128 202128 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5644417 5645153 736 0.0
RAM 228048 228048 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4761282 4762026 744 0.0
RAM 203616 203616 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4405672 4406448 776 0.0
RAM 197760 197760 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4543818 4544596 778 0.0
RAM 202296 202296 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3018989 3019725 736 0.0
RAM 158472 158472 0 0.0
thermostat-no-ble arm64 unknown 9344 9344 0 0.0
FLASH 4343532 4344156 624 0.0
RAM 242112 242112 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5987301 5988053 752 0.0
RAM 582208 582208 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10599965 10600701 736 0.0
RAM 642200 642200 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503716 1503844 128 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 901760 901944 184 0.0
RAM 142084 142084 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 967184 967372 188 0.0
RAM 141188 141188 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 836684 836864 180 0.0
RAM 140944 140944 0 0.0
nxp contact k32w0+release FLASH 576348 576524 176 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592080 592264 184 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612008 612184 176 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 676904 677088 184 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1628732 1628972 240 0.0
RAM 210760 210760 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1538452 1538692 240 0.0
RAM 207536 207536 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463348 240 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1460132 1460372 240 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655084 655276 192 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612520 612712 192 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477448 477640 192 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619270 619460 190 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 673630 673820 190 0.0
RAM 149412 149412 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 769550 769740 190 0.0
RAM 110612 110612 0 0.0
bridge-app tlsr9258a FLASH 677882 678072 190 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620862 621052 190 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706726 706916 190 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 619648 619838 190 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 805734 805924 190 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 652640 652830 190 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 695918 696108 190 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630216 630406 190 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607818 608008 190 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466794 466794 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627626 627836 210 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651640 651830 190 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631406 631596 190 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 521780 521970 190 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1682724 1683220 496 0.0
RAM 51668 51668 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16453266 16455834 2568 0.0
RAM 7226264 7227368 1104 0.0
tcarmelveilleux
tcarmelveilleux commented on 2024-07-30
Conversation is marked as resolved
Show resolved
src/access/RequestPath.h
30 kReadRequest,
31 kWriteRequest,
32 kInvokeRequest,
33
 kSubscribeEventRequest
tcarmelveilleux285 days ago

Why is subscribe event called out here? Subscribe privileges are the same as read privileges

tleacmcsa285 days ago (edited 285 days ago)

In the spec:

if arl_restriction.Type == AccessRestrictionTypeEnum.EventForbidden and
action.Type == Action.TypeEnum.SubscribeRequest:
# if the event id is NULL (wildcard) or matches the cluster_element
if arl_restriction.ID == NULL or arl_restriction.ID == cluster_element:
# then no granted privileges
return set()

Maybe this needs to be clarified. What we are really after is restricting access to an event(s), regardless of if its an attempt to read or subscribe. These enum entries capture the requested action, which could be read or subscribe.

bzbarsky-apple284 days ago

Fundamentally: the spec is broken here.

tcarmelveilleux275 days ago

The fact that it's events separate from attributes is weird. Let's fix follow-up, though.

tleacmcsa274 days ago (edited 274 days ago)

Resolving conversation, but tracking here for 1.4 continuation: #34913

tleacmcsa Addressed review comments
53150f33
github-actions
github-actions285 days ago (edited 285 days ago)

PR #34537: Size comparison from 7153cbd to 53150f3

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 7153cbd 53150f3 change % change
bl602 lighting-app bl602 FLASH 1277116 1277336 220 0.0
RAM 95888 95888 0 0.0
bl602+mfd FLASH 1291374 1291594 220 0.0
RAM 96040 96040 0 0.0
bl602+rpc FLASH 1316084 1316560 476 0.0
RAM 104312 104312 0 0.0
bl702 lighting-app bl702 FLASH 1098268 1098488 220 0.0
RAM 15241 15241 0 0.0
bl702+mfd FLASH 1108962 1109438 476 0.0
RAM 15385 15385 0 0.0
bl702+rpc FLASH 1188334 1188554 220 0.0
RAM 24237 24237 0 0.0
bl706-eth FLASH 881302 881522 220 0.0
RAM 27344 27344 0 0.0
bl706-wifi FLASH 1134400 1134702 302 0.0
RAM 14677 14677 0 0.0
bl702l lighting-app bl702l FLASH 1085166 1085642 476 0.0
RAM 21796 21796 0 0.0
bl702l+mfd FLASH 1096428 1096904 476 0.0
RAM 21948 21948 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802304 802512 208 0.0
RAM 109844 109844 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816996 817196 200 0.0
RAM 117444 117444 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808992 809176 184 0.0
RAM 111724 111724 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762756 762940 184 0.0
RAM 105864 105864 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747392 747592 200 0.0
RAM 106056 106056 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610134 610406 272 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652614 652886 272 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671369 671585 216 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691221 691445 224 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691221 691445 224 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648157 648381 224 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610017 610225 208 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629653 629853 200 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629653 629853 200 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625721 625921 200 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645429 645637 208 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645429 645637 208 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599437 599645 208 0.0
RAM 68364 68364 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619297 619505 208 0.0
RAM 70996 70996 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619297 619505 208 0.0
RAM 70996 70996 0 0.0
efr32 lighting-app BRD4187C FLASH 929392 929616 224 0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 735076 735348 272 0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015188 1015444 256 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 91564 91564 0 0.0
FLASH 1488748 1488974 226 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 118052 118052 0 0.0
FLASH 1557607 1557803 196 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2729683 2730535 852 0.0
RAM 128272 128272 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5969464 5970284 820 0.0
RAM 505944 505944 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5333048 5333868 820 0.0
RAM 239632 239632 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4710496 4711316 820 0.0
RAM 216960 216960 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12396394 12397272 878 0.0
RAM 555418 555418 0 0.0
chip-tool-ipv6only arm64 unknown 20256 20256 0 0.0
FLASH 11084652 11085356 704 0.0
RAM 605296 605296 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11377253 11378131 878 0.0
RAM 552154 552154 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4466484 4467304 820 0.0
RAM 202128 202128 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5644417 5645233 816 0.0
RAM 228048 228048 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4761282 4762102 820 0.0
RAM 203616 203616 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4405672 4406524 852 0.0
RAM 197760 197760 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4543818 4544670 852 0.0
RAM 202296 202296 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3018989 3019805 816 0.0
RAM 158472 158472 0 0.0
thermostat-no-ble arm64 unknown 9344 9344 0 0.0
FLASH 4343532 4344252 720 0.0
RAM 242112 242112 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5987301 5988133 832 0.0
RAM 582208 582208 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10599965 10600781 816 0.0
RAM 642200 642200 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503716 1503908 192 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 901760 901968 208 0.0
RAM 142084 142084 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 967184 967424 240 0.0
RAM 141188 141188 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 836684 836888 204 0.0
RAM 140944 140944 0 0.0
nxp contact k32w0+release FLASH 576348 576588 240 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592080 592288 208 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612008 612216 208 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 676904 677112 208 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1628732 1628988 256 0.0
RAM 210760 210760 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1538452 1538724 272 0.0
RAM 207536 207536 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463364 256 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1460132 1460388 256 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655084 655300 216 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612520 612736 216 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477448 477664 216 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619270 619494 224 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 673630 673856 226 0.0
RAM 149412 149412 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 769550 769776 226 0.0
RAM 110612 110612 0 0.0
bridge-app tlsr9258a FLASH 677882 678108 226 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620862 621086 224 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706726 706950 224 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 619648 619874 226 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 805734 805960 226 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 652640 652864 224 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 695918 696142 224 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630216 630442 226 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607818 608042 224 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466794 466794 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627626 627870 244 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651640 651864 224 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631406 631630 224 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 521780 522004 224 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1682724 1683264 540 0.0
RAM 51668 51668 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16453266 16455930 2664 0.0
RAM 7226264 7227400 1136 0.0
tleacmcsa Clarified RequestType enum values and purpose
5b061bef
tleacmcsa Merge branch 'master' into arl-acl-api-updates
4084522b
github-actions
github-actions283 days ago (edited 283 days ago)

PR #34537: Size comparison from fb1d2d8 to 4084522

Full report (16 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
platform target config section fb1d2d8 4084522 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802368 802536 168 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 817044 817212 168 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 809040 809208 168 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762804 762972 168 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747456 747624 168 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610142 610398 256 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652622 652878 256 0.0
RAM 205620 205620 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503780 1503908 128 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906524 906712 188 0.0
RAM 142221 142221 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879524 879664 140 0.0
RAM 140360 140360 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838280 838464 184 0.0
RAM 141062 141062 0 0.0
qpg lighting-app qpg6105+debug FLASH 655124 655324 200 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612560 612760 200 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477496 477688 192 0.0
RAM 144756 144756 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1701428 1701952 524 0.0
RAM 51812 51812 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16607826 16610466 2640 0.0
RAM 7297180 7298316 1136 0.0
tleacmcsa Renamed CanAccess to CanAccessEvent
5f3bba00
github-actions
github-actions283 days ago (edited 283 days ago)

PR #34537: Size comparison from fb1d2d8 to 5f3bba0

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section fb1d2d8 5f3bba0 change % change
bl602 lighting-app bl602 FLASH 1277128 1277348 220 0.0
RAM 95888 95888 0 0.0
bl602+mfd FLASH 1291386 1291606 220 0.0
RAM 96040 96040 0 0.0
bl602+rpc FLASH 1316096 1316572 476 0.0
RAM 104312 104312 0 0.0
bl702 lighting-app bl702 FLASH 1098280 1098500 220 0.0
RAM 15241 15241 0 0.0
bl702+mfd FLASH 1108974 1109450 476 0.0
RAM 15385 15385 0 0.0
bl702+rpc FLASH 1188346 1188566 220 0.0
RAM 24237 24237 0 0.0
bl706-eth FLASH 881314 881534 220 0.0
RAM 27344 27344 0 0.0
bl706-wifi FLASH 1134412 1134714 302 0.0
RAM 14677 14677 0 0.0
bl702l lighting-app bl702l FLASH 1085434 1085654 220 0.0
RAM 21796 21796 0 0.0
bl702l+mfd FLASH 1096440 1096916 476 0.0
RAM 21948 21948 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802368 802536 168 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 817044 817212 168 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 809040 809208 168 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762804 762972 168 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747456 747624 168 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610142 610398 256 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652622 652878 256 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671425 671625 200 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691285 691477 192 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691285 691477 192 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648213 648421 208 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610065 610265 200 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629701 629893 192 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629701 629893 192 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625777 625953 176 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645485 645669 184 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645485 645669 184 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599533 599717 184 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619393 619577 184 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619393 619577 184 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929456 929648 192 0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 735108 735348 240 0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015188 1015444 256 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 91708 91708 0 0.0
FLASH 1494346 1494546 200 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 118188 118188 0 0.0
FLASH 1563183 1563367 184 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2734851 2735679 828 0.0
RAM 128272 128272 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6016436 6017232 796 0.0
RAM 509808 509808 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5355850 5356646 796 0.0
RAM 239936 239936 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4715534 4716330 796 0.0
RAM 216960 216960 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12485290 12486144 854 0.0
RAM 558298 558298 0 0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11164972 11165644 672 0.0
RAM 608232 608232 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11463497 11464351 854 0.0
RAM 555034 555034 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4471618 4472414 796 0.0
RAM 202128 202128 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5649665 5650465 800 0.0
RAM 228048 228048 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4766354 4767150 796 0.0
RAM 203616 203616 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4410772 4411600 828 0.0
RAM 197760 197760 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4548886 4549714 828 0.0
RAM 202296 202296 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3055069 3055853 784 0.0
RAM 158856 158856 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4347972 4348644 672 0.0
RAM 242128 242128 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5993317 5994117 800 0.0
RAM 583488 583488 0 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10689805 1069060 800 0.0
RAM 645544 645544 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503780 1503908 128 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906524 906712 188 0.0
RAM 142221 142221 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879524 879664 140 0.0
RAM 140360 140360 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838280 838464 184 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576412 576588 176 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592136 592320 184 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612056 612248 192 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 676968 677136 168 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1635716 1635972 256 0.0
RAM 210904 210904 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1540908 1541148 240 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463124 1463380 256 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1460148 1460404 256 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655124 655324 200 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612560 612760 200 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477496 477688 192 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619336 619536 200 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 678126 678326 200 0.0
RAM 149552 149552 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 771360 771560 200 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 677950 678150 200 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620928 621128 200 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706792 706992 200 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 619716 619916 200 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 805802 806002 200 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 652706 652906 200 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 695984 696184 200 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630284 630484 200 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607884 608084 200 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627696 627916 220 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651706 651906 200 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631472 631672 200 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 521846 522046 200 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1701428 1701952 524 0.0
RAM 51812 51812 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16607826 16610466 2640 0.0
RAM 7297180 7298316 1136 0.0
tleacmcsa tleacmcsa requested a review from bzbarsky-apple bzbarsky-apple 278 days ago
tleacmcsa tleacmcsa requested a review from tcarmelveilleux tcarmelveilleux 278 days ago
chrisdecenzo
chrisdecenzo approved these changes on 2024-08-06
tleacmcsa Merge branch 'project-chip:master' into arl-acl-api-updates
39a299fe
github-actions
github-actions277 days ago (edited 276 days ago)

PR #34537: Size comparison from a0fac9f to 39a299f

Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a0fac9f 39a299f change % change
bl602 lighting-app bl602 FLASH 1278102 1278322 220 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292360 1292580 220 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317062 1317538 476 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1099242 1099462 220 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109936 1110412 476 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189308 1189528 220 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 882276 882496 220 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135446 1135748 302 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086404 1086624 220 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097410 1097886 476 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802832 803008 176 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818636 818812 176 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810968 811160 192 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763220 763404 184 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747728 747912 184 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612238 612494 256 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654750 654990 240 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671945 672137 192 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691797 691997 200 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691797 691997 200 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648741 648925 184 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610385 610577 192 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630021 630205 184 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630021 630205 184 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627833 628025 192 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647549 647733 184 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647549 647733 184 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601093 601285 192 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 620953 621145 192 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 620953 621145 192 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929896 930048 152 0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737084 737316 232 0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015476 1015732 256 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94160 94160 0 0.0
FLASH 1532136 1532336 200 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542266 1542450 184 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2752315 2753143 828 0.0
RAM 128272 128272 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6032206 6033002 796 0.0
RAM 510128 510128 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5373196 5373992 796 0.0
RAM 239936 239936 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727382 4728178 796 0.0
RAM 216960 216960 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12490026 12490880 854 0.0
RAM 557914 557914 0 0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11169596 11170284 688 0.0
RAM 607920 607920 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11472803 11473657 854 0.0
RAM 554650 554650 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483624 4484420 796 0.0
RAM 202384 202384 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661569 5662353 784 0.0
RAM 228048 228048 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4781918 4782714 796 0.0
RAM 203776 203776 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422230 4423058 828 0.0
RAM 197760 197760 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560840 4561668 828 0.0
RAM 202296 202296 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3073885 3074685 800 0.0
RAM 159048 159048 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4360580 4361252 672 0.0
RAM 242232 242232 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6005317 6006101 784 0.0
RAM 583584 583584 0 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10693901 10694701 800 0.0
RAM 645064 645064 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908224 908408 184 0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880332 880452 120 0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839876 840064 188 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 577068 577260 192 0.0
RAM 70472 70472 0 0.0
k32w1+release FLASH 592384 592568 184 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612528 612704 176 0.0
RAM 69944 69944 0 0.0
k32w1+release FLASH 677360 677528 168 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637476 1637716 240 0.0
RAM 210928 210928 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1542908 1543164 256 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463492 1463748 256 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462124 1462364 240 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655796 200 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612920 613120 200 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477960 478152 192 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619736 619936 200 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 679796 679996 200 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 772852 773052 200 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678440 678640 200 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621328 621528 200 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707192 707392 200 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620246 620446 200 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806332 806532 200 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654184 654384 200 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696472 696672 200 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630774 630974 200 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608284 608484 200 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628096 628316 220 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652106 652306 200 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 633086 633286 200 0.0
RAM 53380 53380 0 0.0
window-covering tlsr9118bdk40d FLASH 522246 522446 200 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 4824 4824 0 0.0
FLASH 1695540 1696056 516 0.0
RAM 89176 89176 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17324534 17327326 2792 0.0
RAM 7565032 7566168 1136 0.0
restyled-commits Restyled by whitespace
f1496edb
restyled-commits Restyled by clang-format
50250a65
tleacmcsa Fixed some build issues
d732ebad
pullapprove pullapprove requested a review from andyg-apple andyg-apple 276 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 276 days ago
pullapprove pullapprove requested a review from arkq arkq 276 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 276 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 276 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 276 days ago
pullapprove pullapprove requested a review from cecille cecille 276 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 276 days ago
pullapprove pullapprove requested a review from chshu chshu 276 days ago
pullapprove pullapprove requested a review from chulspro chulspro 276 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 276 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 276 days ago
pullapprove pullapprove requested a review from doru91 doru91 276 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 276 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 276 days ago
pullapprove pullapprove requested a review from hicklin hicklin 276 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 276 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 276 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 276 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 276 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 276 days ago
pullapprove pullapprove requested a review from kiel-apple kiel-apple 276 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 276 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 276 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 276 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 276 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 276 days ago
pullapprove pullapprove requested a review from mhazley mhazley 276 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 276 days ago
pullapprove pullapprove requested a review from mspang mspang 276 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 276 days ago
pullapprove pullapprove requested a review from p0fi p0fi 276 days ago
pullapprove pullapprove requested a review from pidarped pidarped 276 days ago
pullapprove pullapprove requested a review from plauric plauric 276 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 276 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 276 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 276 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 276 days ago
pullapprove pullapprove requested a review from selissia selissia 276 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 276 days ago
pullapprove pullapprove requested a review from tima-q tima-q 276 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 276 days ago
pullapprove pullapprove requested a review from turon turon 276 days ago
pullapprove pullapprove requested a review from vivien-apple vivien-apple 276 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 276 days ago
pullapprove pullapprove requested a review from woody-apple woody-apple 276 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 276 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 276 days ago
pullapprove pullapprove requested a review from yunhanw-google yunhanw-google 276 days ago
pullapprove pullapprove added review - approved
github-actions
tleacmcsa Fixed icd-management-server for ARL
29aadb21
tleacmcsa fixed typo in previous fix :-(
192ea0a9
restyled-commits Restyled by clang-format
528782a1
tcarmelveilleux
tcarmelveilleux commented on 2024-08-08
Conversation is marked as resolved
Show resolved
src/access/tests/TestAccessControl.cpp
821821 // Checks for implicit PASE
822822 { .subjectDescriptor = { .fabricIndex = 0, .authMode = AuthMode::kPase, .subject = kPaseVerifier0 },
823 .requestPath = { .cluster = 1, .endpoint = 2 },
823
 .requestPath = { .cluster = 1, .endpoint = 2, .requestType = RequestType::kAttributeReadRequest },
tcarmelveilleux276 days ago

Why not leave as unknown?

Unless ARL is hooked-up and implemented (which it isn't in this PR), all the tests should still pass with the current cases having unknown.

I only expect future NEW tests to test ARL, AFTER setting an ARL over top of the non-ARL test data.

tleacmcsa276 days ago

The updated contract to existing ACL code is that requestType is required to be set per Boris' request/comment or it will fail the Check. I think it makes sense to validate this argument is provided correctly along with this change.

tleacmcsa Moved ARL related checks behind ARL feature flag
fc2d980b
tleacmcsa Add conditional ARL related validation
679f020a
tcarmelveilleux
tcarmelveilleux approved these changes on 2024-08-08
restyled-commits Restyled by clang-format
efead089
mergify mergify merged 5ad899a8 into master 274 days ago
tleacmcsa tleacmcsa deleted the arl-acl-api-updates branch 274 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
app review - approved
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum