connectedhomeip
Fix most TC-SWTCH-2.4 remaining issues
#34677
Merged
Overview
Commits
1
Changes
View On GitHub

Fix most TC-SWTCH-2.4 remaining issues #34677

andy31415 merged 1 commit into project-chip:master from tcarmelveilleux:fix-2.2
tcarmelveilleux
tcarmelveilleux246 days ago
  • Move 2.4 in a better place in the file
  • Add test steps properly
  • Allow default button press position override

Issue #34656

Testing done:

  • Test still passes on DUT with automation
tcarmelveilleux Fix most TC-SWTCH-2.4 remaining issues
827fa453
semanticdiff-com
semanticdiff-com246 days ago (edited 246 days ago)

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 59% smaller than the GitHub diff.

Filename Status
✔️ src/python_testing/TC_SWTCH.py 58.92% smaller
github-actions github-actions added tests
pullapprove pullapprove requested a review from andyg-apple andyg-apple 246 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 246 days ago
pullapprove pullapprove requested a review from arkq arkq 246 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 246 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 246 days ago
pullapprove pullapprove requested a review from bzbarsky-apple bzbarsky-apple 246 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 246 days ago
pullapprove pullapprove requested a review from cecille cecille 246 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 246 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 246 days ago
pullapprove pullapprove requested a review from chshu chshu 246 days ago
pullapprove pullapprove requested a review from chulspro chulspro 246 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 246 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 246 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 246 days ago
pullapprove pullapprove requested a review from doru91 doru91 246 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 246 days ago
pullapprove pullapprove requested a review from harimau-qirex harimau-qirex 246 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 246 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 246 days ago
pullapprove pullapprove requested a review from hicklin hicklin 246 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 246 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 246 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 246 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 246 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 246 days ago
pullapprove pullapprove requested a review from kiel-apple kiel-apple 246 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 246 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 246 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 246 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 246 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 246 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 246 days ago
pullapprove pullapprove requested a review from mhazley mhazley 246 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 246 days ago
pullapprove pullapprove requested a review from mspang mspang 246 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 246 days ago
pullapprove pullapprove requested a review from p0fi p0fi 246 days ago
pullapprove pullapprove requested a review from pidarped pidarped 246 days ago
pullapprove pullapprove requested a review from plauric plauric 246 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 246 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 246 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 246 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 246 days ago
pullapprove pullapprove requested a review from selissia selissia 246 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 246 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 246 days ago
pullapprove pullapprove requested a review from tehampson tehampson 246 days ago
pullapprove pullapprove requested a review from tima-q tima-q 246 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 246 days ago
pullapprove pullapprove requested a review from turon turon 246 days ago
pullapprove pullapprove requested a review from vivien-apple vivien-apple 246 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 246 days ago
pullapprove pullapprove requested a review from woody-apple woody-apple 246 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 246 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 246 days ago
pullapprove pullapprove requested a review from yunhanw-google yunhanw-google 246 days ago
pullapprove pullapprove requested a review from andyg-apple andyg-apple 246 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 246 days ago
pullapprove pullapprove requested a review from arkq arkq 246 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 246 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 246 days ago
pullapprove pullapprove requested a review from bzbarsky-apple bzbarsky-apple 246 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 246 days ago
pullapprove pullapprove requested a review from cecille cecille 246 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 246 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 246 days ago
pullapprove pullapprove requested a review from chshu chshu 246 days ago
pullapprove pullapprove requested a review from chulspro chulspro 246 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 246 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 246 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 246 days ago
pullapprove pullapprove requested a review from doru91 doru91 246 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 246 days ago
pullapprove pullapprove requested a review from harimau-qirex harimau-qirex 246 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 246 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 246 days ago
pullapprove pullapprove requested a review from hicklin hicklin 246 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 246 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 246 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 246 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 246 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 246 days ago
pullapprove pullapprove added review - pending
pullapprove pullapprove requested a review from kiel-apple kiel-apple 246 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 246 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 246 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 246 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 246 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 246 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 246 days ago
pullapprove pullapprove requested a review from mhazley mhazley 246 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 246 days ago
pullapprove pullapprove requested a review from mspang mspang 246 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 246 days ago
pullapprove pullapprove requested a review from p0fi p0fi 246 days ago
pullapprove pullapprove requested a review from pidarped pidarped 246 days ago
pullapprove pullapprove requested a review from plauric plauric 246 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 246 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 246 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 246 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 246 days ago
pullapprove pullapprove requested a review from selissia selissia 246 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 246 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 246 days ago
pullapprove pullapprove requested a review from tehampson tehampson 246 days ago
pullapprove pullapprove requested a review from tima-q tima-q 246 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 246 days ago
pullapprove pullapprove requested a review from turon turon 246 days ago
pullapprove pullapprove requested a review from vivien-apple vivien-apple 246 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 246 days ago
pullapprove pullapprove requested a review from woody-apple woody-apple 246 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 246 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 246 days ago
pullapprove pullapprove requested a review from yunhanw-google yunhanw-google 246 days ago
pullapprove pullapprove removed tests
pullapprove pullapprove added tests
github-actions
github-actions246 days ago (edited 246 days ago)

PR #34677: Size comparison from 6da66b7 to 827fa45

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 6da66b7 827fa45 change % change
bl602 lighting-app bl602 FLASH 1277128 1277128 0 0.0
RAM 95888 95888 0 0.0
bl602+mfd FLASH 1291386 1291386 0 0.0
RAM 96040 96040 0 0.0
bl602+rpc FLASH 1316096 1316096 0 0.0
RAM 104312 104312 0 0.0
bl702 lighting-app bl702 FLASH 1098280 1098280 0 0.0
RAM 15241 15241 0 0.0
bl702+mfd FLASH 1108974 1108974 0 0.0
RAM 15385 15385 0 0.0
bl702+rpc FLASH 1188346 1188346 0 0.0
RAM 24237 24237 0 0.0
bl706-eth FLASH 881314 881314 0 0.0
RAM 27344 27344 0 0.0
bl706-wifi FLASH 1134412 1134412 0 0.0
RAM 14677 14677 0 0.0
bl702l lighting-app bl702l FLASH 1085434 1085434 0 0.0
RAM 21796 21796 0 0.0
bl702l+mfd FLASH 1096440 1096440 0 0.0
RAM 21948 21948 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802368 802368 0 0.0
RAM 109844 109844 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 817044 817044 0 0.0
RAM 117444 117444 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 809040 809040 0 0.0
RAM 111724 111724 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762804 762804 0 0.0
RAM 105864 105864 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747456 747456 0 0.0
RAM 106056 106056 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610142 610142 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652622 652622 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671425 671425 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691285 691285 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691285 691285 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648213 648213 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610065 610065 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629701 629701 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629701 629701 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625777 625777 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645485 645485 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645485 645485 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599533 599533 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619393 619393 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619393 619393 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929456 929456 0 0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 735108 735108 0 0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015188 1015188 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 91580 91580 0 0.0
FLASH 1492470 1492470 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 118068 118068 0 0.0
FLASH 1561391 1561391 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2729823 2729823 0 0.0
RAM 128272 128272 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5991832 5991832 0 0.0
RAM 508752 508752 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5333156 5333156 0 0.0
RAM 239632 239632 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4710604 4710604 0 0.0
RAM 216960 216960 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12404462 12404462 0 0.0
RAM 556122 556122 0 0.0
chip-tool-ipv6only arm64 unknown 20264 20264 0 0.0
FLASH 11090460 11090460 0 0.0
RAM 606008 606008 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11384595 11384595 0 0.0
RAM 552858 552858 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4466624 4466624 0 0.0
RAM 202128 202128 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5644513 5644513 0 0.0
RAM 228048 228048 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4761390 4761390 0 0.0
RAM 203616 203616 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4405812 4405812 0 0.0
RAM 197760 197760 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4543926 4543926 0 0.0
RAM 202296 202296 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3032397 3032397 0 0.0
RAM 158536 158536 0 0.0
thermostat-no-ble arm64 unknown 9344 9344 0 0.0
FLASH 4343716 4343716 0 0.0
RAM 242128 242128 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5987701 5987701 0 0.0
RAM 582720 582720 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10608061 10608061 0 0.0
RAM 642920 642920 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503780 1503780 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 904976 904976 0 0.0
RAM 142103 142103 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 878124 878124 0 0.0
RAM 140242 140242 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 836728 836728 0 0.0
RAM 140944 140944 0 0.0
nxp contact k32w0+release FLASH 576412 576412 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592136 592136 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612056 612056 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 676968 676968 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1633292 1633292 0 0.0
RAM 210784 210784 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1538484 1538484 0 0.0
RAM 207536 207536 0 0.0
light cy8ckit_062s2_43012 FLASH 1463124 1463124 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1460148 1460148 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655124 655124 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612560 612560 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477496 477496 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619336 619336 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 676384 676384 0 0.0
RAM 149432 149432 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 769618 769618 0 0.0
RAM 110612 110612 0 0.0
bridge-app tlsr9258a FLASH 677950 677950 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620928 620928 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706792 706792 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 619716 619716 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 805802 805802 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 652706 652706 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 695984 695984 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630284 630284 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607884 607884 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627696 627696 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651706 651706 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631472 631472 0 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 521846 521846 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1690788 1690788 0 0.0
RAM 51692 51692 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16464378 16464378 0 0.0
RAM 7230388 7230388 0 0.0
cecille
cecille approved these changes on 2024-07-31
rbultman
rbultman approved these changes on 2024-07-31
andy31415 andy31415 merged fbbcc7d9 into master 246 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
review - pending tests
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum