connectedhomeip
TBRM: Add missing PendingDatasetTimestamp attribute and CASE session check
#34768
Merged
Overview
Commits
8
Changes
View On GitHub

TBRM: Add missing PendingDatasetTimestamp attribute and CASE session check #34768

woody-apple merged 8 commits into project-chip:master from wqx6:tbrm/add_attribute
wqx6
wqx6236 days ago (edited 236 days ago)

Add the PendingDatasetTimestamp to ThreadBorderRouterManagement cluster and add CASE session check for SetDataset commands.

Fixes #34751

wqx6 TBRM: Add missing PendingDatasetTimestamp attribute and CASE session …
6ebe9fcf
semanticdiff-com
semanticdiff-com236 days ago (edited 235 days ago)

Review changes with SemanticDiff.

Analyzed 8 of 33 files.

File Information
Filename Status
❔ zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h Unsupported file format
❔ zzz_generated/chip-tool/zap-generated/cluster/Commands.h Unsupported file format
❔ zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-objects.cpp Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-objects.h Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/ids/Attributes.h Unsupported file format
❔ src/platform/OpenThread/GenericThreadBorderRouterDelegate.cpp Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRAttributeSpecifiedCheck.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRAttributeTLVValueDecoder.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusterNames.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusters.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusters.mm Unsupported file format
✔️ src/controller/python/chip/clusters/CHIPClusters.py Analyzed
✔️ src/controller/python/chip/clusters/Objects.py Analyzed
❔ src/controller/java/zap-generated/CHIPAttributeTLVValueDecoder.cpp Unsupported file format
❔ src/controller/java/generated/java/matter/controller/cluster/clusters/ThreadBorderRouterManagementCluster.kt Unsupported file format
✔️ src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java Analyzed
✔️ src/controller/java/generated/java/chip/devicecontroller/ClusterIDMapping.java Analyzed
✔️ src/controller/java/generated/java/chip/devicecontroller/ClusterInfoMapping.java Analyzed
✔️ src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java Analyzed
❔ src/controller/data_model/controller-clusters.matter Unsupported file format
✔️ src/app/zap-templates/zcl/zcl-with-test-extensions.json Analyzed
✔️ src/app/zap-templates/zcl/zcl.json Analyzed
❔ src/app/zap-templates/zcl/data-model/chip/thread-border-router-management-cluster.xml Unsupported file format
❔ src/app/tests/TestThreadBorderRouterManagementCluster.cpp Unsupported file format
❔ src/app/tests/suites/certification/Test_TC_TBRM_2_1.yaml Unsupported file format
❔ src/app/clusters/thread-border-router-management-server/thread-border-router-management-server.cpp Unsupported file format
❔ src/app/clusters/thread-border-router-management-server/thread-border-router-management-server.h Unsupported file format
❔ examples/network-manager-app/network-manager-common/network-manager-app.matter Unsupported file format
❔ examples/network-manager-app/network-manager-common/network-manager-app.zap Unsupported file format
github-actions github-actions added darwin
github-actions github-actions added controller
github-actions github-actions added app
github-actions github-actions added tests
pullapprove pullapprove requested a review from andy31415 andy31415 236 days ago
pullapprove pullapprove requested a review from andy31415 andy31415 236 days ago
pullapprove pullapprove requested a review from andyg-apple andyg-apple 236 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 236 days ago
pullapprove pullapprove requested a review from andyg-apple andyg-apple 236 days ago
pullapprove pullapprove requested a review from arkq arkq 236 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 236 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 236 days ago
pullapprove pullapprove requested a review from arkq arkq 236 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 236 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 236 days ago
pullapprove pullapprove requested a review from bzbarsky-apple bzbarsky-apple 236 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 236 days ago
pullapprove pullapprove requested a review from bzbarsky-apple bzbarsky-apple 236 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 236 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 236 days ago
pullapprove pullapprove requested a review from cecille cecille 236 days ago
pullapprove pullapprove requested a review from cecille cecille 236 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 236 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 236 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 236 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 236 days ago
pullapprove pullapprove requested a review from chshu chshu 236 days ago
pullapprove pullapprove requested a review from chshu chshu 236 days ago
pullapprove pullapprove requested a review from chulspro chulspro 236 days ago
pullapprove pullapprove requested a review from chulspro chulspro 236 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 236 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 236 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 236 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 236 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 236 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 236 days ago
pullapprove pullapprove requested a review from doru91 doru91 236 days ago
pullapprove pullapprove requested a review from doru91 doru91 236 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 236 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 236 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 236 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 236 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 236 days ago
pullapprove pullapprove requested a review from hicklin hicklin 236 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 236 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 236 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 236 days ago
pullapprove pullapprove requested a review from hicklin hicklin 236 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 236 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 236 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 236 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 236 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 236 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 236 days ago
pullapprove pullapprove requested a review from kiel-apple kiel-apple 236 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 236 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 236 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 236 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 236 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 236 days ago
pullapprove pullapprove requested a review from kiel-apple kiel-apple 236 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 236 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 236 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 236 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 236 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 236 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 236 days ago
pullapprove pullapprove requested a review from mhazley mhazley 236 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 236 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 236 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 236 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 236 days ago
pullapprove pullapprove requested a review from p0fi p0fi 236 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 236 days ago
pullapprove pullapprove requested a review from pidarped pidarped 236 days ago
pullapprove pullapprove requested a review from mhazley mhazley 236 days ago
pullapprove pullapprove requested a review from plauric plauric 236 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 236 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 236 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 236 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 236 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 236 days ago
pullapprove pullapprove requested a review from p0fi p0fi 236 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 236 days ago
pullapprove pullapprove requested a review from pidarped pidarped 236 days ago
pullapprove pullapprove requested a review from selissia selissia 236 days ago
pullapprove pullapprove requested a review from plauric plauric 236 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 236 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 236 days ago
pullapprove pullapprove requested a review from tcarmelveilleux tcarmelveilleux 236 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 236 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 236 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 236 days ago
pullapprove pullapprove requested a review from tehampson tehampson 236 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 236 days ago
pullapprove pullapprove requested a review from tima-q tima-q 236 days ago
pullapprove pullapprove requested a review from selissia selissia 236 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 236 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 236 days ago
pullapprove pullapprove requested a review from turon turon 236 days ago
pullapprove pullapprove requested a review from tcarmelveilleux tcarmelveilleux 236 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 236 days ago
pullapprove pullapprove requested a review from vivien-apple vivien-apple 236 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 236 days ago
pullapprove pullapprove requested a review from tehampson tehampson 236 days ago
pullapprove pullapprove requested a review from tima-q tima-q 236 days ago
pullapprove pullapprove requested a review from woody-apple woody-apple 236 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 236 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 236 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 236 days ago
ksperling-apple
ksperling-apple commented on 2024-08-05
Conversation is marked as resolved
Show resolved
src/app/clusters/thread-border-router-management-server/thread-border-router-management-server.cpp
169172 case Commands::SetPendingDatasetRequest::Id:
170173 HandleCommand<Commands::SetPendingDatasetRequest::DecodableType>(ctxt, [this](HandlerContext & ctx, const auto & req) {
171 ctx.mCommandHandler.AddStatus(ctx.mRequestPath, HandleSetPendingDatasetRequest(req));
174
 Status status = HandleSetPendingDatasetRequest(IsCommandOverCASESession(ctx), req);
ksperling-apple236 days ago (edited 236 days ago)

Nit: I think a nicer pattern is to directly pass both the HandlerContext and the request to the Handle...Request method instead of adding logic to this lambda.

wqx6236 days ago

Done

github-actions
github-actions236 days ago (edited 236 days ago)

PR #34768: Size comparison from bbef51a to 6ebe9fc

Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section bbef51a 6ebe9fc change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189004 1189004 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818628 818628 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747768 747768 0 0.0
RAM 113832 113832 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691757 691757 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691757 691757 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627761 627761 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599861 599861 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619713 619713 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619713 619713 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929864 929856 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737116 737108 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1530592 1530592 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1541114 1541110 -4 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2746431 2746431 0 0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6028004 6028004 0 0.0
RAM 509904 509936 32 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5367894 5367894 0 0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727640 4727640 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12496460 12497286 826 0.0
RAM 558362 558394 32 0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11173932 11174492 560 0.0
RAM 608320 608352 32 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11474703 11475347 644 0.0
RAM 555098 555130 32 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483232 4483232 0 0.0
RAM 202192 202192 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661713 5661713 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782040 4782040 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422354 4422354 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560962 4560962 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3067117 3067117 0 0.0
RAM 158952 158952 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4357300 4357300 0 0.0
RAM 242216 242216 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6004981 6005013 32 0.0
RAM 583552 583584 32 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10700989 10701773 784 0.0
RAM 645608 645640 32 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505732 1505732 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906924 906924 0 0.0
RAM 142225 142225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879520 879520 0 0.0
RAM 140364 140364 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838676 838676 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576700 576700 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592408 592408 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612424 612424 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 677376 677376 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1636044 1636044 0 0.0
RAM 210912 210912 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1541244 1541244 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463508 1463508 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462156 1462156 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612912 612912 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477928 477928 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619742 619742 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 678578 678578 0 0.0
RAM 149556 149556 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 771842 771842 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678444 678444 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621334 621334 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707198 707198 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620198 620198 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806284 806284 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654076 654076 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696478 696478 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630778 630778 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608290 608290 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628102 628102 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652112 652112 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631874 631874 0 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 522252 522252 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1705388 1705388 0 0.0
RAM 51820 51820 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16619594 16624794 5200 0.0
RAM 7303840 7304344 504 0.0
ksperling-apple
ksperling-apple commented on 2024-08-05
Conversation is marked as resolved
Show resolved
src/app/clusters/thread-border-router-management-server/thread-border-router-management-server.h
8484 // Attribute Read handlers
8585 void ReadFeatureMap(BitFlags<Feature> & feature);
8686 Optional<uint64_t> ReadActiveDatasetTimestamp();
87
 Optional<uint64_t> ReadPendingDatasetTimestamp();
ksperling-apple236 days ago

New code like this cluster should be using std::optional directly instead of Chip::Optional

wqx6236 days ago

Done.

ksperling-apple
ksperling-apple commented on 2024-08-05
Conversation is marked as resolved
Show resolved
src/app/clusters/thread-border-router-management-server/thread-border-router-management-server.cpp
266282 }
283 case Attributes::PendingDatasetTimestamp::Id: {
284 Optional<uint64_t> pendingDatasetTimestamp = ReadPendingDatasetTimestamp();
285
 status = pendingDatasetTimestamp.HasValue() ? aEncoder.Encode(DataModel::MakeNullable(pendingDatasetTimestamp.Value()))
ksperling-apple236 days ago
Suggested change
status = pendingDatasetTimestamp.HasValue() ? aEncoder.Encode(DataModel::MakeNullable(pendingDatasetTimestamp.Value()))
status = pendingDatasetTimestamp.HasValue() ? aEncoder.Encode(pendingDatasetTimestamp.Value())

There's no need to wrap the value back into a Nullable for Encode since you have already checked for null

wqx6236 days ago

Done

ksperling-apple
ksperling-apple approved these changes on 2024-08-05
ksperling-apple236 days ago

In future it would be good to push the manual changes and the effects of zap_regen_all as separate commits to make them easier to review.

ksperling-apple
ksperling-apple236 days ago

You'll need to update the zap file for the Network Manager example app (by opening it in ZAP and ensuring the PendingDatasetTimestamp attribute is enabled) for the builds to pass.

Also update the Test_TC_TBRM_2_1.yaml test to uncomment the PendingDatasetTimestamp read step at the end.

wqx6 review change
e887c8c8
wqx6 Merge branch 'master' into tbrm/add_attribute
a067fc4d
github-actions
github-actions236 days ago (edited 236 days ago)

PR #34768: Size comparison from bbef51a to a067fc4

Full report (16 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
platform target config section bbef51a a067fc4 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818628 818628 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747768 747768 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610502 610502 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654774 654774 0 0.0
RAM 205620 205620 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505732 1505732 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906924 906924 0 0.0
RAM 142225 142225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879520 879520 0 0.0
RAM 140364 140364 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838676 838676 0 0.0
RAM 141062 141062 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612912 612912 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477928 477928 0 0.0
RAM 144756 144756 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1705388 1705388 0 0.0
RAM 51820 51820 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16619594 16624794 5200 0.0
RAM 7303840 7304344 504 0.0
wqx6 zap regenerate and update the Test_TC_TBRM_2_1.yaml
9514b537
restyled-commits Restyled by clang-format
690ca3e2
github-actions
github-actions236 days ago (edited 236 days ago)

PR #34768: Size comparison from bbef51a to 690ca3e

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section bbef51a 690ca3e change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189004 1189004 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818628 818628 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747768 747768 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610502 610502 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654774 654774 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691757 691757 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691757 691757 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627761 627761 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599861 599861 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619713 619713 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619713 619713 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929864 929856 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737116 737108 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1530592 1530592 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1541114 1541110 -4 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2746431 2746431 0 0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6028004 6028004 0 0.0
RAM 509904 509936 32 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5367894 5367894 0 0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727640 4727640 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12496460 12497286 826 0.0
RAM 558362 558394 32 0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11173932 11174492 560 0.0
RAM 608320 608352 32 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11474703 11475347 644 0.0
RAM 555098 555130 32 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483232 4483232 0 0.0
RAM 202192 202192 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661713 5661713 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782040 4782040 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422354 4422354 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560962 4560962 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3067117 3067117 0 0.0
RAM 158952 158952 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4357300 4357300 0 0.0
RAM 242216 242216 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6004981 6005013 32 0.0
RAM 583552 583584 32 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10700989 10701773 784 0.0
RAM 645608 645640 32 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505732 1505732 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906924 906924 0 0.0
RAM 142225 142225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879520 879520 0 0.0
RAM 140364 140364 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838676 838676 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576700 576700 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592408 592408 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612424 612424 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 677376 677376 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1636044 1636044 0 0.0
RAM 210912 210912 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1541244 1541244 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463508 1463508 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462156 1462156 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612912 612912 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477928 477928 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619742 619742 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 678578 678578 0 0.0
RAM 149556 149556 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 771842 771842 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678444 678444 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621334 621334 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707198 707198 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620198 620198 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806284 806284 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654076 654076 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696478 696478 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630778 630778 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608290 608290 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628102 628102 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652112 652112 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631874 631874 0 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 522252 522252 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1705388 1705388 0 0.0
RAM 51820 51820 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16619594 16624794 5200 0.0
RAM 7303840 7304344 504 0.0
wqx6 Read function error map to IM-space error
3468f0ad
github-actions
github-actions236 days ago (edited 236 days ago)

PR #34768: Size comparison from bbef51a to 3468f0a

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section bbef51a 3468f0a change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189004 1189004 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818628 818628 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747768 747768 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610502 610502 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654774 654774 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691757 691757 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691757 691757 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627761 627761 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599861 599861 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619713 619713 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619713 619713 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929864 929856 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737116 737108 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1530592 1530592 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1541114 1541110 -4 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2746431 2746431 0 0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6028004 6028004 0 0.0
RAM 509904 509936 32 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5367894 5367894 0 0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727640 4727640 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12496460 12497286 826 0.0
RAM 558362 558394 32 0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11173932 11174492 560 0.0
RAM 608320 608352 32 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11474703 11475347 644 0.0
RAM 555098 555130 32 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483232 4483232 0 0.0
RAM 202192 202192 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661713 5661713 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782040 4782040 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422354 4422354 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560962 4560962 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3067117 3067117 0 0.0
RAM 158952 158952 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4357300 4357300 0 0.0
RAM 242216 242216 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6004981 6005013 32 0.0
RAM 583552 583584 32 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10700989 10701773 784 0.0
RAM 645608 645640 32 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505732 1505732 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906924 906924 0 0.0
RAM 142225 142225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879520 879520 0 0.0
RAM 140364 140364 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838676 838676 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576700 576700 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592408 592408 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612424 612424 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 677376 677376 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1636044 1636044 0 0.0
RAM 210912 210912 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1541244 1541244 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463508 1463508 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462156 1462156 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612912 612912 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477928 477928 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619742 619742 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 678578 678578 0 0.0
RAM 149556 149556 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 771842 771842 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678444 678444 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621334 621334 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707198 707198 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620198 620198 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806284 806284 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654076 654076 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696478 696478 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630778 630778 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608290 608290 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628102 628102 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652112 652112 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631874 631874 0 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 522252 522252 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1705388 1705388 0 0.0
RAM 51820 51820 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16619594 16624794 5200 0.0
RAM 7303840 7304344 504 0.0
wqx6 Add attribute report for PendingDatasetTimestamp
d0c5c4e9
github-actions
github-actions235 days ago (edited 235 days ago)

PR #34768: Size comparison from bbef51a to d0c5c4e

Increases above 0.2%:

platform target config section bbef51a d0c5c4e change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610502 612286 1784 0.3
linux air-purifier-app debug FLASH 2746431 2752385 5954 0.2
shell debug FLASH 3067117 3074637 7520 0.2
telink thermostat tlsr9518adk80d FLASH 631874 633186 1312 0.2
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section bbef51a d0c5c4e change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189004 1189260 256 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818628 818612 -16 -0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747768 747752 -16 -0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610502 612286 1784 0.3
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654774 654790 16 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691757 691765 8 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691757 691765 8 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627761 627753 -8 -0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599861 601269 1408 0.2
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619713 621121 1408 0.2
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619713 621121 1408 0.2
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929864 929824 -40 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737116 737124 8 0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94160 24 0.0
FLASH 1530592 1532224 1632 0.1
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115088 16 0.0
FLASH 1541114 1542362 1248 0.1
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2746431 2752385 5954 0.2
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6028004 6033090 5086 0.1
RAM 509904 510448 544 0.1
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5367894 5373502 5608 0.1
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727640 4727646 6 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12496460 12516794 20334 0.2
RAM 558362 558650 288 0.1
chip-tool-ipv6only arm64 unknown 20352 20336 -16 -0.1
FLASH 11173932 11194844 20912 0.2
RAM 608320 608656 336 0.1
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11474703 11494443 19740 0.2
RAM 555098 555386 288 0.1
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483232 4483222 -10 -0.0
RAM 202192 202192 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661713 5661713 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782040 4782046 6 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422354 4422360 6 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560962 4560968 6 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3067117 3074637 7520 0.2
RAM 158952 159112 160 0.1
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4357300 4361284 3984 0.1
RAM 242216 242296 80 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6004981 6004917 -64 -0.0
RAM 583552 583904 352 0.1
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10700989 10720941 19952 0.2
RAM 645608 645928 320 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505732 1505732 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906924 908324 1400 0.2
RAM 142225 142247 22 0.0
nrf7002dk_nrf5340_cpuapp FLASH 879520 880356 836 0.1
RAM 140364 140386 22 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 838676 839828 1152 0.1
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576700 576684 -16 -0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592408 592400 -8 -0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612424 612424 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 677376 677384 8 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1636044 1637692 1648 0.1
RAM 210912 210928 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1541244 1542956 1712 0.1
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463508 1463524 16 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462156 1462172 16 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612912 612896 -16 -0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477928 477920 -8 -0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619742 619760 18 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 678578 679842 1264 0.2
RAM 149556 149576 20 0.0
all-clusters-minimal-app tlsr9528a FLASH 771842 772806 964 0.1
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678444 678462 18 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621334 621352 18 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707198 707216 18 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620198 620216 18 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806284 806302 18 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654076 654094 18 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696478 696496 18 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630778 630796 18 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608290 608308 18 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628102 628120 18 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652112 652130 18 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631874 633186 1312 0.2
RAM 53376 53380 4 0.0
window-covering tlsr9118bdk40d FLASH 522252 522270 18 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1705388 1709556 4168 0.2
RAM 51820 51836 16 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16619594 16640730 21136 0.1
RAM 7303840 7317680 13840 0.2
marchemi
marchemi approved these changes on 2024-08-06
marchemi
marchemi approved these changes on 2024-08-06
chrisdecenzo
chrisdecenzo approved these changes on 2024-08-06
Conversation is marked as resolved
Show resolved
examples/network-manager-app/network-manager-common/network-manager-app.zap
34213421 "singleton": 0,
34223422 "bounded": 0,
3423 "defaultValue": "",
3423
 "defaultValue": null,
chrisdecenzo234 days ago

are these "" -> null changes intentional?

wqx6234 days ago (edited 234 days ago)

No, they are changed by zap automatically after I saved the zap file.

bzbarsky-apple
bzbarsky-apple dismissed these changes on 2024-08-07
Conversation is marked as resolved
Show resolved
src/app/clusters/thread-border-router-management-server/thread-border-router-management-server.cpp
269293 }
270 return status;
294 if (status == CHIP_ERROR_NO_MEMORY)
295 {
296
 // If the status returned by Encode function is CHIP_ERROR_NO_MEMORY, map it to IM status ResourceExhausted
297
 return CHIP_IM_GLOBAL_STATUS(ResourceExhausted);
bzbarsky-apple234 days ago

This will break read/subscribe chunking. Why are we doing this?

wqx6234 days ago

Returned status now.

Conversation is marked as resolved
Show resolved
src/app/clusters/thread-border-router-management-server/thread-border-router-management-server.cpp
298 }
299 if (status != CHIP_NO_ERROR)
300 {
301
 return CHIP_IM_GLOBAL_STATUS(Failure);
bzbarsky-apple234 days ago

No, this is wrong. The contract for AttributeAccessInterface right now is that any error returned from the Encode() call must be propagated out as-is. Anything else breaks chunking.

wqx6234 days ago

Return status now

wqx6 review changes
bbd729e5

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
examples platform darwin controller app review - approved tests matter-1.4-te2-script-change
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum