connectedhomeip
fabric-bridge: Add ECOINFO to dynamic bridged endpoints
#34811
Merged
Overview
Commits
13
Changes
View On GitHub

fabric-bridge: Add ECOINFO to dynamic bridged endpoints #34811

tehampson merged 13 commits into project-chip:master from tehampson:add-ecoinfo-to-fabric-bridge-app
tehampson
tehampson237 days ago (edited 237 days ago)

This also fix issue where no ecosystem information is shared for the endpoint in the cluster server source code

Having application explicitly call EcosystemInformationServer::AddEcosystemInformationClusterToEndpoint instead of having cluster server code emberAfDeviceTypeListFromEndpoint was intentional. This allows EcosystemInformationServer to be more unit testable, at the tradeoff of additionaly boiler plate in application code to let cluster server code know that there is a dynamic endpoint that EcosystemInformation Cluster is expected to respond with even if it does not have any information at the moment.

tehampson fabric-bridge: Add ECOINFO to dynamic bridged endpoints
ab83b229
semanticdiff-com
semanticdiff-com237 days ago

Review changes with SemanticDiff.

github-actions github-actions added examples
github-actions github-actions added app
github-actions
github-actions237 days ago

PR #34811: Size comparison from 7d9a332 to ab83b22

Full report (3 builds for cc32xx, stm32)
platform target config section 7d9a332e ab83b22 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612286 612286 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654790 654790 0 0.0
RAM 205620 205620 0 0.0
stm32 light STM32WB5MM-DK FLASH 477920 477920 0 0.0
RAM 144756 144756 0 0.0
restyled-commits Restyled by whitespace
76614d4d
restyled-commits Restyled by clang-format
2862392e
restyled-commits Restyled by gn
8892df19
pullapprove pullapprove requested a review from andy31415 andy31415 237 days ago
pullapprove pullapprove requested a review from andyg-apple andyg-apple 237 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 237 days ago
pullapprove pullapprove requested a review from arkq arkq 237 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 237 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 237 days ago
pullapprove pullapprove requested a review from bzbarsky-apple bzbarsky-apple 237 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 237 days ago
pullapprove pullapprove requested a review from cecille cecille 237 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 237 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 237 days ago
pullapprove pullapprove requested a review from chshu chshu 237 days ago
pullapprove pullapprove requested a review from chulspro chulspro 237 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 237 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 237 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 237 days ago
pullapprove pullapprove requested a review from doru91 doru91 237 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 237 days ago
pullapprove pullapprove requested a review from harimau-qirex harimau-qirex 237 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 237 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 237 days ago
pullapprove pullapprove requested a review from hicklin hicklin 237 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 237 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 237 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 237 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 237 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 237 days ago
pullapprove pullapprove requested a review from kiel-apple kiel-apple 237 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 237 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 237 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 237 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 237 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 237 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 237 days ago
pullapprove pullapprove requested a review from mhazley mhazley 237 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 237 days ago
pullapprove pullapprove requested a review from mspang mspang 237 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 237 days ago
pullapprove pullapprove requested a review from p0fi p0fi 237 days ago
pullapprove pullapprove requested a review from pidarped pidarped 237 days ago
pullapprove pullapprove requested a review from plauric plauric 237 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 237 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 237 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 237 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 237 days ago
pullapprove pullapprove requested a review from selissia selissia 237 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 237 days ago
pullapprove pullapprove requested a review from tcarmelveilleux tcarmelveilleux 237 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 237 days ago
pullapprove pullapprove requested a review from tima-q tima-q 237 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 237 days ago
pullapprove pullapprove requested a review from turon turon 237 days ago
pullapprove pullapprove requested a review from vivien-apple vivien-apple 237 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 237 days ago
pullapprove pullapprove requested a review from woody-apple woody-apple 237 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 237 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 237 days ago
pullapprove pullapprove added review - pending
saurabhst
saurabhst commented on 2024-08-06
Conversation is marked as resolved
Show resolved
examples/fabric-bridge-app/fabric-bridge-common/BUILD.gn
2525 cflags = [ "-DDYNAMIC_ENDPOINT_COUNT=16" ]
2626}
2727
28
# This is includes all the clusters that only exist on the dynamic endpoint.
saurabhst237 days ago
Suggested change
# This is includes all the clusters that only exist on the dynamic endpoint.
# This includes all the clusters that only exist on the dynamic endpoint.
github-actions
github-actions237 days ago (edited 237 days ago)

PR #34811: Size comparison from 7d9a332 to 8892df1

Full report (7 builds for cc32xx, mbed, nrfconnect, stm32)
platform target config section 7d9a332e 8892df1 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612286 612286 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654790 654790 0 0.0
RAM 205620 205620 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505732 1505732 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908324 908324 0 0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880356 880356 0 0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839828 839828 0 0.0
RAM 141062 141062 0 0.0
stm32 light STM32WB5MM-DK FLASH 477920 477920 0 0.0
RAM 144756 144756 0 0.0
tehampson Update examples/fabric-bridge-app/fabric-bridge-common/BUILD.gn
3248e23d
saurabhst
saurabhst commented on 2024-08-06
Conversation is marked as resolved
Show resolved
src/app/clusters/ecosystem-information-server/ecosystem-information-server.h
151151 static EcosystemInformationServer & Instance();
152152
153 /**
154
 * @brief Add EcosystemInformation Cluster to endpoint so we respond appropritely on endpoint
saurabhst237 days ago
Suggested change
* @brief Add EcosystemInformation Cluster to endpoint so we respond appropritely on endpoint
* @brief Add EcosystemInformation Cluster to endpoint so we respond appropriately on endpoint
saurabhst
saurabhst commented on 2024-08-06
Conversation is marked as resolved
Show resolved
src/app/clusters/ecosystem-information-server/ecosystem-information-server.h
154 * @brief Add EcosystemInformation Cluster to endpoint so we respond appropritely on endpoint
155 *
156 * EcosystemInformation cluster is only ever on dynamic bridge endpoint. If cluster is added
157
 * to a new endpoint, but does not contain any ecosystem information information presently,
saurabhst237 days ago
Suggested change
* to a new endpoint, but does not contain any ecosystem information information presently,
* to a new endpoint, but does not contain any ecosystem information presently,
tehampson Remove blank comments
e062ec4d
tehampson Address PR comments
cddfbf56
restyled-commits Restyled by clang-format
694b38cf
github-actions
github-actions237 days ago (edited 237 days ago)

PR #34811: Size comparison from 7d9a332 to 694b38c

Increases above 0.2%:

platform target config section 7d9a332e 694b38c change % change
linux fabric-bridge-app debug FLASH 4483254 4513432 30178 0.7
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 7d9a332e 694b38c change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189260 1189260 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818612 818612 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747752 747752 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612286 612286 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654790 654790 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691765 691765 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691765 691765 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627753 627753 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601269 601117 -152 -0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 621121 620969 -152 -0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 621121 620969 -152 -0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929832 929824 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737132 737124 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94160 94160 0 0.0
FLASH 1532224 1532096 -128 -0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542358 1542190 -168 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2752385 2752321 -64 -0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6033026 6032524 -502 -0.0
RAM 510192 510192 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5373502 5373438 -64 -0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727646 4727646 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12515936 12515936 0 0.0
RAM 558394 558394 0 0.0
chip-tool-ipv6only arm64 unknown 20336 20336 0 0.0
FLASH 11194268 11194268 0 0.0
RAM 608400 608400 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11493735 11493735 0 0.0
RAM 555130 555130 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483254 4513432 30178 0.7
RAM 202192 202456 264 0.1
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661713 5661713 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782046 4782046 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422360 4422360 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560968 4560968 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3074637 3074125 -512 -0.0
RAM 159112 159112 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4361236 4360740 -496 -0.0
RAM 242296 242296 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6004853 6004853 0 0.0
RAM 583648 583648 0 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10720077 10720077 0 0.0
RAM 645672 645672 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1505732 1505732 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908324 908188 -136 -0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880356 880284 -72 -0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839828 839828 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576684 576684 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592400 592400 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612424 612424 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 677384 677384 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637692 1637508 -184 -0.0
RAM 210928 210928 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1542956 1542956 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463524 1463524 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462172 1462172 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612896 612896 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477920 477920 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619760 619760 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 679842 679766 -76 -0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 772806 772806 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678462 678462 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621352 621352 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707216 707216 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620216 620216 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806302 806302 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654094 654094 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696496 696496 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630796 630796 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608308 608308 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628120 628120 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652130 652130 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 633186 633110 -76 -0.0
RAM 53380 53380 0 0.0
window-covering tlsr9118bdk40d FLASH 522270 522270 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1709556 1709228 -328 -0.0
RAM 51836 51836 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16652730 16652730 0 0.0
RAM 7317176 7317176 0 0.0
cecille
cecille commented on 2024-08-06
Conversation is marked as resolved
Show resolved
examples/fabric-bridge-app/linux/RpcServer.cpp
6263 return pw::Status::Unknown();
6364 }
6465
66
 // Ignoring the error returned.
cecille237 days ago

uh...what error gets returned? Why are you ignoring it? Is it real?

tehampson237 days ago

Changed to VerifyOrDie, if we crash we will fix any assumptions.

Conversation is marked as resolved
Show resolved
examples/fabric-bridge-app/linux/main.cpp
3435#include <sys/ioctl.h>
3536#include <thread>
3637
37using namespace chip;
38
void MatterEcosystemInformationPluginServerInitCallback();
cecille237 days ago

where does this actually get declared? Why not just include the header? Is this one of those fancy ember things where you have to do weird stuff to swap out impls at build?

tehampson237 days ago

This is one of those fancy embr/zap things where the header only gets created if you have a static endpoint for ECOINFO. ECOINFO is only a dynamic endpoint cluster so that doesn't get auto generated for us

https://github.com/project-chip/connectedhomeip/blob/master/scripts/py_matter_idl/matter_idl/generators/cpp/application/PluginApplicationCallbacksHeader.jinja

Conversation is marked as resolved
Show resolved
src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp
258 // We expect that the device has not been previously added.
259 VerifyOrReturnError((it == mDevicesMap.end()), CHIP_ERROR_INCORRECT_STATE);
260 // This create an empty DeviceInfo in mDevicesMap.
261
 mDevicesMap[aEndpoint];
cecille237 days ago

Even with the comment, this made me do a double take. Does mDeviceMap[aEndpoint] = DeviceInfo(); work? Do all the struct members auto-initialize to empty / nullopt?

Not for this PR, but there are a couple of heap-eater stds in there. Is this cluster restricted in some way to NOT be on embedded platforms?

tehampson237 days ago (edited 237 days ago)

Does mDeviceMap[aEndpoint] = DeviceInfo(); work?

Done

Do all the struct members auto-initialize to empty / nullopt?

Added explicit NullOptional, the vector and map both initialized as empty

Not for this PR, but there are a couple of heap-eater stds in there. Is this cluster restricted in some way to NOT be on embedded platforms?

Yes that is explicitly stated where CI would normally block on allowing these types. There is no intention to move away from these heap eater, it is the cost you need to pay for Fabric Sync. If someone wants to make an embed friendly version later on they can, but I have 0 plans for that. If someone accidentally includes this it won't eat that much since you will have an empty list when the mInstance (I just realized I need to rename that to sInstance) is statically allocated.

https://github.com/project-chip/connectedhomeip/blob/master/scripts/tools/check_includes_config.py#L131

cecille237 days ago

okie dokie - thanks. Sounds like it's covered.

cecille
cecille commented on 2024-08-06
Conversation is marked as resolved
Show resolved
src/app/clusters/ecosystem-information-server/ecosystem-information-server.h
158 * this is called to let ECOINFO cluster code know it is supposed to provide blank attribute
159 * information on this endpoint.
160 *
161
 * This approach was intentionally taken instead of relying on emberAfDeviceTypeListFromEndpoint
cecille237 days ago

Are there unit tests for this cluster? Do they need to be updated to test this code?

tehampson237 days ago

Unit test are getting after TE2. They do not exist, but this cluster code is written in a way that is currently testable and we don't want to break that paradime because I intend on adding tests when after TE2

tehampson AddressPR comments
1e60feed
tehampson Fix mistake made when addressing PR comment
bc7d850c
restyled-commits Restyled by clang-format
537df99b
github-actions
github-actions237 days ago (edited 237 days ago)

PR #34811: Size comparison from 7d9a332 to 537df99

Increases above 0.2%:

platform target config section 7d9a332e 537df99 change % change
linux fabric-bridge-app debug FLASH 4483254 4515346 32092 0.7
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 7d9a332e 537df99 change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189260 1189260 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818612 818612 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747752 747752 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612286 612286 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654790 654790 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691765 691765 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691765 691765 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627753 627753 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601269 601117 -152 -0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 621121 620969 -152 -0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 621121 620969 -152 -0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929832 929824 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737132 737124 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94160 94160 0 0.0
FLASH 1532224 1532096 -128 -0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542358 1542190 -168 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2752385 2752321 -64 -0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6033026 6032524 -502 -0.0
RAM 510192 510192 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5373502 5373438 -64 -0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727646 4727646 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12515936 12490196 -25740 -0.2
RAM 558394 557978 -416 -0.1
chip-tool-ipv6only arm64 unknown 20336 20312 -24 -0.1
FLASH 11194268 11169836 -24432 -0.2
RAM 608400 607984 -416 -0.1
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11493735 11472973 -20762 -0.2
RAM 555130 554714 -416 -0.1
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483254 4515346 32092 0.7
RAM 202192 202456 264 0.1
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661713 5661713 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782046 4782046 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422360 4422360 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560968 4560968 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3074637 3074125 -512 -0.0
RAM 159112 159112 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4361236 4360740 -496 -0.0
RAM 242296 242296 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6004853 6004853 0 0.0
RAM 583648 583648 0 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10720077 10694013 -26064 -0.2
RAM 645672 645128 -544 -0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908324 908188 -136 -0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880356 880284 -72 -0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839828 839828 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 576684 577100 416 0.1
RAM 70416 70472 56 0.1
k32w1+release FLASH 592400 592400 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612424 612544 120 0.0
RAM 69920 69944 24 0.0
k32w1+release FLASH 677384 677384 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637692 1637508 -184 -0.0
RAM 210928 210928 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1542956 1542956 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463524 1463524 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462172 1462172 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612896 612896 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477920 477920 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619760 619760 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 679842 679766 -76 -0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 772806 772806 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678462 678462 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621352 621352 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707216 707216 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620216 620216 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806302 806302 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654094 654094 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696496 696496 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630796 630796 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608308 608308 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628120 628120 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652130 652130 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 633186 633110 -76 -0.0
RAM 53380 53380 0 0.0
window-covering tlsr9118bdk40d FLASH 522270 522270 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1709556 1709228 -328 -0.0
RAM 51836 51836 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16652730 16609890 -42840 -0.3
RAM 7317176 7294528 -22648 -0.3
cecille
cecille approved these changes on 2024-08-06
tehampson Merge branch 'master' into add-ecoinfo-to-fabric-bridge-app
86a4d584
tehampson Added comment to describe why something was done the way it was
17e2c84b
github-actions
github-actions236 days ago (edited 236 days ago)

PR #34811: Size comparison from 587665d to 17e2c84

Increases above 0.2%:

platform target config section 587665d 17e2c84 change % change
linux fabric-bridge-app debug FLASH 4483314 4515406 32092 0.7
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 587665d 17e2c84 change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189260 1189260 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818612 818612 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747752 747752 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612286 612286 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654790 654790 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691765 691765 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691765 691765 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627753 627753 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601117 601117 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 620969 620969 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 620969 620969 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929832 929824 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737132 737124 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94160 94160 0 0.0
FLASH 1532096 1532096 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542190 1542190 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2752443 2752443 0 0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6032524 6032524 0 0.0
RAM 510192 510192 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5373438 5373438 0 0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727646 4727646 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12490228 12490228 0 0.0
RAM 557978 557978 0 0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11169836 11169836 0 0.0
RAM 607984 607984 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11473005 11473005 0 0.0
RAM 554714 554714 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483314 4515406 32092 0.7
RAM 202192 202456 264 0.1
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661809 5661809 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782046 4782046 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422360 4422360 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560968 4560968 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3074125 3074125 0 0.0
RAM 159112 159112 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4360740 4360740 0 0.0
RAM 242296 242296 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6005653 6005653 0 0.0
RAM 583648 583648 0 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10694109 10694109 0 0.0
RAM 645128 645128 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908188 908188 0 0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880284 880284 0 0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839828 839828 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 577100 577100 0 0.0
RAM 70472 70472 0 0.0
k32w1+release FLASH 592400 592400 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612544 612544 0 0.0
RAM 69944 69944 0 0.0
k32w1+release FLASH 677384 677384 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637508 1637508 0 0.0
RAM 210928 210928 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1542956 1542956 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463524 1463524 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462172 1462172 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612896 612896 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477920 477920 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619760 619760 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 679766 679766 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 772806 772806 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678462 678462 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621352 621352 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707216 707216 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620216 620216 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806302 806302 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654094 654094 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696496 696496 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630796 630796 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608308 608308 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628120 628120 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652130 652130 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 633110 633110 0 0.0
RAM 53380 53380 0 0.0
window-covering tlsr9118bdk40d FLASH 522270 522270 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 4824 4824 0 0.0
FLASH 1695820 1695820 0 0.0
RAM 89176 89176 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17324630 17324630 0 0.0
RAM 7565168 7565168 0 0.0
saurabhst
saurabhst approved these changes on 2024-08-07
pullapprove pullapprove removed review - pending
pullapprove pullapprove added review - approved
tehampson tehampson enabled auto-merge (squash) 236 days ago
tehampson
tehampson commented on 2024-08-07
Conversation is marked as resolved
Show resolved
examples/fabric-bridge-app/fabric-bridge-common/src/BridgedDeviceManager.cpp
97 DECLARE_DYNAMIC_ATTRIBUTE(EcosystemInformation::Attributes::DeviceDirectory::Id, ARRAY, kDescriptorAttributeArraySize, 0),
98 DECLARE_DYNAMIC_ATTRIBUTE(EcosystemInformation::Attributes::LocationDirectory::Id, ARRAY, kDescriptorAttributeArraySize, 0),
99 DECLARE_DYNAMIC_ATTRIBUTE_LIST_END();
100
tehampson236 days ago (edited 236 days ago)

Adding temp blocking comment. From a strategic merging (with respect to conflict management for up coming PRs) we might want #34845 to land first

tehampson tehampson merged e8186eb0 into master 236 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
examples app review - approved
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum