connectedhomeip
[Darwin] Duplicate MTRDevice with `git cp`
#34826
Closed
Overview
Commits
10
Changes
View On GitHub

[Darwin] Duplicate MTRDevice with `git cp` #34826

kiel-apple wants to merge 10 commits into project-chip:master from kiel-apple:darwin-duplicate-mtrdevice-git-cp
kiel-apple
kiel-apple261 days ago

I'm not sure this would help after a merge-squash but here it is.

semanticdiff-com
semanticdiff-com261 days ago

Review changes with SemanticDiff.

github-actions github-actions added darwin
github-actions
github-actions261 days ago (edited 260 days ago)

PR #34826: Size comparison from 62255da to 0fd5a25

Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 62255da 0fd5a25 change % change
bl602 lighting-app bl602 FLASH 1277798 1277798 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292056 1292056 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317014 1317014 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1098938 1098938 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109888 1109888 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189260 1189260 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 881972 881972 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135150 1135150 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086100 1086100 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097362 1097362 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802792 802792 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818612 818612 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810904 810904 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763244 763244 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747752 747752 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612286 612286 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654790 654790 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671905 671905 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691765 691765 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691765 691765 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648693 648693 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610409 610409 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630037 630037 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627753 627753 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647469 647469 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601117 601117 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 620969 620969 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 620969 620969 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929832 929824 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737132 737124 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94160 94160 0 0.0
FLASH 1532096 1532096 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542190 1542190 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2752443 2752443 0 0.0
RAM 128368 128368 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 6032524 6032524 0 0.0
RAM 510192 510192 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5373438 5373438 0 0.0
RAM 240000 240000 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4727646 4727646 0 0.0
RAM 217024 217024 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12490228 12490228 0 0.0
RAM 557978 557978 0 0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11169836 11169836 0 0.0
RAM 607984 607984 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11473005 11473005 0 0.0
RAM 554714 554714 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4483314 4483314 0 0.0
RAM 202192 202192 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5661809 5661809 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4782046 4782046 0 0.0
RAM 203840 203840 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4422360 4422360 0 0.0
RAM 197824 197824 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4560968 4560968 0 0.0
RAM 202360 202360 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3074125 3074125 0 0.0
RAM 159112 159112 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4360740 4360740 0 0.0
RAM 242296 242296 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6005653 6005653 0 0.0
RAM 583648 583648 0 0.0
tv-casting-app debug unknown 5176 5176 0 0.0
FLASH 10694109 10694109 0 0.0
RAM 645128 645128 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908188 908188 0 0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880284 880284 0 0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839828 839828 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 577100 577100 0 0.0
RAM 70472 70472 0 0.0
k32w1+release FLASH 592400 592400 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612544 612544 0 0.0
RAM 69944 69944 0 0.0
k32w1+release FLASH 677384 677384 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637508 1637508 0 0.0
RAM 210928 210928 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1542956 1542956 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463524 1463524 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462172 1462172 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612896 612896 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477920 477920 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619760 619760 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 679766 679766 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 772806 772806 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678462 678462 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621352 621352 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707216 707216 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620216 620216 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806302 806302 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654094 654094 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696496 696496 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630796 630796 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608308 608308 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628120 628120 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652130 652130 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 633110 633110 0 0.0
RAM 53380 53380 0 0.0
window-covering tlsr9118bdk40d FLASH 522270 522270 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1709228 1709228 0 0.0
RAM 51836 51836 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16609914 16609914 0 0.0
RAM 7294528 7294528 0 0.0
bzbarsky-apple
bzbarsky-apple approved these changes on 2024-08-07
kiel-apple kiel-apple marked this pull request as ready for review 260 days ago
pullapprove pullapprove requested a review from andy31415 andy31415 260 days ago
pullapprove pullapprove requested a review from arkq arkq 260 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 260 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 260 days ago
pullapprove pullapprove requested a review from cecille cecille 260 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 260 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 260 days ago
pullapprove pullapprove requested a review from chshu chshu 260 days ago
pullapprove pullapprove requested a review from chulspro chulspro 260 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 260 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 260 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 260 days ago
pullapprove pullapprove requested a review from doru91 doru91 260 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 260 days ago
pullapprove pullapprove requested a review from harimau-qirex harimau-qirex 260 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 260 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 260 days ago
pullapprove pullapprove requested a review from hicklin hicklin 260 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 260 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 260 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 260 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 260 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 260 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 260 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 260 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 260 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 260 days ago
pullapprove pullapprove requested a review from mhazley mhazley 260 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 260 days ago
pullapprove pullapprove requested a review from mspang mspang 260 days ago
pullapprove pullapprove requested a review from p0fi p0fi 260 days ago
pullapprove pullapprove requested a review from plauric plauric 260 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 260 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 260 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 260 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 260 days ago
pullapprove pullapprove requested a review from selissia selissia 260 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 260 days ago
pullapprove pullapprove requested a review from tcarmelveilleux tcarmelveilleux 260 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 260 days ago
pullapprove pullapprove requested a review from tehampson tehampson 260 days ago
pullapprove pullapprove requested a review from tima-q tima-q 260 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 260 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 260 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 260 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 260 days ago
pullapprove pullapprove requested a review from yunhanw-google yunhanw-google 260 days ago
pullapprove pullapprove added review - pending
bzbarsky-apple bzbarsky-apple enabled auto-merge (rebase) 260 days ago
bzbarsky-apple bzbarsky-apple added fast track
bzbarsky-apple Keep src/darwin/Framework/CHIP/MTRDevice.mm
0fd148c0
bzbarsky-apple Copy src/darwin/Framework/CHIP/MTRDevice.mm into src/darwin/Framework…
e81c80fc
bzbarsky-apple Duplicate src/darwin/Framework/CHIP/MTRDevice.mm history.
fde2414c
bzbarsky-apple Set back src/darwin/Framework/CHIP/MTRDevice.mm file
e455fb2a
bzbarsky-apple Keep src/darwin/Framework/CHIP/MTRDevice.h
3fbb8763
bzbarsky-apple Copy src/darwin/Framework/CHIP/MTRDevice.h into src/darwin/Framework/…
21a44f33
bzbarsky-apple Duplicate src/darwin/Framework/CHIP/MTRDevice.h history.
450f4f30
bzbarsky-apple Set back src/darwin/Framework/CHIP/MTRDevice.h file
52c27fc4
bzbarsky-apple bzbarsky-apple force pushed from 0fd5a259 to 52c27fc4 260 days ago
kiel-apple
kiel-apple260 days ago

welp

github-actions
github-actions260 days ago (edited 260 days ago)

PR #34826: Size comparison from 4e2245b to 63a7930

Full report (19 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
platform target config section 4e2245b 63a7930 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802832 802832 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818636 818636 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810968 810968 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763220 763220 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747728 747728 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612238 612238 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654750 654750 0 0.0
RAM 205620 205620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908224 908224 0 0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880332 880332 0 0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839876 839876 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 577068 577068 0 0.0
RAM 70472 70472 0 0.0
k32w1+release FLASH 592384 592384 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612528 612528 0 0.0
RAM 69944 69944 0 0.0
k32w1+release FLASH 677360 677360 0 0.0
RAM 83232 83232 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612920 612920 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477960 477960 0 0.0
RAM 144756 144756 0 0.0
tizen all-clusters-app arm unknown 4824 4824 0 0.0
FLASH 1695540 1695540 0 0.0
RAM 89176 89176 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17324534 17324534 0 0.0
RAM 7565032 7565032 0 0.0
kiel-apple kiel-apple force pushed from 63a79300 to 04048978 260 days ago
kiel-apple kiel-apple force pushed from 04048978 to e4533ba3 260 days ago
kiel-apple kiel-apple force pushed from e4533ba3 to 52c27fc4 260 days ago
mergify mergify added conflict
kiel-apple Merge branch 'master' into darwin-duplicate-mtrdevice-git-cp
f7d6c80b
mergify mergify removed conflict
github-actions
restyled-commits Restyled by clang-format
6832eb53
github-actions
woody-apple woody-apple closed this 259 days ago
disabled auto-merge 259 days ago
Pull request was closed
woody-apple

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
darwin review - pending fast track
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum