connectedhomeip
[Darwin] apply changes from PR #34797 to to concrete class
#34856
Merged

[Darwin] apply changes from PR #34797 to to concrete class #34856

kiel-apple
kiel-apple260 days ago

since PR was opened before MTRDevice duplication PR landed

kiel-apple apply changes from PR #34797 to to concrete class
08d8c5f6
semanticdiff-com
semanticdiff-com260 days ago

Review changes with SemanticDiff.

github-actions github-actions added darwin
pullapprove pullapprove requested a review from andyg-apple andyg-apple 260 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 260 days ago
pullapprove pullapprove requested a review from arkq arkq 260 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 260 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 260 days ago
pullapprove pullapprove requested a review from bzbarsky-apple bzbarsky-apple 260 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 260 days ago
pullapprove pullapprove requested a review from cecille cecille 260 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 260 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 260 days ago
pullapprove pullapprove requested a review from chshu chshu 260 days ago
pullapprove pullapprove requested a review from chulspro chulspro 260 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 260 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 260 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 260 days ago
pullapprove pullapprove requested a review from doru91 doru91 260 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 260 days ago
pullapprove pullapprove requested a review from harimau-qirex harimau-qirex 260 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 260 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 260 days ago
pullapprove pullapprove requested a review from hicklin hicklin 260 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 260 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 260 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 260 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 260 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 260 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 260 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 260 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 260 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 260 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 260 days ago
pullapprove pullapprove requested a review from mhazley mhazley 260 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 260 days ago
pullapprove pullapprove requested a review from mspang mspang 260 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 260 days ago
pullapprove pullapprove requested a review from p0fi p0fi 260 days ago
pullapprove pullapprove requested a review from pidarped pidarped 260 days ago
pullapprove pullapprove requested a review from plauric plauric 260 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 260 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 260 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 260 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 260 days ago
pullapprove pullapprove requested a review from selissia selissia 260 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 260 days ago
pullapprove pullapprove requested a review from tcarmelveilleux tcarmelveilleux 260 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 260 days ago
pullapprove pullapprove requested a review from tehampson tehampson 260 days ago
pullapprove pullapprove requested a review from tima-q tima-q 260 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 260 days ago
pullapprove pullapprove requested a review from turon turon 260 days ago
pullapprove pullapprove requested a review from vivien-apple vivien-apple 260 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 260 days ago
pullapprove pullapprove requested a review from woody-apple woody-apple 260 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 260 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 260 days ago
pullapprove pullapprove requested a review from yunhanw-google yunhanw-google 260 days ago
pullapprove pullapprove added review - pending
jtung-apple
jtung-apple approved these changes on 2024-08-07
jtung-apple jtung-apple added fast track
bzbarsky-apple
bzbarsky-apple approved these changes on 2024-08-07
github-actions
github-actions260 days ago (edited 260 days ago)

PR #34856: Size comparison from e0a765b to 08d8c5f

Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e0a765b 08d8c5f change % change
bl602 lighting-app bl602 FLASH 1278102 1278102 0 0.0
RAM 95896 95896 0 0.0
bl602+mfd FLASH 1292360 1292360 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1317062 1317062 0 0.0
RAM 104320 104320 0 0.0
bl702 lighting-app bl702 FLASH 1099242 1099242 0 0.0
RAM 15249 15249 0 0.0
bl702+mfd FLASH 1109936 1109936 0 0.0
RAM 15393 15393 0 0.0
bl702+rpc FLASH 1189308 1189308 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 882276 882276 0 0.0
RAM 27352 27352 0 0.0
bl706-wifi FLASH 1135446 1135446 0 0.0
RAM 14685 14685 0 0.0
bl702l lighting-app bl702l FLASH 1086404 1086404 0 0.0
RAM 21804 21804 0 0.0
bl702l+mfd FLASH 1097410 1097410 0 0.0
RAM 21956 21956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802832 802832 0 0.0
RAM 117620 117620 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818636 818636 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 810968 810968 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763220 763220 0 0.0
RAM 113640 113640 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747728 747728 0 0.0
RAM 113832 113832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612238 612238 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654750 654750 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671945 671945 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691797 691797 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691797 691797 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648741 648741 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610385 610385 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630021 630021 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630021 630021 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 627833 627833 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647549 647549 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647549 647549 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601093 601093 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 620953 620953 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 620953 620953 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 929896 929888 -8 -0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 737084 737076 -8 -0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015476 1015476 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94160 94160 0 0.0
FLASH 1532136 1532136 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542266 1542266 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2752139 2752139 0 0.0
RAM 128272 128272 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6032062 6032062 0 0.0
RAM 510128 510128 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5373052 5373052 0 0.0
RAM 239936 239936 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4727238 4727238 0 0.0
RAM 216960 216960 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12490026 12490026 0 0.0
RAM 557914 557914 0 0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11169596 11169596 0 0.0
RAM 607920 607920 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11472803 11472803 0 0.0
RAM 554650 554650 0 0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4515908 4515908 0 0.0
RAM 202648 202648 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5661777 5661777 0 0.0
RAM 228048 228048 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4781774 4781774 0 0.0
RAM 203776 203776 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4422086 4422086 0 0.0
RAM 197760 197760 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4560696 4560696 0 0.0
RAM 202296 202296 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3073885 3073885 0 0.0
RAM 159048 159048 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4360436 4360436 0 0.0
RAM 242232 242232 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 6005173 6005173 0 0.0
RAM 583584 583584 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10693725 10693725 0 0.0
RAM 645064 645064 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908224 908224 0 0.0
RAM 142247 142247 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880332 880332 0 0.0
RAM 140386 140386 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 839876 839876 0 0.0
RAM 141062 141062 0 0.0
nxp contact k32w0+release FLASH 577068 577068 0 0.0
RAM 70472 70472 0 0.0
k32w1+release FLASH 592384 592384 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612528 612528 0 0.0
RAM 69944 69944 0 0.0
k32w1+release FLASH 677360 677360 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637476 1637476 0 0.0
RAM 210928 210928 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1542908 1542908 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1463492 1463492 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462124 1462124 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655596 655596 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612920 612920 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477960 477960 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619736 619736 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 679796 679796 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 772852 772852 0 0.0
RAM 110732 110732 0 0.0
bridge-app tlsr9258a FLASH 678440 678440 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621328 621328 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707192 707192 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620246 620246 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806332 806332 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654184 654184 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 696472 696472 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630774 630774 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608284 608284 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628096 628096 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652106 652106 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 633086 633086 0 0.0
RAM 53380 53380 0 0.0
window-covering tlsr9118bdk40d FLASH 522246 522246 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 4796 4796 0 0.0
FLASH 1695372 1695372 0 0.0
RAM 89176 89176 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17324526 17324526 0 0.0
RAM 7565032 7565032 0 0.0
woody-apple
woody-apple approved these changes on 2024-08-07
kiel-apple kiel-apple merged 968a0e60 into master 260 days ago
kiel-apple kiel-apple deleted the mtrdevice-concrete-update branch 231 days ago

Login to write a write a comment.

Login via GitHub