connectedhomeip
Create new ICD Manager in fabric-admin to service KeepActive Command
#34894
Merged
Overview
Commits
21
Changes
View On GitHub

Create new ICD Manager in fabric-admin to service KeepActive Command #34894

tehampson merged 21 commits into project-chip:master from tehampson:icd-manager-in-fabric-admin
tehampson
tehampson238 days ago (edited 238 days ago)

Moves closer to completing #33221

When fabric-admin commissions the ICD device it needs to commission with the command --icd-registration true

tehampson Create new ICD Manager that allows sending a KeepActive Command
00d707b8
semanticdiff-com
semanticdiff-com238 days ago

Review changes with SemanticDiff.

github-actions github-actions added examples
restyled-commits Restyled by whitespace
79a11858
restyled-commits Restyled by clang-format
6a0eb7b2
tehampson Add TODO comments
4e637117
github-actions
github-actions238 days ago (edited 238 days ago)

PR #34894: Size comparison from 95ff33b to 4e63711

Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 95ff33b 4e63711 change % change
bl602 lighting-app bl602 FLASH 1277892 1277892 0 0.0
RAM 95928 95928 0 0.0
bl602+mfd FLASH 1291744 1291744 0 0.0
RAM 96072 96072 0 0.0
bl602+rpc FLASH 1316856 1316856 0 0.0
RAM 104352 104352 0 0.0
bl702 lighting-app bl702 FLASH 943834 943834 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 946232 946232 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1038890 1038890 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 646552 646552 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894128 894128 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 960238 960238 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 962858 962858 0 0.0
RAM 17012 17012 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802972 802972 0 0.0
RAM 117628 117628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818800 818800 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 811156 811156 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763328 763328 0 0.0
RAM 113648 113648 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747812 747812 0 0.0
RAM 113840 113840 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 612202 612202 0 0.0
RAM 205388 205388 0 0.0
lock CC3235SF_LAUNCHXL FLASH 654802 654802 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672097 672097 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691949 691949 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691949 691949 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648893 648893 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610537 610537 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630173 630173 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630173 630173 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 628009 628009 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647725 647725 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647725 647725 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601261 601261 0 0.0
RAM 68372 68372 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 621121 621121 0 0.0
RAM 71004 71004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 621121 621121 0 0.0
RAM 71004 71004 0 0.0
efr32 lighting-app BRD4187C FLASH 930024 930016 -8 -0.0
RAM 135144 135144 0 0.0
lock-app BRD4338a FLASH 737148 737140 -8 -0.0
RAM 208440 208440 0 0.0
window-app BRD4187C FLASH 1015508 1015508 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94160 94160 0 0.0
FLASH 1533032 1533032 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115088 115088 0 0.0
FLASH 1542830 1542830 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2752651 2752651 0 0.0
RAM 128232 128232 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6033702 6033702 0 0.0
RAM 509576 509576 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5373792 5373792 0 0.0
RAM 239896 239896 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4727732 4727732 0 0.0
RAM 216952 216952 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12488498 12488498 0 0.0
RAM 557426 557426 0 0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11167804 11167804 0 0.0
RAM 607408 607408 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11478375 11488179 9804 0.1
RAM 554898 555194 296 0.1
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4531370 4531370 0 0.0
RAM 203288 203288 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5662289 5662289 0 0.0
RAM 228008 228008 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4782512 4782512 0 0.0
RAM 203736 203736 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4422520 4422520 0 0.0
RAM 197720 197720 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4561138 4561138 0 0.0
RAM 202256 202256 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3074493 3074493 0 0.0
RAM 159008 159008 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4360740 4360740 0 0.0
RAM 242240 242240 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 6005733 6005733 0 0.0
RAM 583032 583032 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10692525 10692525 0 0.0
RAM 644520 644520 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 908576 908576 0 0.0
RAM 142239 142239 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880596 880596 0 0.0
RAM 140378 140378 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 840168 840168 0 0.0
RAM 141058 141058 0 0.0
nxp contact k32w0+release FLASH 577196 577196 0 0.0
RAM 70468 70468 0 0.0
k32w1+release FLASH 592496 592496 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612640 612640 0 0.0
RAM 69940 69940 0 0.0
k32w1+release FLASH 677472 677472 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1637572 1637572 0 0.0
RAM 210912 210912 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1543004 1543004 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1463540 1463540 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462188 1462188 0 0.0
RAM 225112 225112 0 0.0
qpg lighting-app qpg6105+debug FLASH 655716 655716 0 0.0
RAM 105152 105152 0 0.0
lock-app qpg6105+debug FLASH 613072 613072 0 0.0
RAM 99636 99636 0 0.0
stm32 light STM32WB5MM-DK FLASH 478120 478120 0 0.0
RAM 144764 144764 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619928 619928 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 680272 680272 0 0.0
RAM 149576 149576 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 773274 773274 0 0.0
RAM 110736 110736 0 0.0
bridge-app tlsr9258a FLASH 678616 678616 0 0.0
RAM 91636 91636 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621524 621524 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707406 707406 0 0.0
RAM 74320 74320 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620450 620450 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806536 806536 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654396 654396 0 0.0
RAM 67016 67016 0 0.0
ota-requestor-app tlsr9258a FLASH 696632 696632 0 0.0
RAM 91320 91320 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630912 630912 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608422 608422 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628296 628296 0 0.0
RAM 52700 52700 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652292 652292 0 0.0
RAM 56640 56640 0 0.0
thermostat tlsr9518adk80d FLASH 633300 633300 0 0.0
RAM 53384 53384 0 0.0
window-covering tlsr9118bdk40d FLASH 522456 522456 0 0.0
RAM 98540 98540 0 0.0
tizen all-clusters-app arm unknown 4796 4796 0 0.0
FLASH 1695932 1695932 0 0.0
RAM 89172 89172 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17308510 17308510 0 0.0
RAM 7562468 7562468 0 0.0
tehampson
tehampson commented on 2024-08-08
Conversation is marked as resolved
Show resolved
examples/fabric-admin/rpc/RpcServer.cpp
3943public:
44 void OnCheckInCompleted(const chip::app::ICDClientInfo & clientInfo) override
45 {
46
 chip::NodeId nodeId = clientInfo.peer_node.GetNodeId();
tehampson238 days ago (edited 238 days ago)

For some reason this nodeId is not the value I am expecting. This doesn't match the value we assigned when we commissioned the ICD device

tehampson238 days ago (edited 238 days ago)

Learning that this nodeId is fabric admin and not the ICD device. Not sure how we can identify what is the nodeId of the ICD device that is checking in here

yunhanw-google Add StayActiveSender to send stayActive command
4720da81
tehampson
tehampson commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/StayActiveSender.cpp
77{
78 StayActiveSender * const _this = static_cast<StayActiveSender *>(context);
79 VerifyOrDie(_this != nullptr);
80
 ChipLogError(ICD, "Failed to establish CASE for stay active command with error '%" CHIP_ERROR_FORMAT "'", err.Format());;
tehampson233 days ago

Don't we need to free/delete _this, otherwise we have a memory leak?

tehampson
tehampson commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/IcdManager.cpp
3436 }
37
38 uint32_t activeDurationMs = 30000;
39
 auto stayActiveSender = chip::Platform::New<StayActiveSender>(activeDurationMs, clientInfo.peer_node, chip::app::InteractionModelEngine::GetInstance());
tehampson233 days ago

On of the issues I previously mentioned is that clientInfo.peer_node is the node of fabric-admin, and not the LIT device checking-in

tehampson
tehampson commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/IcdManager.cpp
3234 {
3335 mDelegate->OnCheckInCompleted(clientInfo);
3436 }
37
tehampson233 days ago

I think all of this code needs to be in the delegate not in the IcdManager, we need to be giving a activeDurationMs the value we got, not just this hard-coded 30000.

restyled-commits Restyled by whitespace
8af8c50f
restyled-commits Restyled by clang-format
bbb8b246
tehampson Changes to make it work end-to-end
2e365870
tehampson Addressing TODOs
74c90671
restyled-commits Restyled by clang-format
0e6424cf
tehampson Self review fixes
db5aac74
tehampson More self review
44cbd73c
restyled-commits Restyled by clang-format
399cdd94
tehampson tehampson marked this pull request as ready for review 233 days ago
pullapprove pullapprove requested a review from andy31415 andy31415 233 days ago
pullapprove pullapprove requested a review from andyg-apple andyg-apple 233 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 233 days ago
pullapprove pullapprove requested a review from arkq arkq 233 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 233 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 233 days ago
pullapprove pullapprove requested a review from bzbarsky-apple bzbarsky-apple 233 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 233 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 233 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 233 days ago
pullapprove pullapprove requested a review from chshu chshu 233 days ago
pullapprove pullapprove requested a review from chulspro chulspro 233 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 233 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 233 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 233 days ago
pullapprove pullapprove requested a review from doru91 doru91 233 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 233 days ago
pullapprove pullapprove requested a review from harimau-qirex harimau-qirex 233 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 233 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 233 days ago
pullapprove pullapprove requested a review from hicklin hicklin 233 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 233 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 233 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 233 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 233 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 233 days ago
pullapprove pullapprove requested a review from kiel-apple kiel-apple 233 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 233 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 233 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 233 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 233 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 233 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 233 days ago
pullapprove pullapprove requested a review from mhazley mhazley 233 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 233 days ago
pullapprove pullapprove requested a review from mspang mspang 233 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 233 days ago
pullapprove pullapprove requested a review from p0fi p0fi 233 days ago
pullapprove pullapprove requested a review from pidarped pidarped 233 days ago
pullapprove pullapprove requested a review from plauric plauric 233 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 233 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 233 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 233 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 233 days ago
pullapprove pullapprove requested a review from selissia selissia 233 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 233 days ago
pullapprove pullapprove requested a review from tcarmelveilleux tcarmelveilleux 233 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 233 days ago
pullapprove pullapprove requested a review from tima-q tima-q 233 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 233 days ago
pullapprove pullapprove requested a review from turon turon 233 days ago
pullapprove pullapprove requested a review from vivien-apple vivien-apple 233 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 233 days ago
pullapprove pullapprove requested a review from woody-apple woody-apple 233 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 233 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 233 days ago
pullapprove pullapprove requested a review from yunhanw-google yunhanw-google 233 days ago
pullapprove pullapprove added review - pending
andy31415
andy31415 commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/IcdManager.cpp
17 */
18
19#include "IcdManager.h"
20
#include <app/InteractionModelEngine.h>
andy31415233 days ago

what do we use interactionmodelengine for ?

tehampson233 days ago

We don't here. It has been removed

andy31415
andy31415 commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/IcdManager.h
20
21#include <app/icd/client/DefaultCheckInDelegate.h>
22
23
class IcdManager : public chip::app::DefaultCheckInDelegate
andy31415233 days ago

please add a doccomment blurb on why this class exist and its purpose and expected usage.

andy31415
andy31415 commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/StayActiveSender.cpp
22#include <controller/InvokeInteraction.h>
23#include <support/CHIPMem.h>
24
25
StayActiveSender::StayActiveSender(uint32_t stayActiveDuration, const chip::ScopedNodeId & peerNode,
andy31415233 days ago
Suggested change
StayActiveSender::StayActiveSender(uint32_t stayActiveDuration, const chip::ScopedNodeId & peerNode,
StayActiveSender::StayActiveSender(uint32_t stayActiveDurationMs, const chip::ScopedNodeId & peerNode,

please add unit of measurement for all variables holding values with units.

andy31415
andy31415 commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/StayActiveSender.cpp
24
25StayActiveSender::StayActiveSender(uint32_t stayActiveDuration, const chip::ScopedNodeId & peerNode,
26 chip::app::InteractionModelEngine * engine, OnDoneCallbackType onDone) :
27
 mStayActiveDuration(stayActiveDuration),
andy31415233 days ago
Suggested change
mStayActiveDuration(stayActiveDuration),
mStayActiveDurationMs(stayActiveDurationMs),
andy31415
andy31415 commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/StayActiveSender.cpp
37 uint32_t promisedActiveDuration = dataResponse.promisedActiveDuration;
38 ChipLogProgress(ICD, "StayActive command succeeded with promised duration %u", promisedActiveDuration);
39 mOnDone(promisedActiveDuration);
40
 chip::Platform::Delete(this);
andy31415233 days ago

Is it guaranteed that this class is created with Platform::New?
Could we ensure this by making the constructor private and have a Create method instead, so that both New and Delete are always together in the same file?

tehampson233 days ago

Almost. Unfortunately Platform::New is not able to call private function :(

2024-08-13 20:08:03 INFO    ../../examples/fabric-admin/third_party/connectedhomeip/src/lib/support/CHIPMem.h: In instantiation of ‘T* chip::Platform::New(Args&& ...) [with T = StayActiveSender; Args = {unsigned int&, const chip::ScopedNodeId&, chip::app::InteractionModelEngine*, std::function<void(unsigned int)>&}]’:
2024-08-13 20:08:03 INFO    ../../examples/fabric-admin/commands/common/StayActiveSender.cpp:29:66:   required from here
2024-08-13 20:08:03 INFO    ../../examples/fabric-admin/third_party/connectedhomeip/src/lib/support/CHIPMem.h:148:16: error: ‘StayActiveSender::StayActiveSender(uint32_t, const chip::ScopedNodeId&, chip::app::InteractionModelEngine*, OnDoneCallbackType)’ is private within this context
2024-08-13 20:08:03 INFO      148 |         return new (p) T(std::forward<Args>(args)...);
2024-08-13 20:08:03 INFO          |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024-08-13 20:08:03 INFO    ../../examples/fabric-admin/commands/common/StayActiveSender.cpp:40:1: note: declared private here
2024-08-13 20:08:03 INFO       40 | StayActiveSender::StayActiveSender(uint32_t stayActiveDurationMs, const chip::ScopedNodeId & peerNode,
tehampson233 days ago

Let me know if the workaround is acceptable to you. I don't have a good alternative

andy31415
andy31415 commented on 2024-08-13
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/StayActiveSender.h
25
26/**
27 * @brief StayActiveSender contains all the data and methods needed for active period extension of an ICD client.
28
 */
andy31415233 days ago

Please update this with lifetime description and usage: this class makes assumptions on when it auto-deletes, it looks like it auto-deletes if EstablishSessionToPeer returns CHIP_NO_ERROR but is expected to be deleted by the owner if no establish is called or if establish returns an error.

tehampson233 days ago

Added comment, but also lifetime is now managed in StayActiveSender

tehampson Address PR comments
7d8b04ef
tehampson Finish comment
9c56b979
restyled-commits Restyled by whitespace
f6ae4e75
restyled-commits Restyled by clang-format
87d937d5
andy31415
andy31415 commented on 2024-08-14
Conversation is marked as resolved
Show resolved
examples/fabric-admin/rpc/RpcServer.cpp
132 }
133
134 // Modifications to mPendingKeepActive should be done on the MatterEventLoop thread
135
 std::map<chip::NodeId, uint32_t> mPendingKeepActive;
andy31415232 days ago

uint32_t is not obviously a millisecond time unit. Could we name this mPendingKeepActiveTimesMs or use Clock::Milliseconds32 as the type instead of uint32_t ?

andy31415
andy31415 approved these changes on 2024-08-14
tehampson Merge branch 'master' into icd-manager-in-fabric-admin
1dc7a480
tehampson Address PR comment
b9ca50fe
github-actions
github-actions232 days ago (edited 232 days ago)

PR #34894: Size comparison from 927f99a to b9ca50f

Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 927f99a b9ca50f change % change
bl602 lighting-app bl602 FLASH 1278128 1278128 0 0.0
RAM 95928 95928 0 0.0
bl602+mfd FLASH 1292238 1292238 0 0.0
RAM 96072 96072 0 0.0
bl602+rpc FLASH 1317092 1317092 0 0.0
RAM 104352 104352 0 0.0
bl702 lighting-app bl702 FLASH 943988 943988 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 946388 946388 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039044 1039044 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 646706 646706 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894312 894312 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 960392 960392 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963270 963270 0 0.0
RAM 17012 17012 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 803140 803140 0 0.0
RAM 117628 117628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818984 818984 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 811324 811324 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763496 763496 0 0.0
RAM 113648 113648 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747996 747996 0 0.0
RAM 113840 113840 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 613106 613106 0 0.0
RAM 205404 205404 0 0.0
lock CC3235SF_LAUNCHXL FLASH 655074 655074 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672289 672289 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692149 692149 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692149 692149 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649077 649077 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610721 610721 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630349 630349 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630349 630349 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 628185 628185 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647893 647893 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647893 647893 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601717 601717 0 0.0
RAM 68388 68388 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 621577 621577 0 0.0
RAM 71020 71020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 621577 621577 0 0.0
RAM 71020 71020 0 0.0
efr32 lighting-app BRD4187C FLASH 930312 930304 -8 -0.0
RAM 135144 135144 0 0.0
lock-app BRD4338a FLASH 737468 737460 -8 -0.0
RAM 207864 207864 0 0.0
window-app BRD4187C FLASH 1015444 1015436 -8 -0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94176 94176 0 0.0
FLASH 1533510 1533510 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115104 115104 0 0.0
FLASH 1543238 1543238 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2754677 2754677 0 0.0
RAM 128408 128408 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6036734 6036734 0 0.0
RAM 509704 509704 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5375786 5375786 0 0.0
RAM 240072 240072 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4728474 4728474 0 0.0
RAM 216952 216952 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12488074 12488074 0 0.0
RAM 557202 557202 0 0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11163580 11163580 0 0.0
RAM 607272 607272 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11199311 11216315 17004 0.2
RAM 554706 555018 312 0.1
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4539238 4539238 0 0.0
RAM 203456 203456 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5663041 5663041 0 0.0
RAM 228008 228008 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4783222 4783222 0 0.0
RAM 203736 203736 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4423294 4423294 0 0.0
RAM 197720 197720 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4561912 4561912 0 0.0
RAM 202256 202256 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3076221 3076221 0 0.0
RAM 159200 159200 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4363556 4363556 0 0.0
RAM 242416 242416 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 6006501 6006501 0 0.0
RAM 582968 582968 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10691981 10691981 0 0.0
RAM 644280 644280 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 909012 909012 0 0.0
RAM 142255 142255 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880932 880932 0 0.0
RAM 140394 140394 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 840848 840848 0 0.0
RAM 141074 141074 0 0.0
nxp contact k32w0+release FLASH 577372 577372 0 0.0
RAM 70468 70468 0 0.0
k32w1+release FLASH 592680 592680 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612816 612816 0 0.0
RAM 69940 69940 0 0.0
k32w1+release FLASH 677640 677640 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1639108 1639108 0 0.0
RAM 210952 210952 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1543892 1543892 0 0.0
RAM 207672 207672 0 0.0
light cy8ckit_062s2_43012 FLASH 1463796 1463796 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462460 1462460 0 0.0
RAM 225112 225112 0 0.0
qpg lighting-app qpg6105+debug FLASH 655908 655908 0 0.0
RAM 105152 105152 0 0.0
lock-app qpg6105+debug FLASH 613248 613248 0 0.0
RAM 99636 99636 0 0.0
stm32 light STM32WB5MM-DK FLASH 478304 478304 0 0.0
RAM 144764 144764 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620118 620118 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 680630 680630 0 0.0
RAM 149592 149592 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 773898 773898 0 0.0
RAM 110752 110752 0 0.0
bridge-app tlsr9258a FLASH 678806 678806 0 0.0
RAM 91636 91636 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621714 621714 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707596 707596 0 0.0
RAM 74320 74320 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620640 620640 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806726 806726 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654586 654586 0 0.0
RAM 67016 67016 0 0.0
ota-requestor-app tlsr9258a FLASH 696822 696822 0 0.0
RAM 91320 91320 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631102 631102 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608612 608612 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628502 628502 0 0.0
RAM 52700 52700 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652482 652482 0 0.0
RAM 56640 56640 0 0.0
thermostat tlsr9518adk80d FLASH 633666 633666 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 522646 522646 0 0.0
RAM 98540 98540 0 0.0
tizen all-clusters-app arm unknown 4808 4808 0 0.0
FLASH 1700832 1700832 0 0.0
RAM 89348 89348 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17307046 17307046 0 0.0
RAM 7560508 7560508 0 0.0
yufengwangca
yufengwangca approved these changes on 2024-08-14
saurabhst
saurabhst commented on 2024-08-14
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/IcdManager.cpp
36
37void IcdManager::SetDelegate(Delegate * delegate)
38{
39
 // There is an assumption that there is only ever one delegate set and it's
saurabhst232 days ago

whats the basis of this assumption ? Could you provide a bit of background ?

tehampson232 days ago (edited 232 days ago)

If someone wants else calls SetDelegate they will get this crash, if they think that more than one delegate is needed they can change the assumption to suite their needs. But at the time of writing this we have this assumption here and codify those assumptions

tehampson232 days ago👍 1

I will add more to this comment to make that a little more clear that the assumption can be changed, just that we are codifying the assumption based on current simple design of IcdManager

saurabhst
saurabhst commented on 2024-08-14
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/StayActiveSender.cpp
50{
51 auto onSuccess = [&](const chip::app::ConcreteCommandPath & commandPath, const chip::app::StatusIB & status,
52 const auto & dataResponse) {
53
 uint32_t promisedActiveDuration = dataResponse.promisedActiveDuration;
saurabhst232 days ago

should promisedActiveDuration also not be in terms of promisedActiveDurationMs?

tehampson232 days ago👍 1

Good catch, although I can only change it to uint32_t promisedActiveDurationMs = dataResponse.promisedActiveDuration;

the promisedActiveDuration in the dataResponse is outside of this PR and would require xml changes that (I think) cannot change since this would cause downstream API compatibility issues outside of the SDK

saurabhst
saurabhst commented on 2024-08-14
Conversation is marked as resolved
Show resolved
examples/fabric-admin/commands/common/StayActiveSender.h
65
66private:
67 /**
68
 * @brief Sets up a CASE session to the peer for extend a client active period with the peer.
saurabhst232 days ago
Suggested change
* @brief Sets up a CASE session to the peer for extend a client active period with the peer.
* @brief Sets up a CASE session with the peer to extend the client's active period with that peer.
tehampson Address PR comment
5c53fefd
tehampson Address PR comment
b6f4f9e9
saurabhst
saurabhst approved these changes on 2024-08-14
pullapprove pullapprove removed review - pending
pullapprove pullapprove added review - approved
tehampson tehampson enabled auto-merge (squash) 232 days ago
github-actions
github-actions232 days ago (edited 232 days ago)

PR #34894: Size comparison from 927f99a to b6f4f9e

Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 927f99a b6f4f9e change % change
bl602 lighting-app bl602 FLASH 1278128 1278128 0 0.0
RAM 95928 95928 0 0.0
bl602+mfd FLASH 1292238 1292238 0 0.0
RAM 96072 96072 0 0.0
bl602+rpc FLASH 1317092 1317092 0 0.0
RAM 104352 104352 0 0.0
bl702 lighting-app bl702 FLASH 943988 943988 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 946388 946388 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039044 1039044 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 646706 646706 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894312 894312 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 960392 960392 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963270 963270 0 0.0
RAM 17012 17012 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 803140 803140 0 0.0
RAM 117628 117628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 818984 818984 0 0.0
RAM 125220 125220 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 811324 811324 0 0.0
RAM 119500 119500 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 763496 763496 0 0.0
RAM 113648 113648 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747996 747996 0 0.0
RAM 113840 113840 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 613106 613106 0 0.0
RAM 205404 205404 0 0.0
lock CC3235SF_LAUNCHXL FLASH 655074 655074 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672289 672289 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692149 692149 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692149 692149 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649077 649077 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610721 610721 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630349 630349 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630349 630349 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 628185 628185 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 647893 647893 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 647893 647893 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 601717 601717 0 0.0
RAM 68388 68388 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 621577 621577 0 0.0
RAM 71020 71020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 621577 621577 0 0.0
RAM 71020 71020 0 0.0
efr32 lighting-app BRD4187C FLASH 930312 930304 -8 -0.0
RAM 135144 135144 0 0.0
lock-app BRD4338a FLASH 737468 737460 -8 -0.0
RAM 207864 207864 0 0.0
window-app BRD4187C FLASH 1015444 1015436 -8 -0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 94176 94176 0 0.0
FLASH 1533510 1533510 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115104 115104 0 0.0
FLASH 1543238 1543238 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2754677 2754557 -120 -0.0
RAM 128408 128408 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6036734 6036614 -120 -0.0
RAM 509704 509704 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5375786 5375666 -120 -0.0
RAM 240072 240072 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4728474 4728354 -120 -0.0
RAM 216952 216952 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12488074 12488030 -44 -0.0
RAM 557202 557202 0 0.0
chip-tool-ipv6only arm64 unknown 20312 20312 0 0.0
FLASH 11163580 11163548 -32 -0.0
RAM 607272 607272 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11199311 11216271 16960 0.2
RAM 554706 555018 312 0.1
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4539238 4539296 58 0.0
RAM 203456 203456 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5663041 5662913 -128 -0.0
RAM 228008 228008 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4783222 4783102 -120 -0.0
RAM 203736 203736 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4423294 4423174 -120 -0.0
RAM 197720 197720 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4561912 4561792 -120 -0.0
RAM 202256 202256 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3076221 3076093 -128 -0.0
RAM 159200 159200 0 0.0
thermostat-no-ble arm64 unknown 9352 9352 0 0.0
FLASH 4363556 4363444 -112 -0.0
RAM 242416 242416 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 6006501 6006453 -48 -0.0
RAM 582968 582968 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10691981 10691933 -48 -0.0
RAM 644280 644280 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 909012 909012 0 0.0
RAM 142255 142255 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 880932 880932 0 0.0
RAM 140394 140394 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 840848 840848 0 0.0
RAM 141074 141074 0 0.0
nxp contact k32w0+release FLASH 577372 577372 0 0.0
RAM 70468 70468 0 0.0
k32w1+release FLASH 592680 592680 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612816 612816 0 0.0
RAM 69940 69940 0 0.0
k32w1+release FLASH 677640 677640 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1639108 1639108 0 0.0
RAM 210952 210952 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1543892 1543892 0 0.0
RAM 207672 207672 0 0.0
light cy8ckit_062s2_43012 FLASH 1463796 1463796 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462460 1462460 0 0.0
RAM 225112 225112 0 0.0
qpg lighting-app qpg6105+debug FLASH 655908 655908 0 0.0
RAM 105152 105152 0 0.0
lock-app qpg6105+debug FLASH 613248 613248 0 0.0
RAM 99636 99636 0 0.0
stm32 light STM32WB5MM-DK FLASH 478304 478304 0 0.0
RAM 144764 144764 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620118 620118 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 680630 680630 0 0.0
RAM 149592 149592 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 773898 773898 0 0.0
RAM 110752 110752 0 0.0
bridge-app tlsr9258a FLASH 678806 678806 0 0.0
RAM 91636 91636 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621714 621714 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707596 707596 0 0.0
RAM 74320 74320 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620640 620640 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806726 806726 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 654586 654586 0 0.0
RAM 67016 67016 0 0.0
ota-requestor-app tlsr9258a FLASH 696822 696822 0 0.0
RAM 91320 91320 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631102 631102 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608612 608612 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 466810 466810 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628502 628502 0 0.0
RAM 52700 52700 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652482 652482 0 0.0
RAM 56640 56640 0 0.0
thermostat tlsr9518adk80d FLASH 633666 633666 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 522646 522646 0 0.0
RAM 98540 98540 0 0.0
tizen all-clusters-app arm unknown 4808 4808 0 0.0
FLASH 1700832 1700832 0 0.0
RAM 89348 89348 0 0.0
chip-tool-ubsan arm unknown 10236 10236 0 0.0
FLASH 17307046 17306958 -88 -0.0
RAM 7560508 7560464 -44 -0.0
tehampson tehampson merged c11c0ee9 into master 232 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
examples review - approved
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum