connectedhomeip
Update the preset handle field in the SetActivePresetRequest c…
#35105
Merged
Merged
Update the preset handle field in the SetActivePresetRequest c… #35105
mergify
merged
5 commits into
project-chip:master
from
nivi-apple:make_set_active_preset_request_have_nullable_preset_handle
semanticdiff-com223 days ago (edited 223 days ago)
Review changes with SemanticDiff.
Analyzed 2 of 26 files.
Overall, the semantic diff is 18% smaller than the GitHub diff.
File Information
| Filename | Status | |
|---|---|---|
| ❔ | zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h | Unsupported file format |
| ❔ | zzz_generated/app-common/app-common/zap-generated/cluster-objects.h | Unsupported file format |
| ❔ | src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloadsObjc.h | Unsupported file format |
| ❔ | src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloadsObjc.mm | Unsupported file format |
| ✔️ | src/controller/python/chip/clusters/Objects.py | 21.77% smaller |
| ❔ | src/controller/java/generated/java/matter/controller/cluster/clusters/ThermostatCluster.kt | Unsupported file format |
| ✔️ | src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java | 6.64% smaller |
| ❔ | src/controller/data_model/controller-clusters.matter | Unsupported file format |
| ❔ | src/app/zap-templates/zcl/data-model/chip/thermostat-cluster.xml | Unsupported file format |
| ❔ | src/app/clusters/thermostat-server/thermostat-delegate.h | Unsupported file format |
| ❔ | src/app/clusters/thermostat-server/thermostat-server.cpp | Unsupported file format |
| ❔ | examples/thermostat/thermostat-common/thermostat.matter | Unsupported file format |
| ❔ | examples/thermostat/qpg/zap/thermostaticRadiatorValve.matter | Unsupported file format |
| ❔ | examples/thermostat/nxp/zap/thermostat_matter_thread.matter | Unsupported file format |
| ❔ | examples/thermostat/nxp/zap/thermostat_matter_wifi.matter | Unsupported file format |
| ❔ | examples/thermostat/linux/thermostat-delegate-impl.cpp | Unsupported file format |
| ❔ | examples/thermostat/linux/include/thermostat-delegate-impl.h | Unsupported file format |
| ❔ | examples/placeholder/linux/apps/app2/config.matter | Unsupported file format |
| ❔ | examples/placeholder/linux/apps/app1/config.matter | Unsupported file format |
| ❔ | examples/chef/devices/rootnode_airpurifier_airqualitysensor_temperaturesensor_humiditysensor_thermostat_56de3d5f45.matter | Unsupported file format |
| ❔ | examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.matter | Unsupported file format |
| ❔ | examples/chef/devices/rootnode_roomairconditioner_9cf3607804.matter | Unsupported file format |
| ❔ | examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.matter | Unsupported file format |
| ❔ | examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter | Unsupported file format |
| ❔ | examples/all-clusters-app/all-clusters-common/all-clusters-app.matter | Unsupported file format |
| ❔ | examples/air-purifier-app/air-purifier-common/air-purifier-app.matter | Unsupported file format |
nivi-apple
changed the title
nivi-apple223 days ago
Added skip-protocol-compatibility since we are updating command payload for SetActivePresetRequest to be nullable. spec change merged - https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10144
Update the preset handle field in the SetActivePresetRequestRequest c…
2c39518a
Merge remote-tracking branch 'upstream/master' into make_set_active_p…
fc04bb34
Return error if CopySpanToMutableSpan fails
f6f131eb
Restyled by clang-format
e14bf1db
github-actions223 days ago (edited 223 days ago)
PR #35105: Size comparison from 068da61 to e14bf1d
Full report (8 builds for nrfconnect, nxp, stm32, tizen)
| platform | target | config | section | 068da61 | e14bf1d | change | % change |
|---|---|---|---|---|---|---|---|
| nrfconnect | all-clusters-app | nrf52840dk_nrf52840 | FLASH | 909344 | 909420 | 76 | 0.0 |
| RAM | 142211 | 142211 | 0 | 0.0 | |||
| nrf7002dk_nrf5340_cpuapp | FLASH | 881120 | 881200 | 80 | 0.0 | ||
| RAM | 140350 | 140350 | 0 | 0.0 | |||
| all-clusters-minimal-app | nrf52840dk_nrf52840 | FLASH | 841176 | 841188 | 12 | 0.0 | |
| RAM | 141030 | 141030 | 0 | 0.0 | |||
| nxp | contact | k32w1+release | FLASH | 590208 | 590208 | 0 | 0.0 |
| RAM | 62488 | 62488 | 0 | 0.0 | |||
| light | k32w1+release | FLASH | 674880 | 674880 | 0 | 0.0 | |
| RAM | 71472 | 71472 | 0 | 0.0 | |||
| stm32 | light | STM32WB5MM-DK | FLASH | 478472 | 478472 | 0 | 0.0 |
| RAM | 144716 | 144716 | 0 | 0.0 | |||
| tizen | all-clusters-app | arm | unknown | 4820 | 4820 | 0 | 0.0 |
| FLASH | 1701560 | 1701968 | 408 | 0.0 | |||
| RAM | 89300 | 89300 | 0 | 0.0 | |||
| chip-tool-ubsan | arm | unknown | 10252 | 10252 | 0 | 0.0 | |
| FLASH | 17308510 | 17308510 | 0 | 0.0 | |||
| RAM | 7561280 | 7561280 | 0 | 0.0 |
hasty
approved these changes
on 2024-08-20
bzbarsky-apple
approved these changes
on 2024-08-20
Conversation is marked as resolved
Conversation is marked as resolved
Conversation is marked as resolved
Apply suggestions from code review
83704680
github-actions223 days ago (edited 223 days ago)
PR #35105: Size comparison from 068da61 to 8370468
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
| platform | target | config | section | 068da61 | 8370468 | change | % change |
|---|---|---|---|---|---|---|---|
| bl602 | lighting-app | bl602 | FLASH | 1278282 | 1278282 | 0 | 0.0 |
| RAM | 95880 | 95880 | 0 | 0.0 | |||
| bl602+mfd | FLASH | 1292392 | 1292392 | 0 | 0.0 | ||
| RAM | 96024 | 96024 | 0 | 0.0 | |||
| bl602+rpc | FLASH | 1317246 | 1317246 | 0 | 0.0 | ||
| RAM | 104304 | 104304 | 0 | 0.0 | |||
| bl702 | lighting-app | bl702 | FLASH | 944186 | 944186 | 0 | 0.0 |
| RAM | 15209 | 15209 | 0 | 0.0 | |||
| bl702+mfd | FLASH | 946586 | 946586 | 0 | 0.0 | ||
| RAM | 15353 | 15353 | 0 | 0.0 | |||
| bl702+rpc | FLASH | 1039242 | 1039242 | 0 | 0.0 | ||
| RAM | 24221 | 24221 | 0 | 0.0 | |||
| bl706-eth | FLASH | 646848 | 646848 | 0 | 0.0 | ||
| RAM | 25305 | 25305 | 0 | 0.0 | |||
| bl706-wifi | FLASH | 894448 | 894448 | 0 | 0.0 | ||
| RAM | 14525 | 14525 | 0 | 0.0 | |||
| bl702l | lighting-app | bl702l | FLASH | 960590 | 960590 | 0 | 0.0 |
| RAM | 16868 | 16868 | 0 | 0.0 | |||
| bl702l+mfd | FLASH | 963468 | 963468 | 0 | 0.0 | ||
| RAM | 17012 | 17012 | 0 | 0.0 | |||
| cyw30739 | light | CYW30739B2-P5-EVK-01 | unknown | 2040 | 2040 | 0 | 0.0 |
| FLASH | 672465 | 672465 | 0 | 0.0 | |||
| RAM | 78300 | 78300 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 692325 | 692325 | 0 | 0.0 | |||
| RAM | 80932 | 80932 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-03 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 692325 | 692325 | 0 | 0.0 | |||
| RAM | 80932 | 80932 | 0 | 0.0 | |||
| CYW930739M2EVB-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 649261 | 649261 | 0 | 0.0 | |||
| RAM | 73368 | 73368 | 0 | 0.0 | |||
| light-switch | CYW30739B2-P5-EVK-01 | unknown | 2040 | 2040 | 0 | 0.0 | |
| FLASH | 610929 | 610929 | 0 | 0.0 | |||
| RAM | 71292 | 71292 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 630557 | 630557 | 0 | 0.0 | |||
| RAM | 73844 | 73844 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-03 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 630557 | 630557 | 0 | 0.0 | |||
| RAM | 73844 | 73844 | 0 | 0.0 | |||
| lock | CYW30739B2-P5-EVK-01 | unknown | 2040 | 2040 | 0 | 0.0 | |
| FLASH | 628969 | 628969 | 0 | 0.0 | |||
| RAM | 74308 | 74308 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 648677 | 648677 | 0 | 0.0 | |||
| RAM | 76860 | 76860 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-03 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 648677 | 648677 | 0 | 0.0 | |||
| RAM | 76860 | 76860 | 0 | 0.0 | |||
| thermostat | CYW30739B2-P5-EVK-01 | unknown | 2040 | 2040 | 0 | 0.0 | |
| FLASH | 601917 | 601989 | 72 | 0.0 | |||
| RAM | 68340 | 68340 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 621777 | 621849 | 72 | 0.0 | |||
| RAM | 70972 | 70972 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-03 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 621777 | 621849 | 72 | 0.0 | |||
| RAM | 70972 | 70972 | 0 | 0.0 | |||
| efr32 | lighting-app | BRD4187C | FLASH | 930564 | 930564 | 0 | 0.0 |
| RAM | 135096 | 135096 | 0 | 0.0 | |||
| lock-app | BRD4338a | FLASH | 740564 | 740556 | -8 | -0.0 | |
| RAM | 208488 | 208488 | 0 | 0.0 | |||
| window-app | BRD4187C | FLASH | 1015656 | 1015656 | 0 | 0.0 | |
| RAM | 127036 | 127036 | 0 | 0.0 | |||
| esp32 | all-clusters-app | c3devkit | DRAM | 94192 | 94192 | 0 | 0.0 |
| FLASH | 1532632 | 1532726 | 94 | 0.0 | |||
| IRAM | 82538 | 82538 | 0 | 0.0 | |||
| m5stack | DRAM | 115128 | 115128 | 0 | 0.0 | ||
| FLASH | 1542398 | 1542514 | 116 | 0.0 | |||
| IRAM | 117039 | 117039 | 0 | 0.0 | |||
| linux | air-purifier-app | debug | unknown | 4624 | 4624 | 0 | 0.0 |
| FLASH | 2755419 | 2756135 | 716 | 0.0 | |||
| RAM | 128408 | 128408 | 0 | 0.0 | |||
| all-clusters-app | debug | unknown | 5408 | 5408 | 0 | 0.0 | |
| FLASH | 6037850 | 6038834 | 984 | 0.0 | |||
| RAM | 509736 | 509736 | 0 | 0.0 | |||
| all-clusters-minimal-app | debug | unknown | 5304 | 5304 | 0 | 0.0 | |
| FLASH | 5377354 | 5378684 | 1330 | 0.0 | |||
| RAM | 240104 | 240104 | 0 | 0.0 | |||
| bridge-app | debug | unknown | 5288 | 5288 | 0 | 0.0 | |
| FLASH | 4729216 | 4729216 | 0 | 0.0 | |||
| RAM | 216952 | 216952 | 0 | 0.0 | |||
| chip-tool | debug | unknown | 5832 | 5832 | 0 | 0.0 | |
| FLASH | 12488672 | 12488672 | 0 | 0.0 | |||
| RAM | 557202 | 557202 | 0 | 0.0 | |||
| chip-tool-ipv6only | arm64 | unknown | 20312 | 20312 | 0 | 0.0 | |
| FLASH | 11164300 | 11164300 | 0 | 0.0 | |||
| RAM | 607272 | 607272 | 0 | 0.0 | |||
| fabric-admin | debug | unknown | 5664 | 5664 | 0 | 0.0 | |
| FLASH | 10859615 | 10859615 | 0 | 0.0 | |||
| RAM | 555402 | 555402 | 0 | 0.0 | |||
| fabric-bridge-app | debug | unknown | 4520 | 4520 | 0 | 0.0 | |
| FLASH | 4550056 | 4550056 | 0 | 0.0 | |||
| RAM | 203648 | 203648 | 0 | 0.0 | |||
| lighting-app | debug+rpc+ui | unknown | 5936 | 5936 | 0 | 0.0 | |
| FLASH | 5663777 | 5663777 | 0 | 0.0 | |||
| RAM | 228008 | 228008 | 0 | 0.0 | |||
| lock-app | debug | unknown | 5224 | 5224 | 0 | 0.0 | |
| FLASH | 4784562 | 4784562 | 0 | 0.0 | |||
| RAM | 203736 | 203736 | 0 | 0.0 | |||
| ota-provider-app | debug | unknown | 4600 | 4600 | 0 | 0.0 | |
| FLASH | 4424036 | 4424036 | 0 | 0.0 | |||
| RAM | 197720 | 197720 | 0 | 0.0 | |||
| ota-requestor-app | debug | unknown | 4536 | 4536 | 0 | 0.0 | |
| FLASH | 4562654 | 4562654 | 0 | 0.0 | |||
| RAM | 202256 | 202256 | 0 | 0.0 | |||
| shell | debug | unknown | 4176 | 4176 | 0 | 0.0 | |
| FLASH | 3075197 | 3075805 | 608 | 0.0 | |||
| RAM | 158936 | 158936 | 0 | 0.0 | |||
| thermostat-no-ble | arm64 | unknown | 9352 | 9352 | 0 | 0.0 | |
| FLASH | 4364340 | 4364996 | 656 | 0.0 | |||
| RAM | 242416 | 242416 | 0 | 0.0 | |||
| tv-app | debug | unknown | 5496 | 5496 | 0 | 0.0 | |
| FLASH | 6007061 | 6007061 | 0 | 0.0 | |||
| RAM | 582968 | 582968 | 0 | 0.0 | |||
| tv-casting-app | debug | unknown | 5168 | 5168 | 0 | 0.0 | |
| FLASH | 10692765 | 10692765 | 0 | 0.0 | |||
| RAM | 644280 | 644280 | 0 | 0.0 | |||
| nrfconnect | all-clusters-app | nrf52840dk_nrf52840 | FLASH | 909344 | 909420 | 76 | 0.0 |
| RAM | 142211 | 142211 | 0 | 0.0 | |||
| nrf7002dk_nrf5340_cpuapp | FLASH | 881120 | 881200 | 80 | 0.0 | ||
| RAM | 140350 | 140350 | 0 | 0.0 | |||
| all-clusters-minimal-app | nrf52840dk_nrf52840 | FLASH | 841176 | 841188 | 12 | 0.0 | |
| RAM | 141030 | 141030 | 0 | 0.0 | |||
| nxp | contact | k32w0+release | FLASH | 577580 | 577580 | 0 | 0.0 |
| RAM | 70444 | 70444 | 0 | 0.0 | |||
| k32w1+release | FLASH | 590208 | 590208 | 0 | 0.0 | ||
| RAM | 62488 | 62488 | 0 | 0.0 | |||
| light | k32w0+release | FLASH | 613008 | 613008 | 0 | 0.0 | |
| RAM | 69916 | 69916 | 0 | 0.0 | |||
| k32w1+release | FLASH | 674880 | 674880 | 0 | 0.0 | ||
| RAM | 71472 | 71472 | 0 | 0.0 | |||
| psoc6 | all-clusters | cy8ckit_062s2_43012 | FLASH | 1639508 | 1639540 | 32 | 0.0 |
| RAM | 210904 | 210904 | 0 | 0.0 | |||
| all-clusters-minimal | cy8ckit_062s2_43012 | FLASH | 1544260 | 1544372 | 112 | 0.0 | |
| RAM | 207624 | 207624 | 0 | 0.0 | |||
| light | cy8ckit_062s2_43012 | FLASH | 1464028 | 1464028 | 0 | 0.0 | |
| RAM | 200728 | 200728 | 0 | 0.0 | |||
| lock | cy8ckit_062s2_43012 | FLASH | 1463236 | 1463236 | 0 | 0.0 | |
| RAM | 225064 | 225064 | 0 | 0.0 | |||
| qpg | lighting-app | qpg6105+debug | FLASH | 656116 | 656116 | 0 | 0.0 |
| RAM | 105128 | 105128 | 0 | 0.0 | |||
| lock-app | qpg6105+debug | FLASH | 613992 | 613992 | 0 | 0.0 | |
| RAM | 99612 | 99612 | 0 | 0.0 | |||
| stm32 | light | STM32WB5MM-DK | FLASH | 478472 | 478472 | 0 | 0.0 |
| RAM | 144716 | 144716 | 0 | 0.0 | |||
| telink | air-quality-sensor-app | tlsr9528a_retention | FLASH | 620280 | 620280 | 0 | 0.0 |
| RAM | 50932 | 50932 | 0 | 0.0 | |||
| all-clusters-app | tlsr9118bdk40d | FLASH | 680860 | 680952 | 92 | 0.0 | |
| RAM | 149544 | 149544 | 0 | 0.0 | |||
| all-clusters-minimal-app | tlsr9528a | FLASH | 774168 | 774178 | 10 | 0.0 | |
| RAM | 110704 | 110704 | 0 | 0.0 | |||
| bridge-app | tlsr9258a | FLASH | 679010 | 679010 | 0 | 0.0 | |
| RAM | 91588 | 91588 | 0 | 0.0 | |||
| contact-sensor-app | tlsr9528a_retention | FLASH | 621872 | 621872 | 0 | 0.0 | |
| RAM | 50972 | 50972 | 0 | 0.0 | |||
| light-switch-app-ota-shell-factory-data | tlsr9528a | FLASH | 707762 | 707762 | 0 | 0.0 | |
| RAM | 74312 | 74312 | 0 | 0.0 | |||
| lighting-app-ota-factory-data | tlsr9118bdk40d | FLASH | 620758 | 620758 | 0 | 0.0 | |
| RAM | 145532 | 145532 | 0 | 0.0 | |||
| lighting-app-ota-rpc-factory-data-4mb | tlsr9518adk80d | FLASH | 806930 | 806930 | 0 | 0.0 | |
| RAM | 99456 | 99456 | 0 | 0.0 | |||
| lock-app-dfu | tlsr9528a | FLASH | 654854 | 654854 | 0 | 0.0 | |
| RAM | 67008 | 67008 | 0 | 0.0 | |||
| ota-requestor-app | tlsr9258a | FLASH | 697026 | 697026 | 0 | 0.0 | |
| RAM | 91272 | 91272 | 0 | 0.0 | |||
| pump-app-usb | tlsr9518adk80d | FLASH | 631318 | 631318 | 0 | 0.0 | |
| RAM | 55752 | 55752 | 0 | 0.0 | |||
| pump-controller-app | tlsr9518adk80d | FLASH | 608828 | 608828 | 0 | 0.0 | |
| RAM | 52996 | 52996 | 0 | 0.0 | |||
| shell | tlsr9518adk80d | FLASH | 466810 | 466810 | 0 | 0.0 | |
| RAM | 68660 | 68660 | 0 | 0.0 | |||
| smoke_co_alarm-app | tlsr9528a_retention | FLASH | 628662 | 628662 | 0 | 0.0 | |
| RAM | 52692 | 52692 | 0 | 0.0 | |||
| temperature-measurement-app-mars-ota | tlsr9518adk80d | FLASH | 652698 | 652698 | 0 | 0.0 | |
| RAM | 56632 | 56632 | 0 | 0.0 | |||
| thermostat | tlsr9518adk80d | FLASH | 633882 | 633974 | 92 | 0.0 | |
| RAM | 53392 | 53392 | 0 | 0.0 | |||
| window-covering | tlsr9118bdk40d | FLASH | 522774 | 522774 | 0 | 0.0 | |
| RAM | 98532 | 98532 | 0 | 0.0 | |||
| tizen | all-clusters-app | arm | unknown | 4820 | 4820 | 0 | 0.0 |
| FLASH | 1701560 | 1701968 | 408 | 0.0 | |||
| RAM | 89300 | 89300 | 0 | 0.0 | |||
| chip-tool-ubsan | arm | unknown | 10252 | 10252 | 0 | 0.0 | |
| FLASH | 17308510 | 17308510 | 0 | 0.0 | |||
| RAM | 7561280 | 7561280 | 0 | 0.0 |
ReneJosefsen
approved these changes
on 2024-08-21
Login to write a write a comment.
Reviewers
Assignees
No one assigned
Labels
examples
darwin
controller
app
review - approved
skip-protocol-compatibility
Milestone
No milestone
…ommand to be nullable
Fixes: #35104