connectedhomeip
Add chef sample app for dishwasher
#35465
Merged
Overview
Commits
15
Changes
View On GitHub

Add chef sample app for dishwasher #35465

andy31415 merged 15 commits into project-chip:master from bakreanuj:anujbakre_dishwasher
bakreanuj
bakreanuj209 days ago👍 1

Add support for dishwasher chef tool based sample app.

Implement dishwasher alarm cluster, dishwasher mode cluster and operational state cluster.

bakreanuj Update Matter data model/ZAP config for dishwasher
f0d547db
bakreanuj Add support for dishwasher alarm cluster
f32cd7a0
bakreanuj Add support for dishwasher mode cluster
965a3794
bakreanuj Add support for dishwasher mode cluster
8efef59d
bakreanuj Update operational state delegate Emberexteral write and read callback
21574f0e
semanticdiff-com
semanticdiff-com209 days ago

Review changes with SemanticDiff.

github-actions github-actions added examples
github-actions
github-actions209 days ago (edited 209 days ago)

PR #35465: Size comparison from 4e18174 to 21574f0

Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4e18174 21574f0 change % change
bl602 lighting-app bl602 FLASH 1279600 1279600 0 0.0
RAM 95904 95904 0 0.0
bl602+mfd FLASH 1293710 1293710 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1318564 1318564 0 0.0
RAM 104328 104328 0 0.0
bl702 lighting-app bl702 FLASH 944934 944934 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947334 947334 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1040246 1040246 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 648006 648006 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 895420 895420 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961594 961594 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 964216 964216 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678265 678265 0 0.0
RAM 78556 78556 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655053 655053 0 0.0
RAM 73624 73624 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614601 614601 0 0.0
RAM 71524 71524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632625 632625 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606917 606917 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
efr32 lighting-app BRD4187C FLASH 933684 933684 0 0.0
RAM 135120 135120 0 0.0
lock-app BRD4338a FLASH 740804 740804 0 0.0
RAM 197184 197184 0 0.0
window-app BRD4187C FLASH 1017480 1017472 -8 -0.0
RAM 127060 127060 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1538430 1538430 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1548862 1548862 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2768253 2768253 0 0.0
RAM 128808 128808 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6079122 6079122 0 0.0
RAM 510840 510840 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5403236 5403236 0 0.0
RAM 240648 240648 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4737058 4737058 0 0.0
RAM 217640 217640 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 12653086 12653086 0 0.0
RAM 558570 558570 0 0.0
chip-tool-ipv6only arm64 unknown 20368 20368 0 0.0
FLASH 11325156 11325156 0 0.0
RAM 608672 608672 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10960469 10960469 0 0.0
RAM 557562 557562 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4559860 4559860 0 0.0
RAM 204288 204288 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5684561 5684561 0 0.0
RAM 228456 228456 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4791694 4791694 0 0.0
RAM 204040 204040 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4431200 4431200 0 0.0
RAM 198024 198024 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4569776 4569776 0 0.0
RAM 202560 202560 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3105469 3105469 0 0.0
RAM 159520 159520 0 0.0
thermostat-no-ble arm64 unknown 9320 9320 0 0.0
FLASH 4330692 4330692 0 0.0
RAM 242240 242240 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6018149 6018149 0 0.0
RAM 583512 583512 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10859293 10859293 0 0.0
RAM 646200 646200 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914064 914064 0 0.0
RAM 142252 142252 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885732 885732 0 0.0
RAM 140391 140391 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845456 845456 0 0.0
RAM 141070 141070 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 791880 791880 0 0.0
RAM 132225 132225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 936344 936344 0 0.0
RAM 130790 130790 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 883240 883240 0 0.0
RAM 146644 146644 0 0.0
nrf52840dongle_nrf52840 FLASH 824336 824336 0 0.0
RAM 154506 154506 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 780620 780620 0 0.0
RAM 145654 145654 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 936344 936344 0 0.0
RAM 130790 130790 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 805920 805920 0 0.0
RAM 132752 132752 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 731484 731484 0 0.0
RAM 132882 132882 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 951296 951296 0 0.0
RAM 131317 131317 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 757492 757492 0 0.0
RAM 131473 131473 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 742732 742732 0 0.0
RAM 131232 131232 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645964 1645964 0 0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549596 1549596 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1468388 1468388 0 0.0
RAM 200752 200752 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463660 1463660 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 481608 481608 0 0.0
RAM 144740 144740 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620810 620810 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 686304 686304 0 0.0
RAM 149584 149584 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778744 778744 0 0.0
RAM 110744 110744 0 0.0
bridge-app tlsr9258a FLASH 679804 679804 0 0.0
RAM 91596 91596 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622402 622402 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708414 708414 0 0.0
RAM 74320 74320 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624604 624604 0 0.0
RAM 145564 145564 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810734 810734 0 0.0
RAM 99488 99488 0 0.0
lock-app-dfu tlsr9528a FLASH 655386 655386 0 0.0
RAM 67016 67016 0 0.0
ota-requestor-app tlsr9258a FLASH 697670 697670 0 0.0
RAM 91280 91280 0 0.0
pump-app-usb tlsr9518adk80d FLASH 632112 632112 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609360 609360 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 467196 467196 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 629188 629188 0 0.0
RAM 52700 52700 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653342 653342 0 0.0
RAM 56640 56640 0 0.0
thermostat tlsr9518adk80d FLASH 636092 636092 0 0.0
RAM 53408 53408 0 0.0
window-covering tlsr9118bdk40d FLASH 523346 523346 0 0.0
RAM 98540 98540 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1722416 1722416 0 0.0
RAM 89548 89548 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17499570 17499570 0 0.0
RAM 7596248 7596248 0 0.0
lboue
lboue commented on 2024-09-09
Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-mode-delegate-impl.cpp
26using List = chip::app::DataModel::List<T>;
27using ModeTagStructType = chip::app::Clusters::detail::Structs::ModeTagStruct::Type;
28
29
#ifdef MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER
lboue206 days ago (edited 206 days ago)

Could you apply Restyled patches with the instructions given here?

bakreanuj206 days ago

Done

bakreanuj Merge branch 'master' into anujbakre_dishwasher
19554823
github-actions
github-actions206 days ago (edited 206 days ago)

PR #35465: Size comparison from 2e5b709 to 1955482

Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 2e5b709 1955482 change % change
bl602 lighting-app bl602 FLASH 1276224 1276224 0 0.0
RAM 95800 95800 0 0.0
bl602+mfd FLASH 1290332 1290332 0 0.0
RAM 95944 95944 0 0.0
bl602+rpc FLASH 1315180 1315180 0 0.0
RAM 104224 104224 0 0.0
bl702 lighting-app bl702 FLASH 942516 942516 0 0.0
RAM 15137 15137 0 0.0
bl702+mfd FLASH 944914 944914 0 0.0
RAM 15281 15281 0 0.0
bl702+rpc FLASH 1037836 1037836 0 0.0
RAM 24149 24149 0 0.0
bl706-eth FLASH 645588 645588 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 892496 892496 0 0.0
RAM 14453 14453 0 0.0
bl702l lighting-app bl702l FLASH 959176 959176 0 0.0
RAM 16812 16812 0 0.0
bl702l+mfd FLASH 961796 961796 0 0.0
RAM 16956 16956 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 675889 675889 0 0.0
RAM 78460 78460 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 695749 695749 0 0.0
RAM 81092 81092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 695749 695749 0 0.0
RAM 81092 81092 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 652685 652685 0 0.0
RAM 73528 73528 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612257 612257 0 0.0
RAM 71436 71436 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631893 631893 0 0.0
RAM 73988 73988 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631893 631893 0 0.0
RAM 73988 73988 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 631409 631409 0 0.0
RAM 74476 74476 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 651125 651125 0 0.0
RAM 77028 77028 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 651125 651125 0 0.0
RAM 77028 77028 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606917 606917 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
efr32 lighting-app BRD4187C FLASH 931396 931388 -8 -0.0
RAM 135024 135024 0 0.0
lock-app BRD4338a FLASH 739324 739324 0 0.0
RAM 197112 197112 0 0.0
window-app BRD4187C FLASH 1014544 1014536 -8 -0.0
RAM 126964 126964 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1538430 1538430 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1548862 1548862 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2768253 2768253 0 0.0
RAM 128808 128808 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6079122 6079122 0 0.0
RAM 510840 510840 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5403236 5403236 0 0.0
RAM 240648 240648 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4737058 4737058 0 0.0
RAM 217640 217640 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 12653798 12653798 0 0.0
RAM 558570 558570 0 0.0
chip-tool-ipv6only arm64 unknown 20376 20376 0 0.0
FLASH 11325732 11325732 0 0.0
RAM 608672 608672 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10961327 10961327 0 0.0
RAM 557562 557562 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4559860 4559860 0 0.0
RAM 204288 204288 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5673185 5673185 0 0.0
RAM 227928 227928 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4786614 4786614 0 0.0
RAM 203728 203728 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4419788 4419788 0 0.0
RAM 197496 197496 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4558364 4558364 0 0.0
RAM 202032 202032 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3105469 3105469 0 0.0
RAM 159520 159520 0 0.0
thermostat-no-ble arm64 unknown 9320 9320 0 0.0
FLASH 4330692 4330692 0 0.0
RAM 242240 242240 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6018869 6018869 0 0.0
RAM 583512 583512 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10859293 10859293 0 0.0
RAM 646200 646200 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914064 914064 0 0.0
RAM 142252 142252 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885732 885732 0 0.0
RAM 140391 140391 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845456 845456 0 0.0
RAM 141070 141070 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 789596 789596 0 0.0
RAM 132135 132135 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934060 934060 0 0.0
RAM 130700 130700 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 880952 880952 0 0.0
RAM 146554 146554 0 0.0
nrf52840dongle_nrf52840 FLASH 822048 822048 0 0.0
RAM 154416 154416 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 778332 778332 0 0.0
RAM 145564 145564 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934060 934060 0 0.0
RAM 130700 130700 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 804728 804728 0 0.0
RAM 132690 132690 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 730296 730296 0 0.0
RAM 132820 132820 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 950108 950108 0 0.0
RAM 131255 131255 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 757492 757492 0 0.0
RAM 131473 131473 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 742732 742732 0 0.0
RAM 131232 131232 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645964 1645964 0 0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549596 1549596 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1465436 1465436 0 0.0
RAM 200656 200656 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462180 1462180 0 0.0
RAM 225000 225000 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 479320 479320 0 0.0
RAM 144644 144644 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620810 620810 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 686304 686304 0 0.0
RAM 149584 149584 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778744 778744 0 0.0
RAM 110744 110744 0 0.0
bridge-app tlsr9258a FLASH 679804 679804 0 0.0
RAM 91596 91596 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620574 620574 0 0.0
RAM 50892 50892 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706568 706568 0 0.0
RAM 74232 74232 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 622758 622758 0 0.0
RAM 145476 145476 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 808888 808888 0 0.0
RAM 99400 99400 0 0.0
lock-app-dfu tlsr9528a FLASH 654424 654424 0 0.0
RAM 66952 66952 0 0.0
ota-requestor-app tlsr9258a FLASH 695840 695840 0 0.0
RAM 91188 91188 0 0.0
pump-app-usb tlsr9518adk80d FLASH 632112 632112 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609360 609360 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 467196 467196 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627352 627352 0 0.0
RAM 52612 52612 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651496 651496 0 0.0
RAM 56552 56552 0 0.0
thermostat tlsr9518adk80d FLASH 636092 636092 0 0.0
RAM 53408 53408 0 0.0
window-covering tlsr9118bdk40d FLASH 521504 521504 0 0.0
RAM 98452 98452 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1722416 1722416 0 0.0
RAM 89548 89548 0 0.0
chip-tool-ubsan arm unknown 10276 10276 0 0.0
FLASH 17501426 17501426 0 0.0
RAM 7597300 7597300 0 0.0
restyled-commits Restyled by whitespace
90835d99
restyled-commits Restyled by clang-format
a81aee1c
restyled-commits Restyled by gn
bac60e41
pullapprove pullapprove requested a review from andy31415 andy31415 206 days ago
pullapprove pullapprove requested a review from andyg-apple andyg-apple 206 days ago
pullapprove pullapprove requested a review from anush-apple anush-apple 206 days ago
pullapprove pullapprove requested a review from arkq arkq 206 days ago
pullapprove pullapprove requested a review from axelnxp axelnxp 206 days ago
pullapprove pullapprove requested a review from bauerschwan bauerschwan 206 days ago
pullapprove pullapprove requested a review from bzbarsky-apple bzbarsky-apple 206 days ago
pullapprove pullapprove requested a review from carol-apple carol-apple 206 days ago
pullapprove pullapprove requested a review from chapongatien chapongatien 206 days ago
pullapprove pullapprove requested a review from chrisdecenzo chrisdecenzo 206 days ago
pullapprove pullapprove requested a review from chshu chshu 206 days ago
pullapprove pullapprove requested a review from chulspro chulspro 206 days ago
pullapprove pullapprove requested a review from cliffamzn cliffamzn 206 days ago
pullapprove pullapprove requested a review from Damian-Nordic Damian-Nordic 206 days ago
pullapprove pullapprove requested a review from dhrishi dhrishi 206 days ago
pullapprove pullapprove requested a review from doru91 doru91 206 days ago
pullapprove pullapprove requested a review from fessehaeve fessehaeve 206 days ago
pullapprove pullapprove requested a review from harimau-qirex harimau-qirex 206 days ago
pullapprove pullapprove requested a review from harsha-rajendran harsha-rajendran 206 days ago
pullapprove pullapprove requested a review from hawk248 hawk248 206 days ago
pullapprove pullapprove requested a review from hicklin hicklin 206 days ago
pullapprove pullapprove requested a review from jepenven-silabs jepenven-silabs 206 days ago
pullapprove pullapprove requested a review from jmartinez-silabs jmartinez-silabs 206 days ago
pullapprove pullapprove requested a review from jmeg-sfy jmeg-sfy 206 days ago
pullapprove pullapprove requested a review from joonhaengHeo joonhaengHeo 206 days ago
pullapprove pullapprove requested a review from jtung-apple jtung-apple 206 days ago
pullapprove pullapprove requested a review from kiel-apple kiel-apple 206 days ago
pullapprove pullapprove requested a review from kkasperczyk-no kkasperczyk-no 206 days ago
pullapprove pullapprove requested a review from kpschoedel kpschoedel 206 days ago
pullapprove pullapprove requested a review from ksperling-apple ksperling-apple 206 days ago
pullapprove pullapprove requested a review from lazarkov lazarkov 206 days ago
pullapprove pullapprove requested a review from lpbeliveau-silabs lpbeliveau-silabs 206 days ago
pullapprove pullapprove requested a review from LuDuda LuDuda 206 days ago
pullapprove pullapprove requested a review from mhazley mhazley 206 days ago
pullapprove pullapprove requested a review from mkardous-silabs mkardous-silabs 206 days ago
pullapprove pullapprove requested a review from mspang mspang 206 days ago
pullapprove pullapprove requested a review from nivi-apple nivi-apple 206 days ago
pullapprove pullapprove requested a review from p0fi p0fi 206 days ago
pullapprove pullapprove requested a review from pidarped pidarped 206 days ago
pullapprove pullapprove requested a review from plauric plauric 206 days ago
pullapprove pullapprove requested a review from rcasallas-silabs rcasallas-silabs 206 days ago
pullapprove pullapprove requested a review from ReneJosefsen ReneJosefsen 206 days ago
pullapprove pullapprove requested a review from robszewczyk robszewczyk 206 days ago
pullapprove pullapprove requested a review from saurabhst saurabhst 206 days ago
pullapprove pullapprove requested a review from selissia selissia 206 days ago
pullapprove pullapprove requested a review from sharadb-amazon sharadb-amazon 206 days ago
pullapprove pullapprove requested a review from tecimovic tecimovic 206 days ago
pullapprove pullapprove requested a review from tehampson tehampson 206 days ago
pullapprove pullapprove requested a review from tima-q tima-q 206 days ago
pullapprove pullapprove requested a review from tobiasgraf tobiasgraf 206 days ago
pullapprove pullapprove requested a review from turon turon 206 days ago
pullapprove pullapprove requested a review from vivien-apple vivien-apple 206 days ago
pullapprove pullapprove requested a review from wiba-nordic wiba-nordic 206 days ago
pullapprove pullapprove requested a review from woody-apple woody-apple 206 days ago
pullapprove pullapprove requested a review from younghak-hwang younghak-hwang 206 days ago
pullapprove pullapprove requested a review from yufengwangca yufengwangca 206 days ago
pullapprove pullapprove requested a review from yunhanw-google yunhanw-google 206 days ago
pullapprove pullapprove added review - pending
github-actions
github-actions206 days ago (edited 206 days ago)

PR #35465: Size comparison from 2e5b709 to bac60e4

Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 2e5b709 bac60e4 change % change
bl602 lighting-app bl602 FLASH 1276224 1276224 0 0.0
RAM 95800 95800 0 0.0
bl602+mfd FLASH 1290332 1290334 2 0.0
RAM 95944 95944 0 0.0
bl602+rpc FLASH 1315180 1315180 0 0.0
RAM 104224 104224 0 0.0
bl702 lighting-app bl702 FLASH 942516 942516 0 0.0
RAM 15137 15137 0 0.0
bl702+mfd FLASH 944914 944916 2 0.0
RAM 15281 15281 0 0.0
bl702+rpc FLASH 1037836 1037836 0 0.0
RAM 24149 24149 0 0.0
bl706-eth FLASH 645588 645588 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 892496 892496 0 0.0
RAM 14453 14453 0 0.0
bl702l lighting-app bl702l FLASH 959176 959176 0 0.0
RAM 16812 16812 0 0.0
bl702l+mfd FLASH 961796 961798 2 0.0
RAM 16956 16956 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 675889 675889 0 0.0
RAM 78460 78460 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 695749 695749 0 0.0
RAM 81092 81092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 695749 695749 0 0.0
RAM 81092 81092 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 652685 652685 0 0.0
RAM 73528 73528 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612257 612257 0 0.0
RAM 71436 71436 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631893 631893 0 0.0
RAM 73988 73988 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631893 631893 0 0.0
RAM 73988 73988 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 631409 631409 0 0.0
RAM 74476 74476 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 651125 651125 0 0.0
RAM 77028 77028 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 651125 651125 0 0.0
RAM 77028 77028 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606917 606917 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
efr32 lighting-app BRD4187C FLASH 931396 931388 -8 -0.0
RAM 135024 135024 0 0.0
lock-app BRD4338a FLASH 739324 739324 0 0.0
RAM 197112 197112 0 0.0
window-app BRD4187C FLASH 1014544 1014536 -8 -0.0
RAM 126964 126964 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1538430 1538430 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1548862 1548862 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2768253 2768253 0 0.0
RAM 128808 128808 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6079122 6079122 0 0.0
RAM 510840 510840 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5403236 5403236 0 0.0
RAM 240648 240648 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4737058 4737058 0 0.0
RAM 217640 217640 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 12653798 12653798 0 0.0
RAM 558570 558570 0 0.0
chip-tool-ipv6only arm64 unknown 20376 20376 0 0.0
FLASH 11325732 11325732 0 0.0
RAM 608672 608672 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10961327 10961327 0 0.0
RAM 557562 557562 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4559860 4559860 0 0.0
RAM 204288 204288 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5673185 5673185 0 0.0
RAM 227928 227928 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4786614 4786614 0 0.0
RAM 203728 203728 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4419788 4419788 0 0.0
RAM 197496 197496 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4558364 4558364 0 0.0
RAM 202032 202032 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3105469 3105469 0 0.0
RAM 159520 159520 0 0.0
thermostat-no-ble arm64 unknown 9320 9320 0 0.0
FLASH 4330692 4330692 0 0.0
RAM 242240 242240 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6018869 6018869 0 0.0
RAM 583512 583512 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10859293 10859293 0 0.0
RAM 646200 646200 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914064 914064 0 0.0
RAM 142252 142252 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885732 885732 0 0.0
RAM 140391 140391 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845456 845456 0 0.0
RAM 141070 141070 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 789596 789596 0 0.0
RAM 132135 132135 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934060 934060 0 0.0
RAM 130700 130700 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 880952 880952 0 0.0
RAM 146554 146554 0 0.0
nrf52840dongle_nrf52840 FLASH 822048 822048 0 0.0
RAM 154416 154416 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 778332 778332 0 0.0
RAM 145564 145564 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934060 934060 0 0.0
RAM 130700 130700 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 804728 804728 0 0.0
RAM 132690 132690 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 730296 730296 0 0.0
RAM 132820 132820 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 950108 950108 0 0.0
RAM 131255 131255 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 757492 757492 0 0.0
RAM 131473 131473 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 742732 742732 0 0.0
RAM 131232 131232 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645964 1645964 0 0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549596 1549596 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1465436 1465436 0 0.0
RAM 200656 200656 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462180 1462180 0 0.0
RAM 225000 225000 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 479320 479320 0 0.0
RAM 144644 144644 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620810 620810 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 686304 686304 0 0.0
RAM 149584 149584 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778744 778744 0 0.0
RAM 110744 110744 0 0.0
bridge-app tlsr9258a FLASH 679804 679804 0 0.0
RAM 91596 91596 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620574 620574 0 0.0
RAM 50892 50892 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706568 706568 0 0.0
RAM 74232 74232 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 622758 622758 0 0.0
RAM 145476 145476 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 808888 808888 0 0.0
RAM 99400 99400 0 0.0
lock-app-dfu tlsr9528a FLASH 654424 654424 0 0.0
RAM 66952 66952 0 0.0
ota-requestor-app tlsr9258a FLASH 695840 695840 0 0.0
RAM 91188 91188 0 0.0
pump-app-usb tlsr9518adk80d FLASH 632112 632112 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609360 609360 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 467196 467196 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627352 627352 0 0.0
RAM 52612 52612 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651496 651496 0 0.0
RAM 56552 56552 0 0.0
thermostat tlsr9518adk80d FLASH 636092 636092 0 0.0
RAM 53408 53408 0 0.0
window-covering tlsr9118bdk40d FLASH 521504 521504 0 0.0
RAM 98452 98452 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1722416 1722416 0 0.0
RAM 89548 89548 0 0.0
chip-tool-ubsan arm unknown 10276 10276 0 0.0
FLASH 17501426 17501426 0 0.0
RAM 7597300 7597300 0 0.0
bakreanuj Merge branch 'master' into anujbakre_dishwasher
a970dc16
github-actions
github-actions204 days ago (edited 203 days ago)

PR #35465: Size comparison from ac289ed to a970dc1

Full report (73 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
platform target config section ac289ed a970dc1 change % change
bl602 lighting-app bl602 FLASH 1278156 1278156 0 0.0
RAM 95832 95832 0 0.0
bl602+mfd FLASH 1292010 1292010 0 0.0
RAM 95968 95968 0 0.0
bl602+rpc FLASH 1317120 1317120 0 0.0
RAM 104256 104256 0 0.0
bl702 lighting-app bl702 FLASH 943860 943860 0 0.0
RAM 15153 15153 0 0.0
bl702+mfd FLASH 946260 946260 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039180 1039180 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 646056 646056 0 0.0
RAM 25241 25241 0 0.0
bl706-wifi FLASH 894048 894048 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 960520 960520 0 0.0
RAM 16812 16812 0 0.0
bl702l+mfd FLASH 963142 963142 0 0.0
RAM 16964 16964 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677233 677233 0 0.0
RAM 78492 78492 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697085 697085 0 0.0
RAM 81132 81132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697085 697085 0 0.0
RAM 81132 81132 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654021 654021 0 0.0
RAM 73560 73560 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613433 613433 0 0.0
RAM 71460 71460 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633069 633069 0 0.0
RAM 74004 74004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633069 633069 0 0.0
RAM 74004 74004 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632545 632545 0 0.0
RAM 74508 74508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652261 652261 0 0.0
RAM 77052 77052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652261 652261 0 0.0
RAM 77052 77052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608057 608057 0 0.0
RAM 68596 68596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 627909 627909 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 627909 627909 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 932464 932464 0 0.0
RAM 135060 135060 0 0.0
lock-app BRD4338a FLASH 740572 740564 -8 -0.0
RAM 231244 231244 0 0.0
window-app BRD4187C FLASH 1015500 1015492 -8 -0.0
RAM 127000 127000 0 0.0
esp32 all-clusters-app c3devkit DRAM 94168 94168 0 0.0
FLASH 1539596 1539596 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115112 115112 0 0.0
FLASH 1549894 1549894 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2771087 2771087 0 0.0
RAM 128928 128928 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6082608 6082608 0 0.0
RAM 514432 514432 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5406670 5406670 0 0.0
RAM 240784 240784 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4740144 4740144 0 0.0
RAM 217824 217824 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 12676228 12676228 0 0.0
RAM 562250 562250 0 0.0
chip-tool-ipv6only arm64 unknown 20384 20384 0 0.0
FLASH 11341508 11341508 0 0.0
RAM 612376 612376 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10978807 10978807 0 0.0
RAM 561306 561306 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4562880 4562880 0 0.0
RAM 204440 204440 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5676465 5676465 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4789428 4789428 0 0.0
RAM 203912 203912 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4422612 4422612 0 0.0
RAM 197616 197616 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4561356 4561356 0 0.0
RAM 202184 202184 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3107773 3107773 0 0.0
RAM 159624 159624 0 0.0
thermostat-no-ble arm64 unknown 9336 9336 0 0.0
FLASH 4333156 4333156 0 0.0
RAM 242400 242400 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6022117 6022117 0 0.0
RAM 587104 587104 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10883789 10883789 0 0.0
RAM 650224 650224 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915168 915168 0 0.0
RAM 142272 142272 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886472 886472 0 0.0
RAM 140411 140411 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846520 846520 0 0.0
RAM 141090 141090 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 790480 790480 0 0.0
RAM 132155 132155 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934820 934820 0 0.0
RAM 130720 130720 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 882016 882016 0 0.0
RAM 146574 146574 0 0.0
nrf52840dongle_nrf52840 FLASH 823108 823108 0 0.0
RAM 154436 154436 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 779376 779376 0 0.0
RAM 145584 145584 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934820 934820 0 0.0
RAM 130720 130720 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 805564 805564 0 0.0
RAM 132710 132710 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 731108 731108 0 0.0
RAM 132840 132840 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 950832 950832 0 0.0
RAM 131275 131275 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 758372 758372 0 0.0
RAM 131493 131493 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 743568 743568 0 0.0
RAM 131252 131252 0 0.0
nxp contact k32w0+release FLASH 580500 580500 0 0.0
RAM 70712 70712 0 0.0
k32w1+release FLASH 593176 593176 0 0.0
RAM 62536 62536 0 0.0
mcxw71+release FLASH 592936 592936 0 0.0
RAM 62536 62536 0 0.0
light k32w0+release FLASH 616296 616296 0 0.0
RAM 70176 70176 0 0.0
k32w1+release FLASH 679448 679448 0 0.0
RAM 48160 48160 0 0.0
mcxw71+release FLASH 679464 679464 0 0.0
RAM 48160 48160 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646988 1646988 0 0.0
RAM 210968 210968 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550612 1550612 0 0.0
RAM 207680 207680 0 0.0
light cy8ckit_062s2_43012 FLASH 1466436 1466436 0 0.0
RAM 200672 200672 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462956 1462956 0 0.0
RAM 225024 225024 0 0.0
qpg lighting-app qpg6105+debug FLASH 659060 659060 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 616968 616968 0 0.0
RAM 99688 99688 0 0.0
stm32 light STM32WB5MM-DK FLASH 480544 480544 0 0.0
RAM 144676 144676 0 0.0
tizen all-clusters-app arm unknown 4852 4852 0 0.0
FLASH 1724808 1724808 0 0.0
RAM 89608 89608 0 0.0
chip-tool-ubsan arm unknown 10284 10284 0 0.0
FLASH 17532010 17532010 0 0.0
RAM 7609740 7609740 0 0.0
tehampson
tehampson commented on 2024-09-12
Conversation is marked as resolved
Show resolved
examples/chef/devices/rootnode_dishwasher_cc105034fe.matter
284284
 command access(invoke: manage) TriggerEffect(TriggerEffectRequest): DefaultSuccess = 64;
tehampson203 days ago

zap CI is failing, please rerun zap on latest tip-of-tree

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-operational-state-delegate-impl.cpp
237 m == to_underlying(OperationalState::OperationalStateEnum::kRunning))
238 {
239 gOperationalStateDelegate->mCountDownTime.SetNonNull(
240
 static_cast<uint32_t>(gOperationalStateDelegate->kExampleCountDown));
tehampson203 days ago

What does setting this timer get you? If you are expecting that after 30 seconds if goes back to stop, I don't think that works since you have not called DeviceLayer::SystemLayer().StartTimer(System::Clock::Seconds16(1), onOperationalStateTimerTick, this)

bakreanuj198 days ago

Thanks for pointing this out. Added.

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-operational-state-delegate-impl.cpp
215302 gOperationalStateInstance->Init();
216303}
304
305
#endif
tehampson203 days ago

nit,

Suggested change
#endif
#endif // MATTER_DM_PLUGIN_OPERATIONAL_STATE_SERVER
bakreanuj198 days ago

Done.

Conversation is marked as resolved
Show resolved
examples/chef/common/stubs.cpp
3232
33#ifdef MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER
34#include "chef-dishwasher-mode-delegate-impl.h"
35
#endif
tehampson203 days ago

All these endif should have a comment to indicate the closing endif... I know the are just a few lines away, but it is best practice to include them because over time other things might show up inbetween the two making it harder to identify what the endif is for

bakreanuj198 days ago

Done.

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-alarm-delegate-impl.cpp
1/*
2 *
3
 * Copyright (c) 2023 Project CHIP Authors
tehampson203 days ago

nit, 2024

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-mode-delegate-impl.cpp
1/*
2 *
3
 * Copyright (c) 2023 Project CHIP Authors
tehampson203 days ago

nit, 2024

bakreanuj198 days ago

Done

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-mode-delegate-impl.cpp
107 ret = gDishwasherModeInstance->UpdateCurrentMode(m);
108 if (chip::Protocols::InteractionModel::Status::Success != ret)
109 {
110
 ChipLogError(DeviceLayer, "Invalid Attribute Update status: %d", static_cast<int>(ret));
tehampson203 days ago

nit, should you say that invalid attribute write happened to CurrentMode

bakreanuj198 days ago

Done

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-mode-delegate-impl.cpp
133 switch (attributeId)
134 {
135 case chip::app::Clusters::DishwasherMode::Attributes::CurrentMode::Id: {
136
 *buffer = gDishwasherModeInstance->GetCurrentMode();
tehampson203 days ago

Should you be checking that maxReadLength is the expected size of 1 byte?

bakreanuj198 days ago

Done

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-mode-delegate-impl.cpp
123chip::Protocols::InteractionModel::Status chefDishwasherModeReadCallback(chip::EndpointId endpointId, chip::ClusterId clusterId,
124 const EmberAfAttributeMetadata * attributeMetadata,
125 uint8_t * buffer, uint16_t maxReadLength)
126
{
tehampson203 days ago

What if endpointId != 1 should you give unsupported endpoint error?

bakreanuj198 days ago

Hey so these seem to standard across all chef sample apps. Will raise this with chef-tool owners and possibly put a fix in a follow up PR.

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-mode-delegate-impl.cpp
95 const EmberAfAttributeMetadata * attributeMetadata,
96 uint8_t * buffer)
97{
98
 VerifyOrDie(endpointId == 1); // this cluster is only enabled for endpoint 1
tehampson203 days ago

Why are you dying here? Doesn't that mean someone can crash your app by simply trying to write to the attribute that is not 1?

bakreanuj198 days ago

Hey so these seem to standard across all chef sample apps. Will raise this with chef-tool owners and possibly put a fix in a follow up PR.

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-mode-delegate-impl.h
1/*
2 *
3
 * Copyright (c) 2023 Project CHIP Authors
tehampson203 days ago

nit, 2024

bakreanuj198 days ago

Done

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-operational-state-delegate-impl.cpp
210 uint8_t * buffer)
211{
212 chip::Protocols::InteractionModel::Status ret = chip::Protocols::InteractionModel::Status::Success;
213
 VerifyOrDie(endpointId == 1); // this cluster is only enabled for endpoint 1.
tehampson203 days ago

Again I think you should be returning an error here and not dying. I think you can use VerifyOrReturnValue

bakreanuj198 days ago

Hey so these seem to standard across all chef sample apps. Will raise this with chef-tool owners and possibly put a fix in a follow up PR.

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-operational-state-delegate-impl.cpp
257 return ret;
258}
259
260
chip::Protocols::InteractionModel::Status chefOperationalStateReadCallback(chip::EndpointId endpoint, chip::ClusterId clusterId,
tehampson203 days ago

you should preobably check that endpoint is what you expect

bakreanuj198 days ago

Hey so these seem to standard across all chef sample apps. Will raise this with chef-tool owners and possibly put a fix in a follow up PR.

Conversation is marked as resolved
Show resolved
examples/chef/common/chef-dishwasher-mode-delegate-impl.h
87chip::Protocols::InteractionModel::Status chefDishwasherModeReadCallback(chip::EndpointId endpoint, chip::ClusterId clusterId,
88 const EmberAfAttributeMetadata * attributeMetadata,
89 uint8_t * buffer, uint16_t maxReadLength);
90
#endif
tehampson203 days ago

endif needs comment indicating what what is the condition

bakreanuj198 days ago

Done

bakreanuj Update Zap config for dishwasher on TOT
1924910b
bakreanuj bakreanuj marked this pull request as draft 203 days ago
github-actions
github-actions203 days ago (edited 203 days ago)

PR #35465: Size comparison from ac289ed to 1924910

Full report (90 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ac289ed 1924910 change % change
bl602 lighting-app bl602 FLASH 1278156 1278156 0 0.0
RAM 95832 95832 0 0.0
bl602+mfd FLASH 1292010 1292010 0 0.0
RAM 95968 95968 0 0.0
bl602+rpc FLASH 1317120 1317120 0 0.0
RAM 104256 104256 0 0.0
bl702 lighting-app bl702 FLASH 943860 943860 0 0.0
RAM 15153 15153 0 0.0
bl702+mfd FLASH 946260 946260 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039180 1039180 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 646056 646056 0 0.0
RAM 25241 25241 0 0.0
bl706-wifi FLASH 894048 894048 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 960520 960520 0 0.0
RAM 16812 16812 0 0.0
bl702l+mfd FLASH 963142 963142 0 0.0
RAM 16964 16964 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677233 677233 0 0.0
RAM 78492 78492 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697085 697085 0 0.0
RAM 81132 81132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697085 697085 0 0.0
RAM 81132 81132 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654021 654021 0 0.0
RAM 73560 73560 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613433 613433 0 0.0
RAM 71460 71460 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633069 633069 0 0.0
RAM 74004 74004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633069 633069 0 0.0
RAM 74004 74004 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632545 632545 0 0.0
RAM 74508 74508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652261 652261 0 0.0
RAM 77052 77052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652261 652261 0 0.0
RAM 77052 77052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608057 608057 0 0.0
RAM 68596 68596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 627909 627909 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 627909 627909 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 932464 932464 0 0.0
RAM 135060 135060 0 0.0
lock-app BRD4338a FLASH 740572 740564 -8 -0.0
RAM 231244 231244 0 0.0
window-app BRD4187C FLASH 1015500 1015492 -8 -0.0
RAM 127000 127000 0 0.0
esp32 all-clusters-app c3devkit DRAM 94168 94168 0 0.0
FLASH 1539596 1539596 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115112 115112 0 0.0
FLASH 1549894 1549894 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2771087 2771087 0 0.0
RAM 128928 128928 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6082608 6082608 0 0.0
RAM 514432 514432 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5406670 5406670 0 0.0
RAM 240784 240784 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4740144 4740144 0 0.0
RAM 217824 217824 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 12676228 12676228 0 0.0
RAM 562250 562250 0 0.0
chip-tool-ipv6only arm64 unknown 20384 20384 0 0.0
FLASH 11341508 11341508 0 0.0
RAM 612376 612376 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10978807 10978807 0 0.0
RAM 561306 561306 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4562880 4562880 0 0.0
RAM 204440 204440 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5676465 5676465 0 0.0
RAM 228112 228112 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4789428 4789428 0 0.0
RAM 203912 203912 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4422612 4422612 0 0.0
RAM 197616 197616 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4561356 4561356 0 0.0
RAM 202184 202184 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3107773 3107773 0 0.0
RAM 159624 159624 0 0.0
thermostat-no-ble arm64 unknown 9336 9336 0 0.0
FLASH 4333156 4333156 0 0.0
RAM 242400 242400 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6022117 6022117 0 0.0
RAM 587104 587104 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10883789 10883789 0 0.0
RAM 650224 650224 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915168 915168 0 0.0
RAM 142272 142272 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886472 886472 0 0.0
RAM 140411 140411 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846520 846520 0 0.0
RAM 141090 141090 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 790480 790480 0 0.0
RAM 132155 132155 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934820 934820 0 0.0
RAM 130720 130720 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 882016 882016 0 0.0
RAM 146574 146574 0 0.0
nrf52840dongle_nrf52840 FLASH 823108 823108 0 0.0
RAM 154436 154436 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 779376 779376 0 0.0
RAM 145584 145584 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934820 934820 0 0.0
RAM 130720 130720 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 805564 805564 0 0.0
RAM 132710 132710 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 731108 731108 0 0.0
RAM 132840 132840 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 950832 950832 0 0.0
RAM 131275 131275 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 758372 758372 0 0.0
RAM 131493 131493 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 743568 743568 0 0.0
RAM 131252 131252 0 0.0
nxp contact k32w0+release FLASH 580500 580500 0 0.0
RAM 70712 70712 0 0.0
k32w1+release FLASH 593176 593176 0 0.0
RAM 62536 62536 0 0.0
mcxw71+release FLASH 592936 592936 0 0.0
RAM 62536 62536 0 0.0
light k32w0+release FLASH 616296 616296 0 0.0
RAM 70176 70176 0 0.0
k32w1+release FLASH 679448 679448 0 0.0
RAM 48160 48160 0 0.0
mcxw71+release FLASH 679464 679464 0 0.0
RAM 48160 48160 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646988 1646988 0 0.0
RAM 210968 210968 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550612 1550612 0 0.0
RAM 207680 207680 0 0.0
light cy8ckit_062s2_43012 FLASH 1466436 1466436 0 0.0
RAM 200672 200672 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462956 1462956 0 0.0
RAM 225024 225024 0 0.0
qpg lighting-app qpg6105+debug FLASH 659060 659060 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 616968 616968 0 0.0
RAM 99688 99688 0 0.0
stm32 light STM32WB5MM-DK FLASH 480544 480544 0 0.0
RAM 144676 144676 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 621718 621718 0 0.0
RAM 50964 50964 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687326 687326 0 0.0
RAM 149608 149608 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779908 779908 0 0.0
RAM 110768 110768 0 0.0
bridge-app tlsr9258a FLASH 680802 680802 0 0.0
RAM 91620 91620 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621482 621482 0 0.0
RAM 50916 50916 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707514 707514 0 0.0
RAM 74256 74256 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 623742 623742 0 0.0
RAM 145500 145500 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810036 810036 0 0.0
RAM 99424 99424 0 0.0
lock-app-dfu tlsr9528a FLASH 655346 655346 0 0.0
RAM 66976 66976 0 0.0
ota-requestor-app tlsr9258a FLASH 696778 696778 0 0.0
RAM 91212 91212 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633094 633094 0 0.0
RAM 55784 55784 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610282 610282 0 0.0
RAM 53028 53028 0 0.0
shell tlsr9518adk80d FLASH 467196 467196 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628260 628260 0 0.0
RAM 52636 52636 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652418 652418 0 0.0
RAM 56576 56576 0 0.0
thermostat tlsr9518adk80d FLASH 637014 637014 0 0.0
RAM 53432 53432 0 0.0
window-covering tlsr9118bdk40d FLASH 522258 522258 0 0.0
RAM 98476 98476 0 0.0
tizen all-clusters-app arm unknown 4852 4852 0 0.0
FLASH 1724808 1724808 0 0.0
RAM 89608 89608 0 0.0
chip-tool-ubsan arm unknown 10284 10284 0 0.0
FLASH 17532010 17532010 0 0.0
RAM 7609740 7609740 0 0.0
bakreanuj Update Zap config for dishwasher on TOT
b1f29a49
bakreanuj Resolve PR comments for dishwasher
8e9adf01
restyled-commits Restyled by clang-format
bf135942
bakreanuj bakreanuj marked this pull request as ready for review 198 days ago
bakreanuj bakreanuj requested a review from tehampson tehampson 198 days ago
tehampson
tehampson commented on 2024-09-18
Conversation is marked as resolved
Show resolved
examples/chef/common/chef-operational-state-delegate-impl.cpp
11/*
2 * Copyright (c) 2023 Project CHIP Authors
2
 * Copyright (c) 2024 Project CHIP Authors
tehampson198 days ago

nit, sorry, I meant only new files needed this. Old files remain with their old year from my undersanding

bakreanuj198 days ago

Right my bad. Done.

tehampson
tehampson approved these changes on 2024-09-18
bakreanuj rolve PR comments.
2ad78967
andy31415 andy31415 added fast track
andy31415 andy31415 merged e1033521 into master 197 days ago
bakreanuj bakreanuj deleted the anujbakre_dishwasher branch 188 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
examples review - pending fast track
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum