connectedhomeip
[Logging] Use the ephemeral initiator node id in the logging message …
#35654
Merged
Merged
[Logging] Use the ephemeral initiator node id in the logging message … #35654
mergify
merged
1 commit into
project-chip:master
from
vivien-apple:RMP_LogEphemeralInitiatorNodeIdFromResponder
[Logging] Use the ephemeral initiator node id in the logging message …
eadec496
semanticdiff-com194 days ago
Review changes with SemanticDiff.
github-actions194 days ago (edited 194 days ago)
PR #35654: Size comparison from 2396bb4 to eadec49
Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
| platform | target | config | section | 2396bb42 | eadec49 | change | % change |
|---|---|---|---|---|---|---|---|
| bl602 | lighting-app | bl602 | FLASH | 1277856 | 1277878 | 22 | 0.0 |
| RAM | 95824 | 95824 | 0 | 0.0 | |||
| bl602+mfd | FLASH | 1291966 | 1291988 | 22 | 0.0 | ||
| RAM | 95968 | 95968 | 0 | 0.0 | |||
| bl602+rpc | FLASH | 1317068 | 1317090 | 22 | 0.0 | ||
| RAM | 104248 | 104248 | 0 | 0.0 | |||
| bl702 | lighting-app | bl702 | FLASH | 943784 | 943806 | 22 | 0.0 |
| RAM | 15145 | 15145 | 0 | 0.0 | |||
| bl702+mfd | FLASH | 946184 | 946206 | 22 | 0.0 | ||
| RAM | 15305 | 15305 | 0 | 0.0 | |||
| bl702+rpc | FLASH | 1039104 | 1039126 | 22 | 0.0 | ||
| RAM | 24173 | 24173 | 0 | 0.0 | |||
| bl706-eth | FLASH | 645980 | 646002 | 22 | 0.0 | ||
| RAM | 25233 | 25233 | 0 | 0.0 | |||
| bl706-wifi | FLASH | 893736 | 893762 | 26 | 0.0 | ||
| RAM | 14477 | 14477 | 0 | 0.0 | |||
| bl702l | lighting-app | bl702l | FLASH | 960444 | 960466 | 22 | 0.0 |
| RAM | 16804 | 16804 | 0 | 0.0 | |||
| bl702l+mfd | FLASH | 963066 | 963088 | 22 | 0.0 | ||
| RAM | 16964 | 16964 | 0 | 0.0 | |||
| cyw30739 | light | CYW30739B2-P5-EVK-01 | unknown | 2040 | 2040 | 0 | 0.0 |
| FLASH | 677269 | 677285 | 16 | 0.0 | |||
| RAM | 78492 | 78492 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 697121 | 697137 | 16 | 0.0 | |||
| RAM | 81124 | 81124 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-03 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 697121 | 697137 | 16 | 0.0 | |||
| RAM | 81124 | 81124 | 0 | 0.0 | |||
| CYW930739M2EVB-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 654049 | 654065 | 16 | 0.0 | |||
| RAM | 73560 | 73560 | 0 | 0.0 | |||
| light-switch | CYW30739B2-P5-EVK-01 | unknown | 2040 | 2040 | 0 | 0.0 | |
| FLASH | 613341 | 613357 | 16 | 0.0 | |||
| RAM | 71452 | 71452 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 632977 | 632993 | 16 | 0.0 | |||
| RAM | 74004 | 74004 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-03 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 632977 | 632993 | 16 | 0.0 | |||
| RAM | 74004 | 74004 | 0 | 0.0 | |||
| lock | CYW30739B2-P5-EVK-01 | unknown | 2040 | 2040 | 0 | 0.0 | |
| FLASH | 632589 | 632605 | 16 | 0.0 | |||
| RAM | 74500 | 74500 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 652297 | 652313 | 16 | 0.0 | |||
| RAM | 77052 | 77052 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-03 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 652297 | 652313 | 16 | 0.0 | |||
| RAM | 77052 | 77052 | 0 | 0.0 | |||
| thermostat | CYW30739B2-P5-EVK-01 | unknown | 2040 | 2040 | 0 | 0.0 | |
| FLASH | 608005 | 608021 | 16 | 0.0 | |||
| RAM | 68588 | 68588 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-02 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 627857 | 627873 | 16 | 0.0 | |||
| RAM | 71220 | 71220 | 0 | 0.0 | |||
| CYW30739B2-P5-EVK-03 | unknown | 2040 | 2040 | 0 | 0.0 | ||
| FLASH | 627857 | 627873 | 16 | 0.0 | |||
| RAM | 71220 | 71220 | 0 | 0.0 | |||
| efr32 | lighting-app | BRD4187C | FLASH | 932380 | 932380 | 0 | 0.0 |
| RAM | 135056 | 135056 | 0 | 0.0 | |||
| lock-app | BRD2605a | FLASH | 739960 | 739968 | 8 | 0.0 | |
| RAM | 231212 | 231212 | 0 | 0.0 | |||
| BRD4338a | FLASH | 740608 | 740616 | 8 | 0.0 | ||
| RAM | 231244 | 231244 | 0 | 0.0 | |||
| window-app | BRD4187C | FLASH | 1015544 | 1015536 | -8 | -0.0 | |
| RAM | 126996 | 126996 | 0 | 0.0 | |||
| esp32 | all-clusters-app | c3devkit | DRAM | 94064 | 94064 | 0 | 0.0 |
| FLASH | 1537046 | 1537068 | 22 | 0.0 | |||
| IRAM | 82538 | 82538 | 0 | 0.0 | |||
| m5stack | DRAM | 115008 | 115008 | 0 | 0.0 | ||
| FLASH | 1547502 | 1547530 | 28 | 0.0 | |||
| IRAM | 117039 | 117039 | 0 | 0.0 | |||
| linux | air-purifier-app | debug | unknown | 4688 | 4688 | 0 | 0.0 |
| FLASH | 2772147 | 2772195 | 48 | 0.0 | |||
| RAM | 128944 | 128944 | 0 | 0.0 | |||
| all-clusters-app | debug | unknown | 5456 | 5456 | 0 | 0.0 | |
| FLASH | 6074318 | 6074366 | 48 | 0.0 | |||
| RAM | 506928 | 506928 | 0 | 0.0 | |||
| all-clusters-minimal-app | debug | unknown | 5352 | 5352 | 0 | 0.0 | |
| FLASH | 5407696 | 5407744 | 48 | 0.0 | |||
| RAM | 240640 | 240640 | 0 | 0.0 | |||
| bridge-app | debug | unknown | 5336 | 5336 | 0 | 0.0 | |
| FLASH | 4741208 | 4741256 | 48 | 0.0 | |||
| RAM | 217840 | 217840 | 0 | 0.0 | |||
| chip-tool | debug | unknown | 5888 | 5888 | 0 | 0.0 | |
| FLASH | 12540702 | 12540750 | 48 | 0.0 | |||
| RAM | 554506 | 554506 | 0 | 0.0 | |||
| chip-tool-ipv6only | arm64 | unknown | 20320 | 20320 | 0 | 0.0 | |
| FLASH | 11240596 | 11240628 | 32 | 0.0 | |||
| RAM | 604560 | 604560 | 0 | 0.0 | |||
| fabric-admin | debug | unknown | 5720 | 5720 | 0 | 0.0 | |
| FLASH | 10893843 | 1089389 | 48 | 0.0 | |||
| RAM | 553546 | 553546 | 0 | 0.0 | |||
| fabric-bridge-app | debug | unknown | 4568 | 4568 | 0 | 0.0 | |
| FLASH | 4563946 | 4563994 | 48 | 0.0 | |||
| RAM | 204456 | 204456 | 0 | 0.0 | |||
| lighting-app | debug+rpc+ui | unknown | 5984 | 5984 | 0 | 0.0 | |
| FLASH | 5677521 | 5677569 | 48 | 0.0 | |||
| RAM | 228128 | 228128 | 0 | 0.0 | |||
| lock-app | debug | unknown | 5272 | 5272 | 0 | 0.0 | |
| FLASH | 4790488 | 4790536 | 48 | 0.0 | |||
| RAM | 203928 | 203928 | 0 | 0.0 | |||
| ota-provider-app | debug | unknown | 4648 | 4648 | 0 | 0.0 | |
| FLASH | 4423674 | 4423722 | 48 | 0.0 | |||
| RAM | 197632 | 197632 | 0 | 0.0 | |||
| ota-requestor-app | debug | unknown | 4584 | 4584 | 0 | 0.0 | |
| FLASH | 4562420 | 4562468 | 48 | 0.0 | |||
| RAM | 202200 | 202200 | 0 | 0.0 | |||
| shell | debug | unknown | 4216 | 4216 | 0 | 0.0 | |
| FLASH | 3102941 | 3102989 | 48 | 0.0 | |||
| RAM | 158712 | 158712 | 0 | 0.0 | |||
| thermostat-no-ble | arm64 | unknown | 9336 | 9336 | 0 | 0.0 | |
| FLASH | 4334076 | 4334108 | 32 | 0.0 | |||
| RAM | 242256 | 242256 | 0 | 0.0 | |||
| tv-app | debug | unknown | 5552 | 5552 | 0 | 0.0 | |
| FLASH | 6019749 | 6019797 | 48 | 0.0 | |||
| RAM | 580464 | 580464 | 0 | 0.0 | |||
| tv-casting-app | debug | unknown | 5208 | 5208 | 0 | 0.0 | |
| FLASH | 10747277 | 10747325 | 48 | 0.0 | |||
| RAM | 642384 | 642384 | 0 | 0.0 | |||
| nrfconnect | all-clusters-app | nrf52840dk_nrf52840 | FLASH | 912968 | 912984 | 16 | 0.0 |
| RAM | 142175 | 142175 | 0 | 0.0 | |||
| nrf7002dk_nrf5340_cpuapp | FLASH | 884748 | 884748 | 0 | 0.0 | ||
| RAM | 140314 | 140314 | 0 | 0.0 | |||
| all-clusters-minimal-app | nrf52840dk_nrf52840 | FLASH | 846476 | 846492 | 16 | 0.0 | |
| RAM | 141077 | 141077 | 0 | 0.0 | |||
| nxp | contact | k32w0+release | FLASH | 581544 | 581544 | 0 | 0.0 |
| RAM | 70768 | 70768 | 0 | 0.0 | |||
| k32w1+release | FLASH | 594008 | 594024 | 16 | 0.0 | ||
| RAM | 62944 | 62944 | 0 | 0.0 | |||
| mcxw71+release | FLASH | 593760 | 593784 | 24 | 0.0 | ||
| RAM | 62944 | 62944 | 0 | 0.0 | |||
| light | k32w0+release | FLASH | 617388 | 617404 | 16 | 0.0 | |
| RAM | 70224 | 70224 | 0 | 0.0 | |||
| k32w1+release | FLASH | 680584 | 680608 | 24 | 0.0 | ||
| RAM | 48560 | 48560 | 0 | 0.0 | |||
| mcxw71+release | FLASH | 680600 | 680624 | 24 | 0.0 | ||
| RAM | 48560 | 48560 | 0 | 0.0 | |||
| lock | k32w1+release | FLASH | 702576 | 702592 | 16 | 0.0 | |
| RAM | 67076 | 67076 | 0 | 0.0 | |||
| mcxw71+release | FLASH | 702600 | 702616 | 16 | 0.0 | ||
| RAM | 67076 | 67076 | 0 | 0.0 | |||
| psoc6 | all-clusters | cy8ckit_062s2_43012 | FLASH | 1644548 | 1644564 | 16 | 0.0 |
| RAM | 210864 | 210864 | 0 | 0.0 | |||
| all-clusters-minimal | cy8ckit_062s2_43012 | FLASH | 1550556 | 1550588 | 32 | 0.0 | |
| RAM | 207664 | 207664 | 0 | 0.0 | |||
| light | cy8ckit_062s2_43012 | FLASH | 1466372 | 1466388 | 16 | 0.0 | |
| RAM | 200672 | 200672 | 0 | 0.0 | |||
| lock | cy8ckit_062s2_43012 | FLASH | 1462988 | 1463020 | 32 | 0.0 | |
| RAM | 225024 | 225024 | 0 | 0.0 | |||
| qpg | lighting-app | qpg6105+debug | FLASH | 659104 | 659120 | 16 | 0.0 |
| RAM | 105212 | 105212 | 0 | 0.0 | |||
| lock-app | qpg6105+debug | FLASH | 616996 | 617012 | 16 | 0.0 | |
| RAM | 99688 | 99688 | 0 | 0.0 | |||
| stm32 | light | STM32WB5MM-DK | FLASH | 480576 | 480592 | 16 | 0.0 |
| RAM | 144668 | 144668 | 0 | 0.0 | |||
| telink | air-quality-sensor-app | tlsr9528a_retention | FLASH | 621702 | 621724 | 22 | 0.0 |
| RAM | 50964 | 50964 | 0 | 0.0 | |||
| all-clusters-app | tlsr9118bdk40d | FLASH | 686942 | 686964 | 22 | 0.0 | |
| RAM | 148304 | 148304 | 0 | 0.0 | |||
| all-clusters-minimal-app | tlsr9528a | FLASH | 779886 | 779908 | 22 | 0.0 | |
| RAM | 110756 | 110756 | 0 | 0.0 | |||
| bridge-app | tlsr9258a | FLASH | 680722 | 680744 | 22 | 0.0 | |
| RAM | 91620 | 91620 | 0 | 0.0 | |||
| contact-sensor-app | tlsr9528a_retention | FLASH | 621466 | 621488 | 22 | 0.0 | |
| RAM | 50916 | 50916 | 0 | 0.0 | |||
| light-switch-app-ota-shell-factory-data | tlsr9528a | FLASH | 707372 | 707394 | 22 | 0.0 | |
| RAM | 74256 | 74256 | 0 | 0.0 | |||
| lighting-app-ota-factory-data | tlsr9118bdk40d | FLASH | 624620 | 624642 | 22 | 0.0 | |
| RAM | 144292 | 144292 | 0 | 0.0 | |||
| lighting-app-ota-rpc-factory-data-4mb | tlsr9518adk80d | FLASH | 810028 | 810050 | 22 | 0.0 | |
| RAM | 99424 | 99424 | 0 | 0.0 | |||
| lock-app-dfu | tlsr9528a | FLASH | 655218 | 655240 | 22 | 0.0 | |
| RAM | 66976 | 66976 | 0 | 0.0 | |||
| ota-requestor-app | tlsr9258a | FLASH | 696698 | 696720 | 22 | 0.0 | |
| RAM | 91212 | 91212 | 0 | 0.0 | |||
| pump-app-usb | tlsr9518adk80d | FLASH | 633054 | 633076 | 22 | 0.0 | |
| RAM | 55792 | 55792 | 0 | 0.0 | |||
| pump-controller-app | tlsr9518adk80d | FLASH | 610244 | 610266 | 22 | 0.0 | |
| RAM | 53036 | 53036 | 0 | 0.0 | |||
| shell | tlsr9518adk80d | FLASH | 467170 | 467192 | 22 | 0.0 | |
| RAM | 68668 | 68668 | 0 | 0.0 | |||
| smoke_co_alarm-app | tlsr9528a_retention | FLASH | 628430 | 628452 | 22 | 0.0 | |
| RAM | 52636 | 52636 | 0 | 0.0 | |||
| temperature-measurement-app-mars-ota | tlsr9518adk80d | FLASH | 652380 | 652402 | 22 | 0.0 | |
| RAM | 56584 | 56584 | 0 | 0.0 | |||
| thermostat | tlsr9518adk80d | FLASH | 636974 | 636996 | 22 | 0.0 | |
| RAM | 53428 | 53428 | 0 | 0.0 | |||
| window-covering | tlsr9118bdk40d | FLASH | 523150 | 523172 | 22 | 0.0 | |
| RAM | 97268 | 97268 | 0 | 0.0 | |||
| tizen | all-clusters-app | arm | unknown | 4852 | 4852 | 0 | 0.0 |
| FLASH | 1720668 | 1720708 | 40 | 0.0 | |||
| RAM | 88952 | 88952 | 0 | 0.0 | |||
| chip-tool-ubsan | arm | unknown | 10252 | 10252 | 0 | 0.0 | |
| FLASH | 17317338 | 17317442 | 104 | 0.0 | |||
| RAM | 7543536 | 7543576 | 40 | 0.0 |
nivi-apple
approved these changes
on 2024-09-18
woody-apple
approved these changes
on 2024-09-18
andy31415
approved these changes
on 2024-09-19
Login to write a write a comment.
Reviewers
Assignees
Labels
transport
review - approved
Milestone
No milestone
…when the responder transmit a message
Problem
When logging TX unauthenticated messages in
connectedhomeip/src/transport/SessionManager.cpp
Line 388 in 2396bb4
destinationis set tokUndefinedNodeIdbut the responder normally set the destination to the ephemeral initiator node idWhen messages are received (RX logs) the ephemeral initial node id is printed correctly but not when they are transmitted.