connectedhomeip
[Android] Implement DiagnosticLog
#36591
Merged
Overview
Commits
12
Changes
View On GitHub

[Android] Implement DiagnosticLog #36591

yunhanw-google merged 12 commits into project-chip:master from joonhaengHeo:implement_android_diag_log
joonhaengHeo
joonhaengHeo129 days ago (edited 115 days ago)

Fix #31647

Implement DiagnosticLog in Android ChipTool and Java controller.

Test:
Add new DiagnosticLog test inside JavaMatterController in CI
Using real aqara device for testing.

joonhaengHeo Implement Android DiagnosticLog
b915dbdf
semanticdiff-com
semanticdiff-com129 days ago (edited 117 days ago)

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/java-tests.yaml Unsupported file format
  examples/android/CHIPTool/app/src/main/AndroidManifest.xml Unsupported file format
  examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/SelectActionFragment.kt Unsupported file format
  examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/DiagnosticLogFragment.kt Unsupported file format
  examples/android/CHIPTool/app/src/main/res/layout/diagnostic_log_fragment.xml Unsupported file format
  examples/android/CHIPTool/app/src/main/res/layout/select_action_fragment.xml Unsupported file format
  examples/android/CHIPTool/app/src/main/res/values/strings.xml Unsupported file format
  examples/android/CHIPTool/app/src/main/res/xml/file_paths.xml Unsupported file format
  examples/java-matter-controller/BUILD.gn Unsupported file format
  examples/java-matter-controller/java/src/com/matter/controller/Main.kt Unsupported file format
  examples/java-matter-controller/java/src/com/matter/controller/commands/bdx/DownloadLogCommand.kt Unsupported file format
  examples/java-matter-controller/java/src/com/matter/controller/commands/bdx/PairOnNetworkLongDownloadLogCommand.kt Unsupported file format
  kotlin-detect-config.yaml Unsupported file format
  scripts/tests/java/bdx_test.py  0% smaller
  scripts/tests/run_java_test.py  0% smaller
  src/controller/java/AndroidLogDownloadFromNode.cpp Unsupported file format
  src/controller/java/AndroidLogDownloadFromNode.h Unsupported file format
  src/controller/java/BUILD.gn Unsupported file format
  src/controller/java/BdxDiagnosticLogsReceiver.cpp Unsupported file format
  src/controller/java/BdxDiagnosticLogsReceiver.h Unsupported file format
  src/controller/java/CHIPDeviceController-JNI.cpp Unsupported file format
  src/controller/java/src/chip/devicecontroller/ChipDeviceController.java  0% smaller
  src/controller/java/src/chip/devicecontroller/DiagnosticLogType.java  0% smaller
  src/controller/java/src/chip/devicecontroller/DownloadLogCallback.java  0% smaller
  src/protocols/bdx/BdxUri.h Unsupported file format
github-actions github-actions added examples
github-actions github-actions added controller
github-actions github-actions added protocols
bzbarsky-apple
bzbarsky-apple commented on 2024-11-22
Conversation is marked as resolved
Show resolved
src/protocols/bdx/BdxTransferServerDelegate.h
51 return CHIP_ERROR_NOT_IMPLEMENTED;
52 }
53
54
 virtual CHIP_ERROR OnTransferData(BDXTransferProxy * transfer, const ByteSpan & data, bool isEof)
bzbarsky-apple128 days ago👍 1

Why is this needed? The transfer ends OnTransferEnd, no?

joonhaengHeo121 days ago

I understand. I will fix it.

joonhaengHeo Update from comment
de3da7c1
joonhaengHeo Restyled
d82e05e4
joonhaengHeo joonhaengHeo force pushed from 7f85d1d9 to d82e05e4 121 days ago
joonhaengHeo joonhaengHeo marked this pull request as ready for review 121 days ago
joonhaengHeo joonhaengHeo requested a review 121 days ago
pullapprove pullapprove added review - pending
joonhaengHeo Update DiagnosticLog UX (Download complete / failed)
8a4894e6
github-actions
github-actions121 days ago (edited 121 days ago)

PR #36591: Size comparison from b3e074c to 8a4894e

Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section b3e074c 8a4894e change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838792 838792 0 0.0
RAM 123640 123640 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824460 824460 0 0.0
RAM 125520 125520 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771200 771200 0 0.0
RAM 113988 113988 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755388 755388 0 0.0
RAM 114204 114204 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 629462 629462 0 0.0
RAM 205792 205792 0 0.0
lock CC3235SF_LAUNCHXL FLASH 668042 668042 0 0.0
RAM 205936 205936 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916624 916624 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888836 888836 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850788 850788 0 0.0
RAM 142200 142200 0 0.0
qpg lighting-app qpg6105+debug FLASH 663080 663080 0 0.0
RAM 105384 105384 0 0.0
lock-app qpg6105+debug FLASH 620908 620908 0 0.0
RAM 99844 99844 0 0.0
stm32 light STM32WB5MM-DK FLASH 483716 483716 0 0.0
RAM 144848 144848 0 0.0
tizen all-clusters-app arm unknown 4976 4976 0 0.0
FLASH 1727728 1727728 0 0.0
RAM 90648 90648 0 0.0
chip-tool-ubsan arm unknown 10788 10788 0 0.0
FLASH 17952454 17952454 0 0.0
RAM 7831832 7831832 0 0.0
joonhaengHeo Fix timeout issue
8d219dfa
github-actions
github-actions121 days ago (edited 121 days ago)

PR #36591: Size comparison from b3e074c to 8d219df

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section b3e074c 8d219df change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1351196 1351196 0 0.0
RAM 104088 104088 0 0.0
bl702 lighting-app bl702+eth FLASH 650480 650480 0 0.0
RAM 25329 25329 0 0.0
bl702+wifi FLASH 828064 828064 0 0.0
RAM 14069 14069 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056258 1056258 0 0.0
RAM 23917 23917 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 977632 977632 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838792 838792 0 0.0
RAM 123640 123640 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824460 824460 0 0.0
RAM 125520 125520 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771200 771200 0 0.0
RAM 113988 113988 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755388 755388 0 0.0
RAM 114204 114204 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 629462 629462 0 0.0
RAM 205792 205792 0 0.0
lock CC3235SF_LAUNCHXL FLASH 668042 668042 0 0.0
RAM 205936 205936 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 680473 680473 0 0.0
RAM 78700 78700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 700317 700317 0 0.0
RAM 81340 81340 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 700317 700317 0 0.0
RAM 81340 81340 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 657261 657261 0 0.0
RAM 73768 73768 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 617153 617153 0 0.0
RAM 71684 71684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636781 636781 0 0.0
RAM 74228 74228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636781 636781 0 0.0
RAM 74228 74228 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 636545 636545 0 0.0
RAM 74700 74700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656253 656253 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656253 656253 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613021 613021 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 632873 632873 0 0.0
RAM 71420 71420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 632873 632873 0 0.0
RAM 71420 71420 0 0.0
efr32 lock-app BRD4187C FLASH 931292 931292 0 0.0
RAM 160168 160168 0 0.0
BRD4338a FLASH 744680 744672 -8 -0.0
RAM 233296 233296 0 0.0
window-app BRD4187C FLASH 1023240 1023232 -8 -0.0
RAM 128268 128268 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95344 0 0.0
FLASH 1542118 1542118 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116272 116272 0 0.0
FLASH 1549254 1549254 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2707457 2707457 0 0.0
RAM 129656 129656 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5999134 5999134 0 0.0
RAM 523400 523400 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5336942 5336942 0 0.0
RAM 242456 242456 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4676470 4676470 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12839426 12839426 0 0.0
RAM 582218 582218 0 0.0
chip-tool-ipv6only arm64 unknown 21304 21304 0 0.0
FLASH 10973744 10973744 0 0.0
RAM 633168 633168 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11243391 11243391 0 0.0
RAM 582562 582562 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4500726 4500726 0 0.0
RAM 205376 205376 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5597429 5597429 0 0.0
RAM 472360 472360 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5612977 5612977 0 0.0
RAM 228600 228600 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4725856 4725856 0 0.0
RAM 204616 204616 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4351578 4351578 0 0.0
RAM 198288 198288 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4490620 4490620 0 0.0
RAM 202872 202872 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3022061 3022061 0 0.0
RAM 160328 160328 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097104 4097104 0 0.0
RAM 243000 243000 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5950229 5950229 0 0.0
RAM 595888 595888 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11046669 11046669 0 0.0
RAM 691992 691992 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916624 916624 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888836 888836 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850788 850788 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 584608 584608 0 0.0
RAM 71056 71056 0 0.0
mcxw71+release FLASH 599144 599144 0 0.0
RAM 63152 63152 0 0.0
light k32w0+release FLASH 611548 611548 0 0.0
RAM 70448 70448 0 0.0
k32w1+release FLASH 685696 685696 0 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 762016 762016 0 0.0
RAM 70812 70812 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1644716 1644716 0 0.0
RAM 212072 212072 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552508 1552508 0 0.0
RAM 208872 208872 0 0.0
light cy8ckit_062s2_43012 FLASH 1467740 1467740 0 0.0
RAM 200856 200856 0 0.0
lock cy8ckit_062s2_43012 FLASH 1465596 1465596 0 0.0
RAM 225216 225216 0 0.0
qpg lighting-app qpg6105+debug FLASH 663080 663080 0 0.0
RAM 105384 105384 0 0.0
lock-app qpg6105+debug FLASH 620908 620908 0 0.0
RAM 99844 99844 0 0.0
stm32 light STM32WB5MM-DK FLASH 483716 483716 0 0.0
RAM 144848 144848 0 0.0
telink bridge-app tlsr9258a FLASH 681724 681724 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622130 622130 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 763488 763488 0 0.0
RAM 50212 50212 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709554 709554 0 0.0
RAM 73496 73496 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626508 626508 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812416 812416 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4976 4976 0 0.0
FLASH 1727728 1727728 0 0.0
RAM 90648 90648 0 0.0
chip-tool-ubsan arm unknown 10788 10788 0 0.0
FLASH 17952454 17952454 0 0.0
RAM 7831832 7831832 0 0.0
joonhaengHeo Fix java-controller build error
8653d565
joonhaengHeo joonhaengHeo force pushed from 245cb039 to 8653d565 118 days ago
github-actions
github-actions118 days ago (edited 118 days ago)

PR #36591: Size comparison from e402b96 to 8653d56

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e402b96 8653d56 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1352938 1352938 0 0.0
RAM 104104 104104 0 0.0
bl702 lighting-app bl702+eth FLASH 651536 651536 0 0.0
RAM 25345 25345 0 0.0
bl702+wifi FLASH 829120 829120 0 0.0
RAM 14085 14085 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057314 1057314 0 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 978688 978688 0 0.0
RAM 16572 16572 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839576 839576 0 0.0
RAM 123656 123656 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825116 825116 0 0.0
RAM 125536 125536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771864 771864 0 0.0
RAM 114004 114004 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756052 756052 0 0.0
RAM 114220 114220 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 630686 630686 0 0.0
RAM 205808 205808 0 0.0
lock CC3235SF_LAUNCHXL FLASH 669298 669298 0 0.0
RAM 205952 205952 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681249 681249 0 0.0
RAM 78716 78716 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701101 701101 0 0.0
RAM 81348 81348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701101 701101 0 0.0
RAM 81348 81348 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658037 658037 0 0.0
RAM 73784 73784 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 617809 617809 0 0.0
RAM 71692 71692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637437 637437 0 0.0
RAM 74244 74244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637437 637437 0 0.0
RAM 74244 74244 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637201 637201 0 0.0
RAM 74708 74708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656917 656917 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656917 656917 0 0.0
RAM 77260 77260 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613669 613669 0 0.0
RAM 68796 68796 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633521 633521 0 0.0
RAM 71436 71436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633521 633521 0 0.0
RAM 71436 71436 0 0.0
efr32 lock-app BRD4187C FLASH 932116 932116 0 0.0
RAM 160180 160180 0 0.0
BRD4338a FLASH 745920 745912 -8 -0.0
RAM 233312 233312 0 0.0
window-app BRD4187C FLASH 1024480 1024480 0 0.0
RAM 128284 128284 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95344 0 0.0
FLASH 1543258 1543258 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116296 116296 0 0.0
FLASH 1550002 1550002 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2713573 2713573 0 0.0
RAM 129768 129768 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6005592 6005592 0 0.0
RAM 523512 523512 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5343400 5343400 0 0.0
RAM 242568 242568 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4682886 4682886 0 0.0
RAM 218432 218432 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12845674 12845674 0 0.0
RAM 582314 582314 0 0.0
chip-tool-ipv6only arm64 unknown 21312 21312 0 0.0
FLASH 10979680 10979680 0 0.0
RAM 633232 633232 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11249739 11249739 0 0.0
RAM 582690 582690 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4507142 4507142 0 0.0
RAM 205504 205504 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5603733 5603733 0 0.0
RAM 472488 472488 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5619729 5619729 0 0.0
RAM 228760 228760 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4732240 4732240 0 0.0
RAM 204744 204744 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4357994 4357994 0 0.0
RAM 198416 198416 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4497034 4497034 0 0.0
RAM 203000 203000 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3028413 3028413 0 0.0
RAM 160456 160456 0 0.0
thermostat-no-ble arm64 unknown 9520 9520 0 0.0
FLASH 4102464 4102464 0 0.0
RAM 243040 243040 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5956245 5956245 0 0.0
RAM 596000 596000 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11052557 11052557 0 0.0
RAM 692120 692120 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917380 917380 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 889868 889868 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851548 851548 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 585264 585264 0 0.0
RAM 71072 71072 0 0.0
mcxw71+release FLASH 599800 599800 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 612204 612204 0 0.0
RAM 70464 70464 0 0.0
k32w1+release FLASH 686344 686344 0 0.0
RAM 48792 48792 0 0.0
lock mcxw71+release FLASH 762680 762680 0 0.0
RAM 70828 70828 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646068 1646068 0 0.0
RAM 212088 212088 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553836 1553836 0 0.0
RAM 208888 208888 0 0.0
light cy8ckit_062s2_43012 FLASH 1469108 1469108 0 0.0
RAM 200872 200872 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466836 1466836 0 0.0
RAM 225232 225232 0 0.0
qpg lighting-app qpg6105+debug FLASH 663736 663736 0 0.0
RAM 105400 105400 0 0.0
lock-app qpg6105+debug FLASH 621572 621572 0 0.0
RAM 99860 99860 0 0.0
stm32 light STM32WB5MM-DK FLASH 484492 484492 0 0.0
RAM 144864 144864 0 0.0
telink bridge-app tlsr9258a FLASH 682594 682594 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623004 623004 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 764510 764510 0 0.0
RAM 50212 50212 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710424 710424 0 0.0
RAM 73496 73496 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627530 627530 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813458 813458 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4980 4980 0 0.0
FLASH 1731832 1731832 0 0.0
RAM 90724 90724 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 17965582 17965582 0 0.0
RAM 7838600 7838600 0 0.0
yunhanw-google
yunhanw-google commented on 2024-12-02
Conversation is marked as resolved
Show resolved
src/controller/java/src/chip/devicecontroller/DownloadLogCallback.java
1/*
2
 * Copyright (c) 2022 Project CHIP Authors
yunhanw-google118 days ago

copyright update

joonhaengHeo117 days ago

Modified. Thanks.

Conversation is marked as resolved
Show resolved
src/controller/java/BdxDiagnosticLogsReceiver.cpp
111void BdxDiagnosticLogsReceiver::OnTransferTimeout(chip::System::Layer * layer, void * context)
112{
113 ChipLogProgress(Controller, "OnTransferTimeout");
114
 auto * self = static_cast<BdxDiagnosticLogsReceiver *>(context);
yunhanw-google118 days ago

please check if this is nullptr, thanks

Conversation is marked as resolved
Show resolved
src/controller/java/BdxDiagnosticLogsReceiver.cpp
42
43CHIP_ERROR BdxDiagnosticLogsReceiver::OnTransferBegin(chip::bdx::BDXTransferProxy * transfer)
44{
45
 chip::CharSpan fileDesignator = transfer->GetFileDesignator();
yunhanw-google118 days ago

please check if transfer is nullptr or not, return the invalid argument if it is nullptr, thanks

joonhaengHeo117 days ago

Modified. Thanks.

yunhanw-google
yunhanw-google approved these changes on 2024-12-02
Conversation is marked as resolved
Show resolved
src/controller/java/AndroidLogDownloadFromNode.h
65 chip::JniGlobalReference mJavaCallback;
66 NodeId mRemoteNodeId;
67 app::Clusters::DiagnosticLogs::IntentEnum mIntent;
68
 uint16_t mTimeout;
yunhanw-google118 days ago

please pre-initialize these member variables, thanks

joonhaengHeo117 days ago

Modified. Thanks.

Conversation is marked as resolved
Show resolved
src/controller/java/AndroidLogDownloadFromNode.cpp
249{
250 VerifyOrReturn(mJavaCallback.HasValidObjectRef(), ChipLogError(Controller, "mJavaCallback is invalid"));
251
252
 JNIEnv * env = JniReferences::GetInstance().GetEnvForCurrentThread();
yunhanw-google118 days ago

please check if env is nullptr or not, thanks

joonhaengHeo117 days ago

Modified. Thanks.

yunhanw-google
yunhanw-google approved these changes on 2024-12-02
Conversation is marked as resolved
Show resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/bdx/DownloadLogCommand.kt
1/*
2
 * Copyright (c) 2023 Project CHIP Authors
yunhanw-google118 days ago

please update copy with 2024

joonhaengHeo117 days ago

Modified. Thanks.

Conversation is marked as resolved
Show resolved
examples/java-matter-controller/java/src/com/matter/controller/commands/bdx/DownloadLogCommand.kt
26import java.util.concurrent.atomic.AtomicInteger
27import java.util.concurrent.atomic.AtomicLong
28
29
class DownloadLogCommand(controller: ChipDeviceController, credsIssuer: CredentialsIssuer?) :
yunhanw-google118 days ago

could you add this DownloadLogCommand.kt test in
https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/java-tests.yaml#L239

joonhaengHeo117 days ago

Added. Thanks.

yunhanw-google yunhanw-google requested a review from bzbarsky-apple bzbarsky-apple 118 days ago
yunhanw-google
yunhanw-google commented on 2024-12-02
Conversation is marked as resolved
Show resolved
src/controller/java/src/chip/devicecontroller/ChipDeviceController.java
883883 deviceControllerPtr, devicePtr, duration, iteration, discriminator, setupPinCode, callback);
884884 }
885885
886
 public boolean downloadLogFromNode(
yunhanw-google118 days ago

could you add the doxygen for this public API? thanks

joonhaengHeo117 days ago

Added. Thanks.

joonhaengHeo joonhaengHeo force pushed from ae8a8241 to a5a28c1f 117 days ago
joonhaengHeo modify from comment
6bfcb10b
joonhaengHeo joonhaengHeo force pushed from a5a28c1f to 6bfcb10b 117 days ago
github-actions
github-actions117 days ago (edited 117 days ago)

PR #36591: Size comparison from a3a443a to 6bfcb10

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a3a443a 6bfcb10 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1352942 1352942 0 0.0
RAM 104104 104104 0 0.0
bl702 lighting-app bl702+eth FLASH 651536 651536 0 0.0
RAM 25345 25345 0 0.0
bl702+wifi FLASH 829120 829120 0 0.0
RAM 14085 14085 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057314 1057314 0 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 978688 978688 0 0.0
RAM 16572 16572 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839576 839576 0 0.0
RAM 123656 123656 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825116 825116 0 0.0
RAM 125536 125536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771864 771864 0 0.0
RAM 114004 114004 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756052 756052 0 0.0
RAM 114220 114220 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 630686 630686 0 0.0
RAM 205808 205808 0 0.0
lock CC3235SF_LAUNCHXL FLASH 669298 669298 0 0.0
RAM 205952 205952 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681249 681249 0 0.0
RAM 78716 78716 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701101 701101 0 0.0
RAM 81348 81348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701101 701101 0 0.0
RAM 81348 81348 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658037 658037 0 0.0
RAM 73784 73784 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 617809 617809 0 0.0
RAM 71692 71692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637437 637437 0 0.0
RAM 74244 74244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637437 637437 0 0.0
RAM 74244 74244 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637201 637201 0 0.0
RAM 74708 74708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656917 656917 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656917 656917 0 0.0
RAM 77260 77260 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613669 613669 0 0.0
RAM 68796 68796 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633521 633521 0 0.0
RAM 71436 71436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633521 633521 0 0.0
RAM 71436 71436 0 0.0
efr32 lock-app BRD4187C FLASH 932116 932116 0 0.0
RAM 160180 160180 0 0.0
BRD4338a FLASH 745920 745912 -8 -0.0
RAM 233312 233312 0 0.0
window-app BRD4187C FLASH 1024480 1024480 0 0.0
RAM 128284 128284 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95344 0 0.0
FLASH 1543258 1543258 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116296 116296 0 0.0
FLASH 1550002 1550002 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2713581 2713581 0 0.0
RAM 129768 129768 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6005600 6005600 0 0.0
RAM 523512 523512 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5343408 5343408 0 0.0
RAM 242568 242568 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4682894 4682894 0 0.0
RAM 218432 218432 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12845682 12845682 0 0.0
RAM 582314 582314 0 0.0
chip-tool-ipv6only arm64 unknown 21312 21312 0 0.0
FLASH 10979696 10979696 0 0.0
RAM 633232 633232 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11249747 11249747 0 0.0
RAM 582690 582690 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4507150 4507150 0 0.0
RAM 205504 205504 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5603797 5603797 0 0.0
RAM 472488 472488 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5619729 5619729 0 0.0
RAM 228760 228760 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4732248 4732248 0 0.0
RAM 204744 204744 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4358002 4358002 0 0.0
RAM 198416 198416 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4497042 4497042 0 0.0
RAM 203000 203000 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3028477 3028477 0 0.0
RAM 160456 160456 0 0.0
thermostat-no-ble arm64 unknown 9520 9520 0 0.0
FLASH 4102480 4102480 0 0.0
RAM 243040 243040 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5956293 5956293 0 0.0
RAM 596000 596000 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11052605 11052605 0 0.0
RAM 692120 692120 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917380 917380 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 889868 889868 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851548 851548 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 585264 585264 0 0.0
RAM 71072 71072 0 0.0
mcxw71+release FLASH 599800 599800 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 612204 612204 0 0.0
RAM 70464 70464 0 0.0
k32w1+release FLASH 686344 686344 0 0.0
RAM 48792 48792 0 0.0
lock mcxw71+release FLASH 762688 762688 0 0.0
RAM 70828 70828 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646068 1646068 0 0.0
RAM 212088 212088 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553836 1553836 0 0.0
RAM 208888 208888 0 0.0
light cy8ckit_062s2_43012 FLASH 1469108 1469108 0 0.0
RAM 200872 200872 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466836 1466836 0 0.0
RAM 225232 225232 0 0.0
qpg lighting-app qpg6105+debug FLASH 663736 663736 0 0.0
RAM 105400 105400 0 0.0
lock-app qpg6105+debug FLASH 621572 621572 0 0.0
RAM 99860 99860 0 0.0
stm32 light STM32WB5MM-DK FLASH 484492 484492 0 0.0
RAM 144864 144864 0 0.0
telink bridge-app tlsr9258a FLASH 682594 682594 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623004 623004 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 764510 764510 0 0.0
RAM 50212 50212 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710424 710424 0 0.0
RAM 73496 73496 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627530 627530 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813458 813458 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4980 4980 0 0.0
FLASH 1731836 1731836 0 0.0
RAM 90724 90724 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 1796559 1796559 0 0.0
RAM 7838600 7838600 0 0.0
joonhaengHeo Add javadoc, test cases
099a417a
github-actions github-actions added scripts
github-actions github-actions added github
github-actions github-actions added workflows
joonhaengHeo kotlin code style
0b7a8145
github-actions
github-actions117 days ago (edited 117 days ago)

PR #36591: Size comparison from a3a443a to 0b7a814

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a3a443a 0b7a814 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1352942 1352942 0 0.0
RAM 104104 104104 0 0.0
bl702 lighting-app bl702+eth FLASH 651536 651536 0 0.0
RAM 25345 25345 0 0.0
bl702+wifi FLASH 829120 829120 0 0.0
RAM 14085 14085 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057314 1057314 0 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 978688 978688 0 0.0
RAM 16572 16572 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839576 839576 0 0.0
RAM 123656 123656 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825116 825116 0 0.0
RAM 125536 125536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771864 771864 0 0.0
RAM 114004 114004 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756052 756052 0 0.0
RAM 114220 114220 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 630686 630686 0 0.0
RAM 205808 205808 0 0.0
lock CC3235SF_LAUNCHXL FLASH 669298 669298 0 0.0
RAM 205952 205952 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681249 681249 0 0.0
RAM 78716 78716 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701101 701101 0 0.0
RAM 81348 81348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701101 701101 0 0.0
RAM 81348 81348 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658037 658037 0 0.0
RAM 73784 73784 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 617809 617809 0 0.0
RAM 71692 71692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637437 637437 0 0.0
RAM 74244 74244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637437 637437 0 0.0
RAM 74244 74244 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637201 637201 0 0.0
RAM 74708 74708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656917 656917 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656917 656917 0 0.0
RAM 77260 77260 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613669 613669 0 0.0
RAM 68796 68796 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633521 633521 0 0.0
RAM 71436 71436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633521 633521 0 0.0
RAM 71436 71436 0 0.0
efr32 lock-app BRD4187C FLASH 932116 932116 0 0.0
RAM 160180 160180 0 0.0
BRD4338a FLASH 745920 745912 -8 -0.0
RAM 233312 233312 0 0.0
window-app BRD4187C FLASH 1024480 1024480 0 0.0
RAM 128284 128284 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95344 0 0.0
FLASH 1543258 1543258 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116296 116296 0 0.0
FLASH 1550002 1550002 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2713581 2713581 0 0.0
RAM 129768 129768 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6005600 6005600 0 0.0
RAM 523512 523512 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5343408 5343408 0 0.0
RAM 242568 242568 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4682894 4682894 0 0.0
RAM 218432 218432 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12845682 12845682 0 0.0
RAM 582314 582314 0 0.0
chip-tool-ipv6only arm64 unknown 21312 21312 0 0.0
FLASH 10979696 10979696 0 0.0
RAM 633232 633232 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11249747 11249747 0 0.0
RAM 582690 582690 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4507150 4507150 0 0.0
RAM 205504 205504 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5603797 5603797 0 0.0
RAM 472488 472488 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5619729 5619729 0 0.0
RAM 228760 228760 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4732248 4732248 0 0.0
RAM 204744 204744 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4358002 4358002 0 0.0
RAM 198416 198416 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4497042 4497042 0 0.0
RAM 203000 203000 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3028477 3028477 0 0.0
RAM 160456 160456 0 0.0
thermostat-no-ble arm64 unknown 9520 9520 0 0.0
FLASH 4102480 4102480 0 0.0
RAM 243040 243040 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5956293 5956293 0 0.0
RAM 596000 596000 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11052605 11052605 0 0.0
RAM 692120 692120 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917380 917380 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 889868 889868 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851548 851548 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 585264 585264 0 0.0
RAM 71072 71072 0 0.0
mcxw71+release FLASH 599800 599800 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 612204 612204 0 0.0
RAM 70464 70464 0 0.0
k32w1+release FLASH 686344 686344 0 0.0
RAM 48792 48792 0 0.0
lock mcxw71+release FLASH 762688 762688 0 0.0
RAM 70828 70828 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646068 1646068 0 0.0
RAM 212088 212088 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553836 1553836 0 0.0
RAM 208888 208888 0 0.0
light cy8ckit_062s2_43012 FLASH 1469108 1469108 0 0.0
RAM 200872 200872 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466836 1466836 0 0.0
RAM 225232 225232 0 0.0
qpg lighting-app qpg6105+debug FLASH 663736 663736 0 0.0
RAM 105400 105400 0 0.0
lock-app qpg6105+debug FLASH 621572 621572 0 0.0
RAM 99860 99860 0 0.0
stm32 light STM32WB5MM-DK FLASH 484492 484492 0 0.0
RAM 144864 144864 0 0.0
telink bridge-app tlsr9258a FLASH 682594 682594 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623004 623004 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 764510 764510 0 0.0
RAM 50212 50212 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710424 710424 0 0.0
RAM 73496 73496 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627530 627530 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813458 813458 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4980 4980 0 0.0
FLASH 1731836 1731836 0 0.0
RAM 90724 90724 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 1796559 1796559 0 0.0
RAM 7838600 7838600 0 0.0
yunhanw-google
yunhanw-google commented on 2024-12-03
Conversation is marked as resolved
Show resolved
src/controller/java/src/chip/devicecontroller/ChipDeviceController.java
893 * detailed in {@link DownloadLogCallback}.
894 */
895 public boolean downloadLogFromNode(
896
 long deviceId, DiagnosticLogType type, int timeout, DownloadLogCallback callback) {
yunhanw-google116 days ago

int ==> long for timeout

joonhaengHeo116 days ago

Fixed. Thanks.

yunhanw-google
yunhanw-google commented on 2024-12-03
Conversation is marked as resolved
Show resolved
src/controller/java/CHIPDeviceController-JNI.cpp
20602061}
20612062
2063JNI_METHOD(void, downloadLogFromNode)
2064
(JNIEnv * env, jobject self, jlong handle, jlong deviceId, jint typeEnum, jint timeout, jobject downloadLogCallback)
yunhanw-google116 days ago

jlong timeout

joonhaengHeo116 days ago

Fixed. Thanks.

yunhanw-google
yunhanw-google commented on 2024-12-03
Conversation is marked as resolved
Show resolved
src/controller/java/CHIPDeviceController-JNI.cpp
2065{
2066 chip::DeviceLayer::StackLock lock;
2067 CHIP_ERROR err = CHIP_NO_ERROR;
2068
 AndroidDeviceControllerWrapper * wrapper = AndroidDeviceControllerWrapper::FromJNIHandle(handle);
yunhanw-google116 days ago

check whether wrapper is nullptr or not

joonhaengHeo116 days ago

Fixed. Thanks.

joonhaengHeo Fix from comment
a0feff9a
joonhaengHeo Merge branch 'master' into implement_android_diag_log
be99a5fe
github-actions
github-actions116 days ago (edited 116 days ago)

PR #36591: Size comparison from e0fc29a to be99a5f

Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
platform target config section e0fc29a be99a5f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1352942 1352942 0 0.0
RAM 104104 104104 0 0.0
bl702 lighting-app bl702+eth FLASH 651536 651536 0 0.0
RAM 25345 25345 0 0.0
bl702+wifi FLASH 829120 829120 0 0.0
RAM 14085 14085 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057314 1057314 0 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 978688 978688 0 0.0
RAM 16572 16572 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839576 839576 0 0.0
RAM 123656 123656 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825116 825116 0 0.0
RAM 125536 125536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771864 771864 0 0.0
RAM 114004 114004 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756052 756052 0 0.0
RAM 114220 114220 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 630686 630686 0 0.0
RAM 205808 205808 0 0.0
lock CC3235SF_LAUNCHXL FLASH 669298 669298 0 0.0
RAM 205952 205952 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917380 917380 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 889868 889868 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851548 851548 0 0.0
RAM 142200 142200 0 0.0
qpg lighting-app qpg6105+debug FLASH 663736 663736 0 0.0
RAM 105400 105400 0 0.0
lock-app qpg6105+debug FLASH 621572 621572 0 0.0
RAM 99860 99860 0 0.0
stm32 light STM32WB5MM-DK FLASH 484492 484492 0 0.0
RAM 144864 144864 0 0.0
telink bridge-app tlsr9258a FLASH 682594 682594 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623004 623004 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 764510 764510 0 0.0
RAM 50212 50212 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710424 710424 0 0.0
RAM 73496 73496 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627530 627530 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813458 813458 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4980 4980 0 0.0
FLASH 1731836 1731836 0 0.0
RAM 90724 90724 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 1796559 1796559 0 0.0
RAM 7838600 7838600 0 0.0
joonhaengHeo Fix build error
9a010037
github-actions
github-actions116 days ago (edited 116 days ago)

PR #36591: Size comparison from e0fc29a to 9a01003

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e0fc29a 9a01003 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1352942 1352942 0 0.0
RAM 104104 104104 0 0.0
bl702 lighting-app bl702+eth FLASH 651536 651536 0 0.0
RAM 25345 25345 0 0.0
bl702+wifi FLASH 829120 829120 0 0.0
RAM 14085 14085 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057314 1057314 0 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 978688 978688 0 0.0
RAM 16572 16572 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839576 839576 0 0.0
RAM 123656 123656 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825116 825116 0 0.0
RAM 125536 125536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771864 771864 0 0.0
RAM 114004 114004 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756052 756052 0 0.0
RAM 114220 114220 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 630686 630686 0 0.0
RAM 205808 205808 0 0.0
lock CC3235SF_LAUNCHXL FLASH 669298 669298 0 0.0
RAM 205952 205952 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681249 681249 0 0.0
RAM 78716 78716 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701101 701101 0 0.0
RAM 81348 81348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701101 701101 0 0.0
RAM 81348 81348 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658037 658037 0 0.0
RAM 73784 73784 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 617809 617809 0 0.0
RAM 71692 71692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637437 637437 0 0.0
RAM 74244 74244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637437 637437 0 0.0
RAM 74244 74244 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637201 637201 0 0.0
RAM 74708 74708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656917 656917 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656917 656917 0 0.0
RAM 77260 77260 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613669 613669 0 0.0
RAM 68796 68796 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633521 633521 0 0.0
RAM 71436 71436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633521 633521 0 0.0
RAM 71436 71436 0 0.0
efr32 lock-app BRD4187C FLASH 932116 932116 0 0.0
RAM 160180 160180 0 0.0
BRD4338a FLASH 745920 745912 -8 -0.0
RAM 233312 233312 0 0.0
window-app BRD4187C FLASH 1024480 1024480 0 0.0
RAM 128284 128284 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95344 0 0.0
FLASH 1543262 1543262 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116296 116296 0 0.0
FLASH 1550006 1550006 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2713581 2713581 0 0.0
RAM 129768 129768 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6005600 6005600 0 0.0
RAM 523512 523512 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5343408 5343408 0 0.0
RAM 242568 242568 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4682894 4682894 0 0.0
RAM 218368 218368 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12845682 12845682 0 0.0
RAM 582314 582314 0 0.0
chip-tool-ipv6only arm64 unknown 21312 21312 0 0.0
FLASH 10979696 10979696 0 0.0
RAM 633232 633232 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11249747 11249747 0 0.0
RAM 582690 582690 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4508584 4508584 0 0.0
RAM 205536 205536 0 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5605301 5605301 0 0.0
RAM 472536 472536 0 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5619729 5619729 0 0.0
RAM 228760 228760 0 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4732248 4732248 0 0.0
RAM 204744 204744 0 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4358002 4358002 0 0.0
RAM 198416 198416 0 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4497042 4497042 0 0.0
RAM 203000 203000 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3028477 3028477 0 0.0
RAM 160456 160456 0 0.0
thermostat-no-ble arm64 unknown 9520 9520 0 0.0
FLASH 4102480 4102480 0 0.0
RAM 243040 243040 0 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5956293 5956293 0 0.0
RAM 596000 596000 0 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11052605 11052605 0 0.0
RAM 692120 692120 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917380 917380 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 889868 889868 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851548 851548 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 585264 585264 0 0.0
RAM 71072 71072 0 0.0
mcxw71+release FLASH 599800 599800 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 612204 612204 0 0.0
RAM 70464 70464 0 0.0
k32w1+release FLASH 686344 686344 0 0.0
RAM 48792 48792 0 0.0
lock mcxw71+release FLASH 762688 762688 0 0.0
RAM 70828 70828 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646068 1646068 0 0.0
RAM 212088 212088 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553836 1553836 0 0.0
RAM 208888 208888 0 0.0
light cy8ckit_062s2_43012 FLASH 1469108 1469108 0 0.0
RAM 200872 200872 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466836 1466836 0 0.0
RAM 225232 225232 0 0.0
qpg lighting-app qpg6105+debug FLASH 663736 663736 0 0.0
RAM 105400 105400 0 0.0
lock-app qpg6105+debug FLASH 621572 621572 0 0.0
RAM 99860 99860 0 0.0
stm32 light STM32WB5MM-DK FLASH 484492 484492 0 0.0
RAM 144864 144864 0 0.0
telink bridge-app tlsr9258a FLASH 682594 682594 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623004 623004 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 764510 764510 0 0.0
RAM 50212 50212 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710424 710424 0 0.0
RAM 73496 73496 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627530 627530 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813458 813458 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4980 4980 0 0.0
FLASH 1731836 1731836 0 0.0
RAM 90724 90724 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 1796559 1796559 0 0.0
RAM 7838600 7838600 0 0.0
yunhanw-google yunhanw-google enabled auto-merge (squash) 115 days ago
sharadb-amazon
sharadb-amazon approved these changes on 2024-12-04
pullapprove pullapprove removed review - pending
pullapprove pullapprove added review - approved
yunhanw-google yunhanw-google merged ca772d75 into master 115 days ago
pgregorr-amazon
pgregorr-amazon commented on 2024-12-05
Conversation is marked as resolved
Show resolved
src/controller/java/AndroidLogDownloadFromNode.cpp
79 delete logDownload;
80 logDownload = nullptr;
81 }
82
 // Else will clean up when the callback is called.
pgregorr-amazon114 days ago

Missing cleanup for logDownload? I don't see this cleaned up in the callbacks and theAndroidLogDownloadFromNode::FinishLogDownloadFromNode method.

joonhaengHeo114 days ago

I undestand. Thank you for your comment.

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
examples scripts controller github workflows review - approved protocols
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum