connectedhomeip
Move OnboardingCodesUtil out of app/server
#37401
Merged
Overview
Commits
5
Changes
View On GitHub

Move OnboardingCodesUtil out of app/server #37401

mergify merged 5 commits into project-chip:master from adigie:toup-build-opt
adigie
adigie55 days ago (edited 54 days ago)
  • Move OnboardingCodesUtils to separate target.
  • Remove shell dependency on server.
  • Fix dependencies in examples.

Testing

Tested using automated tests.

semanticdiff-com
semanticdiff-com55 days ago (edited 55 days ago)

Review changes with  SemanticDiff

github-actions github-actions added config
adigie adigie force pushed from a4df6533 to 445eb315 55 days ago
github-actions
github-actions55 days ago (edited 55 days ago)

PR #37401: Size comparison from 577b3f2 to 445eb31

Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
platform target config section 577b3f2 445eb31 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093988 1093988 0 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650600 650600 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828508 828508 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057068 1057068 0 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888502 888502 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971488 971488 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838160 838160 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823564 823564 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770836 770836 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755088 755088 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538637 538637 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572493 572493 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679601 679601 0 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699445 699445 0 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699445 699445 0 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656389 656389 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615977 615977 0 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635613 635613 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635613 635613 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635457 635457 0 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655165 655165 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655165 655165 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611893 611893 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631753 631753 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631753 631753 0 0.0
RAM 71252 71252 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646844 1646844 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553612 1553612 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1469292 1469292 0 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467340 1467340 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 662232 662232 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 620004 620004 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482824 482824 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tl7218x FLASH 665242 665242 0 0.0
RAM 90812 90812 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622000 622000 0 0.0
RAM 31484 31484 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770754 770754 0 0.0
RAM 43552 43552 0 0.0
tl7218x FLASH 779284 779284 0 0.0
RAM 98688 98688 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680618 680618 0 0.0
RAM 52176 52176 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709172 709172 0 0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626086 626086 0 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813468 813468 0 0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1752956 1752956 0 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11408 11408 0 0.0
FLASH 18699718 18699718 0 0.0
RAM 8184616 8184616 0 0.0
adigie adigie force pushed from 445eb315 to e9170fbe 55 days ago
github-actions github-actions added lib
github-actions github-actions added app
github-actions github-actions added shell
adigie adigie force pushed from e9170fbe to 6b1eb44d 55 days ago
adigie adigie force pushed from 6b1eb44d to 4dd600bb 55 days ago
adigie adigie force pushed from 4dd600bb to 0101630b 55 days ago
adigie adigie force pushed from 0101630b to 66fc382e 55 days ago
github-actions github-actions added examples
github-actions github-actions added platform
github-actions github-actions added linux
github-actions github-actions added controller
github-actions github-actions added telink
github-actions github-actions added silabs
github-actions github-actions added nxp
adigie adigie force pushed from 66fc382e to d5184dfb 55 days ago
mergify mergify added conflict
andy31415
andy31415 commented on 2025-02-05
Conversation is marked as resolved
Show resolved
src/app/onboarding-codes-utils/BUILD.gn
15import("//build_overrides/chip.gni")
16import("${chip_root}/src/app/common_flags.gni")
17
18
source_set("onboarding-codes-utils") {
andy3141555 days ago

you could make a sourceset without a separate folder too (less changes in include paths, so smaller delta).

Not strongly opposed either way. Somewhat concerned of a new folder with utils in the name since those tend to start accepting anything inside. Maybe just onboarding-codes would be sufficient (and we could rename the Util in the h/cpp as well, but that results in a larger delta.

adigie54 days ago

As @bzbarsky-apple suggested, I moved these files to src/setup_payload. Seems like better place for them.

andy31415
andy31415 commented on 2025-02-05
Conversation is marked as resolved
Show resolved
src/credentials/BUILD.gn
108108 # is changed to generate it's own credentials instead of using Test credentials.
109109 # For some platforms test builds, which are bilding monolithic test library these files are not needed.
110110 import("${chip_root}/build/chip/tests.gni")
111 if (!(chip_build_tests && (chip_device_platform == "mbed" ||
112 chip_device_platform == "openiotsdk" ||
113 chip_device_platform == "nrfconnect" ||
114 chip_device_platform == "esp32"))) {
111
 if (chip_build_tests && !(chip_device_platform == "mbed" ||
andy3141555 days ago

This change should probably be independent.

it does look more correct (i.e. test bits should depend on tests), however it also looks reasonably stand alone.

adigie54 days ago

Opened a separate PR for this one: #37423

bzbarsky-apple
bzbarsky-apple commented on 2025-02-06
Conversation is marked as resolved
Show resolved
src/app/onboarding-codes-utils/BUILD.gn
bzbarsky-apple54 days ago👍 1

Should this really be under src/app? Why is this not under src/setup_payload or so?

adigie adigie force pushed from d5184dfb to d52286c1 54 days ago
mergify mergify removed conflict
adigie adigie force pushed from d52286c1 to 1bd0296e 54 days ago
github-actions github-actions added setup payload
github-actions
github-actions54 days ago (edited 54 days ago)

PR #37401: Size comparison from a998bf6 to 3d4746e

Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, qpg, stm32, telink, tizen)
platform target config section a998bf6 3d4746e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094024 1094028 4 0.0
RAM 103314 103322 8 0.0
bl702 lighting-app bl702+eth FLASH 650542 650546 4 0.0
RAM 25265 25273 8 0.0
bl702+wifi FLASH 828506 828510 4 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057066 1057070 4 0.0
RAM 23861 23853 -8 -0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888444 888448 4 0.0
RAM 18504 18496 -8 -0.0
lighting-app bl702l+mfd+littlefs FLASH 971486 971490 4 0.0
RAM 16368 16360 -8 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838240 838228 -12 -0.0
RAM 123480 123480 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823644 823640 -4 -0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770820 770816 -4 -0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755088 755084 -4 -0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538621 538622 1 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572493 572494 1 0.0
RAM 205360 205360 0 0.0
efr32 lock-app BRD4187C FLASH 936408 936408 0 0.0
RAM 159872 159872 0 0.0
BRD4338a FLASH 730348 730348 0 0.0
RAM 234716 234716 0 0.0
window-app BRD4187C FLASH 1029656 1029656 0 0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1577420 1577418 -2 -0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1545326 1545270 -56 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2709171 2709169 -2 -0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5975584 5975776 192 0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5323948 5324140 192 0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4682560 4682526 -34 -0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099268 13099268 0 0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11162800 11162800 0 0.0
RAM 648256 648256 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11388297 11388297 0 0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4507818 4507850 32 0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5614085 5614085 0 0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5625217 5625249 32 0.0
RAM 231728 231728 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4731186 4731152 -34 -0.0
RAM 207696 207696 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360136 4360296 160 0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4497640 4497800 160 0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3005709 3005852 143 0.0
RAM 160472 160552 80 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097192 4097192 0 0.0
RAM 246024 246024 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5952965 5952997 32 0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11272797 11272797 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907288 907288 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901980 901932 -48 -0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845896 845896 0 0.0
RAM 141339 141339 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 787652 787652 0 0.0
RAM 131402 131402 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953388 953388 0 0.0
RAM 114116 114116 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 867524 867524 0 0.0
RAM 145784 145784 0 0.0
nrf52840dongle_nrf52840 FLASH 807672 807672 0 0.0
RAM 153631 153631 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 766272 766272 0 0.0
RAM 145107 145107 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953388 953388 0 0.0
RAM 114116 114116 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 776012 776012 0 0.0
RAM 131955 131955 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 703592 703592 0 0.0
RAM 132398 132398 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 942728 942728 0 0.0
RAM 114669 114669 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 755928 755928 0 0.0
RAM 130732 130732 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 741564 741564 0 0.0
RAM 130491 130491 0 0.0
qpg lighting-app qpg6105+debug FLASH 662216 662212 -4 -0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 619996 620000 4 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 482872 482880 8 0.0
RAM 144688 144688 0 0.0
telink bridge-app tl7218x FLASH 665258 665256 -2 -0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622020 622016 -4 -0.0
RAM 31500 31500 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770804 770802 -2 -0.0
RAM 43568 43568 0 0.0
tl7218x FLASH 779306 779304 -2 -0.0
RAM 98704 98704 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680618 680618 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709172 709170 -2 -0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626108 626112 4 0.0
RAM 142032 142032 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813492 813490 -2 -0.0
RAM 99576 99576 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752232 1752232 0 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18696694 18696694 0 0.0
RAM 8182536 8182536 0 0.0
adigie adigie force pushed from 3d4746e3 to 8c502922 54 days ago
adigie adigie force pushed from 8c502922 to da2977aa 54 days ago
adigie adigie force pushed from da2977aa to 09b20d3d 54 days ago
adigie adigie force pushed from 09b20d3d to 962ad8f6 54 days ago
adigie adigie changed the title WIP: Build optimizations Move OnboardingCodesUtil out of app/server 54 days ago
adigie adigie force pushed from e53d0234 to 426db4cf 54 days ago
adigie adigie marked this pull request as ready for review 54 days ago
adigie adigie requested a review 54 days ago
adigie adigie requested a review 54 days ago
adigie adigie requested a review 54 days ago
adigie adigie requested a review 54 days ago
pullapprove pullapprove added review - pending
github-actions
github-actions54 days ago (edited 54 days ago)

PR #37401: Size comparison from 7adac6e to 426db4c

Full report (17 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, tizen)
platform target config section 7adac6e 426db4c change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094024 1094028 4 0.0
RAM 103314 103322 8 0.0
bl702 lighting-app bl702+eth FLASH 650542 650546 4 0.0
RAM 25265 25273 8 0.0
bl702+wifi FLASH 828506 828510 4 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057066 1057070 4 0.0
RAM 23861 23853 -8 -0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888444 888448 4 0.0
RAM 18504 18496 -8 -0.0
lighting-app bl702l+mfd+littlefs FLASH 971486 971490 4 0.0
RAM 16368 16360 -8 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838240 838228 -12 -0.0
RAM 123480 123480 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823644 823640 -4 -0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770820 770816 -4 -0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755088 755084 -4 -0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538621 538622 1 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572493 572494 1 0.0
RAM 205360 205360 0 0.0
qpg lighting-app qpg6105+debug FLASH 662216 662212 -4 -0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 619996 620000 4 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 482872 482880 8 0.0
RAM 144688 144688 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752232 1752244 12 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18696694 18696694 0 0.0
RAM 8182536 8182536 0 0.0
shubhamdp
shubhamdp approved these changes on 2025-02-06
shubhamdp54 days ago👍 1

Please remove the multiple includes

Conversation is marked as resolved
Show resolved
examples/contact-sensor-app/nxp/k32w0/main/AppTask.cpp
3029#include <inet/EndPointStateOpenThread.h>
3130#include <lib/support/ThreadOperationalDataset.h>
3231#include <platform/CHIPDeviceLayer.h>
3332
#include <platform/internal/DeviceNetworkInfo.h>
shubhamdp54 days ago
Suggested change
#include <setup_payload/OnboardingCodesUtil.h>
Conversation is marked as resolved
Show resolved
examples/lighting-app/nxp/k32w0/main/AppTask.cpp
2928#include <inet/EndPointStateOpenThread.h>
3029#include <lib/support/ThreadOperationalDataset.h>
3130#include <platform/CHIPDeviceLayer.h>
3231
#include <platform/internal/DeviceNetworkInfo.h>
shubhamdp54 days ago
Suggested change
#include <setup_payload/OnboardingCodesUtil.h>
Conversation is marked as resolved
Show resolved
examples/lock-app/nxp/k32w/k32w0/main/AppTask.cpp
3029#include <inet/EndPointStateOpenThread.h>
3130#include <lib/support/ThreadOperationalDataset.h>
3231#include <platform/CHIPDeviceLayer.h>
3332
#include <platform/internal/DeviceNetworkInfo.h>
shubhamdp54 days ago
Suggested change
#include <setup_payload/OnboardingCodesUtil.h>
Conversation is marked as resolved
Show resolved
examples/shell/cc13x4_26x4/main/AppTask.cpp
4242#include <lib/support/CHIPPlatformMemory.h>
4343
44#include <app/server/OnboardingCodesUtil.h>
44
#include <setup_payload/OnboardingCodesUtil.h>
shubhamdp54 days ago
Suggested change
#include <setup_payload/OnboardingCodesUtil.h>
adigie adigie force pushed from 426db4cf to ff36e431 54 days ago
github-actions
github-actions54 days ago (edited 54 days ago)

PR #37401: Size comparison from 7adac6e to ff36e43

Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 7adac6e ff36e431 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094024 1094028 4 0.0
RAM 103314 103322 8 0.0
bl702 lighting-app bl702+eth FLASH 650542 650546 4 0.0
RAM 25265 25273 8 0.0
bl702+wifi FLASH 828506 828510 4 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057066 1057070 4 0.0
RAM 23861 23853 -8 -0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888444 888448 4 0.0
RAM 18504 18496 -8 -0.0
lighting-app bl702l+mfd+littlefs FLASH 971486 971490 4 0.0
RAM 16368 16360 -8 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838240 838228 -12 -0.0
RAM 123480 123480 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823644 823640 -4 -0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770820 770816 -4 -0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755088 755084 -4 -0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538621 538622 1 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572493 572494 1 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679585 679585 0 0.0
RAM 78548 78548 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699429 699437 8 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699429 699437 8 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656365 656369 4 0.0
RAM 73616 73616 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615945 615929 -16 -0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635573 635573 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635573 635573 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635449 635433 -16 -0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655157 655149 -8 -0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655157 655149 -8 -0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611861 611865 4 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631721 631725 4 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631721 631725 4 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 936408 936408 0 0.0
RAM 159872 159872 0 0.0
BRD4338a FLASH 730348 730348 0 0.0
RAM 234716 234716 0 0.0
window-app BRD4187C FLASH 1029656 1029656 0 0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1577420 1577418 -2 -0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1545326 1545270 -56 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2709171 2709169 -2 -0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5975584 5975678 94 0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5323948 5324042 94 0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4682560 4682526 -34 -0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099268 13099268 0 0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11162800 11162800 0 0.0
RAM 648256 648256 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11388297 11388297 0 0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4507818 4507848 30 0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5614085 5614085 0 0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5625217 5625249 32 0.0
RAM 231728 231728 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4731186 4731186 0 0.0
RAM 207696 207696 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360136 4360168 32 0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4497640 4497672 32 0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3005709 3005852 143 0.0
RAM 160472 160552 80 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097192 4097192 0 0.0
RAM 246024 246024 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5952965 5953029 64 0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11272797 11272877 80 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907288 907288 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901980 901932 -48 -0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845896 845896 0 0.0
RAM 141339 141339 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 787652 787652 0 0.0
RAM 131402 131402 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953388 953388 0 0.0
RAM 114116 114116 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 867524 867524 0 0.0
RAM 145784 145784 0 0.0
nrf52840dongle_nrf52840 FLASH 807672 807672 0 0.0
RAM 153631 153631 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 766272 766272 0 0.0
RAM 145107 145107 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953388 953388 0 0.0
RAM 114116 114116 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 776012 776012 0 0.0
RAM 131955 131955 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 703592 703592 0 0.0
RAM 132398 132398 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 942728 942728 0 0.0
RAM 114669 114669 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 755928 755928 0 0.0
RAM 130732 130732 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 741564 741564 0 0.0
RAM 130491 130491 0 0.0
nxp contact k32w0+release FLASH 584624 584632 8 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 599936 599928 -8 -0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 610932 610940 8 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685336 685328 -8 -0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 748832 748856 24 0.0
RAM 67492 67500 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646740 1646748 8 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553628 1553620 -8 -0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1469356 1469356 0 0.0
RAM 200368 200368 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467308 1467308 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662216 662212 -4 -0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 619996 620000 4 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 482872 482880 8 0.0
RAM 144688 144688 0 0.0
telink bridge-app tl7218x FLASH 665258 665256 -2 -0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622020 622016 -4 -0.0
RAM 31500 31500 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770804 770802 -2 -0.0
RAM 43568 43568 0 0.0
tl7218x FLASH 779306 779304 -2 -0.0
RAM 98704 98704 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680618 680618 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709172 709170 -2 -0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626108 626112 4 0.0
RAM 142032 142032 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813492 813490 -2 -0.0
RAM 99576 99576 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752232 1752244 12 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18696694 18696694 0 0.0
RAM 8182536 8182536 0 0.0
bzbarsky-apple
bzbarsky-apple approved these changes on 2025-02-06
bzbarsky-apple54 days ago

Seems fine, but we should really think about the naming here... Maybe we should have separate headers for the "get a thing" methods and the "print a thing" methods....

pullapprove pullapprove removed review - pending
pullapprove pullapprove added review - approved
adigie Move OnboardingCodesUtil out of server
eb464f0d
adigie [mw320] Remove shell dependency on app/server
4d33cc31
adigie [NXP][examples] Add missing dependency
afbd36e7
adigie [linux][examples] Add missing dependency
90ab5821
adigie [Infineon][examples] Add missing dependency
4d93f880
adigie adigie force pushed from ff36e431 to 4d93f880 54 days ago
Damian-Nordic
Damian-Nordic approved these changes on 2025-02-07
mergify mergify merged b9593646 into master 53 days ago
adigie adigie deleted the toup-build-opt branch 50 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
examples setup payload platform linux lib controller app config review - approved telink shell silabs nxp
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum