connectedhomeip
[bouffalo lab] fix wifi scan issues and update some platform changes
#37455
Merged
Overview
Commits
11
Changes
View On GitHub

[bouffalo lab] fix wifi scan issues and update some platform changes #37455

mergify merged 11 commits into project-chip:master from wy-hh:cert-fix
wy-hh
wy-hh69 days ago (edited 65 days ago)
  • fix wifi scan issue on BL602 and BL706 + BL602 platforms
  • update some platform code change, such as memory layout, app task stack and bouffalo lab SDK gni script

Testing

  • wifi scan issue:
    • targets
      • bouffalolab-bl602dk-light-wifi-littlefs
      • bouffalolab-bl706dk-light-wifi-littlefs
    • tested with chip-tool on wifi scan command
      After target commisioned, try the commands as below 
      ./out/linux-x64-chip-tool/chip-tool networkcommissioning scan-networks 1 0
./out/linux-x64-chip-tool/chip-tool networkcommissioning scan-networks 1 0 --Ssid <wifi ssid>
  • other platform changes
    • targets
      • bouffalolab-bl602dk-light-wifi-littlefs
      • bouffalolab-bl704ldk-light-thread-littlefs
      • bouffalolab-bl706dk-light-wifi-littlefs
      • bouffalolab-bl616dk-light-wifi-littlefs
    • test with chip-tool & alexa-app on commission & control
wy-hh [bouffalo lab] fix wifi scan issues and update some platform changes
818183cf
semanticdiff-com
semanticdiff-com69 days ago (edited 65 days ago)

Review changes with  SemanticDiff

Changed Files
File Status
  scripts/build/builders/bouffalolab.py  52% smaller
  examples/contact-sensor-app/bouffalolab/bl702l/app_pds.cpp Unsupported file format
  examples/lighting-app/bouffalolab/bl602/BUILD.gn Unsupported file format
  examples/lighting-app/bouffalolab/bl616/BUILD.gn Unsupported file format
  examples/lighting-app/bouffalolab/bl616/args.gni Unsupported file format
  examples/lighting-app/bouffalolab/bl702/BUILD.gn Unsupported file format
  examples/lighting-app/bouffalolab/bl702l/BUILD.gn Unsupported file format
  examples/platform/bouffalolab/bl602/ldscripts/flash_rom.ld Unsupported file format
  examples/platform/bouffalolab/bl602/lwipopts/lwipopts.h Unsupported file format
  examples/platform/bouffalolab/bl616/lwipopts.h Unsupported file format
  examples/platform/bouffalolab/bl702/ldscripts/psram_flash.ld Unsupported file format
  examples/platform/bouffalolab/bl702l/ldscripts/psram_flash.ld Unsupported file format
  examples/platform/bouffalolab/common/bouffalo_sdk/platform_port.cpp Unsupported file format
  examples/platform/bouffalolab/common/plat/platform.cpp Unsupported file format
  src/platform/bouffalolab/BL602/NetworkCommissioningDriver.cpp Unsupported file format
  src/platform/bouffalolab/BL702/ConnectivityManagerImpl.cpp Unsupported file format
  src/platform/bouffalolab/BL702/NetworkCommissioningDriver.cpp Unsupported file format
  src/platform/bouffalolab/BL702/NetworkCommissioningDriver.h Unsupported file format
  src/platform/bouffalolab/common/CHIPDevicePlatformConfig.h Unsupported file format
  src/platform/bouffalolab/common/DiagnosticDataProviderImpl.cpp Unsupported file format
  src/platform/bouffalolab/common/DiagnosticDataProviderImpl.h Unsupported file format
  third_party/bouffalolab/bl602/bl_iot_sdk.gni Unsupported file format
  third_party/bouffalolab/bl616/bouffalo_sdk.gni Unsupported file format
  third_party/bouffalolab/bl702/bl_iot_sdk.gni Unsupported file format
  third_party/bouffalolab/bl702l/bl_iot_sdk.gni Unsupported file format
  third_party/bouffalolab/repo  0% smaller
pullapprove pullapprove added review - pending
github-actions github-actions added examples
github-actions github-actions added scripts
github-actions github-actions added platform
restyled-commits Restyled by clang-format
a531c2ab
github-actions
github-actions69 days ago (edited 69 days ago)

PR #37455: Size comparison from 8deebeb to 06da47c

Increases above 0.2%:

platform target config section 8deebeb 06da47c change % change
bl702 lighting-app bl702+eth RAM 25265 33609 8344 33.0
bl702+wifi RAM 13981 22325 8344 59.7
bl706+mfd+rpc+littlefs FLASH 1057816 1061276 3460 0.3
RAM 23893 32277 8384 35.1
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888502 892380 3878 0.4
RAM 18504 26904 8400 45.4
lighting-app bl702l+mfd+littlefs FLASH 971544 975358 3814 0.4
RAM 16368 24744 8376 51.2
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8deebeb 06da47c change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094778 1095790 1012 0.1
RAM 103346 94882 -8464 -8.2
bl702 lighting-app bl702+eth FLASH 650600 651624 1024 0.2
RAM 25265 33609 8344 33.0
bl702+wifi FLASH 828564 829616 1052 0.1
RAM 13981 22325 8344 59.7
bl706+mfd+rpc+littlefs FLASH 1057816 1061276 3460 0.3
RAM 23893 32277 8384 35.1
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888502 892380 3878 0.4
RAM 18504 26904 8400 45.4
lighting-app bl702l+mfd+littlefs FLASH 971544 975358 3814 0.4
RAM 16368 24744 8376 51.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838456 838456 0 0.0
RAM 123480 123480 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823860 823860 0 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771036 771036 0 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755304 755304 0 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538925 538925 0 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572805 572805 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679809 679809 0 0.0
RAM 78548 78548 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699653 699653 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699653 699653 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656589 656589 0 0.0
RAM 73616 73616 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616153 616153 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635781 635781 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635781 635781 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635657 635657 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655365 655365 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655365 655365 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612077 612077 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631937 631937 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631937 631937 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937120 937120 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 730516 730516 0 0.0
RAM 234716 234716 0 0.0
window-app BRD4187C FLASH 1029808 1029808 0 0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1577574 1577574 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1545434 1545434 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2709805 2709805 0 0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5976268 5976268 0 0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5324612 5324612 0 0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4683224 4683224 0 0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099952 13099952 0 0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11163376 11163376 0 0.0
RAM 648256 648256 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11388981 11388981 0 0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4508482 4508482 0 0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5614773 5614773 0 0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5630465 5630465 0 0.0
RAM 231792 231792 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4731818 4731818 0 0.0
RAM 207696 207696 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360788 4360788 0 0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4498196 4498196 0 0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3006445 3006445 0 0.0
RAM 160472 160472 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097736 4097736 0 0.0
RAM 246024 246024 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5953653 5953653 0 0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11273469 11273469 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907584 907584 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 902100 902100 0 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846188 846188 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584768 584768 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600232 600232 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611076 611076 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685552 685552 0 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749040 749040 0 0.0
RAM 67492 67492 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646972 1646972 0 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553876 1553876 0 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1469604 1469604 0 0.0
RAM 200368 200368 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467540 1467540 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662360 662360 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620148 620148 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 483016 483016 0 0.0
RAM 144688 144688 0 0.0
telink bridge-app tl7218x FLASH 665410 665410 0 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622172 622172 0 0.0
RAM 31500 31500 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770956 770956 0 0.0
RAM 43568 43568 0 0.0
tl7218x FLASH 779458 779458 0 0.0
RAM 98704 98704 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680770 680770 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709324 709324 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626260 626260 0 0.0
RAM 142032 142032 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814104 814104 0 0.0
RAM 99608 99608 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752596 1752596 0 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18698526 18698526 0 0.0
RAM 8183320 8183320 0 0.0
restyled-commits Restyled by gn
c49a75ed
wy-hh wy-hh force pushed from 06da47c2 to c49a75ed 66 days ago
restyled-commits Restyled by clang-format
28781cc9
github-actions
github-actions66 days ago (edited 66 days ago)

PR #37455: Size comparison from e86768b to 28781cc

Increases above 0.2%:

platform target config section e86768b 28781cc change % change
bl702 lighting-app bl702+eth RAM 25273 33617 8344 33.0
bl702+wifi RAM 13981 22325 8344 59.7
bl706+mfd+rpc+littlefs FLASH 1057820 1061280 3460 0.3
RAM 23885 32269 8384 35.1
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888506 892248 3742 0.4
RAM 18496 26896 8400 45.4
lighting-app bl702l+mfd+littlefs FLASH 971548 975362 3814 0.4
RAM 16360 24736 8376 51.2
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e86768b 28781cc change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094776 1095788 1012 0.1
RAM 103354 94890 -8464 -8.2
bl702 lighting-app bl702+eth FLASH 650604 651628 1024 0.2
RAM 25273 33617 8344 33.0
bl702+wifi FLASH 828306 829614 1308 0.2
RAM 13981 22325 8344 59.7
bl706+mfd+rpc+littlefs FLASH 1057820 1061280 3460 0.3
RAM 23885 32269 8384 35.1
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888506 892248 3742 0.4
RAM 18496 26896 8400 45.4
lighting-app bl702l+mfd+littlefs FLASH 971548 975362 3814 0.4
RAM 16360 24736 8376 51.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838452 838452 0 0.0
RAM 123480 123480 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823864 823864 0 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771024 771024 0 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755292 755292 0 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538926 538926 0 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572806 572806 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679801 679801 0 0.0
RAM 78548 78548 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699653 699653 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699653 699653 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656593 656593 0 0.0
RAM 73616 73616 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616153 616153 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635789 635789 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635789 635789 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635649 635649 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655365 655365 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655365 655365 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612073 612073 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631933 631933 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631933 631933 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937120 937120 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 730516 730516 0 0.0
RAM 234716 234716 0 0.0
window-app BRD4187C FLASH 1029808 1029808 0 0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1577572 1577572 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1545374 1545374 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2709835 2709835 0 0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5976330 5976330 0 0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5323874 5323874 0 0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4682390 4682390 0 0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13099986 13099986 0 0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11163392 11163392 0 0.0
RAM 648256 648256 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11389003 11389003 0 0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4507712 4507712 0 0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5613989 5613989 0 0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5630465 5630465 0 0.0
RAM 231792 231792 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4731818 4731818 0 0.0
RAM 207696 207696 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4360820 4360820 0 0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4498228 4498228 0 0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3006572 3006572 0 0.0
RAM 160552 160552 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4097752 4097752 0 0.0
RAM 246024 246024 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5952901 5952901 0 0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11272749 11272749 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907584 907584 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 902052 902052 0 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846108 846108 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584792 584792 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600232 600232 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611084 611084 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685544 685544 0 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749056 749056 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646980 1646980 0 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553660 1553660 0 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1469604 1469604 0 0.0
RAM 200368 200368 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467540 1467540 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662356 662356 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620152 620152 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 483024 483024 0 0.0
RAM 144688 144688 0 0.0
telink bridge-app tl7218x FLASH 665308 665308 0 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622168 622168 0 0.0
RAM 31500 31500 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770954 770954 0 0.0
RAM 43568 43568 0 0.0
tl7218x FLASH 779456 779456 0 0.0
RAM 98704 98704 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680770 680770 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709322 709322 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626264 626264 0 0.0
RAM 142032 142032 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814102 814102 0 0.0
RAM 99608 99608 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752600 1752600 0 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18686646 18686646 0 0.0
RAM 8183340 8183340 0 0.0
wy-hh fix wifi scan on bl706 + bl602 platform
3da3746e
restyled-commits Restyled by whitespace
6253f1cd
restyled-commits Restyled by clang-format
31405bca
github-actions
github-actions65 days ago (edited 65 days ago)

PR #37455: Size comparison from e86768b to 31405bc

Full report (8 builds for cc32xx, nrfconnect, stm32, tizen)
platform target config section e86768b 31405bc change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538926 538894 -32 -0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572806 572758 -48 -0.0
RAM 205360 205360 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907584 907544 -40 -0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 902052 901932 -120 -0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846108 846072 -36 -0.0
RAM 141339 141339 0 0.0
stm32 light STM32WB5MM-DK FLASH 483024 482992 -32 -0.0
RAM 144688 144688 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1752600 1751732 -868 -0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18686646 18683046 -3600 -0.0
RAM 8183340 8181084 -2256 -0.0
jmartinez-silabs
jmartinez-silabs approved these changes on 2025-02-11
Conversation is marked as resolved
Show resolved
src/platform/bouffalolab/BL702/NetworkCommissioningDriver.cpp
296266 }
297 else
267
268 p->security.SetRaw(pmsg->records[i].auth_mode);
269
 p->ssidLen = strlen((char *) pmsg->records[i].ssid) < chip::DeviceLayer::Internal::kMaxWiFiSSIDLength
270
 ? strlen((char *) pmsg->records[i].ssid)
271
 : chip::DeviceLayer::Internal::kMaxWiFiSSIDLength;
jmartinez-silabs65 days ago

consider using bytespan or chip's CopyString

You can avoid calling strlen((char *) pmsg->records[i].ssid) twice with a local variable

wy-hh65 days ago

copy dest ssid is 32 byte length without null terminator. use strncpy to copy ssid to avoid calling strlen twice

Conversation is marked as resolved
Show resolved
examples/contact-sensor-app/bouffalolab/bl702l/app_pds.cpp
6161 {
6262 extern void * pxCurrentTCB;
6363
64 ChipLogProgress(NotSpecified, "wakeup source: rtc. %lu vs %lu ms @ %lu\r\n", xExpectedIdleTime,
65 (uint32_t) (bl_rtc_get_timestamp_ms() - sleep_before), (uint32_t) bl_rtc_get_timestamp_ms());
64
 // ChipLogProgress(NotSpecified, "wakeup source: rtc. %lu vs %lu ms @ %lu\r\n", xExpectedIdleTime,
jmartinez-silabs65 days ago

I'd suggest cleaning out the commented log code here.

wy-hh65 days ago

Done

andy31415
andy31415 approved these changes on 2025-02-11
pullapprove pullapprove removed review - pending
pullapprove pullapprove added review - approved
andy31415 andy31415 added changing-submodules-on-purpose
wy-hh use strncpy to copy ssid
d8c085db
restyled-commits Restyled by whitespace
103327ab
restyled-commits Restyled by clang-format
6b2511e1
wy-hh Merge branch 'master' into cert-fix
adcfbddd
github-actions
github-actions64 days ago (edited 64 days ago)

PR #37455: Size comparison from e5a49c8 to adcfbdd

Increases above 0.2%:

platform target config section e5a49c8 adcfbdd change % change
bl702 lighting-app bl702+eth RAM 25289 33633 8344 33.0
bl702+wifi RAM 13997 22341 8344 59.6
bl706+mfd+rpc+littlefs FLASH 1058036 1061752 3716 0.4
RAM 23901 32285 8384 35.1
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888884 892626 3742 0.4
RAM 18512 26912 8400 45.4
lighting-app bl702l+mfd+littlefs FLASH 971926 975740 3814 0.4
RAM 16376 24752 8376 51.1
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e5a49c8 adcfbdd change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094978 1095998 1020 0.1
RAM 103370 94906 -8464 -8.2
bl702 lighting-app bl702+eth FLASH 650834 651858 1024 0.2
RAM 25289 33633 8344 33.0
bl702+wifi FLASH 828766 828350 -416 -0.1
RAM 13997 22341 8344 59.6
bl706+mfd+rpc+littlefs FLASH 1058036 1061752 3716 0.4
RAM 23901 32285 8384 35.1
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888884 892626 3742 0.4
RAM 18512 26912 8400 45.4
lighting-app bl702l+mfd+littlefs FLASH 971926 975740 3814 0.4
RAM 16376 24752 8376 51.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838396 838396 0 0.0
RAM 123480 123480 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823816 823816 0 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770984 770984 0 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755244 755244 0 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538894 538894 0 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572758 572758 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679765 679765 0 0.0
RAM 78548 78548 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699625 699625 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699625 699625 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656549 656549 0 0.0
RAM 73616 73616 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616101 616101 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635745 635745 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635745 635745 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635613 635613 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655329 655329 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655329 655329 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611953 611953 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631813 631813 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631813 631813 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937088 937088 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 730340 730340 0 0.0
RAM 234716 234716 0 0.0
window-app BRD4187C FLASH 1029648 1029648 0 0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1577408 1577408 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1545102 1545102 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2708611 2708611 0 0.0
RAM 132784 132784 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5975074 5975074 0 0.0
RAM 531600 531600 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5322586 5322586 0 0.0
RAM 242712 242712 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4681230 4681230 0 0.0
RAM 221448 221448 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13098792 13098792 0 0.0
RAM 596578 596578 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11162160 11162160 0 0.0
RAM 648256 648256 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11387841 11387841 0 0.0
RAM 596362 596362 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4506552 4506552 0 0.0
RAM 208632 208632 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5612805 5612805 0 0.0
RAM 483504 483504 0 0.0
lighting-app debug+rpc+ui unknown 6152 6152 0 0.0
FLASH 5645489 5645489 0 0.0
RAM 231792 231792 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4730626 4730626 0 0.0
RAM 207696 207696 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4359692 4359692 0 0.0
RAM 201336 201336 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4497036 4497036 0 0.0
RAM 205920 205920 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3005340 3005340 0 0.0
RAM 160552 160552 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4096408 4096408 0 0.0
RAM 246024 246024 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5951749 5951749 0 0.0
RAM 606904 606904 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11271549 11271549 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907452 907452 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901932 901932 0 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846072 846072 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 584744 584744 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600184 600184 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611052 611052 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685504 685504 0 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749008 749008 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646732 1646732 0 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553500 1553500 0 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1469428 1469428 0 0.0
RAM 200368 200368 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467364 1467364 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662324 662324 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620112 620112 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 482992 482992 0 0.0
RAM 144688 144688 0 0.0
telink bridge-app tl7218x FLASH 665214 665214 0 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621896 621896 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770882 770882 0 0.0
RAM 43568 43568 0 0.0
tl7218x FLASH 779352 779352 0 0.0
RAM 100752 100752 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680666 680666 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709228 709228 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626174 626174 0 0.0
RAM 142032 142032 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814004 814004 0 0.0
RAM 99608 99608 0 0.0
tizen all-clusters-app arm unknown 5104 5104 0 0.0
FLASH 1751644 1751644 0 0.0
RAM 93508 93508 0 0.0
chip-tool-ubsan arm unknown 11396 11396 0 0.0
FLASH 18683046 18683046 0 0.0
RAM 8181084 8181084 0 0.0
mergify mergify merged c81b3d4d into master 64 days ago
wy-hh wy-hh deleted the cert-fix branch 64 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
examples scripts platform review - approved changing-submodules-on-purpose
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum