PR #38435 Command handler interface mixin no change

ratgr30 days ago (edited 24 days ago)

This is one of 3 proposals I'm drafting for #37139

This is the No-Change-Required by User change, however its just too big for smaller platforms
As an example this PR doesn't change the Network Commissioning cluster to showcase the use case

Advantages

No change needed to user code, just update and that's it

Disadvantages

It just dumps all of the metadata for all clusters on the binary
The extra metadata is big enough to overflow some devices .text segment (about 8kb)
It requires the original name

Suggestions

Maybe provide a Flag to only enable some clusters, but I think if you have to know which clusters you need then it is best to go with the minimal-change solution

On generation we can know the clusters that will be added so we can add this flag dynamically to make sure worst case never happens

Testing

all UT's still pass

Changing AcceptedCommands Interface

a6c102cf

Update CHI::EnumerateGeneratedCommands to use builder

60c855fc

Added Builder initializer support

97a16dba

Update all cluster Implentations of the CHI interface

0aeb4e5a

Restyled by whitespace

c9918d22

Fixing Checks

9685feef

Size_t

1e118db6

[PATCH] Restyled by clang-format

3a551c13

Updated attributes

ff544647

Restyled by whitespace

6511c428

Restyled by clang-format

77a4f9fb

Clear up Access Permissions

7cb4b5ee

remove unnecesary file

dde4481c

Restyled by whitespace

e55e2372

Restyled by clang-format

5a0a9345

Fix to networkCommisioning

62429e8f

AcceptedCommands should return early

6f5ea52c

Check Error for CHIP_ERROR_NOT_IMPLEMENTED

319d9aab

Make sure there is space before appending

8e92e770

Fix Darwing Clangtidy issue

777a609d

Merge remote-tracking branch 'origin/master' into command-handler-int…

5f532241

Fixing dependency movement

9671d96f

Restyled by clang-format

33a06639

Remove Forward declaration

6e4a9e9e

Use builder instead of static array for network comissioning

e4a4968d

Update Comment on new AppendElements for initializer list

10cd5d33

Better phrasing in comments

731222ea

TestClusterCommandHandler::EnumerateAcceptedCommands don't use dynami…

98ea178c

Update src/app/CommandHandlerInterface.h

3f4a9060

Documenting Upgrading changes

3037bfc6

Quick Fix

f4cdd15f

Update docs/upgrading.md

7f56e9ff

Making all Privileges Explicit

a20600ed

Remove return of stack ptr

afc80b16

Allocate only once in enumeration

8c10c167

Privileges in ResetWatermarks up to spec

2bf9949b

remove chip from Access::Privilege;

8b8947bc

Rephrasing Upgrading comment

316072b4

Some more fixes

9c54176c

Start to support some metadata generation

25959702

Fix import

b6421106

Clean up sources

92c5d61f

Add generated metadata

94287a9e

Remove extra comma to make this a valid build.gn

b24b549e

Restyle

eab8a7d7

Updated content a bit: cluster ID is also fixed

70ddd243

Temporary workaround...but will look for something better

f30d5324

Better code reuse

50f9b2f9

Restyle

b5acd7dd

Restyle and add missing file

78226b1a

Remove some todo comments

85f88c9e

make linter happy

c7480097

Fix one case for namespace end comment

d7ad7277

move generation to zzz_generated

9e5a8ab4

rename path a bit more

8e675efc

Updated structure to zzz_generated/clusters/<NAME>' to contain indivi…

34ca4e61

Merge branch 'master' into cluster_metadata_generation

d01ff2ad

Merge branch 'master' into cluster_metadata_generation

7743a41e

Update generated code: generate IDs that are compatible with old IDs …

0af924ac

Add extra files

9822acb3

Fix up data type for events

34e2fab3

More arrangement of things ... it almost works

e1c0d083

Things now compile with dependencies. Need to figure out globals and …

f07aed49

Start adding some global attribute handling

fb0b7238

Update the code generator file list

945140bb

Global attributes work

9666f703

Update naming and add pragma once

dc64dcb8

Add response command IDs

c584a97d

All clusters app now compiles

bea53847

update paths to one more level of indirection

318fdaad

Update darwin projects to add data_model whenever app-common is there

0ba07e66

Update more include paths, make ASR compile by fixing platform depend…

ba0f0e4e

Fix qpg compilation

d557077c

Fix more builds: nrf, nxp, stm32, telink

74fa0c75

Fix ameba compilation

95c072b3

Restyle

c001a2dc

fix MW320 builds

9396f6a0

Fix bouffalolab compiles

60bcd057

Fix TI compilation

96cdc614

Add ids dependencies to darwin

cc40cab9

Add ids dependencies to NuttX

3bd8ce27

Fix tizen build

caa1d690

Fix android build

0469e5a6

Restyle

249a3317

fix zephyr

104af60b

match zap gen

ba33572f

more nxp fixes for ids

2ef090c2

more nxp fixes for ids

62e4ea18

make silabs/efr32 compile

0614613b

Bulk-add depdendencies on IDs on all platforms

d99c0840

Update more cmake files to include directories that include data_mode…

07892bad

Cleanup NXP dependencies

7bac9af7

NuttX code cleanup: generate does a real generate, cleanup the target…

15d6f425

darwin framework tool compile fix

4b6679b7

Disabled NuttX builds - platform maintainer has been notified

c3aa9cdb

Merge branch 'master' into cluster_metadata_generation

04dd2b87

Look to move items to reduce blast radius of changes

7ae2ffe9

Start updating the structure to reduce stutter

489af4b3

Move into clusters

f5f42a29

Fix include path

1e6d5b14

Regenerate and better sorting

48bb8f42

Fix build files

3b91fbcb

Now that paths moved, re-enable nuttx

aaadd2c6

Update namespacing for attribute metadata entries

4b1c62ab

Restyled by autopep8

4c542e8e

Remove references to data_model name

ef09db8e

Fix darwin framework tool build: its dependencies are just bad

5c48be7f

Restyled by gn

12271588

Cleanup dependencies, we do not need util types

caded691

Merge branch 'master' into cluster_metadata_generation

7fd24da3

Merge branch 'master' into cluster_metadata_generation

099f433f

Merge branch 'master' into cluster_metadata_generation

9a53a7bd

Merge branch 'master' into cluster_metadata_generation

ab297f9d

Merge branch 'master' into cluster_metadata_generation

5ff2c539

Fix path in Ids.h

2d72431f

Fix case typo in Clusters/clusters namespace

f8c5e2d6

Zap regen

4c8dc15b

Adding updated CHI interface into generation

433647be

temporal cha

4661c920

Update Generation

c517aaf8

Update generation, and generate

0a9101e4

Update to use kMetadataEntry

e6721f0b

Adding Shim Interface for CommandHandler

fd4e0806

Removing unnecesary usings

bf806acd

updating generation

99f47aad

Undoing changes to show that one liner to update

198c1702

More to simple change

a2e4b014

Fix warning

bd1fcc3f

github-actions added documentation

github-actions added examples

github-actions added scripts

github-actions added platform

github-actions added darwin

github-actions added esp32

github-actions added linux

github-actions added nrf connect

github-actions added zephyr

github-actions added lib

github-actions added controller

github-actions added app

github-actions added vscode

github-actions added telink

github-actions added tests

github-actions added support

github-actions added tizen

github-actions added silabs

github-actions added nxp

mergify added conflict

ratgr marked this pull request as ready for review 30 days ago

ratgr requested a review from

joonhaengHeo 30 days ago

ratgr requested a review from

s07641069 30 days ago

ratgr requested a review 30 days ago

ratgr requested a review from

arkq 30 days ago

ratgr requested a review 30 days ago

pullapprove added review - pending

ratgr assigned

ratgr 30 days ago

Merge branch 'master' into command-handler-interface-mixin-minimal-ch…

df445123

Merge Fixes

861bfca2

Merge fixes

98441288

Merge remote-tracking branch 'origin/master' into command-handler-int…

bf706769

ratgr force pushed from 2e5c3ef2 to bf706769 30 days ago

github-actions added config

mergify30 days ago

⚠️ The sha of the head commit of this PR conflicts with #38389. Mergify cannot evaluate rules on this PR. ⚠️

Rename new CHI to new name and shim to CHI

72758278

mergify removed conflict

ratgr marked this pull request as draft 30 days ago

removing unnecesary changes

88533bf5

Restyled by clang-format

cd63ff71

removing accidental submodules

3d302d3e

gn add to list

cf06c173

Restyled by clang-format

6fd7e13c

Restyled by clang-format

a8bc01ba

Fix TestCodeGenModel

d8f9c68d

Merge remote-tracking branch 'ratgr/command-handler-interface-mixin-n…

91455a46

Removing Template Switch and instead generate code

0610b84d

Remove unnesesarry changes

1c8d6e84

Run metageneration

b7a16194

Fixed generation

333afc10

Removed submodule accidental change

bb81acf7

Merge remote-tracking branch 'origin/master' into command-handler-int…

7448c733

Restyled by clang-format

0e861aaf

ratgr force pushed from 2f2fcb7a to b32c3231 28 days ago

Fix Merge errors

ae7c0b30

ratgr force pushed from b32c3231 to ae7c0b30 28 days ago

Changed some more to CommandHandlerInterfaceB

aba07771

Restyled by clang-format

4bb4ce9e

Fix on energy-evse

5418f290

Restyled by clang-format

10bf9105

Fix on all clusters

c383d49c

Restyled by clang-format

debac555

Fix private clusters

d8f82072

Fix private clusters

e46f8351

Restyled by clang-format

2a480b30

inherinting constructor

f1c4f866

github-actions28 days ago (edited 28 days ago)

PR #38435: Size comparison from 4a26ee2 to ebac26e

Increases above 0.2%:

platform	target	config	section	`4a26ee2`	`ebac26e`	change	% change
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	818796	827444	8648	1.1
	lock-ftd	LP_EM_CC1354P10_6	FLASH	827756	836404	8648	1.0
	pump-app	LP_EM_CC1354P10_6	FLASH	774800	783424	8624	1.1
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	759100	767748	8648	1.1
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	917312	926172	8860	1.0
		nrf7002dk_nrf5340_cpuapp	FLASH	909780	917596	7816	0.9
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	853840	862492	8652	1.0
qpg	lighting-app	qpg6105+debug	FLASH	665820	674468	8648	1.3
	lock-app	qpg6105+debug	FLASH	624104	632752	8648	1.4
stm32	light	STM32WB5MM-DK	FLASH	463016	471664	8648	1.9
tizen	all-clusters-app	arm	unknown	5164	6328	1164	22.5
			FLASH	1801660	`1825620`	23960	1.3

Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)

platform	target	config	section	`4a26ee2`	`ebac26e`	change	% change
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	818796	827444	8648	1.1
			RAM	120288	120288	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	827756	836404	8648	1.0
			RAM	125384	125384	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	774800	783424	8624	1.1
			RAM	113756	113756	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	759100	767748	8648	1.1
			RAM	113972	113972	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	542474	542226	-248	-0.0
			RAM	205144	205144	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	576438	576198	-240	-0.0
			RAM	205392	205392	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	917312	926172	8860	1.0
			RAM	167469	167469	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	909780	917596	7816	0.9
			RAM	145713	145713	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	853840	862492	8652	1.0
			RAM	141223	141223	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	665820	674468	8648	1.3
			RAM	105188	105188	0	0.0
	lock-app	qpg6105+debug	FLASH	624104	632752	8648	1.4
			RAM	99816	99816	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	463016	471664	8648	1.9
			RAM	141488	141488	0	0.0
tizen	all-clusters-app	arm	unknown	5164	6328	1164	22.5
			FLASH	1801660	`1825620`	23960	1.3
			RAM	94528	94572	44	0.0
	chip-tool-ubsan	arm	unknown	20272	20272	0	0.0
			FLASH	20379990	20377126	-2864	-0.0
			RAM	8882592	8881488	-1104	-0.0

More updates

408f217c

ratgr force pushed from ebac26ef to 408f217c 28 days ago

github-actions28 days ago (edited 28 days ago)

PR #38435: Size comparison from 4a26ee2 to 408f217

Increases above 0.2%:

platform	target	config	section	`4a26ee2`	`408f217`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1098928	1110120	11192	1.0
bl702	lighting-app	bl702+wifi	FLASH	831096	842292	11196	1.3
		bl706+mfd+rpc+littlefs	FLASH	1063620	`1074816`	11196	1.1
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	894508	905704	11196	1.3
	lighting-app	bl702l+mfd+littlefs	FLASH	977296	988492	11196	1.1
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	818796	827444	8648	1.1
	lock-ftd	LP_EM_CC1354P10_6	FLASH	827756	836404	8648	1.0
	pump-app	LP_EM_CC1354P10_6	FLASH	774800	783424	8624	1.1
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	759100	767748	8648	1.1
cyw30739	light	CYW30739B2-P5-EVK-01	FLASH	660813	669469	8656	1.3
		CYW30739B2-P5-EVK-02	FLASH	680673	689329	8656	1.3
		CYW30739B2-P5-EVK-03	FLASH	680673	689329	8656	1.3
		CYW930739M2EVB-02	FLASH	637597	646253	8656	1.4
	light-switch	CYW30739B2-P5-EVK-01	FLASH	620893	629533	8640	1.4
		CYW30739B2-P5-EVK-02	FLASH	640529	649177	8648	1.4
		CYW30739B2-P5-EVK-03	FLASH	640529	649177	8648	1.4
	lock	CYW30739B2-P5-EVK-01	FLASH	640341	648989	8648	1.4
		CYW30739B2-P5-EVK-02	FLASH	660057	668705	8648	1.3
		CYW30739B2-P5-EVK-03	FLASH	660057	668705	8648	1.3
	thermostat	CYW30739B2-P5-EVK-01	FLASH	616737	625385	8648	1.4
		CYW30739B2-P5-EVK-02	FLASH	636597	645245	8648	1.4
		CYW30739B2-P5-EVK-03	FLASH	636597	645245	8648	1.4
efr32	lock-app	BRD4187C	FLASH	942008	950648	8640	0.9
		BRD4338a	FLASH	735864	749400	13536	1.8
	window-app	BRD4187C	FLASH	1033632	1047152	13520	1.3
esp32	all-clusters-app	c3devkit	FLASH	`1800048`	1811884	11836	0.7
		m5stack	FLASH	1765606	1777674	12068	0.7
linux	air-purifier-app	debug	FLASH	2749687	2772731	23044	0.8
	all-clusters-app	debug	FLASH	6295040	6319354	24314	0.4
	all-clusters-minimal-app	debug	FLASH	5419840	`5442834`	22994	0.4
	bridge-app	debug	FLASH	4719680	`4742674`	22994	0.5
	camera-app	debug	FLASH	6793019	6816011	22992	0.3
	fabric-bridge-app	debug	FLASH	`4550444`	4573472	23028	0.5
	fabric-sync	debug	FLASH	5690069	`5713061`	22992	0.4
	lighting-app	debug+rpc+ui	FLASH	`5620433`	5643425	22992	0.4
	lock-app	debug	FLASH	4788208	4811198	22990	0.5
	ota-provider-app	debug	FLASH	4407894	4430756	22862	0.5
	ota-requestor-app	debug	FLASH	`4540234`	4563096	22862	0.5
	thermostat-no-ble	arm64	unknown	9560	12472	2912	30.5
			FLASH	4206536	`4245336`	38800	0.9
	tv-app	debug	FLASH	`6037173`	`6060197`	23024	0.4
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	917312	926172	8860	1.0
		nrf7002dk_nrf5340_cpuapp	FLASH	909780	917596	7816	0.9
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	853840	862492	8652	1.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1662140	1675940	13800	0.8
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1566396	1579916	13520	0.9
	light	cy8ckit_062s2_43012	FLASH	1442692	1456212	13520	0.9
	lock	cy8ckit_062s2_43012	FLASH	1471468	1484996	13528	0.9
qpg	lighting-app	qpg6105+debug	FLASH	665820	674468	8648	1.3
	lock-app	qpg6105+debug	FLASH	624104	632752	8648	1.4
stm32	light	STM32WB5MM-DK	FLASH	463016	471664	8648	1.9
telink	bridge-app	tl7218x	FLASH	696146	702702	6556	0.9
	light-app-ota-compress-lzma-factory-data	tl3218x	FLASH	777962	784518	6556	0.8
	light-app-ota-compress-lzma-shell-factory-data	tl3218x	FLASH	768224	774780	6556	0.9
	light-switch-app-ota-shell-factory-data	tl3218x_retention	FLASH	709710	716266	6556	0.9
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	603726	610282	6556	1.1
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	819212	825772	6560	0.8
tizen	all-clusters-app	arm	unknown	5164	6328	1164	22.5
			FLASH	1801660	`1825620`	23960	1.3

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`4a26ee2`	`408f217`	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1098928	1110120	11192	1.0
			RAM	94850	94850	0	0.0
bl702	lighting-app	bl702+eth	FLASH	653844	653588	-256	-0.0
			RAM	33533	33533	0	0.0
		bl702+wifi	FLASH	831096	842292	11196	1.3
			RAM	22257	22257	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1063620	`1074816`	11196	1.1
			RAM	32181	32181	0	0.0
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	894508	905704	11196	1.3
			RAM	26920	26920	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	977296	988492	11196	1.1
			RAM	24668	24668	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	818796	827444	8648	1.1
			RAM	120288	120288	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	827756	836404	8648	1.0
			RAM	125384	125384	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	774800	783424	8624	1.1
			RAM	113756	113756	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	759100	767748	8648	1.1
			RAM	113972	113972	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	542474	542226	-248	-0.0
			RAM	205144	205144	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	576438	576198	-240	-0.0
			RAM	205392	205392	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	660813	669469	8656	1.3
			RAM	77260	77260	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	680673	689329	8656	1.3
			RAM	79900	79900	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	680673	689329	8656	1.3
			RAM	79900	79900	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	637597	646253	8656	1.4
			RAM	72328	72328	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	620893	629533	8640	1.4
			RAM	73508	73508	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	640529	649177	8648	1.4
			RAM	76052	76052	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	640529	649177	8648	1.4
			RAM	76052	76052	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	640341	648989	8648	1.4
			RAM	76508	76508	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	660057	668705	8648	1.3
			RAM	79052	79052	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	660057	668705	8648	1.3
			RAM	79052	79052	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	616737	625385	8648	1.4
			RAM	70596	70596	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	636597	645245	8648	1.4
			RAM	73236	73236	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	636597	645245	8648	1.4
			RAM	73236	73236	0	0.0
efr32	lock-app	BRD4187C	FLASH	942008	950648	8640	0.9
			RAM	132008	132008	0	0.0
		BRD4338a	FLASH	735864	749400	13536	1.8
			RAM	206916	206916	0	0.0
	window-app	BRD4187C	FLASH	1033632	1047152	13520	1.3
			RAM	128048	128048	0	0.0
esp32	all-clusters-app	c3devkit	DRAM	103408	103408	0	0.0
			FLASH	`1800048`	1811884	11836	0.7
			IRAM	83846	83846	0	0.0
		m5stack	DRAM	121980	121980	0	0.0
			FLASH	1765606	1777674	12068	0.7
			IRAM	117043	117043	0	0.0
linux	air-purifier-app	debug	unknown	4848	4848	0	0.0
			FLASH	2749687	2772731	23044	0.8
			RAM	114264	114360	96	0.1
	all-clusters-app	debug	unknown	5656	5656	0	0.0
			FLASH	6295040	6319354	24314	0.4
			RAM	532432	532512	80	0.0
	all-clusters-minimal-app	debug	unknown	5528	5528	0	0.0
			FLASH	5419840	`5442834`	22994	0.4
			RAM	224528	224640	112	0.0
	bridge-app	debug	unknown	5544	5544	0	0.0
			FLASH	4719680	`4742674`	22994	0.5
			RAM	202880	202976	96	0.0
	camera-app	debug	unknown	8832	8832	0	0.0
			FLASH	6793019	6816011	22992	0.3
			RAM	225264	225360	96	0.0
	camera-controller	debug	unknown	9120	9120	0	0.0
			FLASH	13890123	13887803	-2320	-0.0
			RAM	646352	646352	0	0.0
	chip-tool	debug	unknown	6256	6256	0	0.0
			FLASH	14316015	14313699	-2316	-0.0
			RAM	636544	636544	0	0.0
	chip-tool-ipv6only	arm64	unknown	39696	39696	0	0.0
			FLASH	12349184	12347280	-1904	-0.0
			RAM	682720	682720	0	0.0
	fabric-admin	debug	unknown	5936	5936	0	0.0
			FLASH	12415827	12413511	-2316	-0.0
			RAM	635904	635904	0	0.0
	fabric-bridge-app	debug	unknown	4800	4800	0	0.0
			FLASH	`4550444`	4573472	23028	0.5
			RAM	190160	190224	64	0.0
	fabric-sync	debug	unknown	5056	5056	0	0.0
			FLASH	5690069	`5713061`	22992	0.4
			RAM	486664	486744	80	0.0
	lighting-app	debug+rpc+ui	unknown	6264	6264	0	0.0
			FLASH	`5620433`	5643425	22992	0.4
			RAM	207144	207240	96	0.0
	lock-app	debug	unknown	5496	5496	0	0.0
			FLASH	4788208	4811198	22990	0.5
			RAM	194272	194352	80	0.0
	ota-provider-app	debug	unknown	4840	4840	0	0.0
			FLASH	4407894	4430756	22862	0.5
			RAM	182992	183088	96	0.1
	ota-requestor-app	debug	unknown	4792	4792	0	0.0
			FLASH	`4540234`	4563096	22862	0.5
			RAM	187464	187560	96	0.1
	shell	debug	unknown	4272	4272	0	0.0
			FLASH	`3055676`	`3053484`	-2192	-0.1
			RAM	147824	147824	0	0.0
	thermostat-no-ble	arm64	unknown	9560	12472	2912	30.5
			FLASH	4206536	`4245336`	38800	0.9
			RAM	230856	230992	136	0.1
	tv-app	debug	unknown	5832	5832	0	0.0
			FLASH	`6037173`	`6060197`	23024	0.4
			RAM	610080	610160	80	0.0
	tv-casting-app	debug	unknown	5416	5416	0	0.0
			FLASH	12481789	12504877	23088	0.2
			RAM	754464	754576	112	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	917312	926172	8860	1.0
			RAM	167469	167469	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	909780	917596	7816	0.9
			RAM	145713	145713	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	853840	862492	8652	1.0
			RAM	141223	141223	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1662140	1675940	13800	0.8
			RAM	212352	212352	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1566396	1579916	13520	0.9
			RAM	208544	208544	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1442692	1456212	13520	0.9
			RAM	197312	197312	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1471468	1484996	13528	0.9
			RAM	224976	224976	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	665820	674468	8648	1.3
			RAM	105188	105188	0	0.0
	lock-app	qpg6105+debug	FLASH	624104	632752	8648	1.4
			RAM	99816	99816	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	463016	471664	8648	1.9
			RAM	141488	141488	0	0.0
telink	bridge-app	tl7218x	FLASH	696146	702702	6556	0.9
			RAM	101860	101860	0	0.0
	light-app-ota-compress-lzma-factory-data	tl3218x	FLASH	777962	784518	6556	0.8
			RAM	50120	50120	0	0.0
	light-app-ota-compress-lzma-shell-factory-data	tl3218x	FLASH	768224	774780	6556	0.9
			RAM	40420	40420	0	0.0
	light-app-ota-shell-factory-data	tl7218x	FLASH	784598	763240	-21358	-2.7
			RAM	109308	97540	-11768	-10.8
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	705824	690270	-15554	-2.2
			RAM	62620	51588	-11032	-17.6
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	742006	718720	-23286	-3.1
			RAM	85808	73408	-12400	-14.5
	light-switch-app-ota-shell-factory-data	tl3218x_retention	FLASH	709710	716266	6556	0.9
			RAM	37044	37044	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	603726	610282	6556	1.1
			RAM	148704	148704	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	819212	825772	6560	0.8
			RAM	107568	107568	0	0.0
tizen	all-clusters-app	arm	unknown	5164	6328	1164	22.5
			FLASH	1801660	`1825620`	23960	1.3
			RAM	94528	94572	44	0.0
	chip-tool-ubsan	arm	unknown	20272	20272	0	0.0
			FLASH	20379990	20377126	-2864	-0.0
			RAM	8882592	8881488	-1104	-0.0

woody-apple added this to the No Target Milestone milestone 17 days ago

mergify added conflict

andy31415 requested changes on 2025-04-30

andy3141516 days ago

Marking this as changes-requested: I believe anything that increases flash by this much by default is not something we can use.

connectedhomeip
Command handler interface mixin no change
#38435

Open

Command handler interface mixin no change #38435

Advantages

Disadvantages

Suggestions

Testing

connectedhomeip Command handler interface mixin no change #38435 Open

Command handler interface mixin no change #38435

Advantages

Disadvantages

Suggestions

Testing

connectedhomeip
Command handler interface mixin no change
#38435

Open