connectedhomeip
Darwin: Make os_log() integration more efficient
#38442
Merged
Overview
Commits
1
Changes
View On GitHub

Darwin: Make os_log() integration more efficient #38442

mergify merged 1 commit into project-chip:master from ksperling-apple:darwin-log-tweaks
ksperling-apple
ksperling-apple19 days ago
  • Simplify call sites by not passing the stringified module name
  • Avoid duplicate plain and os_log string constants
  • Actually avoid retain/release of the logger

Overall this saves about 50k of code and 100k of strings in Matter.framework

Testing

Existing CI tests

ksperling-apple ksperling-apple requested a review 19 days ago
pullapprove pullapprove added review - pending
github-actions github-actions added platform
github-actions github-actions added darwin
ksperling-apple ksperling-apple force pushed from 425b6f37 to 929b3a1c 19 days ago
ksperling-apple Darwin: Make os_log() implementation more efficient
8a6c47ec
ksperling-apple ksperling-apple force pushed from 929b3a1c to 8a6c47ec 19 days ago
github-actions
github-actions19 days ago (edited 19 days ago)

PR #38442: Size comparison from c94e337 to 8a6c47e

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c94e337 8a6c47e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098928 1098928 0 0.0
RAM 94850 94850 0 0.0
bl702 lighting-app bl702+eth FLASH 653588 653588 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830840 830840 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063620 1063620 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894508 894508 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 977040 977040 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818708 818708 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827668 827668 0 0.0
RAM 125384 125384 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774728 774728 0 0.0
RAM 113756 113756 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 759028 759028 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542386 542386 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576366 576366 0 0.0
RAM 205392 205392 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660693 660693 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680545 680545 0 0.0
RAM 79900 79900 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680545 680545 0 0.0
RAM 79900 79900 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637477 637477 0 0.0
RAM 72328 72328 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620773 620773 0 0.0
RAM 73508 73508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640409 640409 0 0.0
RAM 76052 76052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640409 640409 0 0.0
RAM 76052 76052 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 640213 640213 0 0.0
RAM 76508 76508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659937 659937 0 0.0
RAM 79052 79052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659937 659937 0 0.0
RAM 79052 79052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616617 616617 0 0.0
RAM 70596 70596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636469 636469 0 0.0
RAM 73236 73236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636469 636469 0 0.0
RAM 73236 73236 0 0.0
efr32 lock-app BRD4187C FLASH 941280 941280 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 735128 735120 -8 -0.0
RAM 234852 234852 0 0.0
window-app BRD4187C FLASH 1033568 1033568 0 0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1799328 1799328 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121980 121980 0 0.0
FLASH 1764974 1764974 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2749157 2749157 0 0.0
RAM 114264 114264 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6290122 6290122 0 0.0
RAM 532400 532400 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5419310 5419310 0 0.0
RAM 224528 224528 0 0.0
bridge-app debug unknown 5544 5544 0 0.0
FLASH 4719150 4719150 0 0.0
RAM 202880 202880 0 0.0
camera-app debug unknown 8832 8832 0 0.0
FLASH 6787147 6787147 0 0.0
RAM 225200 225200 0 0.0
camera-controller debug unknown 9120 9120 0 0.0
FLASH 13751131 13751131 0 0.0
RAM 646352 646352 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14178353 14178353 0 0.0
RAM 636544 636544 0 0.0
chip-tool-ipv6only arm64 unknown 39696 39696 0 0.0
FLASH 12240128 12240128 0 0.0
RAM 680368 680368 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12277135 12277135 0 0.0
RAM 635904 635904 0 0.0
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4549914 4549914 0 0.0
RAM 190160 190160 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5689541 5689541 0 0.0
RAM 486664 486664 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5616465 5616465 0 0.0
RAM 207144 207144 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4787710 4787710 0 0.0
RAM 194272 194272 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4407364 4407364 0 0.0
RAM 182992 182992 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4539704 4539704 0 0.0
RAM 187464 187464 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3054796 3054796 0 0.0
RAM 147824 147824 0 0.0
thermostat-no-ble arm64 unknown 9560 9560 0 0.0
FLASH 4206168 4206168 0 0.0
RAM 230856 230856 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6033749 6033749 0 0.0
RAM 610080 610080 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12343709 12343709 0 0.0
RAM 754464 754464 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917244 917244 0 0.0
RAM 167469 167469 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 909720 909720 0 0.0
RAM 145713 145713 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 853768 853768 0 0.0
RAM 141223 141223 0 0.0
nxp contact k32w0+release FLASH 589176 589176 0 0.0
RAM 72836 72836 0 0.0
mcxw71+release FLASH 607488 607488 0 0.0
RAM 63152 63152 0 0.0
light k32w0+release FLASH 614948 614948 0 0.0
RAM 72132 72132 0 0.0
k32w1+release FLASH 691592 691592 0 0.0
RAM 72000 72000 0 0.0
lock mcxw71+release FLASH 756600 756600 0 0.0
RAM 67564 67564 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1662044 1662044 0 0.0
RAM 212352 212352 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1566300 1566300 0 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442596 1442596 0 0.0
RAM 197312 197312 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471372 1471372 0 0.0
RAM 224976 224976 0 0.0
qpg lighting-app qpg6105+debug FLASH 665748 665748 0 0.0
RAM 105188 105188 0 0.0
lock-app qpg6105+debug FLASH 624024 624024 0 0.0
RAM 99816 99816 0 0.0
stm32 light STM32WB5MM-DK FLASH 461432 461432 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 672932 672932 0 0.0
696050 696050 0 0.0
RAM 90712 90712 0 0.0
101860 101860 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 777866 777866 0 0.0
RAM 50120 50120 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 768128 768128 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 756588 756588 0 0.0
784502 784502 0 0.0
RAM 97540 97540 0 0.0
109308 109308 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 683618 683618 0 0.0
705728 705728 0 0.0
RAM 51588 51588 0 0.0
62620 62620 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 712068 712068 0 0.0
741910 741910 0 0.0
RAM 73408 73408 0 0.0
85808 85808 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 709614 709614 0 0.0
RAM 37044 37044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 604092 604092 0 0.0
603630 603630 0 0.0
RAM 138640 138640 0 0.0
148704 148704 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 791586 791590 4 0.0
819116 819120 4 0.0
RAM 96396 96396 0 0.0
107568 107568 0 0.0
tizen all-clusters-app arm unknown 5164 5164 0 0.0
FLASH 1801132 1801132 0 0.0
RAM 94528 94528 0 0.0
chip-tool-ubsan arm unknown 20272 20272 0 0.0
FLASH 20198334 20198334 0 0.0
RAM 8809700 8809700 0 0.0
woody-apple
woody-apple approved these changes on 2025-04-18
woody-apple woody-apple added fast track
mergify mergify merged be718961 into master 17 days ago
ksperling-apple ksperling-apple deleted the darwin-log-tweaks branch 4 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
platform darwin review - pending fast track
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum