connectedhomeip
RVC Example app: new opstates/errors
#38651
Open
Overview
Commits
5
Changes
View On GitHub

RVC Example app: new opstates/errors #38651

kiel-apple wants to merge 5 commits into project-chip:master from kiel-apple:rvc-example-new-opstates-errors
kiel-apple
kiel-apple30 days ago (edited 7 hours ago)

Add the new Operational States / Operational State Errors to the example app.

TODO

  • find out if new operational states should only be reachable from Docked state
  • check if other test scripts need to be run

Testing

Run the following test scripts:

  • src/python_testing/TC_RVCOPSTATE_2_1.py in TH
    • passed against pre-change RVC sample app (in TH)
    • passed against RVC sample app with change (in TH)
  • src/python_testing/TC_RVCOPSTATE_2_1.py directly
    • passed against RVC sample app with change
    • scripts/run_in_python_env.sh pyenv-kmo "python3 src/python_testing/TC_RVCOPSTATE_2_1.py --commissioning-method on-network --qr-code MT:-24J0AFN00KA0648G00 --endpoint 1 --storage-path admin_storage.json --app-pipe_prefix /tmp/chip_rvc_fifo_ --PICS examples/rvc-app/rvc-common/pics/rvc-app-pics-values --app-pid 55091"
  • src/python_testing/TC_RVCOPSTATE_2_3.py directly
    • passed against RVC sample app with change
    • scripts/run_in_python_env.sh pyenv-kmo "python3 src/python_testing/TC_RVCOPSTATE_2_3.py --commissioning-method on-network --qr-code MT:-24J0AFN00KA0648G00 --endpoint 1 --storage-path admin_storage.json --app-pipe_prefix /tmp/chip_rvc_fifo_ --app-pid 54914 --PICS examples/rvc-app/rvc-common/pics/rvc-app-pics-values"
  • src/python_testing/TC_RVCOPSTATE_2_4.py directly
    • passed against RVC sample app with change
    • scripts/run_in_python_env.sh pyenv-kmo "python3 src/python_testing/TC_RVCOPSTATE_2_4.py --commissioning-method on-network --qr-code MT:-24J0AFN00KA0648G00 --endpoint 1 --storage-path admin_storage.json --app-pipe_prefix /tmp/chip_rvc_fifo_ --app-pid 54990 --PICS examples/rvc-app/rvc-common/pics/rvc-app-pics-values"
github-actions github-actions added examples
github-actions
github-actions30 days ago (edited 29 days ago)

PR #38651: Size comparison from bde2c56 to 573986d

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section bde2c56 573986d change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1100472 1100472 0 0.0
RAM 94866 94866 0 0.0
bl702 lighting-app bl702+eth FLASH 655390 655390 0 0.0
RAM 33637 33637 0 0.0
bl702+wifi FLASH 832640 832640 0 0.0
RAM 22361 22361 0 0.0
bl706+mfd+rpc+littlefs FLASH 1065164 1065164 0 0.0
RAM 32285 32285 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 896052 896052 0 0.0
RAM 27024 27024 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 978840 978840 0 0.0
RAM 24772 24772 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 820292 820292 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 829568 829568 0 0.0
RAM 125432 125432 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 776288 776288 0 0.0
RAM 113780 113780 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 760604 760604 0 0.0
RAM 113988 113988 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 546922 546922 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 578482 578482 0 0.0
RAM 205440 205440 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 662213 662213 0 0.0
RAM 77284 77284 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 682065 682065 0 0.0
RAM 79924 79924 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 682065 682065 0 0.0
RAM 79924 79924 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 639005 639005 0 0.0
RAM 72352 72352 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 622437 622437 0 0.0
RAM 73524 73524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 642073 642073 0 0.0
RAM 76076 76076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 642073 642073 0 0.0
RAM 76076 76076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 642213 642213 0 0.0
RAM 76548 76548 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 661921 661921 0 0.0
RAM 79100 79100 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 661921 661921 0 0.0
RAM 79100 79100 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618617 618617 0 0.0
RAM 70644 70644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638477 638477 0 0.0
RAM 73276 73276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638477 638477 0 0.0
RAM 73276 73276 0 0.0
efr32 lock-app BRD4187C FLASH 943876 943876 0 0.0
RAM 132064 132064 0 0.0
BRD4338a FLASH 738192 738192 0 0.0
RAM 206956 206956 0 0.0
window-app BRD4187C FLASH 1035984 1035976 -8 -0.0
RAM 128072 128072 0 0.0
esp32 all-clusters-app c3devkit DRAM 103384 103384 0 0.0
FLASH 1804130 1804130 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121956 121956 0 0.0
FLASH 1769462 1769462 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2767565 2767565 0 0.0
RAM 114536 114536 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6309252 6309252 0 0.0
RAM 531720 531720 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5433504 5433504 0 0.0
RAM 224712 224712 0 0.0
bridge-app debug unknown 5544 5544 0 0.0
FLASH 4733024 4733024 0 0.0
RAM 203792 203792 0 0.0
camera-app debug unknown 8856 8856 0 0.0
FLASH 6808267 6808267 0 0.0
RAM 225512 225512 0 0.0
camera-controller debug unknown 9240 9240 0 0.0
FLASH 14062219 14062219 0 0.0
RAM 649552 649552 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14324061 14324061 0 0.0
RAM 636208 636208 0 0.0
chip-tool-ipv6only arm64 unknown 39608 39608 0 0.0
FLASH 12360416 12360416 0 0.0
RAM 682304 682304 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12435859 12435859 0 0.0
RAM 635568 635568 0 0.0
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4558304 4558304 0 0.0
RAM 190216 190216 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5699445 5699445 0 0.0
RAM 485912 485912 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5628465 5628465 0 0.0
RAM 207160 207160 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4798958 4798958 0 0.0
RAM 194424 194424 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4420812 4420812 0 0.0
RAM 183640 183640 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4548556 4548556 0 0.0
RAM 187544 187544 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3069708 3069708 0 0.0
RAM 147912 147912 0 0.0
thermostat-no-ble arm64 unknown 9544 9544 0 0.0
FLASH 4215160 4215160 0 0.0
RAM 230896 230896 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6054469 6054469 0 0.0
RAM 610592 610592 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12492285 12492285 0 0.0
RAM 754376 754376 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 919692 919692 0 0.0
RAM 167395 167395 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 911716 911716 0 0.0
RAM 145639 145639 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 856300 856300 0 0.0
RAM 141163 141163 0 0.0
nxp contact k32w0+release FLASH 590656 590656 0 0.0
RAM 72848 72848 0 0.0
mcxw71+release FLASH 622720 622720 0 0.0
RAM 63188 63188 0 0.0
light k32w0+release FLASH 616484 616484 0 0.0
RAM 72144 72144 0 0.0
k32w1+release FLASH 706936 706936 0 0.0
RAM 72036 72036 0 0.0
lock mcxw71+release FLASH 771968 771968 0 0.0
RAM 67612 67612 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1665820 1665820 0 0.0
RAM 212400 212400 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1570148 1570148 0 0.0
RAM 208576 208576 0 0.0
light cy8ckit_062s2_43012 FLASH 1445164 1445164 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1474444 1474444 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 667132 667132 0 0.0
RAM 105200 105200 0 0.0
lock-app qpg6105+debug FLASH 625552 625552 0 0.0
RAM 99820 99820 0 0.0
stm32 light STM32WB5MM-DK FLASH 464460 464460 0 0.0
RAM 141504 141504 0 0.0
telink bridge-app tl7218x FLASH 697916 697916 0 0.0
RAM 101800 101800 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 779370 779370 0 0.0
RAM 50032 50032 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 769630 769630 0 0.0
RAM 40332 40332 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 786022 758104 -27918 -3.6
RAM 109220 97452 -11768 -10.8
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 707248 685138 -22110 -3.1
RAM 62532 51500 -11032 -17.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 743430 713588 -29842 -4.0
RAM 85720 73320 -12400 -14.5
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 711118 711118 0 0.0
RAM 36956 36956 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 605150 605150 0 0.0
RAM 148616 148616 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820636 820640 4 0.0
RAM 107480 107480 0 0.0
tizen all-clusters-app arm unknown 5184 5184 0 0.0
FLASH 1808628 1808628 0 0.0
RAM 94560 94560 0 0.0
chip-tool-ubsan arm unknown 20240 20240 0 0.0
FLASH 20399382 20399382 0 0.0
RAM 8895140 8895140 0 0.0
woody-apple woody-apple requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 29 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2025-04-29
copilot-pull-request-reviewer29 days ago

Pull Request Overview

This pull request extends the error handling and operational state support in the RVC Example app.

  • Introduces new error event branches in rvc-device.cpp for additional error types (e.g. "LowBattery", "BrushJammed", etc.).
  • Expands the operational state list in rvc-operational-state-delegate.h to include four new states.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
examples/rvc-app/rvc-common/src/rvc-device.cpp Added multiple new error branches in HandleErrorEvent for improved error reporting.
examples/rvc-app/rvc-common/include/rvc-operational-state-delegate.h Increased the array size and appended new operational states to support enhanced functionality.
Comments suppressed due to low confidence (2)

examples/rvc-app/rvc-common/src/rvc-device.cpp:398

  • [nitpick] Consider refactoring the chain of error conditionals into a lookup table (e.g. std::unordered_map<std::string, ErrorStateEnum>) to simplify maintenance as the number of error cases grows.
else if (error == "LowBattery")

examples/rvc-app/rvc-common/include/rvc-operational-state-delegate.h:40

  • Verify that the updated array size (11) accurately reflects all operational states expected throughout the system to prevent potential off-by-one errors.
const Clusters::OperationalState::GenericOperationalState mOperationalStateList[11] = {
woody-apple woody-apple force pushed from 573986de to c48af9ff 29 days ago
github-actions
github-actions29 days ago (edited 29 days ago)

PR #38651: Size comparison from ccdaefe to c48af9f

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ccdaefe c48af9f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1100472 1100472 0 0.0
RAM 94866 94866 0 0.0
bl702 lighting-app bl702+eth FLASH 655390 655390 0 0.0
RAM 33637 33637 0 0.0
bl702+wifi FLASH 832640 832640 0 0.0
RAM 22361 22361 0 0.0
bl706+mfd+rpc+littlefs FLASH 1065164 1065164 0 0.0
RAM 32285 32285 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 896052 896052 0 0.0
RAM 27024 27024 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 978840 978840 0 0.0
RAM 24772 24772 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 820292 820292 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 829568 829568 0 0.0
RAM 125432 125432 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 776288 776288 0 0.0
RAM 113780 113780 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 760604 760604 0 0.0
RAM 113988 113988 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 546922 546922 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 578482 578482 0 0.0
RAM 205440 205440 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 662213 662213 0 0.0
RAM 77284 77284 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 682065 682065 0 0.0
RAM 79924 79924 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 682065 682065 0 0.0
RAM 79924 79924 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 639005 639005 0 0.0
RAM 72352 72352 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 622437 622437 0 0.0
RAM 73524 73524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 642073 642073 0 0.0
RAM 76076 76076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 642073 642073 0 0.0
RAM 76076 76076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 642213 642213 0 0.0
RAM 76548 76548 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 661921 661921 0 0.0
RAM 79100 79100 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 661921 661921 0 0.0
RAM 79100 79100 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618617 618617 0 0.0
RAM 70644 70644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638477 638477 0 0.0
RAM 73276 73276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638477 638477 0 0.0
RAM 73276 73276 0 0.0
efr32 lock-app BRD4187C FLASH 943876 943876 0 0.0
RAM 132064 132064 0 0.0
BRD4338a FLASH 738192 738192 0 0.0
RAM 206956 206956 0 0.0
window-app BRD4187C FLASH 1035984 1035976 -8 -0.0
RAM 128072 128072 0 0.0
esp32 all-clusters-app c3devkit DRAM 103384 103384 0 0.0
FLASH 1804130 1804130 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121956 121956 0 0.0
FLASH 1769486 1769486 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2767403 2767403 0 0.0
RAM 114536 114536 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6309156 6309156 0 0.0
RAM 533096 533096 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5433344 5433344 0 0.0
RAM 224712 224712 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4739068 4739068 0 0.0
RAM 204160 204160 0 0.0
camera-app debug unknown 8856 8856 0 0.0
FLASH 6812363 6812363 0 0.0
RAM 225928 225928 0 0.0
camera-controller debug unknown 9240 9240 0 0.0
FLASH 14086811 14086811 0 0.0
RAM 651344 651344 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14358691 14358691 0 0.0
RAM 638064 638064 0 0.0
chip-tool-ipv6only arm64 unknown 39696 39696 0 0.0
FLASH 12387824 12387824 0 0.0
RAM 684176 684176 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12460189 12460189 0 0.0
RAM 637424 637424 0 0.0
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4558144 4558144 0 0.0
RAM 190216 190216 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5699381 5699381 0 0.0
RAM 487288 487288 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5628321 5628321 0 0.0
RAM 207160 207160 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4798798 4798798 0 0.0
RAM 194424 194424 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4420652 4420652 0 0.0
RAM 183640 183640 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4548398 4548398 0 0.0
RAM 187544 187544 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3069548 3069548 0 0.0
RAM 147912 147912 0 0.0
thermostat-no-ble arm64 unknown 9544 9544 0 0.0
FLASH 4215160 4215160 0 0.0
RAM 230896 230896 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6054373 6054373 0 0.0
RAM 611968 611968 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12527133 12527133 0 0.0
RAM 756280 756280 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 919692 919692 0 0.0
RAM 167395 167395 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 911716 911716 0 0.0
RAM 145639 145639 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 856300 856300 0 0.0
RAM 141163 141163 0 0.0
nxp contact k32w0+release FLASH 590656 590656 0 0.0
RAM 72848 72848 0 0.0
mcxw71+release FLASH 622720 622720 0 0.0
RAM 63188 63188 0 0.0
light k32w0+release FLASH 616484 616484 0 0.0
RAM 72144 72144 0 0.0
k32w1+release FLASH 706936 706936 0 0.0
RAM 72036 72036 0 0.0
lock mcxw71+release FLASH 771968 771968 0 0.0
RAM 67612 67612 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1665820 1665820 0 0.0
RAM 212400 212400 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1570148 1570148 0 0.0
RAM 208576 208576 0 0.0
light cy8ckit_062s2_43012 FLASH 1445164 1445164 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1474444 1474444 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 667132 667132 0 0.0
RAM 105200 105200 0 0.0
lock-app qpg6105+debug FLASH 625552 625552 0 0.0
RAM 99820 99820 0 0.0
stm32 light STM32WB5MM-DK FLASH 464460 464460 0 0.0
RAM 141504 141504 0 0.0
telink bridge-app tl7218x FLASH 697916 674798 -23118 -3.3
697916 697916 0 0.0
RAM 101800 90652 -11148 -11.0
101800 101800 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 779370 779370 0 0.0
RAM 50032 50032 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 769630 769630 0 0.0
RAM 40332 40332 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 786022 758104 -27918 -3.6
786022 786022 0 0.0
RAM 109220 97452 -11768 -10.8
109220 109220 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 707248 685138 -22110 -3.1
707248 707248 0 0.0
RAM 62532 51500 -11032 -17.6
62532 62532 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 743430 713588 -29842 -4.0
743430 743430 0 0.0
RAM 85720 73320 -12400 -14.5
85720 85720 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 711118 711118 0 0.0
RAM 36956 36956 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 605150 605608 458 0.1
605150 605150 0 0.0
RAM 148616 138552 -10064 -6.8
148616 148616 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820636 793110 -27526 -3.4
820636 820640 4 0.0
RAM 107480 96308 -11172 -10.4
107480 107480 0 0.0
tizen all-clusters-app arm unknown 5184 5184 0 0.0
FLASH 1808628 1808628 0 0.0
RAM 94560 94560 0 0.0
chip-tool-ubsan arm unknown 20284 20284 0 0.0
FLASH 20465606 20465606 0 0.0
RAM 8916972 8916972 0 0.0
kiel-apple kiel-apple requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 29 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2025-04-29
copilot-pull-request-reviewer29 days ago

Pull Request Overview

This PR introduces new operational state error mappings in the device handler and extends the list of supported operational states.

  • Added new error condition handling in rvc-device.cpp for states such as "LowBattery", "CannotReachTargetArea", and others.
  • Expanded the operational state list in rvc-operational-state-delegate.h by increasing the array size and appending new states.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
examples/rvc-app/rvc-common/src/rvc-device.cpp Added additional error handling for new operational states.
examples/rvc-app/rvc-common/include/rvc-operational-state-delegate.h Increased the operational state array size and appended new state entries.
Comments suppressed due to low confidence (1)

examples/rvc-app/rvc-common/include/rvc-operational-state-delegate.h:49

  • [nitpick] Ensure that the updated array size and ordering of states matches the corresponding enum definitions to maintain consistency in state mapping.
OperationalState::GenericOperationalState(
Conversation is marked as resolved
Show resolved
examples/rvc-app/rvc-common/src/rvc-device.cpp
395395 {
396396 err.errorStateID = to_underlying(RvcOperationalState::ErrorStateEnum::kMopCleaningPadMissing);
397397 }
398
 else if (error == "LowBattery")
copilot-pull-request-reviewer29 days ago

[nitpick] Consider refactoring the sequential 'else if' conditions into a lookup table or map to reduce repetition and improve maintainability.

kiel-apple kiel-apple marked this pull request as ready for review 29 days ago
pullapprove pullapprove added review - pending
kiel-apple kiel-apple requested a review from hicklin hicklin 29 days ago
kiel-apple kiel-apple requested a review from plauric plauric 29 days ago
kiel-apple kiel-apple marked this pull request as draft 29 days ago
kiel-apple kiel-apple force pushed from c48af9ff to 66c148d1 20 days ago
github-actions
github-actions20 days ago (edited 20 days ago)

PR #38651: Size comparison from eea4ef6 to 66c148d

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section eea4ef6 66c148d change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1102926 1102926 0 0.0
RAM 94866 94866 0 0.0
bl702 lighting-app bl702+eth FLASH 657772 657772 0 0.0
RAM 33637 33637 0 0.0
bl702+wifi FLASH 834770 834770 0 0.0
RAM 22361 22361 0 0.0
bl706+mfd+rpc+littlefs FLASH 1067550 1067550 0 0.0
RAM 32285 32285 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 898442 898442 0 0.0
RAM 27024 27024 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 980970 980970 0 0.0
RAM 24772 24772 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 822180 822180 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 831952 831952 0 0.0
RAM 125432 125432 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 778360 778360 0 0.0
RAM 113780 113780 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 762700 762700 0 0.0
RAM 113988 113988 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549042 549042 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 581090 581090 0 0.0
RAM 205440 205440 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 663757 663757 0 0.0
RAM 77324 77324 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 683609 683609 0 0.0
RAM 79964 79964 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 683609 683609 0 0.0
RAM 79964 79964 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 640549 640549 0 0.0
RAM 72392 72392 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623901 623901 0 0.0
RAM 73564 73564 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643529 643529 0 0.0
RAM 76116 76116 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643529 643529 0 0.0
RAM 76116 76116 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 644165 644165 0 0.0
RAM 76588 76588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 663873 663873 0 0.0
RAM 79140 79140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 663873 663873 0 0.0
RAM 79140 79140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620569 620569 0 0.0
RAM 70684 70684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640421 640421 0 0.0
RAM 73316 73316 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640421 640421 0 0.0
RAM 73316 73316 0 0.0
efr32 lock-app BRD4187C FLASH 946348 946348 0 0.0
RAM 132096 132096 0 0.0
BRD4338a FLASH 741240 741240 0 0.0
RAM 206996 206996 0 0.0
window-app BRD4187C FLASH 1039048 1039040 -8 -0.0
RAM 128232 128232 0 0.0
esp32 all-clusters-app c3devkit DRAM 103328 103328 0 0.0
FLASH 1806116 1806116 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121932 121932 0 0.0
FLASH 1771238 1771238 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2781773 2781773 0 0.0
RAM 114680 114680 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6334516 6334516 0 0.0
RAM 529688 529688 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5439734 5439734 0 0.0
RAM 224616 224616 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4756290 4756290 0 0.0
RAM 204272 204272 0 0.0
camera-app debug unknown 8856 8856 0 0.0
FLASH 6890795 6890795 0 0.0
RAM 226448 226448 0 0.0
camera-controller debug unknown 9240 9240 0 0.0
FLASH 14014187 14014187 0 0.0
RAM 645232 645232 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14229841 14229841 0 0.0
RAM 631824 631824 0 0.0
chip-tool-ipv6only arm64 unknown 39432 39432 0 0.0
FLASH 12280560 12280560 0 0.0
RAM 677928 677928 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12373185 12373185 0 0.0
RAM 631184 631184 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4573166 4573166 0 0.0
RAM 190312 190312 0 0.0
fabric-sync debug unknown 5064 5064 0 0.0
FLASH 5712741 5712741 0 0.0
RAM 483096 483096 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5642705 5642705 0 0.0
RAM 207288 207288 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4816152 4816152 0 0.0
RAM 194520 194520 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4435976 4435976 0 0.0
RAM 183752 183752 0 0.0
ota-requestor-app debug unknown 4800 4800 0 0.0
FLASH 4563712 4563712 0 0.0
RAM 187656 187656 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3077404 3077404 0 0.0
RAM 148072 148072 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4227888 4227888 0 0.0
RAM 231024 231024 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6069909 6069909 0 0.0
RAM 607744 607744 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12408365 12408365 0 0.0
RAM 749544 749544 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 919644 919644 0 0.0
RAM 167328 167328 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 911644 911644 0 0.0
RAM 145572 145572 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 856308 856308 0 0.0
RAM 141091 141091 0 0.0
nxp contact k32w0+release FLASH 592304 592304 0 0.0
RAM 72848 72848 0 0.0
mcxw71+release FLASH 624568 624568 0 0.0
RAM 63188 63188 0 0.0
light k32w0+release FLASH 618268 618268 0 0.0
RAM 72144 72144 0 0.0
k32w1+release FLASH 709032 709032 0 0.0
RAM 72036 72036 0 0.0
lock mcxw71+release FLASH 774048 774048 0 0.0
RAM 67612 67612 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1665860 1665860 0 0.0
RAM 212328 212328 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1570348 1570348 0 0.0
RAM 208504 208504 0 0.0
light cy8ckit_062s2_43012 FLASH 1447620 1447620 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1477476 1477476 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 667716 667716 0 0.0
RAM 105200 105200 0 0.0
lock-app qpg6105+debug FLASH 626080 626080 0 0.0
RAM 99820 99820 0 0.0
stm32 light STM32WB5MM-DK FLASH 466548 466548 0 0.0
RAM 141504 141504 0 0.0
telink bridge-app tl7218x FLASH 677132 677132 0 0.0
693866 693866 0 0.0
RAM 90692 90692 0 0.0
101832 101832 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 774498 774498 0 0.0
RAM 50072 50072 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 771614 771614 0 0.0
RAM 40372 40372 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 760070 760070 0 0.0
781604 781604 0 0.0
RAM 97492 97492 0 0.0
109252 109252 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 687108 687108 0 0.0
702982 702982 0 0.0
RAM 51540 51540 0 0.0
62572 62572 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 715558 715558 0 0.0
740936 740936 0 0.0
RAM 73360 73360 0 0.0
85752 85752 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 712886 712886 0 0.0
RAM 36996 36996 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 608508 608508 0 0.0
608050 608050 0 0.0
RAM 106748 106748 0 0.0
119468 119468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 795072 795076 4 0.0
816866 816870 4 0.0
RAM 96348 96348 0 0.0
107520 107520 0 0.0
tizen all-clusters-app arm unknown 5176 5176 0 0.0
FLASH 1808780 1808780 0 0.0
RAM 94656 94656 0 0.0
chip-tool-ubsan arm unknown 20152 20152 0 0.0
FLASH 20258926 20258926 0 0.0
RAM 8821644 8821644 0 0.0
kiel-apple kiel-apple force pushed from 66c148d1 to d5ef616b 19 days ago
github-actions
github-actions19 days ago (edited 19 days ago)

PR #38651: Size comparison from 99c3a2d to d5ef616

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 99c3a2d d5ef616b change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1102758 1102758 0 0.0
RAM 94882 94882 0 0.0
bl702 lighting-app bl702+eth FLASH 657604 657604 0 0.0
RAM 33645 33645 0 0.0
bl702+wifi FLASH 834858 834858 0 0.0
RAM 22369 22369 0 0.0
bl706+mfd+rpc+littlefs FLASH 1067638 1067638 0 0.0
RAM 32293 32293 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 898530 898530 0 0.0
RAM 27040 27040 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 981314 981314 0 0.0
RAM 24780 24780 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 822260 822260 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 832072 832072 0 0.0
RAM 125432 125432 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 778448 778448 0 0.0
RAM 113780 113780 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 762780 762780 0 0.0
RAM 113988 113988 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549026 549026 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 581082 581082 0 0.0
RAM 205440 205440 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 663837 663837 0 0.0
RAM 77324 77324 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 683689 683689 0 0.0
RAM 79964 79964 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 683689 683689 0 0.0
RAM 79964 79964 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 640621 640621 0 0.0
RAM 72392 72392 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623981 623981 0 0.0
RAM 73564 73564 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643617 643617 0 0.0
RAM 76116 76116 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643617 643617 0 0.0
RAM 76116 76116 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 644285 644285 0 0.0
RAM 76588 76588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 663993 663993 0 0.0
RAM 79140 79140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 663993 663993 0 0.0
RAM 79140 79140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620649 620649 0 0.0
RAM 70684 70684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640501 640501 0 0.0
RAM 73316 73316 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640501 640501 0 0.0
RAM 73316 73316 0 0.0
efr32 lock-app BRD4187C FLASH 946756 946756 0 0.0
RAM 132096 132096 0 0.0
BRD4338a FLASH 773544 773536 -8 -0.0
RAM 173328 173328 0 0.0
window-app BRD4187C FLASH 1039560 1039560 0 0.0
RAM 128232 128232 0 0.0
esp32 all-clusters-app c3devkit DRAM 103328 103328 0 0.0
FLASH 1806256 1806256 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121932 121932 0 0.0
FLASH 1771270 1771270 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2782919 2782919 0 0.0
RAM 114680 114680 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6336638 6336638 0 0.0
RAM 537624 537624 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5440898 5440898 0 0.0
RAM 224616 224616 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4757302 4757302 0 0.0
RAM 204272 204272 0 0.0
camera-app debug unknown 8856 8856 0 0.0
FLASH 6892187 6892187 0 0.0
RAM 226448 226448 0 0.0
camera-controller debug unknown 9240 9240 0 0.0
FLASH 14317099 14317099 0 0.0
RAM 663280 663280 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14604557 14604557 0 0.0
RAM 650032 650032 0 0.0
chip-tool-ipv6only arm64 unknown 40328 40328 0 0.0
FLASH 12582272 12582272 0 0.0
RAM 696336 696336 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12676169 12676169 0 0.0
RAM 649392 649392 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4574310 4574310 0 0.0
RAM 190312 190312 0 0.0
fabric-sync debug unknown 5064 5064 0 0.0
FLASH 5714789 5714789 0 0.0
RAM 491032 491032 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5643841 5643841 0 0.0
RAM 207288 207288 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4817146 4817146 0 0.0
RAM 194520 194520 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4437058 4437058 0 0.0
RAM 183752 183752 0 0.0
ota-requestor-app debug unknown 4800 4800 0 0.0
FLASH 4564858 4564858 0 0.0
RAM 187656 187656 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3078572 3078572 0 0.0
RAM 148072 148072 0 0.0
thermostat-no-ble arm64 unknown 9576 9576 0 0.0
FLASH 4229040 4229040 0 0.0
RAM 231024 231024 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6071957 6071957 0 0.0
RAM 615680 615680 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12792397 12792397 0 0.0
RAM 770120 770120 0 0.0
nxp contact k32w0+release FLASH 592400 592400 0 0.0
RAM 72848 72848 0 0.0
mcxw71+release FLASH 624648 624648 0 0.0
RAM 63188 63188 0 0.0
light k32w0+release FLASH 618340 618340 0 0.0
RAM 72144 72144 0 0.0
k32w1+release FLASH 709120 709120 0 0.0
RAM 72036 72036 0 0.0
lock mcxw71+release FLASH 774176 774176 0 0.0
RAM 67612 67612 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1666052 1666052 0 0.0
RAM 212328 212328 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1570564 1570564 0 0.0
RAM 208504 208504 0 0.0
light cy8ckit_062s2_43012 FLASH 1447820 1447820 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1477668 1477668 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 667780 667780 0 0.0
RAM 105200 105200 0 0.0
lock-app qpg6105+debug FLASH 626184 626184 0 0.0
RAM 99820 99820 0 0.0
stm32 light STM32WB5MM-DK FLASH 466620 466620 0 0.0
RAM 141504 141504 0 0.0
telink bridge-app tl7218x FLASH 694024 677290 -16734 -2.4
RAM 101832 90692 -11140 -10.9
light-app-ota-compress-lzma-factory-data tl3218x FLASH 774656 774656 0 0.0
RAM 50072 50072 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 771772 771772 0 0.0
RAM 40372 40372 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 781762 760228 -21534 -2.8
RAM 109252 97492 -11760 -10.8
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 703140 687266 -15874 -2.3
RAM 62572 51540 -11032 -17.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 741094 715716 -25378 -3.4
RAM 85752 73360 -12392 -14.5
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 713044 713044 0 0.0
RAM 36996 36996 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 608060 608518 458 0.1
RAM 119468 106748 -12720 -10.6
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 817024 795234 -21790 -2.7
RAM 107520 96348 -11172 -10.4
tizen all-clusters-app arm unknown 5188 5188 0 0.0
FLASH 1809944 1809944 0 0.0
RAM 94656 94656 0 0.0
chip-tool-ubsan arm unknown 20600 20600 0 0.0
FLASH 20843606 20843606 0 0.0
RAM 9071080 9071080 0 0.0
kiel-apple rvc example: additional Operational States
18e966af
kiel-apple rvc example: additional Operational State Errors
492f7d73
restyled-commits Restyled by clang-format
59f2b35e
kiel-apple kiel-apple force pushed from d5ef616b to 59f2b35e 6 days ago
github-actions
kiel-apple kiel-apple marked this pull request as ready for review 6 days ago
kiel-apple kiel-apple marked this pull request as draft 6 days ago
kiel-apple kiel-apple marked this pull request as ready for review 6 days ago
kiel-apple
kiel-apple commented on 2025-05-23
Conversation is marked as resolved
Show resolved
examples/rvc-app/rvc-common/src/rvc-device.cpp
269269
270void RvcDevice::HandleEmptyingDustBinMessage()
271{
272
 // TODO: should we only allow this transition while we are docked?
kiel-apple5 days ago

working to find out more about desired constraints here.

kiel-apple1 day ago

update: we do not need to constrain this transition; the spec does not say anything about such a constraint, and devices may vary in how they represent the transition.

kiel-apple add handlers / named pipe commands for setting new operational states
b54da4d3
kiel-apple kiel-apple force pushed from 63d66bdd to b54da4d3 5 days ago
github-actions
kiel-apple new operational states need not constrain based on prior operational …
95e3b47d
woody-apple
woody-apple approved these changes on 2025-05-28
kiel-apple kiel-apple removed review request from hicklin hicklin 7 hours ago
kiel-apple kiel-apple removed review request from plauric plauric 7 hours ago
kiel-apple kiel-apple requested a review from hicklin hicklin 7 hours ago
kiel-apple kiel-apple requested a review from plauric plauric 7 hours ago
kiel-apple kiel-apple requested a review from andy31415 andy31415 7 hours ago
kiel-apple kiel-apple requested a review from cecille cecille 7 hours ago
kiel-apple kiel-apple requested a review from bzbarsky-apple bzbarsky-apple 7 hours ago
kiel-apple kiel-apple requested a review from jtrejoespinoza-grid jtrejoespinoza-grid 7 hours ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
examples review - pending
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum