xla
Updating the API guide with a few more pitfalls.
#1059

Merged

Updating the API guide with a few more pitfalls. #1059

taylanbil merged 9 commits into pytorch:master from taylanbil:pitfalls

added some pitfalls

a768ddff

bulleting correct

5e53f4b3

made code block python

a5d6a472

taylanbil requested a review from

asuhan 6 years ago

taylanbil requested a review from

dlibenzi 6 years ago

taylanbil commented on 2019-09-17

asuhan requested changes on 2019-09-17

dlibenzi commented on 2019-09-17

Instead of `xm.mark_step`, mention `barrier=True`.

096daac1

Added barrier=True in the markdown as well as the code block.

5a200304

Address Alex s comments.

5862c186

"There is no steps" corrected to "There are no steps."

87edc04f

taylanbil changed the title ~~added some pitfalls~~ Updating the API guide with a few more pitfalls 6 years ago

taylanbil changed the title ~~Updating the API guide with a few more pitfalls~~ Updating the API guide with a few more pitfalls. 6 years ago

taylanbil requested a review from

asuhan 6 years ago

taylanbil requested a review from

dlibenzi 6 years ago

dlibenzi requested changes on 2019-09-18

Addressing Davide s comments.

e94db3c7

dlibenzi requested a review from

ailzhang 6 years ago

dlibenzi approved these changes on 2019-09-18

ailzhang approved these changes on 2019-09-18

asuhan commented on 2019-09-18

Inlined torch.where per suggestion.

c0bc8656

taylanbil merged 9be6d100 into master 6 years ago

taylanbil deleted the pitfalls branch 6 years ago

Reviewers

dlibenzi

ailzhang

asuhan

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

xla Updating the API guide with a few more pitfalls. #1059 Merged

Updating the API guide with a few more pitfalls. #1059

xla
Updating the API guide with a few more pitfalls.
#1059

Merged