PR #4026 Add "getDynamicValue" for SizeAdd node.

Add "getDynamicValue" for SizeAdd node. #4026

JackCaoG merged 8 commits into master from getDynamicValueForSizeAddNode

vanbasten23 force pushed from 9b1f5703 to 6c121bda 3 years ago

vanbasten23 marked this pull request as ready for review 3 years ago

vanbasten23 requested a review from

JackCaoG 3 years ago

vanbasten23 requested a review from

Krovatkin 3 years ago

vanbasten23 requested a review from

miladm 3 years ago

vanbasten23 added dynamism

Krovatkin commented on 2022-09-22

Krovatkin approved these changes on 2022-09-22

added the failing test.

043e2c4d

Implement getDynamicValue and the test passes.

07c1a2f4

uses the common function

d8798486

remove unnecessary typo

8cf1d01b

reformated.

fa30f5f8

vanbasten23 force pushed from b3c0a6e5 to fa30f5f8 3 years ago

miladm approved these changes on 2022-09-23

miladm assigned

vanbasten23 3 years ago

rebased from origin master

1ded16b6

Add a new test in response to a pr comment.

f55dbd6e

reformated.

c9648743

JackCaoG approved these changes on 2022-09-23

JackCaoG merged 72244be8 into master 3 years ago

miladm commented on 2022-09-25

Reviewers

miladm

JackCaoG

Krovatkin

Assignees

vanbasten23

Labels

dynamism

Milestone

No milestone

xla Add "getDynamicValue" for SizeAdd node. #4026 Merged

Add "getDynamicValue" for SizeAdd node. #4026

xla
Add "getDynamicValue" for SizeAdd node.
#4026

Merged