Fix clear counter #4143
JackCaoG
merged
3 commits into
master
from
fix_clear_counter
Fix clear counter
b92cff21
Fix metrics
627ccba6
alanwaketan
approved these changes
on 2022-11-01
alanwaketan2 years ago
LGTM.
linter
c3a3a69f
Login to write a write a comment.
My previous implementation clear the
vector<CounterData>andvector<MetricsData>directly, but this is incorrect. Counters and Metrics and declared as static variable in different places of code, and won't get recreated if being deleted. What we can do is to reset the value of those counters and make sure they don't show up in report if value is zero. Added additional test to account for this case.