xla
[FSDP] Fix pre-hook check when module is only used in forward
#4670
Merged

[FSDP] Fix pre-hook check when module is only used in forward #4670

alanwaketan merged 4 commits into pytorch:master from zachzzc:fix_fsdp
zachzzc
JackCaoG JackCaoG requested a review from ronghanghu ronghanghu 3 years ago
ronghanghu
alanwaketan
zachzzc zachzzc force pushed from e9824004 to e55b0ff7 2 years ago
Avoid pre-hook check when module is only used in forward
124e370e
Resolve comments
c43a5a53
zachzzc zachzzc force pushed from e55b0ff7 to c43a5a53 2 years ago
zachzzc
alanwaketan
alanwaketan commented on 2023-03-02
Fix eval mode error
6ea994fb
zachzzc zachzzc changed the title [FSDP] Avoid pre-hook check when module is only used in forward [FSDP] Fix pre-hook check when module is only used in forward or in eval mode 2 years ago
ronghanghu
ronghanghu commented on 2023-03-04
Revert eval mode change
1b65fc1d
alanwaketan
alanwaketan approved these changes on 2023-03-04
zachzzc zachzzc changed the title [FSDP] Fix pre-hook check when module is only used in forward or in eval mode [FSDP] Fix pre-hook check when module is only used in forward 2 years ago
zachzzc
ronghanghu
ronghanghu approved these changes on 2023-03-07
alanwaketan alanwaketan merged 50141f2e into master 2 years ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone