xla
[FSDP] Fix pre-hook check when module is only used in forward
#4670

Merged

[FSDP] Fix pre-hook check when module is only used in forward #4670

alanwaketan merged 4 commits into pytorch:master from zachzzc:fix_fsdp

JackCaoG requested a review from

ronghanghu 3 years ago

zachzzc force pushed from e9824004 to e55b0ff7 3 years ago

Avoid pre-hook check when module is only used in forward

124e370e

Resolve comments

c43a5a53

zachzzc force pushed from e55b0ff7 to c43a5a53 3 years ago

alanwaketan commented on 2023-03-02

Fix eval mode error

6ea994fb

zachzzc changed the title ~~[FSDP] Avoid pre-hook check when module is only used in forward~~ [FSDP] Fix pre-hook check when module is only used in forward or in eval mode 3 years ago

ronghanghu commented on 2023-03-04

Revert eval mode change

1b65fc1d

alanwaketan approved these changes on 2023-03-04

zachzzc changed the title ~~[FSDP] Fix pre-hook check when module is only used in forward or in eval mode~~ [FSDP] Fix pre-hook check when module is only used in forward 3 years ago

ronghanghu approved these changes on 2023-03-07

alanwaketan merged 50141f2e into master 3 years ago

Reviewers

ronghanghu

alanwaketan

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

xla [FSDP] Fix pre-hook check when module is only used in forward #4670 Merged

[FSDP] Fix pre-hook check when module is only used in forward #4670

xla
[FSDP] Fix pre-hook check when module is only used in forward
#4670

Merged