xla
Re-implement `ComputationClient::WaitDeviceOps`
#5811

Merged

Re-implement `ComputationClient::WaitDeviceOps` #5811

will-cromar merged 19 commits into master from wcromar/operation-tracker

Replace device_locks_

19c8f79c

will-cromar added runtime

block new ops while waiting

ac0fef6b

get lock before notifying cv

e242f014

Hold onto device locks until wait is complete

d33c25db

formatting

64cd7d39

shared_ptr -> unique_ptr

9916010e

remove lock_device

3f244c9c

construct counter inplace

3506ce5f

improve logging

c717be02

make operation_tracker private

edc92706

will-cromar changed the title ~~Replace `ComputationClient::device_locks_`~~ Re-implement `ComputationClient::WaitDeviceOps` 1 year ago

formatting

b8328fa9

Comments

2a31035a

absl span

a8462d59

will-cromar requested a review from

alanwaketan 1 year ago

will-cromar requested a review from

JackCaoG 1 year ago

will-cromar marked this pull request as ready for review 1 year ago

yeounoh requested a review from

yeounoh 1 year ago

yeounoh commented on 2023-11-17

yeounoh approved these changes on 2023-11-17

address review comments

77f4b148

JackCaoG commented on 2023-11-20

JackCaoG approved these changes on 2023-11-20

remove comment

60773c1d

actually make a vector for `returned_futures`

4da19d3d

Revert "address review comments"

93a392d3

naming

61275b78

correct comment

314c9e08

will-cromar requested a review from

JackCaoG 1 year ago

JackCaoG approved these changes on 2023-11-21

will-cromar merged 175e86b8 into master 1 year ago

Reviewers

JackCaoG

yeounoh

alanwaketan

Assignees

No one assigned

Labels

runtime

Milestone

No milestone

xla Re-implement `ComputationClient::WaitDeviceOps` #5811 Merged

Re-implement `ComputationClient::WaitDeviceOps` #5811

xla
Re-implement `ComputationClient::WaitDeviceOps`
#5811

Merged