PR #593 Fix s_copy_ and indexing types

Fix s_copy_ and indexing types #593

dlibenzi merged 3 commits into master from asuhan/fix_s_copy_dest_type

asuhan requested a review from

ailzhang 6 years ago

asuhan requested a review from

dlibenzi 6 years ago

ailzhang approved these changes on 2019-04-13

dlibenzi requested changes on 2019-04-13

asuhan force pushed from 6ecf3859 to 0deaba56 6 years ago

asuhan force pushed from 0deaba56 to 45cee765 6 years ago

asuhan force pushed from 45cee765 to 8145692e 6 years ago

dlibenzi requested changes on 2019-04-14

Fix s_copy_ and indexing types

510cb249

Add more shape checks

3d871271

Add tests for index with integer base

1d3907fe

asuhan force pushed from 8145692e to 1d3907fe 6 years ago

dlibenzi approved these changes on 2019-04-14

dlibenzi merged c58c087c into master 6 years ago

asuhan deleted the asuhan/fix_s_copy_dest_type branch 6 years ago

Reviewers

dlibenzi

ailzhang

Assignees

No one assigned

Labels

None yet

Milestone

No milestone