xla
ErrorHandling: make `GetComputationClient()` return `StatusOr<T>` type.
#9384
Merged

ErrorHandling: make `GetComputationClient()` return `StatusOr<T>` type. #9384

ysiraichi
ysiraichi ysiraichi requested a review from ghpvnist ghpvnist 98 days ago
ysiraichi ysiraichi requested a review from zhanyong-wan zhanyong-wan 98 days ago
ghpvnist
ghpvnist requested changes on 2025-06-18
ysiraichi ysiraichi force pushed from 391d353e to 3344bb06 98 days ago
ysiraichi
zhanyong-wan
zhanyong-wan requested changes on 2025-06-18
ghpvnist
ghpvnist requested changes on 2025-06-18
ysiraichi
ghpvnist
ysiraichi Handle `Status` return value.
3359fa6b
ysiraichi Inline.
45f4ba65
ysiraichi Rename to `GetComputationClientOrDie()`.
3c030bea
ysiraichi Fix lint.
4ecb8c1d
ysiraichi Address reviews.
73f1b03c
ysiraichi Call value() directly.
8cacb84f
ysiraichi Create test + fix.
74911988
ysiraichi Centralize `Status` exception throw.
7e0da022
ysiraichi ysiraichi force pushed from a351a69f to 7e0da022 97 days ago
ysiraichi Add test to run_test.sh.
31863a87
zhanyong-wan
zhanyong-wan
zhanyong-wan requested changes on 2025-06-20
ysiraichi Fix tests + make trivially destructible static variable.
22bf7767
ysiraichi Fix lint.
f60315b7
ysiraichi
zhanyong-wan
ysiraichi
zhanyong-wan
zhanyong-wan approved these changes on 2025-06-23
ysiraichi Remove test, and simplify implementation.
387fa4dc
ysiraichi Remove test in csrc directory.
bdc4c128
ysiraichi Make bool variable not static.
143dd958
zhanyong-wan
zhanyong-wan approved these changes on 2025-06-23
ysiraichi Remove nullptr check.
2a72d5a0
ysiraichi ysiraichi requested a review from ghpvnist ghpvnist 92 days ago
zhanyong-wan
zhanyong-wan approved these changes on 2025-06-24
ghpvnist
ghpvnist approved these changes on 2025-06-24
ysiraichi ysiraichi merged 10ed5547 into master 92 days ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone