readthedocs.org
Build: Simplify and optimize git backend: New clone+fetch pattern
#10430
Merged
Overview
Commits
60
Changes
View On GitHub

Build: Simplify and optimize git backend: New clone+fetch pattern #10430

humitos merged 60 commits into main from feature/git-clone-fetch-checkout
benjaoming
benjaoming New git clone/fetch/checkout behavior first steps
f8f35acc
benjaoming Use `identifier` argument for `.update()`, add lots of comments for f…
9d616f05
benjaoming benjaoming force pushed from 64478503 to 9d616f05 2 years ago
benjaoming
benjaoming Add missing str() cast
614963dc
benjaoming Remove the `identifier` keyword since we are forced to use verbose_na…
82178a37
benjaoming Revert "Remove the `identifier` keyword since we are forced to use ve…
a45b42b1
benjaoming We need the identifier for branches, but not for tags and PRs
746d94ba
benjaoming Update some comments after noticing how `Build.identifier/.verbose_na…
b3af824a
benjaoming benjaoming force pushed from 4c1fe9b7 to b3af824a 2 years ago
benjaoming
benjaoming Merge branch 'main' of github.com:readthedocs/readthedocs.org into fe…
1f538b65
benjaoming lint
04f3caf6
humitos
humitos commented on 2023-06-14
humitos
benjaoming
benjaoming Revert "Revert "Remove the `identifier` keyword since we are forced t…
2f8d346f
benjaoming Use version_identifier as an instance property
c634ca41
benjaoming Update readthedocs/vcs_support/backends/git.py
6725dbbc
benjaoming Updates to return values, comments and logging
e186e7fb
benjaoming Merge branch 'feature/git-clone-fetch-checkout' of github.com:readthe…
7fcf9378
benjaoming Restore common
8d13787c
benjaoming Stop fetching --tags and fetch the direct remote reference
a41e3526
benjaoming Appease linter: Use raise-from pattern
0cb043a9
benjaoming Hello darker my old friend
e9322df1
benjaoming Restore error handling for clone operation
b6ba466e
benjaoming Update a few comments, add a bit more raise-from pattern (actually tr…
230e04f0
benjaoming WIP: refine some comments, log calls and small things while testing l…
e3fcbf50
humitos
humitos commented on 2023-06-19
benjaoming New test class with Feature flag defined
abf41b96
benjaoming Adds a tearDown method after discovering that tests were wrongly pass…
c2b3d440
benjaoming Merge branch 'main' of github.com:readthedocs/readthedocs.org into fe…
84492ad5
benjaoming Log a warning if we aren't specifying the version type when using Git…
95878448
benjaoming Update test cases for new git clone+fetch pattern
9dbc8c3a
benjaoming Git fetch change: Fetch branches to :refs/remotes/origin/<branch-name…
d8cbc50b
benjaoming Overwrite tests to call clone_ng and fetch_ng, and rewrite some entirely
15eab05b
benjaoming Update update() docstring
c5abe46f
benjaoming Always use lsremote for GIT_CLONE_FETCH_CHECKOUT_PATTERN
577bf51a
benjaoming Builds need to know about Version.machine=True for tags "stable" so t…
b507d02f
benjaoming Conditionally log a warning on stable versions
52f071c1
benjaoming linting
693eef99
benjaoming
benjaoming add "machine" to version API test case
bd98bf60
benjaoming Use "refspec" terminology more consistently
21dd16ec
benjaoming Add test case for un-named default branches
b1cea441
benjaoming Don't have "--no-checkout" when we *need* to checkout the remote HEAD
2eba2f55
benjaoming Add test case to verify that we can clone+fetch special tag "stable" …
176f8023
benjaoming benjaoming marked this pull request as ready for review 2 years ago
benjaoming benjaoming requested a review 2 years ago
benjaoming benjaoming requested a review from stsewd stsewd 2 years ago
auto-assign auto-assign assigned benjaoming benjaoming 2 years ago
humitos
humitos commented on 2023-06-20
humitos
humitos commented on 2023-06-20
benjaoming
humitos
humitos commented on 2023-06-20
benjaoming benjaoming marked this pull request as draft 2 years ago
benjaoming Update readthedocs/vcs_support/backends/git.py
4191e11e
benjaoming Remove unused logging
acb7dd98
benjaoming Use `git fetch <commit hash>` for special "stable" versions
3fe74867
benjaoming Building an unnamed default branch now skips `git fetch`
33fa7dab
benjaoming Remove unnecessary logging, add a lot of comments to tests
6431c003
benjaoming
benjaoming commented on 2023-06-20
benjaoming benjaoming marked this pull request as ready for review 2 years ago
humitos
humitos commented on 2023-06-20
benjaoming
benjaoming commented on 2023-06-22
benjaoming Apply suggestions from @humitos code review
e42f902f
jcfr
benjaoming Update readthedocs/projects/models.py
c573736e
benjaoming Always clean up the presumed repo working dir after a test case
4343fcf5
benjaoming Move `machine` to `VersionAdminSerializer`
f02c8ff6
benjaoming Add precision to comment
ae064b8c
benjaoming Use identifier and verbose_name that looks more like actual data woul…
2f3e6ca3
benjaoming remove unused local reference in git fetch for "stable" tag
f2fc2b0c
benjaoming Don't use --no-checkout, just checkout whatever is at the FETCH_HEAD
6628d4fd
benjaoming Add more logging
5d5a6f59
benjaoming Update comment
85ac0e42
stsewd
stsewd commented on 2023-06-26
benjaoming Fix logic condition: Always include `vcs_repository.supports_lsremote`
f1d426b3
benjaoming Log a warning when we try to generate a pr/mr refspec for an unsuppor…
19eb2823
benjaoming improve doc strings
5b104008
benjaoming Merge branch 'main' of github.com:readthedocs/readthedocs.org into fe…
b007df93
benjaoming Remove TestGitBackendTwiceInARow
a2d7223b
benjaoming
benjaoming Use real commit hash in test case
41e1f09d
humitos Merge branch 'main' of github.com:readthedocs/readthedocs.org into fe…
98597f21
humitos
humitos humitos enabled auto-merge (squash) 2 years ago
humitos
humitos approved these changes on 2023-07-10
humitos humitos merged 1add44a6 into main 2 years ago
humitos humitos deleted the feature/git-clone-fetch-checkout branch 2 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum