pytorch
2beb57a8 - Add `-Werror=non-virtual-dtor` (reland) (#81012)

Commit
2 years ago
Add `-Werror=non-virtual-dtor` (reland) (#81012) This PR relands #80584, but instead of adding suppression in CMakeLists.txt suppresses it directly in `llvm_codegen.cpp` and just for a single header. In general, it's better to avoid `set_target_properties` pattern for suppressing warnings, as it makes build brittle and hard to debug/understand Test plan: wait for `ciflow/binaries_wheel` to finish Pull Request resolved: https://github.com/pytorch/pytorch/pull/81012 Approved by: https://github.com/huydhn, https://github.com/kit1980
Author
Committer
Parents
Loading