pytorch
5efdcd58 - Handle long Docker image name when building Docker image (#103562)

Commit
2 years ago
Handle long Docker image name when building Docker image (#103562) After https://github.com/pytorch/pytorch/pull/102562, the `IMAGE_NAME` input to `.ci/docker/build_docker.sh` now accepts the name in the following two formats: * Short form, like `pytorch-linux-bionic-py3.11-clang9` * Or long form, like `308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-py3.11-clang9` This PR updates the build script to handle both cases. This bug was discovered when I saw the wrong image name in https://github.com/pytorch/pytorch/actions/runs/5261424181/jobs/9509633110. ### Testing Verify that the long form is handled correctly ``` export IMAGE_NAME=308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-py3.8-gcc7:06fdf1facf0eef5e5f303dd9cfac8639fb5f9201 export DOCKER_TAG=06fdf1facf0eef5e5f303dd9cfac8639fb5f9201 ./build_docker.sh + tag=06fdf1facf0eef5e5f303dd9cfac8639fb5f9201 + registry=308535385114.dkr.ecr.us-east-1.amazonaws.com + [[ 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-py3.8-gcc7:06fdf1facf0eef5e5f303dd9cfac8639fb5f9201 == *\3\0\8\5\3\5\3\8\5\1\1\4\.\d\k\r\.\e\c\r\.\u\s\-\e\a\s\t\-\1\.\a\m\a\z\o\n\a\w\s\.\c\o\m\/\p\y\t\o\r\c\h\/* ]] ++ echo pytorch-linux-focal-py3.8-gcc7:06fdf1facf0eef5e5f303dd9cfac8639fb5f9201 ++ awk -F '[:,]' '{print $1}' + EXTRACTED_IMAGE_NAME=pytorch-linux-focal-py3.8-gcc7 + IMAGE_NAME=pytorch-linux-focal-py3.8-gcc7 + image=308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-py3.8-gcc7 + [[ -z '' ]] + retry login 308535385114.dkr.ecr.us-east-1.amazonaws.com + login 308535385114.dkr.ecr.us-east-1.amazonaws.com + aws ecr get-authorization-token --region us-east-1 --output text --query 'authorizationData[].authorizationToken' + base64 -d + cut -d: -f2 + docker login -u AWS --password-stdin 308535385114.dkr.ecr.us-east-1.amazonaws.com ``` Pull Request resolved: https://github.com/pytorch/pytorch/pull/103562 Approved by: https://github.com/PaliC
Author
Committer
Parents
Loading