pytorch
7ec43920 - Remove in-place operations in NegativeBinomial (#96748)

Commit
1 year ago
Remove in-place operations in NegativeBinomial (#96748) This is a suggestion for a minor modification. The line `log_normalization[self.total_count + value == 0.] = 0.` prevents Jit compilation when the condition occurs, with the error message `RuntimeError: a view of a leaf Variable that requires grad is being used in an in-place operation.` I propose an alternative that does not involve in-place operations. It uses the function `nan_to_num()` to replace infinite values by 0 where `self.total_count + value == 0.` while leaving `nan` and `-inf` as they are. Readability is suboptimal because the code does not replace nan with numbers, but I could not find a function that only replaces infinite values. Pull Request resolved: https://github.com/pytorch/pytorch/pull/96748 Approved by: https://github.com/fritzo, https://github.com/soulitzer
Author
Committer
Parents
Loading