pytorch
8da704cd - [MPS] Remove incorrect asserts from `Copy.mm` (#86184)

Commit
2 years ago
[MPS] Remove incorrect asserts from `Copy.mm` (#86184) Those asserts simply do not work for views. I.e. they are erroneously triggered for in `copy_to_mps_` when running something like `python -c "import torch;x=torch.empty(10,device='mps');y=torch.tensor([10]);print(x.shape);x[2]=y[0]"` And in `copy_from_mps_` when running the same script, but with order of devices inverted: `python -c "import torch;x=torch.empty(10);y=torch.tensor([10], device="mps");print(x.shape);x[2]=y[0]"` If this was supposed to be a boundary check, than it should have validated, that `storage_offset() + nbytes() <= storage.nbytes()`, but this check is already done by the upper layer, isn't it? Fixes https://github.com/pytorch/pytorch/issues/86153 Pull Request resolved: https://github.com/pytorch/pytorch/pull/86184 Approved by: https://github.com/kulinseth
Author
Committer
Parents
Loading