pytorch
f1a13569 - [ROCm] Enable/fix unit tests test_stream_args and test_event_args (#82346)

Commit
3 years ago
[ROCm] Enable/fix unit tests test_stream_args and test_event_args (#82346) ### Description Removed some stubbed out code that was necessary for ROCm builds to support JIT compilation of Event and Stream classes. Original motivation for the code to be stubbed out in the ROCm case was likely due to this pull request: https://github.com/pytorch/pytorch/pull/48020 In this PR, the include statement at the at the top of cuda.h was incorrectly pointed to aten/src/ATen/cuda/CUDAEvent.h when it should have been set to ATen/cuda/CUDAEvent.h. This error caused the hipification process of build_amd.py to not hipify this include statement correctly, causing errors. The include statement in question was subsequently fixed in the following commit: https://github.com/pytorch/pytorch/commit/acd072967a950dc2415a70dfa96e6437237912a9 This PR re-introduces the stubbed out code to the ROCm build and "unskips" the associated unit tests. ### Testing Note: bullets prepended by ROCm were tested on systems with AMD GPUs while the others were tested with NVIDIA GPUs. - apply commit - (ROCm)`python tools/amd_build/build_amd.py` - `python setup.py develop` - (ROCm)`PYTORCH_TEST_WITH_ROCM=1 python test/test_jit.py TestCUDA.test_event_args` - (ROCm)`PYTORCH_TEST_WITH_ROCM=1 python test/test_jit.py TestCUDA.test_stream_args` - `python test/test_jit.py TestCUDA.test_event_args` - `python test/test_jit.py TestCUDA.test_stream_args` - Confirm tests pass in all scenarios Pull Request resolved: https://github.com/pytorch/pytorch/pull/82346 Approved by: https://github.com/malfet
Author
Committer
Parents
Loading