swift
71697c37 - Allow implicit self in escaping closures when self usage is unlikely to cause cycle (#23934)

Commit
6 years ago
Allow implicit self in escaping closures when self usage is unlikely to cause cycle (#23934) * WIP implementation * Cleanup implementation * Install backedge rather than storing array reference * Add diagnostics * Add missing parameter to ResultFinderForTypeContext constructor * Fix tests for correct fix-it language * Change to solution without backedge, change lookup behavior * Improve diagnostics for weak captures and captures under different names * Remove ghosts of implementations past * Address review comments * Reorder member variable initialization * Fix typos * Exclude value types from explicit self requirements * Add tests * Add implementation for AST lookup * Add tests * Begin addressing review comments * Re-enable AST scope lookup * Add fixme * Pull fix-its into a separate function * Remove capturedSelfContext tracking from type property initializers * Add const specifiers to arguments * Address review comments * Fix string literals * Refactor implicit self diagnostics * Add comment * Remove trailing whitespace * Add tests for capture list across multiple lines * Add additional test * Fix typo * Remove use of ?: to fix linux build * Remove second use of ?: * Rework logic for finding nested self contexts
Author
Committer
Parents
Loading