swift
Allow implicit self in escaping closures when self usage is unlikely to cause cycle
#23934

Merged

Allow implicit self in escaping closures when self usage is unlikely to cause cycle #23934

theblixguy merged 37 commits into swiftlang:master from Jumhyn:implicit-self-capture

beccadax added swift evolution pending discussion

Jumhyn force pushed 6 years ago

gregomni commented on 2019-07-29

Jumhyn commented on 2019-08-04

WIP implementation

1555a1f9

Cleanup implementation

43dd8578

Install backedge rather than storing array reference

1d3c2d66

Add diagnostics

adf6589e

Add missing parameter to ResultFinderForTypeContext constructor

48047259

Fix tests for correct fix-it language

509036a4

Change to solution without backedge, change lookup behavior

18b31c77

Improve diagnostics for weak captures and captures under different names

3b358918

Remove ghosts of implementations past

df5f6a1f

Jumhyn force pushed to df5f6a1f 6 years ago

beccadax requested changes on 2019-08-13

beccadax commented on 2019-08-13

Address review comments

6c657fbd

Merge remote-tracking branch 'origin/master' into implicit-self-capture

7406101f

Reorder member variable initialization

638a6218

Fix typos

05d79f82

Exclude value types from explicit self requirements

84f61311

beccadax requested changes on 2019-10-02

Merge remote-tracking branch 'origin/master' into implicit-self-capture

a5d7da0d

Add tests

a7e7d199

Add implementation for AST lookup

9eb87a5f

Add tests

898f6c2e

Jumhyn requested a review from

beccadax 6 years ago

Jumhyn changed the title ~~Allow implicit self in escaping closures when self is explicitly captured~~ Allow implicit self in escaping closures when self usage is unlikely to cause cycle 6 years ago

davidungar assigned

davidungar 6 years ago

beccadax commented on 2019-10-17

davidungar requested changes on 2019-10-17

Jumhyn commented on 2019-10-17

Begin addressing review comments

93be3a91

Re-enable AST scope lookup

fa779772

Merge remote-tracking branch 'origin/master' into implicit-self-capture

6ccc6d00

Add fixme

84363aa6

Pull fix-its into a separate function

89dd8425

Remove capturedSelfContext tracking from type property initializers

2a27245a

Jumhyn requested a review from

davidungar 6 years ago

Jumhyn requested a review from

beccadax 6 years ago

Add const specifiers to arguments

c897186a

davidungar requested changes on 2019-10-19

Address review comments

f8856f88

davidungar approved these changes on 2019-10-20

Fix string literals

48f63f45

Refactor implicit self diagnostics

9a72c14a

Add comment

2806afbf

Remove trailing whitespace

29056109

Add tests for capture list across multiple lines

72466037

Add additional test

d191ac25

Fix typo

b9f95890

Remove use of ?: to fix linux build

20cb90e3

Remove second use of ?:

ddd1ce8b

tkremenek removed swift evolution pending discussion

theblixguy added swift evolution approved

Merge remote-tracking branch 'origin/master' into implicit-self-capture

0b073126

Rework logic for finding nested self contexts

558c942b

beccadax approved these changes on 2019-12-18

theblixguy merged 71697c37 into master 6 years ago

Reviewers

beccadax

davidungar

gregomni

paiv

Assignees

davidungar

Labels

swift evolution approved

Milestone

No milestone

swift Allow implicit self in escaping closures when self usage is unlikely to cause cycle #23934 Merged

Allow implicit self in escaping closures when self usage is unlikely to cause cycle #23934

swift
Allow implicit self in escaping closures when self usage is unlikely to cause cycle
#23934

Merged