swift
[swift-4.0-branch][overlay] Fix Foundation extensions to Substring
#12300

Merged

[swift-4.0-branch][overlay] Fix Foundation extensions to Substring #12300

moiseev merged 1 commit into swiftlang:swift-4.0-branch from moiseev:ns-substring-4

moiseev7 years ago

Explanation: Fixes the NSStringAPIs on Substring that accept or return a range
Scope: When a substring gets bridged to NSString, it loses the initial offset,
therefore APIs that accept or return StringIndex ranges should handle
this case explicitly by adding/subtracting the substring start offset.
Risk: Minimal
Reviewed By: Philippe Hausler
Testing: Automated test suite + extra test cases
Directions for QA: N/A
Radar: rdar://problem/33873277

[overlay] Fix Foundation extensions to Substring

3e4a9d86

moiseev7 years ago

@swift-ci Please test

moiseev merged 31cb83a1 into swift-4.0-branch 7 years ago

moiseev deleted the ns-substring-4 branch 7 years ago

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone