Applying API guidelines to The Standard Library #1607
moiseev
merged
353 commits into
master
from
swift-3-api-guidelines
fixing validation tests
fc65e676
moving `unsafeUnwrap` into `Optional`
ee7d55f7
Fixing tests
a28a5104
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
3fe0c60d
Merge remote-tracking branch 'origin/swift-3-api-guidelines' into swi…
f245f18a
Clang importer: use lookup table version number in the module file ex…
3969ed2a
fixing tests after merge
9f099344
Omit needless words: fix 1_stdlib/NSObject.swift test to use remapped…
fa9792bd
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
824088a0
Collection.count => .length
73ce9ae7
Repeat => Repeated
86f12588
var Repeated.length => let
33bda61f
Repeated(repeating:length:) => repeatElement(_:count:)
15a96490
countStrings() => digits() in docs and tests
9096a960
String.lowercaseString and .uppercaseString => lowercased and uppercased
e7d516e5
fixing validation tests
9d875551
Remove ImplicitlyUnwrappedOptional.{map,flatMap}
11855e40
Remove no-arg initializers from Optional and IOU
6b2ad53f
Remove IOU(Wrapped?) initializer, we prefer to use the implicit conve…
fef2d5db
public class VaListBuilder => internal class _VaListBuilder
4cd48e0f
StaticString.stringValue => String.init(_:T)
a97a0ddf
UnicodeDecodingResult: case Result(...) => case ScalarValue(...)
6eedc990
ObjectIdentifier.uintValue => {Int,UInt}.init(_: ObjectIdentifier)
b580d55d
internal or public // @testable initializers
9e505059
Fix coding style in Stride.swift
9d4d9e8d
Sequence.{min,max}Element() => .min(), .max()
ebb3e458
flatMap(): generic type parameter `Intermediate` => `SegmentOfResult`
156d29a2
change return type of String.fromCStringRepairingIllFormedUTF8
d2be97d8
revisiting CString related String extensions
f4aaece7
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
a97ab6dd
[SIL] Add test case for crash triggered in swift::Parser::parseSILVTa…
49fc8236
Annotate new tests for the --no-assertions build
fa76f200
Fix 80-column violations.
8f56c2a1
Replace tabs with spaces.
564ea394
fixing tests after merge
9607883b
Annotate SIL crash tests for the --no-assertions build
5b89565c
Remove 'REQUIRES: asserts' from fixed crash tests: they don't crash a…
45bec1bc
Extract method to run all function passes over a given function.
b44a5be3
Add frontend option -debug-time-compilation.
b365e27f
Fix another -Wpessimizing-move issue.
fe95ac63
Clang importer: factor out "should this declaration be imported?". NFC
6468863c
Clang importer: use proper Clang context when omitting needless words.
16144876
Merge remote-tracking branch 'origin/swift-3-api-guidelines' into swi…
2091e7f8
Omit needless words requires the use of Swift name lookup tables.
e05ca056
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
cd1c106e
Merge remote-tracking branch 'origin/swift-3-api-guidelines' into swi…
eb90d97d
Merge pull request #648 from apple/swift-3-omit-needless-words
eefada1c
Remove Range<Index> argument from Collection.partition()
5b728dc8
using `expectUnreachable` instead of `expectTrue(false, "")`
f19fc920
Refactoring `Sequence.split` family of methods
30c77a18
removing Collection.split(_ separator: ...) in favor of the one in Se…
514047b6
Remove an unsafeBitCast() that is not actually needed
7a33fb12
Collection.sort() => .sorted()
8f7c9ae3
Collection.sortInPlace() => .sort()
77376883
`stride(to:by:)` => `strideTo(_:by:)`
5498aa19
Revert "removing Collection.split(_ separator: ...) in favor of the o…
ddd45f58
turning UnicodeScalar.isASCII etc into properties
497b3486
Unmanaged<T>.toOpaque() => OpaquePointer.init<T>()
e175a841
reverse() => reversed()
50371821
func isEmptyInput => var isEmptyInput {get}
bbfcab87
func superclassMirror() => var superclassMirror {get}
3ab767a6
func customMirror() => var
117b6539
func customPlaygroundQuickLook() => var
47d48e45
func _unsafeUnwrap() => var _unsafelyUnwrapped
2245f750
String: var lowercased, uppercased => func
f6c00e83
Replace Unmanaged with UnsafeReference
d72932e9
underestimateLength() => underestimatedLength()
b3fcc5fe
func underestimatedLength() => var underestimatedLength { get }
5ccc258f
var Sequence.enumerated => func
06577273
Set: maybeSuperset => possibleSuperset in argument labels
e7b26661
Mirrors: T => Subject
c07056dd
IteratorOverOne.init(_:) => internal
1e26d22d
startsWith(): other => possiblePrefix
7e375df8
cleaning up initializePointee/deinitializePointee, error messages and…
bc942090
Fixing tests
b2277939
Merge remote-tracking branch 'origin' into swift-3-api-guidelines
2f7b64e4
Fixing the build after merge
547b6501
_debugRequire => _stdlibAssert etc.
51865a17
Merge remote-tracking branch 'origin' into swift-3-api-guidelines
a7339e67
Merge remote-tracking branch 'origin' into swift-3-api-guidelines
200be715
Reverting fixits-apply.swift changes applied on merge
9391b0a8
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
f51e708a
Merge branch 'master' into swift-3-api-guidelines
1a38e0ad
[Clang importer] Enable inference of default arguments by default
8674f9d3
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
08e1e4a0
Add unavailable declarations for Swift 2.2 -> 3 migration
74ce1ca7
Merge commit '5e11e3f7287427d386636a169c4065c0373931a8' into swift-3-…
7d70b704
[stdlib] @available attributes for removed APIs
86680ec6
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
9a018bd7
Fix test 'test/SILOptimizer/side-effect.sil'
1852e25e
fixing mention of FloatingPointType in tests
c9a6dca0
Merge remote-tracking branch 'origin/swift-3-api-guidelines' into swi…
a244465e
fixing tests
7c35559a
improving the deprecation attribute message for MutableSliceable
b4d74838
Swift 3 migration: add migration aids for EnumerateSequence
a34a44f6
Rename CollectionDefaultIterator to IndexingIterator
62f73f44
[stdlib] adding init(repeating:length:) to RangeReplaceableCollection
e3bb2a09
[stdlib] optimization for RangeReplaceableCollection.appendContentsOf
744b989f
[stdlib] RangeReplaceable.init with 0 repeated elements optimization
55684269
[stdlib] checking for negative count value in Repeated.init
d00f407a
[stdlib] test for negative count in RangeReplaceableCollection.init
70d346c0
Swift 3 migration: add migration aids for EnumeratedIterator and Enum…
c5d694c4
stdlib: standardize fatalError() messages for unavailable APIs
b371422d
stdlib: standardize fatalError() messages for unavailable APIs
574052f1
stdlib: rename count labels in underscored protocols
f5153572
stdlib: add migration aids for lazy filter collections
3b4248ea
Swift 3 migration: add annotations for MirrorPathType
ed790c8d
[stdlib] making Set conform to SetAlgebra
29b26cf3
Collection.length => .count
9bcd5a10
stdlib comments: remove duplicated punctuation
fa5e4c74
[stdlib] improving RangeReplaceableCollection
59303e23
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
61c83720
Commenting out 'strip NS prefix' functionality for now
bc684879
making Swift build succesfully after the merge
39fdbca8
making tests pass
55fde4c9
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
3a398487
Revert "Replace Unmanaged with UnsafeReference"
a558d13a
stdlib: add first argument labels and some other changes to conform t…
efaa39ea
stdlib: fix coding style
40a31f2d
stdlib: lowercase cases of FloatingPointClassification enum
bf34b047
stdlib: add first argument labels to Set and Dictionary
25cc2d56
wip
624461f2
stdlib: print, debugPrint: 'toStream:' => 'to:'
0e1c488f
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
dd75aed6
stdlib: fix coding style
80fa72ad
stdlib: lowercase cases in Optional and ImplicitlyUnwrappedOptional
65d840c0
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
0f36bec3
stdlib: add first argument label to _failEarlyRangeCheck2()
593b4cc3
stdlib: readLine(stripNewline:) => readLine(strippingNewline:)
f912c8fa
stdlib: remove redundant initializers for HalfOpenInterval and Closed…
52981e87
Fix ClangModules/attr-swift_private.swift
325bc5ac
stdlib: lowercase enum cases in _JoinIteratorState
6c64dcf4
stdlib: joinWithSeparator(_:) => join(separator:)
98561f61
stdlib: fix coding style
9293c1f5
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
f39b443e
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
b90470e2
stdlib: fix coding style
08229b21
stdlib: ManagedBuffer.create(_:) => .create(minimumCapacity:)
f64f0be9
stdlib: lowercase cases of the _DefaultDescendantRepresentation enum
380a13e9
stdlib: lowercase cases of AncestorRepresentation and DisplayStyle enums
b1ef18fb
[stdlib] all sorts of require renamed back to precondition
40b1a0b7
[stdlib] Requires in comments changed to Precondition
78ba5d5f
stdlib: lowercase cases of the PlaygroundQuickLook enum
63481be8
stdlib: add labels to DictionaryLiteral.Element tuple
2c14a00d
Fix benchmarks after Optional.None => .none rename
51ce68ce
stdlib: remove dead code
9968dee7
stdlib: lowercase option set names in a comment
a6696ef9
stdlib: Optional._unsafelyUnwrapped => ._unsafelyUnwrappedUnchecked
a5bdf9bc
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
3d3d4540
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
f27315b6
Introducing `by` argument label to `Sequence.split`
675f457c
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
fcad164e
[stdlib] API naming guidelines applied to `split` and `join`
481bcabc
`appendContentsOf` => `appendContents(of:)`
4b9eab62
stdlib: rename Optional and IUO intrinsics
8c3fbc51
stdlib: Streamable.writeTo() => .write(to:)
e2f5e05e
stdlib: _TeeStream: unlock streams in the order opposite to locking o…
82998a15
stdlib: add argument labels to _didEnterMain
3085c493
stdlib: add 'to:' label to dump()
196188b9
build-script: let distcc dictate parallelism
642fb405
[stdlib] Fix API renaming build failures
9bf2a86c
Revert "[stdlib] Fix API renaming build failures"
7e7da9ed
[gardening] Remove tab characters.
db4e802d
Revert "Revert "[stdlib] Fix API renaming build failures""
ad2a309e
[gardening] Remove tab characters.
86d1629f
[api-rename] Fix tests to use new APIs.
ecde5aae
[stdlib] indexOf => index(of:)/index(where:)
52f0cf49
Improve a doc comment
acd97e3e
stdlib: Add 'invoke:' label to withVaList
158adab7
stdlib: fix renaming mistake
577bb743
stdlib: Sequence.iterator() => .makeIterator()
f0633ce5
stdlib: fix coding style
ffeec94e
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
0b759a40
[stdlib] availability attributes for indexOf
85766f8d
stdlib: Revert "UnsafePointer.move() => .take()"
423b6ab4
Merge remote-tracking branch 'origin/swift-3-api-guidelines' into swi…
42d5f30d
[api-renaming] XFAIL this test on iOS platforms
3aa7fc18
Merge remote-tracking branch 'origin/swift-3-api-guidelines' into swi…
e62bd68b
stdlib: initializePointee(_) => initialize(with:)
d96b051d
[api-renaming] XFAIL this test on iOS platforms
1998aeed
stdlib: deinitializePointee(_) => deinitialize()
64a5165e
stdlib: merge swift 3 UnsafePointer migrations
ece87787
Merge pull request #1414 from apple/mish-swift-3
bd6d7173
[stdlib] availability attributes in CString
e207ae3f
[stdlib] fixing the unavailable function declaration
a7c1df83
stdlib: insertContentsOf(_:at:) becomes insertContents(of:at:)
40d5e349
stdlib: unsafeAddressOf(_:) becomes unsafeAddress(of:)
416b25bd
stdlib: SequenceType._initializeTo(_:) becomes _copyContents(initiali…
0205191e
stdlib: Update NSStringAPI.swift to match NSString under Swift 3 nami…
6f0a1adb
Merge pull request #1420 from cwillmor/swift-3-api-guidelines
27e8f725
stdlib: Sequence.startsWith() => .starts(with:)
e81f99d7
stdlib: Sequence.lexicographicalCompare(_:) => .lexicographicallyPrec…
097085e1
stdlib: Unavailable decls for renamed NSStringAPI methods
e9212d40
Merge pull request #1423 from cwillmor/swift-3-api-guidelines
d1878354
Adjust SceneKit test for String API changes
391d1c34
stdlib: rename _uninitializedCopy to _copyContents
fb1ed8e7
stdlib: add argument labels to sort() implementation details
d7e82519
[stdlib] adding 'invoke' label to StaticString.withUTF8Buffer
f9f618b4
[stdlib] strideTo/strideThrough => stride(to:...)/stride(through:...)
0490e86d
stdlib: Mark old insertContentsOf(_:at:) and unsafeAddressOf(_:) unav…
12574d0f
Fix build failure after String API changes
24218e08
stdlib: fix coding style
8fa5bb18
stdlib: add argument labels to _cocoaStringToContiguous()
18965b37
stdlib: add argument labels in _StringBufferIVars
c2c714b0
Merging in latest master
bb3eaaf3
stdlib: Audit API for Swift 3 preposition, first-arg label rules
2ddb6106
Merge pull request #1439 from cwillmor/swift-3-api-guidelines
1731ed21
stdlib: String indices: samePositionIn(_:) => samePosition(in:)
f3389273
stdlib: Add missing separator label that escaped previous audit.
a5e2e41d
stdlib: Audit StringUTF16.swift, StringUTF8.swift for Swift 3 naming.
c305ea03
Rename _BridgedNSError._NSErrorDomain to _nsErrorDomain.
81905be8
stdlib: Rename cases in XCTest._XCTThrowableBlockResult.
b71f7440
stdlib: Adjust names of hand-imported NSCocoaError/NSURLError cases.
1a5f23e4
stdlib: Rename {Float,Double.CGFloat}.NaN to 'nan'
979e4a8e
stdlib: Rename 'Native'/'Cocoa' representations inside Dictionary/Set.
e45dfe09
stdlib: Rename some helpers inside UnicodeTrie. NFC.
e5ae60aa
stdlib: Rename some implementation details of mirrors/reflection.
8fdee4ad
stdlib: Rename miscellaneous enum cases and static vars.
f9220841
StdlibUnittest: Rename enum cases and static vars to match API guidel…
e4e9c71d
Merge pull request #1440 from cwillmor/swift-3-api-guidelines
5cffdeed
stdlib: add argument labels in _StringBufferIVars
9a0c50b8
stdlib: fix coding style
7b3e9c34
stdlib: apply API guidelines in Unicode.swift
68bf4ae8
stdlib: apply API guidelines and fix coding style in SwiftNativeNSArr…
3c93ccc4
stdlib: add argument labels to UTF16._copy()
63ec99b1
stdlib: replace UnicodeDecodingResult.isEmptyInput with Equatable
f6b27191
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
488b464f
stdlib: Adjust to insert(contentsOf:at:) and append(contentsOf:)
b319e3da
stdlib: remove UnicodeScalar.init()
5f4fec74
stdlib: UnicodeScalar.escape() => .escaped()
1f4d8e20
stdlib: add better argument labels to transcode()
6bb8045a
stdlib: UTF16.measure() => .transcodedLength()
836e7785
Update tests after transcode() API changes
a77104d4
Fix call sites of unsafeBitCast() in the Glibc overlay
2fe3a39a
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
a49dab6b
Removing unnecessary test command
71384c73
Merge remote-tracking branch 'origin/swift-3-api-guidelines' into swi…
e48f452a
[stdlib] fixing compilation on Linux
234bc283
[stdlib] availability attributes for UnsafePointer.destroy
a61d9d04
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
859db53d
stdlib: docs: fix a reference to a type that does not exist
27c4074b
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
cf4bafe9
stdlib: rename Array.appendContents(of:) to Array.append(contentsOf:)
43a5d4cf
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
7fe6916b
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
1fae0d13
copy(withZone:) => copy(with:) in ShadowProtocols
4da439d4
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
02006f20
merging RangeReplaceableCollectionType into RangeReplaceableCollection
aacc0f82
fixing availability attribute hint for joinWithSeparator
bcc08b6c
Merge remote-tracking branch 'origin/master' into swift-3-api-guidelines
885b564b
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub