swift
[dfe] Change Impl to be a stongly typed PointerUnion instead of a union.
#17462
Merged
Merged
[dfe] Change Impl to be a stongly typed PointerUnion instead of a union. #17462
gottesmm
merged
1 commit into
swiftlang:master
from
gottesmm:pr-92939fbdadf6a8d47003dd8b04dd863fe3b0d92f
gottesmm7 years ago
No description provided.
[dfe] Change Impl to be a stongly typed PointerUnion instead of a union.
27c5366f
gottesmm7 years ago
@swift-ci smoke test
gottesmm7 years ago
@eeckstein for when you get back.
jrose-apple
commented
on 2018-06-25
lib/SILOptimizer/IPO/DeadFunctionElimination.cpp
| 320 | 317 | return; | |
| 321 | 318 | mi->methodIsCalled = true; | |
| 322 | 319 | for (FuncImpl &FImpl : mi->implementingFunctions) { | |
| 323 | if (FImpl.Impl.Conf) { | ||
| 324 | SILWitnessTable *WT = Module->lookUpWitnessTable(FImpl.Impl.Conf, | ||
| 325 | /*deserializeLazily*/ false); | ||
| 320 | if (auto *Conf = FImpl.Impl.dyn_cast<ProtocolConformance *>()) { |
jrose-apple7 years agoThis should be a get also, right?
gottesmm7 years agoJordan and I talked about this offline. I explained to him that PointerUnion by default assumes that null values have the first case value. I was trying to be conservative to work around such issues.
Login to write a write a comment.