swift
[5.1][AST] Use LookUpConformanceInModule to check if extension applied
#26329

Merged

[5.1][AST] Use LookUpConformanceInModule to check if extension applied #26329

rintaro merged 1 commit into swiftlang:swift-5.1-branch from rintaro:5.1-ide-completion-rdar53401609

rintaro5 years ago (edited 5 years ago)

Cherry-pick of #26321 into swift-5.1-branch

Explanation: If a extension have some requirements, we check if it's applied or not. However, it used to fail to classify as "applied" when the requirement has "chained" constraints like Index : Strideable, Index.Stride == Int. This patch fixes that by using LookUpConformanceInModule to check the conformance
Scope: Inherited member lookup for code completion
Risk: Low.
Issue: rdar://problem/53401609
Testing: Added regression test case
Reviewer: Slava Pestov (@slavapestov)

[AST] Use LookUpConformanceInModule to check if extension applied

69418864

rintaro5 years ago

@swift-ci Please test

slavapestov approved these changes on 2019-07-24

rintaro5 years ago

@swift-ci Please nominate

rintaro merged e9b6385f into swift-5.1-branch 5 years ago

rintaro deleted the 5.1-ide-completion-rdar53401609 branch 5 years ago

Reviewers

slavapestov

Assignees

No one assigned

Labels

None yet

Milestone

No milestone