swift
[CSApply] Don't diagnose a 'static let none' as ambiguous none unless its an enum type
#27382

Merged

[CSApply] Don't diagnose a 'static let none' as ambiguous none unless its an enum type #27382

theblixguy merged 7 commits into swiftlang:master from fix/SR-11522

[CSApply] Don't diagnose a 'static let none' as ambiguous none unless…

8d869e6f

theblixguy requested a review from

xedin 6 years ago

theblixguy requested a review from

jrose-apple 6 years ago

jrose-apple commented on 2019-09-26

beccadax requested changes on 2019-09-26

[CSApply] Filter out functions and instance members before the ambigu…

25e1bb5a

[CSApply] Compare variable's type with the base type of the enum we'r…

aa565f55

beccadax commented on 2019-09-26

jrose-apple commented on 2019-09-27

[CSApply] Move the variable type check into the lookup filter call

0a39e7db

[Test] Add a FIXME next to a test case that should be diagnosed

389232ac

jrose-apple commented on 2019-09-27

[CSApply] Filtering 'none' results should filter out any other decl (…

2de47555

[Test] Add some more tests around edge cases

b3d79625

jrose-apple approved these changes on 2019-09-27

beccadax approved these changes on 2019-09-28

theblixguy merged ad4d6238 into master 6 years ago

theblixguy deleted the fix/SR-11522 branch 6 years ago

Reviewers

beccadax

jrose-apple

xedin

Assignees

No one assigned

Labels

None yet

Milestone

No milestone