Fix KeyPath with default arg #27951
slavapestov
merged
32 commits into
swiftlang:master
from
zoecarver:key-path-default-arg
Fix support for subscript default arguments in KeyPath
e87d243d
xedin
approved these changes
on 2019-10-31
xedin
commented
on 2019-10-31
Refactor as suggested by @xedin
0376dd01
Stash progress before changing branches
4da9c425
Move default argument lowering into coerceCallArguments
14a2ad6a
Clean up spacing and remove lingering debugging calls
ff29b8e9
xedin
commented
on 2019-11-06
Merge branch 'master' into key-path-default-arg
5b4e3856
Add edgecases to tests
327c08a9
Fix based on review comments
00ebbee3
slavapestov
approved these changes
on 2019-11-07
Emit default arguments in silgen
3da27993
Merge branch 'master' into key-path-default-arg
ecba9c37
Move default arg generation into SILGen
8c3bfc59
Run code through clang-format
f7dd8138
zoecarver
commented
on 2019-11-10
Remove lingering newline
b6bca529
Re-enable tests (oops)
b0877fb4
theblixguy
commented
on 2019-11-11
Move default arg generation into lambda instead of modifing AST
921c1ebf
Regenerate labels in CSApply instead of keeping two sizes
18f918b5
Use ArgEmitter
e385439e
Create emitKeyPathSubscriptOperands to lower all the args properly (i…
51dc7c85
Use range-based for-loop
27ffff10
Use correct function type to prevent conflicting argument types
0f3dd529
Format properly
08244697
Copy labels and conformances
853dfbef
Fix spacing
5e1e9075
Fix spacing
800feda1
Fix spacing (again)
775c0625
Fix merge conflict
0374c94a
Add FileCheck tests
3a984522
Add tests
976c8c93
More tests
fd02663b
Format with clang-format
a8953b1f
Add more FileCheck tests
b8947c4e
Fix nits
3f7ee854
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub