swift
[Type checker] Remove an unnecessary cycle break.
#28411
Merged

[Type checker] Remove an unnecessary cycle break. #28411

DougGregor
DougGregor5 years ago

The hasInterfaceType() check should only be used for cycle breaking, and in
this case was preventing us from properly establishing the capabilities of
a property wrapper.

Fixes rdar://problem/57350503 and several dupes.

DougGregor [Type checker] Remove an unnecessary cycle break.
60e501d8
DougGregor DougGregor requested a review from theblixguy theblixguy 5 years ago
DougGregor
DougGregor5 years ago

@swift-ci please smoke test

theblixguy
theblixguy approved these changes on 2019-11-21
slavapestov
slavapestov approved these changes on 2019-11-21
DougGregor DougGregor merged 7501113e into master 5 years ago
DougGregor DougGregor deleted the property-wrapper-bad-recursion-break branch 5 years ago
CodaFi
CodaFi5 years ago👍 1

Always nice when the right thing is deleting code.

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone