swift
[AutoDiff] Fix `@noDerivative` attributes in non-primary-files.
#29647

Merged

[AutoDiff] Fix `@noDerivative` attributes in non-primary-files. #29647

dan-zheng merged 1 commit into swiftlang:tensorflow from dan-zheng:noderivative-attr-fix

dan-zheng5 years ago

Previously, @noDerivative attribute type-checking generated implicit
@_semantics("autodiff.nonvarying") attributes.

However, attributes in non-primary-files are not type-checked, so
@noDerivative attributes in non-primary-files are not processed.

Now, all @noDerivative attributes are lowered to
[_semantics "autodiff.nonvarying"] SIL function attributes.

Resolves TF-1145.

[AutoDiff] Fix `@noDerivative` attributes in non-primary-files.

78f5e7e0

dan-zheng added tensorflow

dan-zheng requested a review from

rxwei 5 years ago

dan-zheng requested a review from

marcrasi 5 years ago

marcrasi approved these changes on 2020-02-04

dan-zheng5 years ago

@swift-ci Please test tensorflow

rxwei approved these changes on 2020-02-04

dan-zheng merged 5f65a37a into tensorflow 5 years ago

dan-zheng deleted the noderivative-attr-fix branch 5 years ago

Reviewers

rxwei

marcrasi

Assignees

No one assigned

Labels

tensorflow

Milestone

No milestone